SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 04:08:27 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FUGR: Give proper error messages for RFC parameter (#3222)

Browse Source 
* FUGR: Give proper error messages for RFC parameter

* reduce line length
This commit is contained in:
Lars Hvam 2020-03-03 10:21:33 +01:00 committed by GitHub
parent b4b3414009
commit 4b35ecffb3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 63 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

64
src/objects/zcl_abapgit_object_fugr.clas.abap
View File

@ -37,6 +37,11 @@ CLASS zcl_abapgit_object_fugr DEFINITION PUBLIC INHERITING FROM zcl_abapgit_obje
TYPES:
tt_tpool_i18n TYPE STANDARD TABLE OF ty_tpool_i18n .
METHODS check_rfc_parameters
IMPORTING
!is_function TYPE ty_function
RAISING
zcx_abapgit_exception .
METHODS update_where_used
IMPORTING
!it_includes TYPE ty_sobj_name_tt .
@ -169,6 +174,52 @@ CLASS ZCL_ABAPGIT_OBJECT_FUGR IMPLEMENTATION.
ENDMETHOD.
METHOD check_rfc_parameters.
* function module RS_FUNCTIONMODULE_INSERT does the same deep down, but the right error
* message is not returned to the user, this is a workaround to give a proper error
* message to the user
DATA: ls_parameter TYPE rsfbpara,
lt_fupa TYPE rsfb_param,
ls_fupa LIKE LINE OF lt_fupa.
IF is_function-remote_call = 'R'.
cl_fb_parameter_conversion=>convert_parameter_old_to_fupa(
EXPORTING
functionname = is_function-funcname
import = is_function-import
export = is_function-export
change = is_function-changing
tables = is_function-tables
except = is_function-exception
IMPORTING
fupararef = lt_fupa ).
LOOP AT lt_fupa INTO ls_fupa WHERE paramtype = 'I' OR paramtype = 'E' OR paramtype = 'C' OR paramtype = 'T'.
cl_fb_parameter_conversion=>convert_intern_to_extern(
EXPORTING
parameter_db = ls_fupa
IMPORTING
parameter_vis = ls_parameter ).
CALL FUNCTION 'RS_FB_CHECK_PARAMETER_REMOTE'
EXPORTING
parameter = ls_parameter
basxml_enabled = is_function-remote_basxml
EXCEPTIONS
not_remote_compatible = 1
OTHERS = 2.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
ENDLOOP.
ENDIF.
ENDMETHOD.
METHOD deserialize_functions.
DATA: lv_include TYPE rs38l-include,
@ -177,11 +228,13 @@ CLASS ZCL_ABAPGIT_OBJECT_FUGR IMPLEMENTATION.
lv_namespace TYPE rs38l-namespace,
lt_source TYPE TABLE OF abaptxt255,
lv_msg TYPE string,
lx_error TYPE REF TO zcx_abapgit_exception,
lv_corrnum TYPE e070use-ordernum.
FIELD-SYMBOLS: <ls_func> LIKE LINE OF it_functions.
lv_corrnum = zcl_abapgit_default_transport=>get_instance( )->get( )-ordernum.
lv_corrnum = zcl_abapgit_default_transport=>get_instance( )->get( )-ordernum.
LOOP AT it_functions ASSIGNING <ls_func>.
@ -228,6 +281,15 @@ CLASS ZCL_ABAPGIT_OBJECT_FUGR IMPLEMENTATION.
ENDIF.
ENDIF.
TRY.
check_rfc_parameters( <ls_func> ).
CATCH zcx_abapgit_exception INTO lx_error.
ii_log->add_error(
iv_msg = |Function module { <ls_func>-funcname }: { lx_error->get_text( ) }|
is_item = ms_item ).
CONTINUE. "with next function module
ENDTRY.
CALL FUNCTION 'RS_FUNCTIONMODULE_INSERT'
EXPORTING
funcname = <ls_func>-funcname