diff --git a/src/objects/core/zcl_abapgit_file_deserialize.clas.abap b/src/objects/core/zcl_abapgit_file_deserialize.clas.abap index c075a8c23..6359c6e4c 100644 --- a/src/objects/core/zcl_abapgit_file_deserialize.clas.abap +++ b/src/objects/core/zcl_abapgit_file_deserialize.clas.abap @@ -27,11 +27,6 @@ CLASS zcl_abapgit_file_deserialize DEFINITION !it_results TYPE zif_abapgit_definitions=>ty_results_tt RETURNING VALUE(rt_results) TYPE zif_abapgit_definitions=>ty_results_tt. - CLASS-METHODS adjust_namespaces - IMPORTING - !it_results TYPE zif_abapgit_definitions=>ty_results_tt - RETURNING - VALUE(rt_results) TYPE zif_abapgit_definitions=>ty_results_tt. ENDCLASS. @@ -40,19 +35,6 @@ ENDCLASS. CLASS zcl_abapgit_file_deserialize IMPLEMENTATION. - METHOD adjust_namespaces. - - FIELD-SYMBOLS: LIKE LINE OF rt_results. - - rt_results = it_results. - - LOOP AT rt_results ASSIGNING . - REPLACE ALL OCCURRENCES OF '#' IN -obj_name WITH '/'. - ENDLOOP. - - ENDMETHOD. - - METHOD filter_files_to_deserialize. DATA lt_objects LIKE rt_results. @@ -144,18 +126,17 @@ CLASS zcl_abapgit_file_deserialize IMPLEMENTATION. METHOD get_results. - rt_results = adjust_namespaces( - prioritize_deser( - filter_files_to_deserialize( - it_results = zcl_abapgit_file_status=>status( io_repo ) - ii_log = ii_log ) ) ). + rt_results = prioritize_deser( + filter_files_to_deserialize( + it_results = zcl_abapgit_file_status=>status( io_repo ) + ii_log = ii_log ) ). ENDMETHOD. METHOD prioritize_deser. -* todo, refactor this method +* todo, refactor this method #3536 FIELD-SYMBOLS: LIKE LINE OF it_results. diff --git a/src/objects/core/zcl_abapgit_file_deserialize.clas.testclasses.abap b/src/objects/core/zcl_abapgit_file_deserialize.clas.testclasses.abap index 63a5240ac..11b12b45f 100644 --- a/src/objects/core/zcl_abapgit_file_deserialize.clas.testclasses.abap +++ b/src/objects/core/zcl_abapgit_file_deserialize.clas.testclasses.abap @@ -1,9 +1,7 @@ CLASS ltcl_filter_files_to_deser DEFINITION DEFERRED. -CLASS ltcl_adjust_namespaces DEFINITION DEFERRED. CLASS ltcl_prio_deserialization DEFINITION DEFERRED. CLASS zcl_abapgit_file_deserialize DEFINITION LOCAL FRIENDS ltcl_filter_files_to_deser. -CLASS zcl_abapgit_file_deserialize DEFINITION LOCAL FRIENDS ltcl_adjust_namespaces. CLASS zcl_abapgit_file_deserialize DEFINITION LOCAL FRIENDS ltcl_prio_deserialization. CLASS ltcl_filter_files_to_deser DEFINITION FINAL FOR TESTING @@ -215,58 +213,6 @@ CLASS ltcl_filter_files_to_deser IMPLEMENTATION. ENDCLASS. -CLASS ltcl_adjust_namespaces DEFINITION FINAL FOR TESTING - DURATION SHORT - RISK LEVEL HARMLESS. - - PRIVATE SECTION. - METHODS: - setup, - adjust_namespaces FOR TESTING RAISING cx_static_check. - - DATA: - mo_objects TYPE REF TO zcl_abapgit_file_deserialize. - -ENDCLASS. - -CLASS ltcl_adjust_namespaces IMPLEMENTATION. - - METHOD setup. - - CREATE OBJECT mo_objects. - - ENDMETHOD. - - METHOD adjust_namespaces. - - DATA: lt_input TYPE zif_abapgit_definitions=>ty_results_tt, - lt_ouptut TYPE zif_abapgit_definitions=>ty_results_tt, - ls_result LIKE LINE OF lt_input. - - ls_result-obj_name = |#SAP#ZTEST|. - INSERT ls_result INTO TABLE lt_input. - - ls_result-obj_name = |ZTEST|. - INSERT ls_result INTO TABLE lt_input. - - lt_ouptut = mo_objects->adjust_namespaces( lt_input ). - - READ TABLE lt_ouptut INTO ls_result INDEX 1. - - cl_abap_unit_assert=>assert_equals( - exp = |/SAP/ZTEST| - act = ls_result-obj_name ). - - READ TABLE lt_ouptut INTO ls_result INDEX 2. - - cl_abap_unit_assert=>assert_equals( - exp = |ZTEST| - act = ls_result-obj_name ). - - ENDMETHOD. - -ENDCLASS. - CLASS ltcl_prio_deserialization DEFINITION FINAL FOR TESTING DURATION SHORT RISK LEVEL HARMLESS.