SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Remove adjust_namespaces (#4760)

Browse Source 
* Remove adjust_namespace

Method is obsolete since namespace of object is already adjusted in `zcl_abapgit_filename_logic=>file_to_object`

* Remove adjust_namespace

* Remove bracket

Co-authored-by: Lars Hvam <larshp@hotmail.com>
This commit is contained in:
Marc Bernard 2021-05-14 10:55:46 +02:00 committed by GitHub
parent ce677e449f
commit 4d9d7fb37e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 78 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/objects/core/zcl_abapgit_file_deserialize.clas.abap
View File

@ -27,11 +27,6 @@ CLASS zcl_abapgit_file_deserialize DEFINITION
!it_results TYPE zif_abapgit_definitions=>ty_results_tt
RETURNING
VALUE(rt_results) TYPE zif_abapgit_definitions=>ty_results_tt.
CLASS-METHODS adjust_namespaces
IMPORTING
!it_results TYPE zif_abapgit_definitions=>ty_results_tt
RETURNING
VALUE(rt_results) TYPE zif_abapgit_definitions=>ty_results_tt.
ENDCLASS.
@ -40,19 +35,6 @@ ENDCLASS.
CLASS zcl_abapgit_file_deserialize IMPLEMENTATION.
METHOD adjust_namespaces.
FIELD-SYMBOLS: <ls_result> LIKE LINE OF rt_results.
rt_results = it_results.
LOOP AT rt_results ASSIGNING <ls_result>.
REPLACE ALL OCCURRENCES OF '#' IN <ls_result>-obj_name WITH '/'.
ENDLOOP.
ENDMETHOD.
METHOD filter_files_to_deserialize.
DATA lt_objects LIKE rt_results.
@ -144,18 +126,17 @@ CLASS zcl_abapgit_file_deserialize IMPLEMENTATION.
METHOD get_results.
rt_results = adjust_namespaces(
prioritize_deser(
filter_files_to_deserialize(
it_results = zcl_abapgit_file_status=>status( io_repo )
ii_log = ii_log ) ) ).
rt_results = prioritize_deser(
filter_files_to_deserialize(
it_results = zcl_abapgit_file_status=>status( io_repo )
ii_log = ii_log ) ).
ENDMETHOD.
METHOD prioritize_deser.
* todo, refactor this method
* todo, refactor this method #3536
FIELD-SYMBOLS: <ls_result> LIKE LINE OF it_results.

54
src/objects/core/zcl_abapgit_file_deserialize.clas.testclasses.abap
View File

@ -1,9 +1,7 @@
CLASS ltcl_filter_files_to_deser DEFINITION DEFERRED.
CLASS ltcl_adjust_namespaces DEFINITION DEFERRED.
CLASS ltcl_prio_deserialization DEFINITION DEFERRED.
CLASS zcl_abapgit_file_deserialize DEFINITION LOCAL FRIENDS ltcl_filter_files_to_deser.
CLASS zcl_abapgit_file_deserialize DEFINITION LOCAL FRIENDS ltcl_adjust_namespaces.
CLASS zcl_abapgit_file_deserialize DEFINITION LOCAL FRIENDS ltcl_prio_deserialization.
CLASS ltcl_filter_files_to_deser DEFINITION FINAL FOR TESTING
@ -215,58 +213,6 @@ CLASS ltcl_filter_files_to_deser IMPLEMENTATION.
ENDCLASS.
CLASS ltcl_adjust_namespaces DEFINITION FINAL FOR TESTING
DURATION SHORT
RISK LEVEL HARMLESS.
PRIVATE SECTION.
METHODS:
setup,
adjust_namespaces FOR TESTING RAISING cx_static_check.
DATA:
mo_objects TYPE REF TO zcl_abapgit_file_deserialize.
ENDCLASS.
CLASS ltcl_adjust_namespaces IMPLEMENTATION.
METHOD setup.
CREATE OBJECT mo_objects.
ENDMETHOD.
METHOD adjust_namespaces.
DATA: lt_input TYPE zif_abapgit_definitions=>ty_results_tt,
lt_ouptut TYPE zif_abapgit_definitions=>ty_results_tt,
ls_result LIKE LINE OF lt_input.
ls_result-obj_name = |#SAP#ZTEST|.
INSERT ls_result INTO TABLE lt_input.
ls_result-obj_name = |ZTEST|.
INSERT ls_result INTO TABLE lt_input.
lt_ouptut = mo_objects->adjust_namespaces( lt_input ).
READ TABLE lt_ouptut INTO ls_result INDEX 1.
cl_abap_unit_assert=>assert_equals(
exp = |/SAP/ZTEST|
act = ls_result-obj_name ).
READ TABLE lt_ouptut INTO ls_result INDEX 2.
cl_abap_unit_assert=>assert_equals(
exp = |ZTEST|
act = ls_result-obj_name ).
ENDMETHOD.
ENDCLASS.
CLASS ltcl_prio_deserialization DEFINITION FINAL FOR TESTING
DURATION SHORT
RISK LEVEL HARMLESS.