SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

zcl_abapgit_code_inspector: Remove duplication (#3117)

Browse Source 
* zcl_abapgit_code_inspector: Remove duplication 

Removes duplication of subpackage determination in zcl_abapgit_code_inspector

* add current package
This commit is contained in:
Christian Günter 2019-12-12 11:01:29 +01:00 committed by Lars Hvam
parent 60a57cf356
commit 4f47fa64a7
1 changed files with 5 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
src/zcl_abapgit_code_inspector.clas.abap
View File

@ -18,10 +18,6 @@ CLASS zcl_abapgit_code_inspector DEFINITION
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
PROTECTED SECTION. PROTECTED SECTION.
TYPES:
ty_tdevc_tt TYPE STANDARD TABLE OF tdevc WITH DEFAULT KEY .
DATA mv_package TYPE devclass . DATA mv_package TYPE devclass .
METHODS create_variant METHODS create_variant
@ -52,11 +48,7 @@ CLASS zcl_abapgit_code_inspector DEFINITION
DATA mv_name TYPE sci_objs . DATA mv_name TYPE sci_objs .
DATA mv_run_mode TYPE sychar01 . DATA mv_run_mode TYPE sychar01 .
METHODS find_all_subpackages
IMPORTING
!iv_package TYPE devclass
RETURNING
VALUE(rt_packages) TYPE ty_tdevc_tt .
METHODS create_objectset METHODS create_objectset
RETURNING RETURNING
VALUE(ro_set) TYPE REF TO cl_ci_objectset . VALUE(ro_set) TYPE REF TO cl_ci_objectset .
@ -178,19 +170,16 @@ CLASS ZCL_ABAPGIT_CODE_INSPECTOR IMPLEMENTATION.
METHOD create_objectset. METHOD create_objectset.
DATA: lt_objs TYPE scit_objs, DATA: lt_objs TYPE scit_objs,
lt_packages TYPE ty_tdevc_tt. lt_packages TYPE zif_abapgit_sap_package=>ty_devclass_tt.
lt_packages = zcl_abapgit_factory=>get_sap_package( mv_package )->list_subpackages( ).
lt_packages = find_all_subpackages( mv_package ). INSERT mv_package INTO TABLE lt_packages.
IF lines( lt_packages ) = 0.
RETURN.
ENDIF.
SELECT object AS objtype obj_name AS objname SELECT object AS objtype obj_name AS objname
FROM tadir FROM tadir
INTO CORRESPONDING FIELDS OF TABLE lt_objs INTO CORRESPONDING FIELDS OF TABLE lt_objs
FOR ALL ENTRIES IN lt_packages FOR ALL ENTRIES IN lt_packages
WHERE devclass = lt_packages-devclass WHERE devclass = lt_packages-table_line
AND delflag = abap_false AND delflag = abap_false
AND pgmid = 'R3TR'. "#EC CI_GENBUFF AND pgmid = 'R3TR'. "#EC CI_GENBUFF
@ -228,30 +217,6 @@ CLASS ZCL_ABAPGIT_CODE_INSPECTOR IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD find_all_subpackages.
* TODO, in the future, move this method to the ABAPGIT global package class
DATA: ls_package LIKE LINE OF rt_packages,
lt_found LIKE rt_packages,
lt_sub LIKE rt_packages.
SELECT SINGLE * FROM tdevc INTO ls_package WHERE devclass = iv_package.
ASSERT sy-subrc = 0.
APPEND ls_package TO rt_packages.
SELECT * FROM tdevc APPENDING TABLE lt_sub
WHERE parentcl = ls_package-devclass.
LOOP AT lt_sub INTO ls_package.
lt_found = find_all_subpackages( ls_package-devclass ).
APPEND LINES OF lt_found TO rt_packages.
ENDLOOP.
ENDMETHOD.
METHOD run_inspection. METHOD run_inspection.
io_inspection->run( io_inspection->run(