Merge branch 'main' into hvam/npm2111

src/cts/zif_abapgit_default_transport.intf.xml

@@ -5,7 +5,7 @@
    <VSEOINTERF>
     <CLSNAME>ZIF_ABAPGIT_DEFAULT_TRANSPORT</CLSNAME>
     <LANGU>E</LANGU>
-    <DESCRIPT>ZIF_ABAPGIT_DEFAULT_TRANSPORT</DESCRIPT>
+    <DESCRIPT>abapGit - Default Transport</DESCRIPT>
     <EXPOSURE>2</EXPOSURE>
     <STATE>1</STATE>
     <UNICODE>X</UNICODE>

src/exits/zif_abapgit_exit.intf.abap

@@ -7,7 +7,7 @@ INTERFACE zif_abapgit_exit PUBLIC.
       clone_url TYPE string,
     END OF ty_ci_repo.
   TYPES:
-    ty_ci_repos TYPE TABLE OF ty_ci_repo.
+    ty_ci_repos TYPE STANDARD TABLE OF ty_ci_repo WITH DEFAULT KEY.
   TYPES:
     ty_object_types TYPE STANDARD TABLE OF tadir-object WITH DEFAULT KEY.
   TYPES:

src/inspect/zcl_abapgit_where_used_tools.clas.xml

@@ -5,7 +5,7 @@
    <VSEOCLASS>
     <CLSNAME>ZCL_ABAPGIT_WHERE_USED_TOOLS</CLSNAME>
     <LANGU>E</LANGU>
-    <DESCRIPT>abapGit where used utilities</DESCRIPT>
+    <DESCRIPT>abapGit - Where-used Utilities</DESCRIPT>
     <STATE>1</STATE>
     <CLSCCINCL>X</CLSCCINCL>
     <FIXPT>X</FIXPT>

src/objects/aff/zcl_abapgit_json_handler.clas.abap

@@ -18,7 +18,7 @@ CLASS zcl_abapgit_json_handler DEFINITION
         mappings TYPE ty_json_abap_mappings,
       END OF ty_enum_mapping .
     TYPES:
-      ty_enum_mappings TYPE TABLE OF ty_enum_mapping WITH DEFAULT KEY .
+      ty_enum_mappings TYPE STANDARD TABLE OF ty_enum_mapping WITH DEFAULT KEY .
     TYPES:
       BEGIN OF ty_path_value_pair,
         path  TYPE string,

src/objects/core/zcl_abapgit_file_deserialize.clas.abap

@@ -214,6 +214,9 @@ CLASS zcl_abapgit_file_deserialize IMPLEMENTATION.
           DELETE lt_requires WHERE obj_type <> 'IASP'
             AND obj_type <> 'PROG'
             AND obj_type <> 'IARP'.
+        WHEN 'IDOC' OR 'IEXT'.
+          lt_requires = lt_items.
+          DELETE lt_requires WHERE obj_type <> 'TABL'.
         WHEN 'DCLS'.
           lt_requires = lt_items.
           DELETE lt_requires WHERE obj_type <> 'DDLS'.

src/objects/jump/zcl_abapgit_gui_jumper.clas.abap

@@ -253,7 +253,8 @@ CLASS zcl_abapgit_gui_jumper IMPLEMENTATION.
       EXCEPTIONS
         communication_failure = 1 MESSAGE lv_msg
         system_failure        = 2 MESSAGE lv_msg
-        OTHERS                = 3.
+        resource_failure      = 3
+        OTHERS                = 4.
 
     lv_subrc = sy-subrc.
 

src/objects/texts/zcl_abapgit_longtexts.clas.abap

@@ -64,6 +64,10 @@ CLASS zcl_abapgit_longtexts IMPLEMENTATION.
 
     FIELD-SYMBOLS: <ls_dokil> LIKE LINE OF lt_dokil.
 
+    IF iv_object_name CA '#'.
+      zcx_abapgit_exception=>raise( |Invalid name for longtext: { iv_longtext_id } { iv_object_name }| ).
+    ENDIF.
+
     lv_object = escape_name(
       iv_longtext_id = iv_longtext_id
       iv_object_name = iv_object_name ).
@@ -77,7 +81,6 @@ CLASS zcl_abapgit_longtexts IMPLEMENTATION.
       ENDIF.
 
     ELSEIF iv_longtext_id IS NOT INITIAL.
-      IF lv_object NA '#'.
       IF iv_main_lang_only = abap_true.
         SELECT * FROM dokil
                  INTO TABLE lt_dokil
@@ -92,7 +95,6 @@ CLASS zcl_abapgit_longtexts IMPLEMENTATION.
                  AND object LIKE lv_object ESCAPE '#'
                  ORDER BY PRIMARY KEY.
       ENDIF.
-      ENDIF.
     ELSE.
 
       zcx_abapgit_exception=>raise( |serialize_longtexts parameter error| ).

src/objects/zcl_abapgit_object_fugs.clas.xml

@@ -5,7 +5,7 @@
    <VSEOCLASS>
     <CLSNAME>ZCL_ABAPGIT_OBJECT_FUGS</CLSNAME>
     <LANGU>E</LANGU>
-    <DESCRIPT>abapGit - FUGS</DESCRIPT>
+    <DESCRIPT>abapGit - FUGS - Function Group (SAP)</DESCRIPT>
     <STATE>1</STATE>
     <CLSCCINCL>X</CLSCCINCL>
     <FIXPT>X</FIXPT>

src/objects/zcl_abapgit_object_idoc.clas.abap

@@ -163,6 +163,9 @@ CLASS zcl_abapgit_object_idoc IMPLEMENTATION.
     MOVE-CORRESPONDING ls_idoc-attributes TO ls_attributes.
 
     IF zif_abapgit_object~exists( ) = abap_false.
+      " Avoid popup asking for package
+      tadir_insert( iv_package ).
+
       CALL FUNCTION 'IDOCTYPE_CREATE'
         EXPORTING
           pi_idoctyp       = mv_idoctyp

src/objects/zcl_abapgit_object_iext.clas.abap

@@ -97,6 +97,9 @@ CLASS zcl_abapgit_object_iext IMPLEMENTATION.
         EXCEPTIONS
           OTHERS        = 1.
     ELSE.
+      " Avoid popup asking for package
+      tadir_insert( iv_package ).
+
       CALL FUNCTION 'EXTTYPE_CREATE'
         EXPORTING
           pi_cimtyp     = mv_extension

src/objects/zcl_abapgit_object_msag.clas.abap

@@ -84,7 +84,7 @@ CLASS zcl_abapgit_object_msag IMPLEMENTATION.
         object_is_enqueued_by_corr     = 6
         user_break                     = 7
         OTHERS                         = 8.
-    IF sy-subrc <> 0.
+    IF sy-subrc <> 0 AND sy-subrc <> 4.
       zcx_abapgit_exception=>raise( 'Error deleting longtext for message' ).
     ENDIF.
 

src/objects/zcl_abapgit_object_sush.clas.abap

@@ -23,10 +23,10 @@ CLASS zcl_abapgit_object_sush DEFINITION
     METHODS clear_metadata
       CHANGING
         cs_data_head TYPE any
-        ct_usobx     TYPE table
+        ct_usobx     TYPE STANDARD TABLE
-        ct_usobt     TYPE table
+        ct_usobt     TYPE STANDARD TABLE
-        ct_usobx_ext TYPE table
+        ct_usobx_ext TYPE STANDARD TABLE
-        ct_usobt_ext TYPE table.
+        ct_usobt_ext TYPE STANDARD TABLE.
 
 ENDCLASS.
 

src/ui/lib/zcl_abapgit_gui_picklist.clas.xml

@@ -5,7 +5,7 @@
    <VSEOCLASS>
     <CLSNAME>ZCL_ABAPGIT_GUI_PICKLIST</CLSNAME>
     <LANGU>E</LANGU>
-    <DESCRIPT>abapGit - Pick from list</DESCRIPT>
+    <DESCRIPT>abapGit - GUI Pick List</DESCRIPT>
     <STATE>1</STATE>
     <CLSCCINCL>X</CLSCCINCL>
     <FIXPT>X</FIXPT>

src/ui/pages/codi/zcl_abapgit_gui_page_whereused.clas.xml

@@ -5,7 +5,7 @@
    <VSEOCLASS>
     <CLSNAME>ZCL_ABAPGIT_GUI_PAGE_WHEREUSED</CLSNAME>
     <LANGU>E</LANGU>
-    <DESCRIPT>abapGit where-used page</DESCRIPT>
+    <DESCRIPT>abapGit - GUI Where-used</DESCRIPT>
     <STATE>1</STATE>
     <CLSCCINCL>X</CLSCCINCL>
     <FIXPT>X</FIXPT>

src/ui/routing/zcl_abapgit_gui_router.clas.abap

@@ -186,7 +186,8 @@ CLASS zcl_abapgit_gui_router IMPLEMENTATION.
       EXCEPTIONS
         communication_failure = 1 MESSAGE lv_msg
         system_failure        = 2 MESSAGE lv_msg
-        OTHERS                = 3.
+        resource_failure      = 3
+        OTHERS                = 4.
     IF sy-subrc <> 0.
       lv_msg = |Error starting transaction { iv_tcode }: { lv_msg }|.
       MESSAGE lv_msg TYPE 'I'.
@@ -478,6 +479,22 @@ CLASS zcl_abapgit_gui_router IMPLEMENTATION.
   ENDMETHOD.
 
 
+  METHOD go_stage_transport.
+
+    DATA lt_r_trkorr TYPE zif_abapgit_definitions=>ty_trrngtrkor_tt.
+    DATA lo_repo TYPE REF TO zcl_abapgit_repo.
+
+    lt_r_trkorr = zcl_abapgit_ui_factory=>get_popups( )->popup_select_wb_tc_tr_and_tsk( ).
+
+    lo_repo ?= zcl_abapgit_repo_srv=>get_instance( )->get( iv_key ).
+
+    CREATE OBJECT ro_filter.
+    ro_filter->set_filter_values( iv_package  = lo_repo->get_package( )
+                                  it_r_trkorr = lt_r_trkorr ).
+
+  ENDMETHOD.
+
+
   METHOD jump_display_transport.
 
     DATA:
@@ -762,6 +779,28 @@ CLASS zcl_abapgit_gui_router IMPLEMENTATION.
   ENDMETHOD.
 
 
+  METHOD zip_export_transport.
+
+    DATA lo_obj_filter_trans TYPE REF TO zcl_abapgit_object_filter_tran.
+    DATA lt_r_trkorr         TYPE zif_abapgit_definitions=>ty_trrngtrkor_tt.
+    DATA lo_repo             TYPE REF TO zcl_abapgit_repo.
+    DATA lv_xstr             TYPE xstring.
+
+    lt_r_trkorr = zcl_abapgit_ui_factory=>get_popups( )->popup_select_wb_tc_tr_and_tsk( ).
+    lo_repo ?= zcl_abapgit_repo_srv=>get_instance( )->get( iv_key ).
+    lo_repo->refresh( ).
+    CREATE OBJECT lo_obj_filter_trans.
+    lo_obj_filter_trans->set_filter_values( iv_package  = lo_repo->get_package( )
+                                            it_r_trkorr = lt_r_trkorr ).
+
+    lv_xstr = zcl_abapgit_zip=>encode_files( lo_repo->get_files_local_filtered( lo_obj_filter_trans ) ).
+    lo_repo->refresh( ).
+    file_download( iv_package = lo_repo->get_package( )
+                   iv_xstr    = lv_xstr ).
+
+  ENDMETHOD.
+
+
   METHOD zip_services.
 
     DATA: lv_key            TYPE zif_abapgit_persistence=>ty_repo-key,
@@ -860,40 +899,4 @@ CLASS zcl_abapgit_gui_router IMPLEMENTATION.
     ENDCASE.
 
   ENDMETHOD.
-
-  METHOD zip_export_transport.
-
-    DATA lo_obj_filter_trans TYPE REF TO zcl_abapgit_object_filter_tran.
-    DATA lt_r_trkorr         TYPE zif_abapgit_definitions=>ty_trrngtrkor_tt.
-    DATA lo_repo             TYPE REF TO zcl_abapgit_repo.
-    DATA lv_xstr             TYPE xstring.
-
-    lt_r_trkorr = zcl_abapgit_ui_factory=>get_popups( )->popup_select_wb_tc_tr_and_tsk( ).
-    lo_repo ?= zcl_abapgit_repo_srv=>get_instance( )->get( iv_key ).
-    lo_repo->refresh( ).
-    CREATE OBJECT lo_obj_filter_trans.
-    lo_obj_filter_trans->set_filter_values( iv_package  = lo_repo->get_package( )
-                                            it_r_trkorr = lt_r_trkorr ).
-
-    lv_xstr = zcl_abapgit_zip=>encode_files( lo_repo->get_files_local_filtered( lo_obj_filter_trans ) ).
-    lo_repo->refresh( ).
-    file_download( iv_package = lo_repo->get_package( )
-                   iv_xstr    = lv_xstr ).
-
-  ENDMETHOD.
-
-  METHOD go_stage_transport.
-
-    DATA lt_r_trkorr TYPE zif_abapgit_definitions=>ty_trrngtrkor_tt.
-    DATA lo_repo TYPE REF TO zcl_abapgit_repo.
-
-    lt_r_trkorr = zcl_abapgit_ui_factory=>get_popups( )->popup_select_wb_tc_tr_and_tsk( ).
-
-    lo_repo ?= zcl_abapgit_repo_srv=>get_instance( )->get( iv_key ).
-
-    CREATE OBJECT ro_filter.
-    ro_filter->set_filter_values( iv_package  = lo_repo->get_package( )
-                                  it_r_trkorr = lt_r_trkorr ).
-
-  ENDMETHOD.
 ENDCLASS.

src/ui/zabapgit_css_theme_dark.w3mi.data.css

@@ -263,4 +263,4 @@ div.log { color: var(--theme-greyscale-dark); }
 .dialog input[readonly] {
   background-color: var(--theme-greyscale-dark);
   color: var(--theme-greyscale-medium);
-}
+}

src/ui/zif_abapgit_popups.intf.abap

@@ -12,7 +12,7 @@ INTERFACE zif_abapgit_popups
       show_icon TYPE abap_bool,
       center    TYPE abap_bool,
     END OF ty_alv_column,
-    ty_alv_column_tt TYPE TABLE OF ty_alv_column WITH DEFAULT KEY.
+    ty_alv_column_tt TYPE STANDARD TABLE OF ty_alv_column WITH DEFAULT KEY.
 
   TYPES:
     BEGIN OF ty_popup_position,