SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-04-30 20:03:20 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

remove max length for commit comment/body line size

Browse Source
This commit is contained in:
bigld 2017-04-26 07:37:23 +02:00
parent 989801ac3c
commit 4fc5bc10f6
3 changed files with 24 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/zabapgit_page_commit.prog.abap
View File

@ -37,10 +37,10 @@ CLASS lcl_gui_page_commit DEFINITION FINAL INHERITING FROM lcl_gui_page.
RETURNING VALUE(ro_html) TYPE REF TO lcl_html
RAISING lcx_exception,
render_text_input
IMPORTING iv_name TYPE string
iv_label TYPE string
iv_value TYPE string OPTIONAL
iv_max_length TYPE string OPTIONAL
IMPORTING iv_name TYPE string
iv_label TYPE string
iv_value TYPE string OPTIONAL
iv_max_length TYPE string OPTIONAL
RETURNING VALUE(ro_html) TYPE REF TO lcl_html.
ENDCLASS.
@ -155,11 +155,14 @@ CLASS lcl_gui_page_commit IMPLEMENTATION.
METHOD render_form.
DATA: lo_user TYPE REF TO lcl_persistence_user.
DATA: lv_user TYPE string.
DATA: lv_email TYPE string.
DATA: lv_s_param TYPE string.
DATA: lo_settings TYPE REF TO lcl_settings.
CONSTANTS: lc_body_col_max TYPE i VALUE 150.
DATA: lo_user TYPE REF TO lcl_persistence_user.
DATA: lv_user TYPE string.
DATA: lv_email TYPE string.
DATA: lv_s_param TYPE string.
DATA: lo_settings TYPE REF TO lcl_settings.
data: lv_body_size type i.
* see https://git-scm.com/book/ch5-2.html
* commit messages should be max 50 characters
@ -202,8 +205,13 @@ CLASS lcl_gui_page_commit IMPLEMENTATION.
ro_html->add( '<div class="row">' ).
ro_html->add( '<label for="c-body">body</label>' ).
lv_body_size = lo_settings->get_commitmsg_body_size( ).
IF lv_body_size > lc_body_col_max.
lv_body_size = lc_body_col_max.
ENDIF.
ro_html->add( |<textarea id="c-body" name="body" rows="10" cols="| &&
|{ lo_settings->get_commitmsg_body_size( ) }" wrap="hard"></textarea>| ).
|{ lv_body_size }"></textarea>| ).
ro_html->add( '<input type="submit" class="hidden-submit">' ).
ro_html->add( '</div>' ).

16
src/zabapgit_page_settings.prog.abap
View File

@ -173,10 +173,8 @@ CLASS lcl_gui_page_settings IMPLEMENTATION.
lv_i_param_value = <ls_post_field>-value.
IF lv_i_param_value < lcl_settings=>c_commitmsg_comment_length_dft.
IF lv_i_param_value < lcl_settings=>c_commitmsg_comment_length_dft.
lv_i_param_value = lcl_settings=>c_commitmsg_comment_length_dft.
ELSEIF lv_i_param_value > lcl_settings=>c_commitmsg_comment_length_max.
lv_i_param_value = lcl_settings=>c_commitmsg_comment_length_max.
ENDIF.
mo_settings->set_commitmsg_comment_length( lv_i_param_value ).
@ -192,10 +190,8 @@ CLASS lcl_gui_page_settings IMPLEMENTATION.
lv_i_param_value = <ls_post_field>-value.
IF lv_i_param_value < lcl_settings=>c_commitmsg_body_size_dft.
IF lv_i_param_value < lcl_settings=>c_commitmsg_body_size_dft.
lv_i_param_value = lcl_settings=>c_commitmsg_body_size_dft.
ELSEIF lv_i_param_value > lcl_settings=>c_commitmsg_body_size_max.
lv_i_param_value = lcl_settings=>c_commitmsg_body_size_max.
ENDIF.
mo_settings->set_commitmsg_body_size( lv_i_param_value ).
@ -298,14 +294,14 @@ CLASS lcl_gui_page_settings IMPLEMENTATION.
CREATE OBJECT ro_html.
ro_html->add( |<h2>Commit Message</h2>| ).
ro_html->add( |<label for="comment_length">Max. length of comment</label>| ).
ro_html->add( |<label for="comment_length">Max. length of comment (recommendation 50)</label>| ).
ro_html->add( |<br>| ).
ro_html->add( |<input name="comment_length" type="number" step="10" size="3" maxlength="3" min="50" max="100"| &&
ro_html->add( |<input name="comment_length" type="number" step="10" size="3" maxlength="3" min="50"| &&
| value="{ mo_settings->get_commitmsg_comment_length( ) }">| ).
ro_html->add( |<br>| ).
ro_html->add( |<label for="body_size">Max. line size of body</label>| ).
ro_html->add( |<label for="body_size">Max. line size of body (recommendation 72)</label>| ).
ro_html->add( |<br>| ).
ro_html->add( |<input name="body_size" type="number" step="10" size="3" maxlength="3" min="50" max="100"| &&
ro_html->add( |<input name="body_size" type="number" step="10" size="3" maxlength="3" min="50"| &&
| value="{ mo_settings->get_commitmsg_body_size( ) }">| ).
ro_html->add( |<br>| ).
ro_html->add( |<br>| ).

2
src/zabapgit_persistence.prog.abap
View File

@ -1535,9 +1535,7 @@ CLASS lcl_settings DEFINITION FINAL.
PUBLIC SECTION.
CONSTANTS: c_commitmsg_comment_length_dft TYPE i VALUE 50.
CONSTANTS: c_commitmsg_comment_length_max TYPE i VALUE 100.
CONSTANTS: c_commitmsg_body_size_dft TYPE i VALUE 72.
CONSTANTS: c_commitmsg_body_size_max TYPE i VALUE 100.
METHODS set_proxy_url
IMPORTING