Merge pull request #1583 from larshp/issue_1449

remove link to plugins #1449

src/ui/zcl_abapgit_gui_router.clas.abap

@@ -53,7 +53,7 @@ CLASS zcl_abapgit_gui_router IMPLEMENTATION.
       EXPORTING
         iv_key = iv_key.
 
-  ENDMETHOD.  "get_page_background
+  ENDMETHOD.
 
 
   METHOD get_page_branch_overview.
@@ -73,7 +73,7 @@ CLASS zcl_abapgit_gui_router IMPLEMENTATION.
 
     ri_page = lo_page.
 
-  ENDMETHOD.  "get_page_branch_overview
+  ENDMETHOD.
 
 
   METHOD get_page_diff.
@@ -101,7 +101,7 @@ CLASS zcl_abapgit_gui_router IMPLEMENTATION.
 
     ri_page = lo_page.
 
-  ENDMETHOD.  "get_page_diff
+  ENDMETHOD.
 
 
   METHOD get_page_playground.
@@ -123,7 +123,7 @@ CLASS zcl_abapgit_gui_router IMPLEMENTATION.
         zcx_abapgit_exception=>raise( |Cannot create page class { lv_class_name }| ).
     ENDTRY.
 
-  ENDMETHOD.  "get_page_playground
+  ENDMETHOD.
 
 
   METHOD get_page_stage.
@@ -168,7 +168,7 @@ CLASS zcl_abapgit_gui_router IMPLEMENTATION.
 
     ENDIF.
 
-  ENDMETHOD.  "get_page_stage
+  ENDMETHOD.
 
 
   METHOD on_event.
@@ -266,9 +266,6 @@ CLASS zcl_abapgit_gui_router IMPLEMENTATION.
       WHEN zif_abapgit_definitions=>gc_action-abapgit_install.                 " Install abapGit
         zcl_abapgit_services_abapgit=>install_abapgit( ).
         ev_state = zif_abapgit_definitions=>gc_event_state-re_render.
-      WHEN zif_abapgit_definitions=>gc_action-abapgit_install_pi.              " Install abapGit plugins
-        zcl_abapgit_services_abapgit=>install_abapgit_pi( ).
-        ev_state = zif_abapgit_definitions=>gc_event_state-re_render.
 
         " REPOSITORY services actions
       WHEN zif_abapgit_definitions=>gc_action-repo_newoffline.                 " New offline repo
@@ -379,5 +376,5 @@ CLASS zcl_abapgit_gui_router IMPLEMENTATION.
         ev_state = zif_abapgit_definitions=>gc_event_state-not_handled.
     ENDCASE.
 
-  ENDMETHOD.        " on_event
+  ENDMETHOD.
 ENDCLASS.

src/ui/zcl_abapgit_gui_view_tutorial.clas.abap

@@ -49,7 +49,7 @@ CLASS ZCL_ABAPGIT_GUI_VIEW_TUTORIAL IMPLEMENTATION.
                   zcl_abapgit_html=>icon( 'star/darkgrey' ) } icon at repo toolbar.</li>| ).
     ro_html->add( '</ul></p>' ).
 
-    ro_html->add( '<h2>abapGit related repositories</h2>' ).
+    ro_html->add( '<h2>abapGit repository</h2>' ).
     ro_html->add( '<p><ul>' ).
     ro_html->add( '<li>' ).
     IF zcl_abapgit_services_abapgit=>is_installed( ) = abap_true.
@@ -61,24 +61,14 @@ CLASS ZCL_ABAPGIT_GUI_VIEW_TUTORIAL IMPLEMENTATION.
       ro_html->add( 'install it as a repository.' ).
     ENDIF.
     ro_html->add( '</li>' ).
-    ro_html->add( '<li>' ).
-    IF zcl_abapgit_services_abapgit=>is_installed_pi( ) = abap_true.
-      ro_html->add( 'abapGit plugins installed in package&nbsp;' ).
-      ro_html->add( zcl_abapgit_services_abapgit=>c_package_plugins ).
-    ELSE.
-      ro_html->add_a( iv_txt = 'install abapGit plugins'
-                      iv_act = zif_abapgit_definitions=>gc_action-abapgit_install_pi ).
-      ro_html->add( ' - you can also install plugins to extend supported object types' ).
-    ENDIF.
-    ro_html->add( '</li>' ).
     ro_html->add( '</ul></p>' ).
 
-  ENDMETHOD. " render_content.
+  ENDMETHOD.
 
 
   METHOD zif_abapgit_gui_page~on_event.
     ev_state = zif_abapgit_definitions=>gc_event_state-not_handled.
-  ENDMETHOD.  " lif_gui_page~on_event.
+  ENDMETHOD.
 
 
   METHOD zif_abapgit_gui_page~render.
@@ -89,5 +79,5 @@ CLASS ZCL_ABAPGIT_GUI_VIEW_TUTORIAL IMPLEMENTATION.
     ro_html->add( render_content( ) ).
     ro_html->add( '</div>' ).
 
-  ENDMETHOD.  "lif_gui_page~render
+  ENDMETHOD.
 ENDCLASS.

src/ui/zcl_abapgit_services_abapgit.clas.abap

@@ -8,9 +8,7 @@ CLASS zcl_abapgit_services_abapgit DEFINITION
     CONSTANTS c_abapgit_homepage TYPE string VALUE 'http://www.abapgit.org' ##NO_TEXT.
     CONSTANTS c_abapgit_wikipage TYPE string VALUE 'http://docs.abapgit.org' ##NO_TEXT.
     CONSTANTS c_package_abapgit TYPE devclass VALUE '$ABAPGIT' ##NO_TEXT.
-    CONSTANTS c_package_plugins TYPE devclass VALUE '$ABAPGIT_PLUGINS' ##NO_TEXT.
     CONSTANTS c_abapgit_url TYPE string VALUE 'https://github.com/larshp/abapGit.git' ##NO_TEXT.
-    CONSTANTS c_plugins_url TYPE string VALUE 'https://github.com/larshp/abapGit-plugins.git' ##NO_TEXT.
 
     CLASS-METHODS open_abapgit_homepage
       RAISING
@@ -22,16 +20,9 @@ CLASS zcl_abapgit_services_abapgit DEFINITION
       RAISING
         zcx_abapgit_exception
         zcx_abapgit_cancel .
-    CLASS-METHODS install_abapgit_pi
-      RAISING
-        zcx_abapgit_exception
-        zcx_abapgit_cancel .
     CLASS-METHODS is_installed
       RETURNING
         VALUE(rv_installed) TYPE abap_bool .
-    CLASS-METHODS is_installed_pi
-      RETURNING
-        VALUE(rv_installed) TYPE abap_bool .
   PRIVATE SECTION.
 
     CLASS-METHODS do_install
@@ -84,7 +75,7 @@ CLASS zcl_abapgit_services_abapgit IMPLEMENTATION.
 
     COMMIT WORK.
 
-  ENDMETHOD.  " do_install.
+  ENDMETHOD.
 
 
   METHOD install_abapgit.
@@ -107,32 +98,7 @@ CLASS zcl_abapgit_services_abapgit IMPLEMENTATION.
                 iv_url     = c_abapgit_url
                 iv_package = c_package_abapgit ).
 
-  ENDMETHOD.  "install_abapgit
-
-
-  METHOD install_abapgit_pi.
-
-    CONSTANTS lc_title TYPE c LENGTH 40 VALUE 'Install abapGit plugins'.
-    DATA lv_text       TYPE c LENGTH 100.
-
-    IF is_installed_pi( ) = abap_true.
-      lv_text = 'Seems like abapGit plugins package is already installed. No changes to be done'.
-      zcl_abapgit_ui_factory=>get_popups( )->popup_to_inform(
-        titlebar              = lc_title
-        text_message          = lv_text ).
-      RETURN.
-    ENDIF.
-
-    lv_text = |Confirm to install current version abapGit plugins to package {
-               c_package_plugins }|.
-
-    do_install( iv_title   = lc_title
-                iv_text    = lv_text
-                iv_url     = c_plugins_url
-                iv_package = c_package_plugins ).
-
-  ENDMETHOD.  "install_abapgit_pi
-
+  ENDMETHOD.
 
   METHOD is_installed.
 
@@ -144,21 +110,7 @@ CLASS zcl_abapgit_services_abapgit IMPLEMENTATION.
         rv_installed = abap_false.
     ENDTRY.
 
-  ENDMETHOD.                    "is_installed
-
-
-  METHOD is_installed_pi.
-
-    TRY.
-        rv_installed = zcl_abapgit_repo_srv=>get_instance( )->is_repo_installed( c_plugins_url ).
-        " TODO, alternative checks for presence in the system
-      CATCH zcx_abapgit_exception.
-        " cannot be installed anyway in this case, e.g. no connection
-        rv_installed = abap_false.
-    ENDTRY.
-
-  ENDMETHOD.                    "is_installed_pi
-
+  ENDMETHOD.
 
   METHOD open_abapgit_homepage.
 
@@ -169,7 +121,7 @@ CLASS zcl_abapgit_services_abapgit IMPLEMENTATION.
       zcx_abapgit_exception=>raise( 'Opening page in external browser failed.' ).
     ENDIF.
 
-  ENDMETHOD.  "open_abapgit_homepage
+  ENDMETHOD.
 
 
   METHOD open_abapgit_wikipage.
@@ -181,5 +133,5 @@ CLASS zcl_abapgit_services_abapgit IMPLEMENTATION.
       zcx_abapgit_exception=>raise( 'Opening page in external browser failed.' ).
     ENDIF.
 
-  ENDMETHOD.  "open_abapgit_wikipage
+  ENDMETHOD.
 ENDCLASS.

src/zif_abapgit_definitions.intf.abap

@@ -400,7 +400,6 @@ INTERFACE zif_abapgit_definitions PUBLIC.
       abapgit_home             TYPE string VALUE 'abapgit_home',
       abapgit_wiki             TYPE string VALUE 'abapgit_wiki',
       abapgit_install          TYPE string VALUE 'abapgit_install',
-      abapgit_install_pi       TYPE string VALUE 'abapgit_install_pi',
 
       zip_import               TYPE string VALUE 'zip_import',
       zip_export               TYPE string VALUE 'zip_export',