- iv_action = iv_action
IMPORTING
ev_filename = lv_filename
ev_line_index = lv_line_index ).
@@ -534,11 +531,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DIFF IMPLEMENTATION.
CLEAR: ev_filename, ev_line_index.
- IF iv_action <> c_patch_action-add AND iv_action <> c_patch_action-remove.
- zcx_abapgit_exception=>raise( |Invalid action { iv_action }| ).
- ENDIF.
-
- FIND FIRST OCCURRENCE OF REGEX `patch_line_` && iv_action && `_(.*)_(\d)+_(\d+)`
+ FIND FIRST OCCURRENCE OF REGEX `patch_line` && `_(.*)_(\d)+_(\d+)`
IN iv_patch
SUBMATCHES ev_filename lv_section ev_line_index.
IF sy-subrc <> 0.
@@ -609,19 +602,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DIFF IMPLEMENTATION.
IF mv_patch_mode = abap_true.
ro_html->add( || ).
-
- ro_html->add_a( iv_txt = |{ c_patch_action-add }|
- iv_act = |patch_section_add('{ is_diff-filename }','{ mv_section_count }')|
- iv_id = |patch_section_add_{ is_diff-filename }_{ mv_section_count }|
- iv_class = |patch_section_add|
- iv_typ = zif_abapgit_html=>c_action_type-dummy ).
-
- ro_html->add_a( iv_txt = |{ c_patch_action-remove }|
- iv_act = |patch_section_remove('{ is_diff-filename }', '{ mv_section_count }')|
- iv_id = |patch_section_remove_{ is_diff-filename }_{ mv_section_count }|
- iv_class = |patch_section_remove|
- iv_typ = zif_abapgit_html=>c_action_type-dummy ).
-
+ ro_html->add_checkbox( iv_id = |patch_section_{ is_diff-filename }_{ mv_section_count }| ).
ro_html->add( ' | ' ).
ELSE.
@@ -913,8 +894,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DIFF IMPLEMENTATION.
CONSTANTS:
BEGIN OF c_css_class,
- patch_active TYPE string VALUE `patch-active` ##NO_TEXT,
- patch TYPE string VALUE `patch` ##NO_TEXT,
+ patch TYPE string VALUE `patch` ##NO_TEXT,
END OF c_css_class.
DATA: lv_id TYPE string,
@@ -929,24 +909,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DIFF IMPLEMENTATION.
lv_id = |{ lv_object }_{ mv_section_count }_{ iv_index }|.
io_html->add( || ).
-
- IF is_diff_line-patch_flag = abap_true.
- lv_left_class = c_css_class-patch_active.
- ELSE.
- lv_right_class = c_css_class-patch_active.
- ENDIF.
-
- io_html->add_a( iv_txt = |{ c_patch_action-add }|
- iv_act = ||
- iv_id = |patch_line_{ c_patch_action-add }_{ lv_id }|
- iv_typ = zif_abapgit_html=>c_action_type-dummy
- iv_class = lv_left_class ).
- io_html->add_a( iv_txt = |{ c_patch_action-remove }|
- iv_act = ||
- iv_id = |patch_line_{ c_patch_action-remove }_{ lv_id }|
- iv_typ = zif_abapgit_html=>c_action_type-dummy
- iv_class = lv_right_class ).
-
+ io_html->add_checkbox( iv_id = |patch_line_{ lv_id }| ).
io_html->add( | | | ).
ELSE.
@@ -962,19 +925,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DIFF IMPLEMENTATION.
METHOD render_patch_head.
io_html->add( || ).
-
- io_html->add_a( iv_txt = |{ c_patch_action-add }|
- iv_act = |patch_file_add('{ is_diff-filename }')|
- iv_id = |patch_file_add_{ is_diff-filename }|
- iv_class = |patch_file_add|
- iv_typ = zif_abapgit_html=>c_action_type-dummy ).
-
- io_html->add_a( iv_txt = |{ c_patch_action-remove }|
- iv_act = |patch_file_remove('{ is_diff-filename }')|
- iv_id = |patch_file_remove_{ is_diff-filename }|
- iv_class = |patch_file_remove|
- iv_typ = zif_abapgit_html=>c_action_type-dummy ).
-
+ io_html->add_checkbox( iv_id = |patch_file_{ is_diff-filename }| ).
io_html->add( ' | ' ).
ENDMETHOD.
@@ -1051,12 +1002,10 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DIFF IMPLEMENTATION.
it_field = lt_fields
CHANGING cg_field = lv_remove ).
- apply_patch_all( iv_action = c_patch_action-add
- iv_patch = lv_add
+ apply_patch_all( iv_patch = lv_add
iv_patch_flag = abap_true ).
- apply_patch_all( iv_action = c_patch_action-remove
- iv_patch = lv_remove
+ apply_patch_all( iv_patch = lv_remove
iv_patch_flag = abap_false ).
add_to_stage( ).
diff --git a/src/ui/zcl_abapgit_gui_page_diff.clas.testclasses.abap b/src/ui/zcl_abapgit_gui_page_diff.clas.testclasses.abap
index 2bc11d43a..4d6cb259e 100644
--- a/src/ui/zcl_abapgit_gui_page_diff.clas.testclasses.abap
+++ b/src/ui/zcl_abapgit_gui_page_diff.clas.testclasses.abap
@@ -8,7 +8,6 @@ CLASS ltcl_patch DEFINITION FINAL FOR TESTING
METHODS:
get_patch_data_add FOR TESTING RAISING cx_static_check,
get_patch_data_remove FOR TESTING RAISING cx_static_check,
- invalid_action FOR TESTING RAISING cx_static_check,
invalid_patch_missing_file FOR TESTING RAISING cx_static_check,
invalid_patch_missing_index FOR TESTING RAISING cx_static_check.
@@ -25,8 +24,7 @@ CLASS ltcl_patch IMPLEMENTATION.
zcl_abapgit_gui_page_diff=>get_patch_data(
EXPORTING
- iv_patch = |patch_line_add_zcl_test_git_add_p.clas.abap_0_19|
- iv_action = |add|
+ iv_patch = |patch_line_zcl_test_git_add_p.clas.abap_0_19|
IMPORTING
ev_filename = lv_file_name
ev_line_index = lv_line_index ).
@@ -48,8 +46,7 @@ CLASS ltcl_patch IMPLEMENTATION.
zcl_abapgit_gui_page_diff=>get_patch_data(
EXPORTING
- iv_patch = |patch_line_remove_ztest_patch.prog.abap_0_39|
- iv_action = |remove|
+ iv_patch = |patch_line_ztest_patch.prog.abap_0_39|
IMPORTING
ev_filename = lv_file_name
ev_line_index = lv_line_index ).
@@ -64,24 +61,6 @@ CLASS ltcl_patch IMPLEMENTATION.
ENDMETHOD.
- METHOD invalid_action.
-
- DATA: lx_error TYPE REF TO zcx_abapgit_exception.
-
- TRY.
- zcl_abapgit_gui_page_diff=>get_patch_data(
- iv_patch = |remove_patch_ztest_patch.prog.abap_39|
- iv_action = |mix| ).
-
- cl_abap_unit_assert=>fail( ).
-
- CATCH zcx_abapgit_exception INTO lx_error.
- cl_abap_unit_assert=>assert_equals(
- exp = |Invalid action mix|
- act = lx_error->get_text( ) ).
- ENDTRY.
-
- ENDMETHOD.
METHOD invalid_patch_missing_file.
@@ -92,8 +71,7 @@ CLASS ltcl_patch IMPLEMENTATION.
TRY.
zcl_abapgit_gui_page_diff=>get_patch_data(
EXPORTING
- iv_patch = |add_patch_39|
- iv_action = |add|
+ iv_patch = |patch_39|
IMPORTING
ev_filename = lv_file_name
ev_line_index = lv_line_index ).
@@ -117,8 +95,7 @@ CLASS ltcl_patch IMPLEMENTATION.
TRY.
zcl_abapgit_gui_page_diff=>get_patch_data(
EXPORTING
- iv_patch = |remove_patch_ztest_patch.prog.abap|
- iv_action = |remove|
+ iv_patch = |patch_ztest_patch.prog.abap|
IMPORTING
ev_filename = lv_file_name
ev_line_index = lv_line_index ).