From 5b93872199a07c1c842b82460759a734993db93c Mon Sep 17 00:00:00 2001
From: Lars Hvam <larshp@hotmail.com>
Date: Tue, 15 Sep 2020 08:14:42 +0200
Subject: [PATCH] reduce existing string templates (#3886)

---
 src/objects/zcl_abapgit_objects_saxx_super.clas.abap | 2 +-
 src/ui/db/zcl_abapgit_gui_page_db_edit.clas.abap     | 2 +-
 src/ui/zcl_abapgit_gui_chunk_lib.clas.abap           | 4 ++--
 src/ui/zcl_abapgit_gui_page_tag.clas.abap            | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/objects/zcl_abapgit_objects_saxx_super.clas.abap b/src/objects/zcl_abapgit_objects_saxx_super.clas.abap
index 64848cbfe..dca3f3968 100644
--- a/src/objects/zcl_abapgit_objects_saxx_super.clas.abap
+++ b/src/objects/zcl_abapgit_objects_saxx_super.clas.abap
@@ -134,7 +134,7 @@ CLASS zcl_abapgit_objects_saxx_super IMPLEMENTATION.
         OTHERS         = 3 ).
 
     IF sy-subrc <> 0.
-      zcx_abapgit_exception=>raise( |Error occured while locking { ms_item-obj_type } | && lv_objname ).
+      zcx_abapgit_exception=>raise( |Error occured while locking { ms_item-obj_type } { lv_objname }| ).
     ENDIF.
 
   ENDMETHOD.
diff --git a/src/ui/db/zcl_abapgit_gui_page_db_edit.clas.abap b/src/ui/db/zcl_abapgit_gui_page_db_edit.clas.abap
index 9e7ecdcc2..578ae3cea 100644
--- a/src/ui/db/zcl_abapgit_gui_page_db_edit.clas.abap
+++ b/src/ui/db/zcl_abapgit_gui_page_db_edit.clas.abap
@@ -114,7 +114,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DB_EDIT IMPLEMENTATION.
     ri_html->add( '</td></tr></table>' ).
 
     " Form
-    ri_html->add( |<form id="db_form" method="post" action="sapevent:| && |{ c_action-update }">| ).
+    ri_html->add( |<form id="db_form" method="post" action="sapevent:{ c_action-update }">| ).
     ri_html->add( |<input type="hidden" name="type" value="{ ms_key-type }">| ).
     ri_html->add( |<input type="hidden" name="value" value="{ ms_key-value }">| ).
     ri_html->add( |<textarea rows="20" cols="100" name="xmldata">{ lv_data }</textarea>| ).
diff --git a/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap b/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap
index 63d58cea4..1030f6fe3 100644
--- a/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap
+++ b/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap
@@ -811,7 +811,7 @@ CLASS ZCL_ABAPGIT_GUI_CHUNK_LIB IMPLEMENTATION.
         lv_display_url = io_repo_online->get_commit_display_url( lv_commit_hash ).
 
         ii_html->add_a( iv_txt   = |{ lv_icon_commit }{ lv_commit_short_hash }|
-                        iv_act   = |{ zif_abapgit_definitions=>c_action-url }?| && lv_display_url
+                        iv_act   = |{ zif_abapgit_definitions=>c_action-url }?{ lv_display_url }|
                         iv_class = |url| ).
       CATCH zcx_abapgit_exception.
         ii_html->add( |<span class="url">{ lv_icon_commit }{ lv_commit_short_hash }</span>| ).
@@ -824,7 +824,7 @@ CLASS ZCL_ABAPGIT_GUI_CHUNK_LIB IMPLEMENTATION.
 
     CREATE OBJECT ri_html TYPE zcl_abapgit_html.
     ri_html->add( '<div class="dummydiv warning">' ).
-    ri_html->add( |{ ri_html->icon( 'exclamation-triangle/yellow' ) }| && | { iv_text }| ).
+    ri_html->add( |{ ri_html->icon( 'exclamation-triangle/yellow' ) } { iv_text }| ).
     ri_html->add( '</div>' ).
 
   ENDMETHOD.
diff --git a/src/ui/zcl_abapgit_gui_page_tag.clas.abap b/src/ui/zcl_abapgit_gui_page_tag.clas.abap
index bab10ad0c..2b99e597a 100644
--- a/src/ui/zcl_abapgit_gui_page_tag.clas.abap
+++ b/src/ui/zcl_abapgit_gui_page_tag.clas.abap
@@ -308,7 +308,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_TAG IMPLEMENTATION.
       IF lv_body_size > lc_body_col_max.
         lv_body_size = lc_body_col_max.
       ENDIF.
-      ri_html->add( |<textarea id="c-body" name="body" rows="10" cols="| && |{ lv_body_size }"></textarea>| ).
+      ri_html->add( |<textarea id="c-body" name="body" rows="10" cols="{ lv_body_size }"></textarea>| ).
 
     ENDIF.