From 609abed8fb7dde96ce5e16ca886fb9362bf23763 Mon Sep 17 00:00:00 2001 From: Marc Bernard <59966492+mbtools@users.noreply.github.com> Date: Tue, 29 Aug 2023 01:46:40 -0400 Subject: [PATCH] Downport: Fix syntax errors in unit tests (#6437) Co-authored-by: Lars Hvam --- ...zcl_abapgit_git_commit.clas.testclasses.abap | 14 ++++++++------ ..._abapgit_services_repo.clas.testclasses.abap | 17 ++++++++++++----- 2 files changed, 20 insertions(+), 11 deletions(-) diff --git a/src/git/zcl_abapgit_git_commit.clas.testclasses.abap b/src/git/zcl_abapgit_git_commit.clas.testclasses.abap index 78098c7c9..4290359c9 100644 --- a/src/git/zcl_abapgit_git_commit.clas.testclasses.abap +++ b/src/git/zcl_abapgit_git_commit.clas.testclasses.abap @@ -193,15 +193,17 @@ CLASS ltc_parent_handling IMPLEMENTATION. METHOD parent_should_be_missing. - cl_abap_unit_assert=>assert_true( - zcl_abapgit_git_commit=>is_missing( it_commits = mt_commits - iv_sha1 = iv_sha1 ) ). + cl_abap_unit_assert=>assert_equals( + act = zcl_abapgit_git_commit=>is_missing( it_commits = mt_commits + iv_sha1 = iv_sha1 ) + exp = abap_true ). ENDMETHOD. METHOD parent_should_not_be_missing. - cl_abap_unit_assert=>assert_false( - zcl_abapgit_git_commit=>is_missing( it_commits = mt_commits - iv_sha1 = iv_sha1 ) ). + cl_abap_unit_assert=>assert_equals( + act = zcl_abapgit_git_commit=>is_missing( it_commits = mt_commits + iv_sha1 = iv_sha1 ) + exp = abap_false ). ENDMETHOD. METHOD given_commit. diff --git a/src/ui/routing/zcl_abapgit_services_repo.clas.testclasses.abap b/src/ui/routing/zcl_abapgit_services_repo.clas.testclasses.abap index 339b6f20d..ea9cde061 100644 --- a/src/ui/routing/zcl_abapgit_services_repo.clas.testclasses.abap +++ b/src/ui/routing/zcl_abapgit_services_repo.clas.testclasses.abap @@ -213,7 +213,9 @@ CLASS ltcl_create_package IMPLEMENTATION. METHOD then_popup_is_shown. - cl_abap_unit_assert=>assert_true( mo_popups_mock->was_create_package_popup_shown( ) ). + cl_abap_unit_assert=>assert_equals( + act = mo_popups_mock->was_create_package_popup_shown( ) + exp = abap_true ). ENDMETHOD. @@ -227,7 +229,9 @@ CLASS ltcl_create_package IMPLEMENTATION. METHOD then_no_package_is_created. - cl_abap_unit_assert=>assert_false( mo_sap_package_mock->was_create_called( ) ). + cl_abap_unit_assert=>assert_equals( + act = mo_sap_package_mock->was_create_called( ) + exp = abap_false ). ENDMETHOD. @@ -241,10 +245,13 @@ CLASS ltcl_create_package IMPLEMENTATION. METHOD then_package_is_created. - cl_abap_unit_assert=>assert_true( mo_sap_package_mock->was_create_called( ) ). cl_abap_unit_assert=>assert_equals( - exp = mv_package - act = mv_created_package ). + act = mo_sap_package_mock->was_create_called( ) + exp = abap_true ). + + cl_abap_unit_assert=>assert_equals( + exp = mv_package + act = mv_created_package ). ENDMETHOD.