Add package parameter to zif_abapgit_object~delete (#3114)

src/objects/zcl_abapgit_object_enho.clas.abap

@@ -138,7 +138,7 @@ CLASS ZCL_ABAPGIT_OBJECT_ENHO IMPLEMENTATION.
 
 
     IF zif_abapgit_object~exists( ) = abap_true.
-      zif_abapgit_object~delete( ).
+      zif_abapgit_object~delete( iv_package ).
     ENDIF.
 
     io_xml->read( EXPORTING iv_name = 'TOOL'

src/objects/zcl_abapgit_object_enhs.clas.abap

@@ -87,7 +87,7 @@ CLASS ZCL_ABAPGIT_OBJECT_ENHS IMPLEMENTATION.
           li_enhs      TYPE REF TO zif_abapgit_object_enhs.
 
     IF zif_abapgit_object~exists( ) = abap_true.
-      zif_abapgit_object~delete( ).
+      zif_abapgit_object~delete( iv_package ).
     ENDIF.
 
     io_xml->read( EXPORTING iv_name = 'TOOL'

src/objects/zcl_abapgit_object_ensc.clas.abap

@@ -69,7 +69,7 @@ CLASS ZCL_ABAPGIT_OBJECT_ENSC IMPLEMENTATION.
                   CHANGING  cg_data = lt_comp_spots ).
 
     IF zif_abapgit_object~exists( ) = abap_true.
-      zif_abapgit_object~delete( ).
+      zif_abapgit_object~delete( iv_package ).
     ENDIF.
 
     lv_package = iv_package.

src/objects/zcl_abapgit_object_iaxu.clas.abap

@@ -241,7 +241,7 @@ CLASS zcl_abapgit_object_iaxu IMPLEMENTATION.
     ls_attr-devclass = iv_package.
 
     IF zif_abapgit_object~exists( ) = abap_true.
-      zif_abapgit_object~delete( ).
+      zif_abapgit_object~delete( iv_package ).
     ENDIF.
 
     save( is_attr = ls_attr ).

src/objects/zcl_abapgit_object_iobj.clas.abap

@@ -55,15 +55,10 @@ CLASS zcl_abapgit_object_iobj IMPLEMENTATION.
     DATA: lt_iobjname     TYPE STANDARD TABLE OF t_iobj,
           lv_object       TYPE string,
           lv_object_class TYPE string,
-          ls_tadir        TYPE zif_abapgit_definitions=>ty_tadir,
           lv_transp_pkg   TYPE abap_bool.
 
-    ls_tadir = zcl_abapgit_factory=>get_tadir( )->read_single(
+    lv_transp_pkg = zcl_abapgit_factory=>get_sap_package( iv_package
-                                                   iv_object   = ms_item-obj_type
+                                      )->are_changes_recorded_in_tr_req( ).
-                                                   iv_obj_name = ms_item-obj_name ).
-
-    lv_transp_pkg =
-    zcl_abapgit_factory=>get_sap_package( iv_package = ls_tadir-devclass )->are_changes_recorded_in_tr_req( ).
 
     APPEND ms_item-obj_name TO lt_iobjname.
 

src/objects/zcl_abapgit_object_sfpi.clas.abap

@@ -104,7 +104,7 @@ CLASS ZCL_ABAPGIT_OBJECT_SFPI IMPLEMENTATION.
     lv_xstr = cl_ixml_80_20=>render_to_xstring( io_xml->get_raw( ) ).
 
     IF zif_abapgit_object~exists( ) = abap_true.
-      zif_abapgit_object~delete( ).
+      zif_abapgit_object~delete( iv_package ).
     ENDIF.
 
     TRY.

src/objects/zcl_abapgit_object_shi3.clas.abap

@@ -204,7 +204,7 @@ CLASS ZCL_ABAPGIT_OBJECT_SHI3 IMPLEMENTATION.
                   CHANGING  cg_data = lt_texts ).
 
     IF zif_abapgit_object~exists( ) = abap_true.
-      zif_abapgit_object~delete( ).
+      zif_abapgit_object~delete( iv_package ).
     ENDIF.
 
     CALL FUNCTION 'STREE_HIERARCHY_SAVE'

src/objects/zcl_abapgit_object_sqsc.clas.abap

@@ -103,6 +103,7 @@ CLASS zcl_abapgit_object_sqsc DEFINITION
     METHODS:
       delete_interface_if_it_exists
         IMPORTING
+          iv_package   TYPE devclass
           iv_interface TYPE ty_abap_name
         RAISING
           zcx_abapgit_exception.
@@ -161,7 +162,7 @@ CLASS ZCL_ABAPGIT_OBJECT_SQSC IMPLEMENTATION.
           is_item     = ls_item
           iv_language = mv_language.
 
-      lo_interface->zif_abapgit_object~delete( ).
+      lo_interface->zif_abapgit_object~delete( iv_package ).
 
     ENDIF.
 
@@ -203,7 +204,9 @@ CLASS ZCL_ABAPGIT_OBJECT_SQSC IMPLEMENTATION.
 
     IF zif_abapgit_object~exists( ) = abap_false.
 
-      delete_interface_if_it_exists( ls_proxy-header-interface_pool ).
+      delete_interface_if_it_exists(
+          iv_package   = iv_package
+          iv_interface = ls_proxy-header-interface_pool ).
 
       CALL METHOD mo_proxy->('IF_DBPROC_PROXY_UI~CREATE')
         EXPORTING

src/objects/zcl_abapgit_object_tran.clas.abap

@@ -553,7 +553,7 @@ CLASS ZCL_ABAPGIT_OBJECT_TRAN IMPLEMENTATION.
 
 
     IF zif_abapgit_object~exists( ) = abap_true.
-      zif_abapgit_object~delete( ).
+      zif_abapgit_object~delete( iv_package ).
     ENDIF.
 
     io_xml->read( EXPORTING iv_name = 'TSTC'

src/objects/zcl_abapgit_object_xslt.clas.abap

@@ -103,7 +103,7 @@ CLASS ZCL_ABAPGIT_OBJECT_XSLT IMPLEMENTATION.
 
 
     IF zif_abapgit_object~exists( ) = abap_true.
-      zif_abapgit_object~delete( ).
+      zif_abapgit_object~delete( iv_package ).
     ENDIF.
 
     io_xml->read( EXPORTING iv_name = 'ATTRIBUTES'

src/objects/zcl_abapgit_objects_saxx_super.clas.abap

@@ -240,7 +240,7 @@ CLASS ZCL_ABAPGIT_OBJECTS_SAXX_SUPER IMPLEMENTATION.
         cg_data = <lg_data> ).
 
     IF zif_abapgit_object~exists( ) = abap_true.
-      zif_abapgit_object~delete( ).
+      zif_abapgit_object~delete( iv_package ).
     ENDIF.
 
     TRY.

src/objects/zif_abapgit_object.intf.abap

@@ -33,6 +33,8 @@ INTERFACE zif_abapgit_object
     RAISING
       zcx_abapgit_exception .
   METHODS delete
+    IMPORTING
+      iv_package TYPE devclass
     RAISING
       zcx_abapgit_exception .
   METHODS exists

src/zcl_abapgit_objects.clas.abap

@@ -181,7 +181,8 @@ CLASS zcl_abapgit_objects DEFINITION
         !iv_package TYPE devclass .
     CLASS-METHODS delete_obj
       IMPORTING
-        !is_item TYPE zif_abapgit_definitions=>ty_item
+        !iv_package TYPE devclass
+        !is_item    TYPE zif_abapgit_definitions=>ty_item
       RAISING
         zcx_abapgit_exception .
     CLASS-METHODS compare_remote_to_local
@@ -516,7 +517,9 @@ CLASS ZCL_ABAPGIT_OBJECTS IMPLEMENTATION.
           CLEAR ls_item.
           ls_item-obj_type = <ls_tadir>-object.
           ls_item-obj_name = <ls_tadir>-obj_name.
-          delete_obj( ls_item ).
+          delete_obj(
+            iv_package = <ls_tadir>-devclass
+            is_item    = ls_item ).
 
 * make sure to save object deletions
           COMMIT WORK.
@@ -542,7 +545,7 @@ CLASS ZCL_ABAPGIT_OBJECTS IMPLEMENTATION.
       li_obj = create_object( is_item     = is_item
                               iv_language = zif_abapgit_definitions=>c_english ).
 
-      li_obj->delete( ).
+      li_obj->delete( iv_package ).
 
       IF li_obj->get_metadata( )-delete_tadir = abap_true.
         CALL FUNCTION 'TR_TADIR_INTERFACE'