SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-04-30 20:03:20 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Omit parameter name where possible (#1704)

Browse Source 
* zcl_abapgit_2fa_github_auth omit parameter name

* ecatt omit parameter names

* zcl_abapgit_ecatt_script_downl pretty print

* zcl_abapgit_ecatt_script_downl omit parameter name

* zcl_abapgit_ecatt_val_obj_upl omit parameter name

* zcl_abapgit_file_status omit parameter name

* zcl_abapgit_gui omit parameter name

* zcl_abapgit_gui_page_boverview omit parameter name

* zcl_abapgit_syntax_highlighter omit parameter name
This commit is contained in:
Lars Hvam 2018-07-28 07:25:28 +02:00 committed by GitHub
parent 7a7587a481
commit 62580af494
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
9 changed files with 180 additions and 180 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/http/zcl_abapgit_2fa_github_auth.clas.abap
View File

@ -210,7 +210,7 @@ CLASS ZCL_ABAPGIT_2FA_GITHUB_AUTH IMPLEMENTATION.
" 2. Create an access token which can be used instead of a password " 2. Create an access token which can be used instead of a password
" https://developer.github.com/v3/oauth_authorizations/#create-a-new-authorization " https://developer.github.com/v3/oauth_authorizations/#create-a-new-authorization
set_new_token_request( ii_request = li_http_client->request ). set_new_token_request( li_http_client->request ).
li_http_client->send( EXCEPTIONS OTHERS = 1 ). li_http_client->send( EXCEPTIONS OTHERS = 1 ).
IF sy-subrc <> 0. IF sy-subrc <> 0.

7
src/objects/ecatt/zcl_abapgit_ecatt_config_downl.clas.abap
View File

@ -27,7 +27,9 @@ CLASS zcl_abapgit_ecatt_config_downl DEFINITION
ENDCLASS. ENDCLASS.
CLASS zcl_abapgit_ecatt_config_downl IMPLEMENTATION.
CLASS ZCL_ABAPGIT_ECATT_CONFIG_DOWNL IMPLEMENTATION.
METHOD download. METHOD download.
@ -69,7 +71,7 @@ CLASS zcl_abapgit_ecatt_config_downl IMPLEMENTATION.
ENDIF. ENDIF.
ENDLOOP. ENDLOOP.
set_variants_to_dom( im_params = ecatt_config->params ). set_variants_to_dom( ecatt_config->params ).
download_data( ). download_data( ).
@ -102,5 +104,4 @@ CLASS zcl_abapgit_ecatt_config_downl IMPLEMENTATION.
rv_xml_stream_size = mv_xml_stream_size. rv_xml_stream_size = mv_xml_stream_size.
ENDMETHOD. ENDMETHOD.
ENDCLASS. ENDCLASS.

6
src/objects/ecatt/zcl_abapgit_ecatt_data_downl.clas.abap
View File

@ -32,7 +32,8 @@ CLASS zcl_abapgit_ecatt_data_downl DEFINITION
ENDCLASS. ENDCLASS.
CLASS zcl_abapgit_ecatt_data_downl IMPLEMENTATION.
CLASS ZCL_ABAPGIT_ECATT_DATA_DOWNL IMPLEMENTATION.
METHOD download. METHOD download.
@ -79,7 +80,7 @@ CLASS zcl_abapgit_ecatt_data_downl IMPLEMENTATION.
* MS180406 * MS180406
set_var_mode_to_dom( ). set_var_mode_to_dom( ).
* ENDMS180406 * ENDMS180406
set_variants_to_dom( im_params = ecatt_data->params ). set_variants_to_dom( ecatt_data->params ).
* download_schema( ). * download_schema( ).
download_data( ). download_data( ).
@ -120,5 +121,4 @@ CLASS zcl_abapgit_ecatt_data_downl IMPLEMENTATION.
mv_generate_xml_no_download = iv_generate_xml_no_download. mv_generate_xml_no_download = iv_generate_xml_no_download.
ENDMETHOD. ENDMETHOD.
ENDCLASS. ENDCLASS.

277
src/objects/ecatt/zcl_abapgit_ecatt_script_downl.clas.abap
View File

@ -56,7 +56,9 @@ CLASS zcl_abapgit_ecatt_script_downl DEFINITION
ENDCLASS. ENDCLASS.
CLASS zcl_abapgit_ecatt_script_downl IMPLEMENTATION.
CLASS ZCL_ABAPGIT_ECATT_SCRIPT_DOWNL IMPLEMENTATION.
METHOD download. METHOD download.
@ -94,7 +96,7 @@ CLASS zcl_abapgit_ecatt_script_downl IMPLEMENTATION.
* set_params_to_schema( ). * set_params_to_schema( ).
TRY. TRY.
get_general_params_data( im_params = ecatt_script->params ). get_general_params_data( ecatt_script->params ).
CATCH cx_ecatt_apl INTO lx_ecatt. "#EC NOHANDLER CATCH cx_ecatt_apl INTO lx_ecatt. "#EC NOHANDLER
* proceed with download and report errors later * proceed with download and report errors later
ENDTRY. ENDTRY.
@ -107,7 +109,7 @@ CLASS zcl_abapgit_ecatt_script_downl IMPLEMENTATION.
set_general_params_data_to_dom( ). set_general_params_data_to_dom( ).
IF NOT wa_parm-pstruc_typ IS INITIAL. IF NOT wa_parm-pstruc_typ IS INITIAL.
set_deep_stru_to_dom( ecatt_script->params ). set_deep_stru_to_dom( ecatt_script->params ).
set_deep_data_to_dom( im_params = ecatt_script->params ). set_deep_data_to_dom( ecatt_script->params ).
IF wa_parm-xmlref_typ EQ cl_apl_ecatt_const=>ref_type_c_tcd. IF wa_parm-xmlref_typ EQ cl_apl_ecatt_const=>ref_type_c_tcd.
set_control_data_for_tcd( is_param = wa_parm set_control_data_for_tcd( is_param = wa_parm
io_params = ecatt_script->params ). io_params = ecatt_script->params ).
@ -146,6 +148,51 @@ CLASS zcl_abapgit_ecatt_script_downl IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD escape_control_data.
" Downport
DATA: li_iter TYPE REF TO if_ixml_node_iterator,
li_textit TYPE REF TO if_ixml_node_iterator,
li_abapctrl TYPE REF TO if_ixml_node_collection,
li_text TYPE REF TO if_ixml_text,
li_filter TYPE REF TO if_ixml_node_filter,
li_list TYPE REF TO if_ixml_node_list,
lv_value TYPE etdom_name,
li_vars TYPE REF TO if_ixml_element,
li_elem TYPE REF TO if_ixml_element.
li_vars = ii_element->find_from_name_ns( iv_tabname ).
li_filter = ii_element->create_filter_node_type(
if_ixml_node=>co_node_text ).
IF li_vars IS NOT INITIAL.
li_abapctrl = ii_element->get_elements_by_tag_name_ns( iv_node ).
* just for debugging
li_iter = li_abapctrl->create_iterator( ).
li_elem ?= li_iter->get_next( ).
WHILE li_elem IS NOT INITIAL.
li_list = li_elem->get_children( ).
li_textit = li_list->create_rev_iterator_filtered( li_filter ).
li_text ?= li_textit->get_next( ).
IF li_text IS NOT INITIAL.
lv_value = li_text->get_data( ).
IF lv_value(1) = cl_abap_char_utilities=>minchar.
REPLACE SECTION OFFSET 0 LENGTH 1 OF lv_value WITH space.
li_text->set_value( value = lv_value ).
ENDIF.
ENDIF.
CLEAR: li_textit, li_list, li_elem, lv_value.
li_elem ?= li_iter->get_next( ).
ENDWHILE.
CLEAR: li_abapctrl, li_elem, li_iter.
ENDIF.
ENDMETHOD.
METHOD get_xml_stream. METHOD get_xml_stream.
rv_xml_stream = mv_xml_stream. rv_xml_stream = mv_xml_stream.
@ -160,60 +207,81 @@ CLASS zcl_abapgit_ecatt_script_downl IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD set_script_to_template. METHOD set_artmp_to_template.
" Downport " Downport
DATA: DATA: li_artmp_node TYPE REF TO if_ixml_element,
lt_text TYPE etxml_line_tabtype, lv_rc TYPE sy-subrc,
li_element TYPE REF TO if_ixml_element, lv_text TYPE string,
lv_rc TYPE sy-subrc. lv_rc_args_tmpl TYPE int4,
lv_errmsg TYPE string.
ecatt_script->get_script_text( li_artmp_node = template_over_all->create_simple_element(
CHANGING name = 'ECET_ARTMP'
scripttext = lt_text ). parent = root_node ).
mi_script_node = template_over_all->create_simple_element( ecatt_extprog->get_args_tmpl(
name = 'SCRIPT'
parent = root_node ).
IF mi_script_node IS INITIAL.
me->raise_download_exception(
textid = cx_ecatt_apl_util=>download_processing
previous = ex_ecatt
called_method = 'CL_APL_ECATT_SCRIPT_DOWNLOAD->SET_SCRIPT_TO_TEMPLATE' ) .
ENDIF.
CALL FUNCTION 'SDIXML_DATA_TO_DOM'
EXPORTING
name = 'ETXML_LINE_TABTYPE'
dataobject = lt_text
IMPORTING IMPORTING
data_as_dom = li_element ex_xml_arg_tmpl = lv_text
CHANGING ex_rc = lv_rc_args_tmpl
document = template_over_all ex_errmsg = lv_errmsg ).
EXCEPTIONS
illegal_name = 1
OTHERS = 2.
IF sy-subrc <> 0.
me->raise_download_exception(
textid = cx_ecatt_apl_util=>download_processing
previous = ex_ecatt
called_method = 'CL_APL_ECATT_SCRIPT_DOWNLOAD->SET_SCRIPT_TO_TEMPLATE' ).
IF li_artmp_node IS INITIAL OR lv_rc_args_tmpl > 0.
me->raise_download_exception(
textid = cx_ecatt_apl_util=>download_processing
previous = ex_ecatt
called_method = 'CL_APL_ECATT_SCRIPT_DOWNLOAD->SET_ARTMP_TO_TEMPLATE'
free_text = lv_errmsg ).
ENDIF. ENDIF.
lv_rc = mi_script_node->append_child( li_element ). lv_rc = li_artmp_node->set_value( value = lv_text ).
IF lv_rc <> 0. IF lv_rc <> 0.
me->raise_download_exception( me->raise_download_exception(
textid = cx_ecatt_apl_util=>download_processing textid = cx_ecatt_apl_util=>download_processing
previous = ex_ecatt previous = ex_ecatt
called_method = 'CL_APL_ECATT_SCRIPT_DOWNLOAD->SET_SCRIPT_TO_TEMPLATE' ). called_method = 'CL_APL_ECATT_SCRIPT_DOWNLOAD->SET_ARTMP_TO_TEMPLATE' ).
ENDIF. ENDIF.
ENDMETHOD. ENDMETHOD.
METHOD set_blob_to_template.
" Downport
DATA: li_blob_node TYPE REF TO if_ixml_element,
lv_rc TYPE sy-subrc,
lv_text TYPE string.
li_blob_node = template_over_all->create_simple_element(
name = 'ECET_BLOBS'
parent = root_node ).
IF li_blob_node IS INITIAL.
me->raise_download_exception(
textid = cx_ecatt_apl_util=>download_processing
previous = ex_ecatt
called_method = 'CL_APL_ECATT_SCRIPT_DOWNLOAD->SET_BLOB_TO_TEMPLATE' ).
ENDIF.
ecatt_extprog->get_blob(
EXPORTING
im_whole_data = 1
IMPORTING
ex_xml_blob = lv_text ).
lv_rc = li_blob_node->set_value( value = lv_text ).
IF lv_rc <> 0.
me->raise_download_exception(
textid = cx_ecatt_apl_util=>download_processing
previous = ex_ecatt
called_method = 'CL_APL_ECATT_SCRIPT_DOWNLOAD->SET_BLOB_TO_TEMPLATE' ).
ENDIF.
ENDMETHOD. "SET_BLOB_TO_TEMPLATE
METHOD set_control_data_for_tcd. METHOD set_control_data_for_tcd.
" Downport " Downport
@ -361,125 +429,56 @@ CLASS zcl_abapgit_ecatt_script_downl IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD escape_control_data. METHOD set_script_to_template.
" Downport " Downport
DATA: li_iter TYPE REF TO if_ixml_node_iterator, DATA:
li_textit TYPE REF TO if_ixml_node_iterator, lt_text TYPE etxml_line_tabtype,
li_abapctrl TYPE REF TO if_ixml_node_collection, li_element TYPE REF TO if_ixml_element,
li_text TYPE REF TO if_ixml_text, lv_rc TYPE sy-subrc.
li_filter TYPE REF TO if_ixml_node_filter,
li_list TYPE REF TO if_ixml_node_list,
lv_value TYPE etdom_name,
li_vars TYPE REF TO if_ixml_element,
li_elem TYPE REF TO if_ixml_element.
li_vars = ii_element->find_from_name_ns( ecatt_script->get_script_text(
name = iv_tabname ). CHANGING
li_filter = ii_element->create_filter_node_type( scripttext = lt_text ).
if_ixml_node=>co_node_text ).
IF li_vars IS NOT INITIAL.
li_abapctrl = ii_element->get_elements_by_tag_name_ns( name = iv_node ).
* just for debugging mi_script_node = template_over_all->create_simple_element(
li_iter = li_abapctrl->create_iterator( ). name = 'SCRIPT'
li_elem ?= li_iter->get_next( ). parent = root_node ).
WHILE li_elem IS NOT INITIAL.
li_list = li_elem->get_children( ).
li_textit = li_list->create_rev_iterator_filtered( IF mi_script_node IS INITIAL.
filter = li_filter ).
li_text ?= li_textit->get_next( ).
IF li_text IS NOT INITIAL.
lv_value = li_text->get_data( ).
IF lv_value(1) = cl_abap_char_utilities=>minchar.
REPLACE SECTION OFFSET 0 LENGTH 1 OF lv_value WITH space.
li_text->set_value( value = lv_value ).
ENDIF.
ENDIF.
CLEAR: li_textit, li_list, li_elem, lv_value.
li_elem ?= li_iter->get_next( ).
ENDWHILE.
CLEAR: li_abapctrl, li_elem, li_iter.
ENDIF.
ENDMETHOD.
METHOD set_blob_to_template.
" Downport
DATA: li_blob_node TYPE REF TO if_ixml_element,
lv_rc TYPE sy-subrc,
lv_text TYPE string.
li_blob_node = template_over_all->create_simple_element(
name = 'ECET_BLOBS'
parent = root_node ).
IF li_blob_node IS INITIAL.
me->raise_download_exception( me->raise_download_exception(
textid = cx_ecatt_apl_util=>download_processing textid = cx_ecatt_apl_util=>download_processing
previous = ex_ecatt previous = ex_ecatt
called_method = 'CL_APL_ECATT_SCRIPT_DOWNLOAD->SET_BLOB_TO_TEMPLATE' ). called_method = 'CL_APL_ECATT_SCRIPT_DOWNLOAD->SET_SCRIPT_TO_TEMPLATE' ) .
ENDIF. ENDIF.
ecatt_extprog->get_blob( CALL FUNCTION 'SDIXML_DATA_TO_DOM'
EXPORTING EXPORTING
im_whole_data = 1 name = 'ETXML_LINE_TABTYPE'
dataobject = lt_text
IMPORTING IMPORTING
ex_xml_blob = lv_text ). data_as_dom = li_element
CHANGING
document = template_over_all
EXCEPTIONS
illegal_name = 1
OTHERS = 2.
IF sy-subrc <> 0.
me->raise_download_exception(
textid = cx_ecatt_apl_util=>download_processing
previous = ex_ecatt
called_method = 'CL_APL_ECATT_SCRIPT_DOWNLOAD->SET_SCRIPT_TO_TEMPLATE' ).
lv_rc = li_blob_node->set_value( value = lv_text ). ENDIF.
lv_rc = mi_script_node->append_child( li_element ).
IF lv_rc <> 0. IF lv_rc <> 0.
me->raise_download_exception( me->raise_download_exception(
textid = cx_ecatt_apl_util=>download_processing textid = cx_ecatt_apl_util=>download_processing
previous = ex_ecatt previous = ex_ecatt
called_method = 'CL_APL_ECATT_SCRIPT_DOWNLOAD->SET_BLOB_TO_TEMPLATE' ). called_method = 'CL_APL_ECATT_SCRIPT_DOWNLOAD->SET_SCRIPT_TO_TEMPLATE' ).
ENDIF.
ENDMETHOD. "SET_BLOB_TO_TEMPLATE
METHOD set_artmp_to_template.
" Downport
DATA: li_artmp_node TYPE REF TO if_ixml_element,
lv_rc TYPE sy-subrc,
lv_text TYPE string,
lv_rc_args_tmpl TYPE int4,
lv_errmsg TYPE string.
li_artmp_node = template_over_all->create_simple_element(
name = 'ECET_ARTMP'
parent = root_node ).
ecatt_extprog->get_args_tmpl(
IMPORTING
ex_xml_arg_tmpl = lv_text
ex_rc = lv_rc_args_tmpl
ex_errmsg = lv_errmsg ).
IF li_artmp_node IS INITIAL OR lv_rc_args_tmpl > 0.
me->raise_download_exception(
textid = cx_ecatt_apl_util=>download_processing
previous = ex_ecatt
called_method = 'CL_APL_ECATT_SCRIPT_DOWNLOAD->SET_ARTMP_TO_TEMPLATE'
free_text = lv_errmsg ).
ENDIF.
lv_rc = li_artmp_node->set_value( value = lv_text ).
IF lv_rc <> 0.
me->raise_download_exception(
textid = cx_ecatt_apl_util=>download_processing
previous = ex_ecatt
called_method = 'CL_APL_ECATT_SCRIPT_DOWNLOAD->SET_ARTMP_TO_TEMPLATE' ).
ENDIF. ENDIF.
ENDMETHOD. ENDMETHOD.
ENDCLASS. ENDCLASS.

4
src/objects/ecatt/zcl_abapgit_ecatt_val_obj_upl.clas.abap
View File

@ -47,7 +47,7 @@ ENDCLASS.
CLASS zcl_abapgit_ecatt_val_obj_upl IMPLEMENTATION. CLASS ZCL_ABAPGIT_ECATT_VAL_OBJ_UPL IMPLEMENTATION.
METHOD get_business_msgs_from_dom. METHOD get_business_msgs_from_dom.
@ -288,7 +288,7 @@ CLASS zcl_abapgit_ecatt_val_obj_upl IMPLEMENTATION.
ENDTRY. ENDTRY.
TRY. TRY.
get_params_from_dom_new( im_params = lo_params ). get_params_from_dom_new( lo_params ).
CATCH cx_ecatt_apl INTO lx_ex. CATCH cx_ecatt_apl INTO lx_ex.
lv_exc_occ = 'X'. lv_exc_occ = 'X'.
ENDTRY. ENDTRY.

56
src/syntax/zcl_abapgit_syntax_highlighter.clas.testclasses.abap
View File

@ -32,7 +32,7 @@ CLASS ltcl_syntax_cases DEFINITION FINAL FOR TESTING RISK LEVEL HARMLESS
test_xml_04 FOR TESTING, test_xml_04 FOR TESTING,
test_xml_05 FOR TESTING. test_xml_05 FOR TESTING.
ENDCLASS. " ltcl_syntax_cases ENDCLASS.
*----------------------------------------------------------------------* *----------------------------------------------------------------------*
* CLASS ltcl_syntax_cases IMPLEMENTATION * CLASS ltcl_syntax_cases IMPLEMENTATION
*----------------------------------------------------------------------* *----------------------------------------------------------------------*
@ -43,7 +43,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION.
ms_match-offset = &2. ms_match-offset = &2.
ms_match-length = &3. ms_match-length = &3.
APPEND ms_match TO mt_after_parse. APPEND ms_match TO mt_after_parse.
END-OF-DEFINITION. " _generate_parse END-OF-DEFINITION.
DEFINE _generate_order. DEFINE _generate_order.
ms_match-token = &1. ms_match-token = &1.
@ -51,7 +51,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION.
ms_match-length = &3. ms_match-length = &3.
ms_match-text_tag = &4. ms_match-text_tag = &4.
APPEND ms_match TO mt_after_order. APPEND ms_match TO mt_after_order.
END-OF-DEFINITION. " _generate_order END-OF-DEFINITION.
DEFINE _generate_extend. DEFINE _generate_extend.
ms_match-token = &1. ms_match-token = &1.
@ -59,7 +59,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION.
ms_match-length = &3. ms_match-length = &3.
ms_match-text_tag = &4. ms_match-text_tag = &4.
APPEND ms_match TO mt_after_extend. APPEND ms_match TO mt_after_extend.
END-OF-DEFINITION. " _generate_extend END-OF-DEFINITION.
METHOD do_test. METHOD do_test.
@ -94,7 +94,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION.
act = lt_matches_act act = lt_matches_act
msg = | Error during extending: { iv_line }| ). msg = | Error during extending: { iv_line }| ).
ENDMETHOD. "test ENDMETHOD.
****************************************************** ******************************************************
* Test parsing and ordering of comments * * Test parsing and ordering of comments *
@ -122,7 +122,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION.
do_test( iv_line = lv_line iv_filename = '*.abap' ). do_test( iv_line = lv_line iv_filename = '*.abap' ).
ENDMETHOD. " test_abap_01 ENDMETHOD.
****************************************************** ******************************************************
* Test parsing and ordering of remainder of string * * Test parsing and ordering of remainder of string *
@ -149,7 +149,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION.
do_test( iv_line = lv_line iv_filename = '*.abap' ). do_test( iv_line = lv_line iv_filename = '*.abap' ).
ENDMETHOD. " test_abap_02 ENDMETHOD.
****************************************************** ******************************************************
* Test parsing and ordering of key words & texts * * Test parsing and ordering of key words & texts *
@ -185,7 +185,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION.
do_test( iv_line = lv_line iv_filename = '*.abap' ). do_test( iv_line = lv_line iv_filename = '*.abap' ).
ENDMETHOD. " test_abap_03 ENDMETHOD.
****************************************************** ******************************************************
* Test parsing and ordering of key words in texts * * Test parsing and ordering of key words in texts *
@ -222,7 +222,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION.
do_test( iv_line = lv_line iv_filename = '*.abap' ). do_test( iv_line = lv_line iv_filename = '*.abap' ).
ENDMETHOD. " test_abap_04 ENDMETHOD.
****************************************************** ******************************************************
* Test parsing and ordering texts in curly brackets * * Test parsing and ordering texts in curly brackets *
@ -261,7 +261,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION.
do_test( iv_line = lv_line iv_filename = '*.abap' ). do_test( iv_line = lv_line iv_filename = '*.abap' ).
ENDMETHOD. " test_abap_05 ENDMETHOD.
****************************************************** ******************************************************
* Test parsing and ordering of texts * * Test parsing and ordering of texts *
@ -318,7 +318,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION.
do_test( iv_line = lv_line iv_filename = '*.abap' ). do_test( iv_line = lv_line iv_filename = '*.abap' ).
ENDMETHOD. " test_abap_06 ENDMETHOD.
******************************************************** ********************************************************
* Check that '*' in select statement is not a match * * Check that '*' in select statement is not a match *
@ -345,7 +345,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION.
do_test( iv_line = lv_line iv_filename = '*.abap' ). do_test( iv_line = lv_line iv_filename = '*.abap' ).
ENDMETHOD. " test_abap_07 ENDMETHOD.
******************************************************** ********************************************************
* Test parsing and ordering of key words in structures * * Test parsing and ordering of key words in structures *
@ -365,7 +365,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION.
do_test( iv_line = lv_line iv_filename = '*.abap' ). do_test( iv_line = lv_line iv_filename = '*.abap' ).
ENDMETHOD. " test_abap_08 ENDMETHOD.
******************************************************** ********************************************************
* Test parsing and ordering of tags in xml * * Test parsing and ordering of tags in xml *
@ -393,7 +393,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION.
do_test( iv_line = lv_line iv_filename = '*.xml' ). do_test( iv_line = lv_line iv_filename = '*.xml' ).
ENDMETHOD. " test_xml_01 ENDMETHOD.
METHOD test_xml_02. METHOD test_xml_02.
@ -413,7 +413,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION.
do_test( iv_line = lv_line iv_filename = '*.xml' ). do_test( iv_line = lv_line iv_filename = '*.xml' ).
ENDMETHOD. " test_xml_02 ENDMETHOD.
METHOD test_xml_03. METHOD test_xml_03.
@ -442,7 +442,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION.
do_test( iv_line = lv_line iv_filename = '*.xml' ). do_test( iv_line = lv_line iv_filename = '*.xml' ).
ENDMETHOD. " test_xml_03 ENDMETHOD.
METHOD test_xml_04. METHOD test_xml_04.
@ -471,7 +471,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION.
do_test( iv_line = lv_line iv_filename = '*.xml' ). do_test( iv_line = lv_line iv_filename = '*.xml' ).
ENDMETHOD. " test_xml_04 ENDMETHOD.
METHOD test_xml_05. METHOD test_xml_05.
@ -513,9 +513,9 @@ CLASS ltcl_syntax_cases IMPLEMENTATION.
do_test( iv_line = lv_line iv_filename = '*.xml' ). do_test( iv_line = lv_line iv_filename = '*.xml' ).
ENDMETHOD. " test_xml_05 ENDMETHOD.
ENDCLASS. " ltcl_syntax_cases IMPLEMENTATION ENDCLASS.
CLASS ltcl_syntax_basic_logic DEFINITION DEFERRED. CLASS ltcl_syntax_basic_logic DEFINITION DEFERRED.
CLASS zcl_abapgit_syntax_highlighter DEFINITION LOCAL FRIENDS ltcl_syntax_basic_logic. CLASS zcl_abapgit_syntax_highlighter DEFINITION LOCAL FRIENDS ltcl_syntax_basic_logic.
@ -538,7 +538,7 @@ CLASS ltcl_syntax_basic_logic DEFINITION FINAL FOR TESTING RISK LEVEL HARMLESS
format_line FOR TESTING, format_line FOR TESTING,
apply_style FOR TESTING. apply_style FOR TESTING.
ENDCLASS. " ltcl_syntax_basic_logic ENDCLASS.
*----------------------------------------------------------------------* *----------------------------------------------------------------------*
* CLASS ltcl_syntax_highlighter IMPLEMENTATION * CLASS ltcl_syntax_highlighter IMPLEMENTATION
@ -547,7 +547,7 @@ CLASS ltcl_syntax_basic_logic IMPLEMENTATION.
METHOD setup. METHOD setup.
mo = zcl_abapgit_syntax_highlighter=>create( '*.abap' ). mo = zcl_abapgit_syntax_highlighter=>create( '*.abap' ).
ENDMETHOD. " setup ENDMETHOD.
METHOD format_line. METHOD format_line.
@ -564,13 +564,13 @@ CLASS ltcl_syntax_basic_logic IMPLEMENTATION.
' <span class="text">&#39;FM_NAME&#39;</span>.' && "#EC NOTEXT ' <span class="text">&#39;FM_NAME&#39;</span>.' && "#EC NOTEXT
' <span class="comment">&quot; Commented</span>'. "#EC NOTEXT ' <span class="comment">&quot; Commented</span>'. "#EC NOTEXT
lv_line_act = mo->process_line( iv_line = lv_line ). lv_line_act = mo->process_line( lv_line ).
cl_abap_unit_assert=>assert_equals( exp = lv_line_exp cl_abap_unit_assert=>assert_equals( exp = lv_line_exp
act = lv_line_act act = lv_line_act
msg = | Error during formating: { lv_line }| ). msg = | Error during formating: { lv_line }| ).
ENDMETHOD. " format_line ENDMETHOD.
METHOD apply_style. METHOD apply_style.
@ -585,14 +585,14 @@ CLASS ltcl_syntax_basic_logic IMPLEMENTATION.
exp = '<span class="keyword">CALL FUNCTION</span>' "#EC NOTEXT exp = '<span class="keyword">CALL FUNCTION</span>' "#EC NOTEXT
msg = 'Failure during applying of style.' ). "#EC NOTEXT msg = 'Failure during applying of style.' ). "#EC NOTEXT
ENDMETHOD. " apply_style ENDMETHOD.
METHOD process_line. METHOD process_line.
DATA lv_line_act TYPE string. DATA lv_line_act TYPE string.
" Call the method with empty parameter and compare results " Call the method with empty parameter and compare results
lv_line_act = mo->process_line( iv_line = '' ). lv_line_act = mo->process_line( '' ).
cl_abap_unit_assert=>assert_equals( cl_abap_unit_assert=>assert_equals(
act = lv_line_act act = lv_line_act
@ -600,13 +600,13 @@ CLASS ltcl_syntax_basic_logic IMPLEMENTATION.
msg = 'Failure in method process_line.' ). "#EC NOTEXT msg = 'Failure in method process_line.' ). "#EC NOTEXT
" Call the method with non-empty line and compare results " Call the method with non-empty line and compare results
lv_line_act = mo->process_line( iv_line = '* CALL FUNCTION' ). "#EC NOTEXT lv_line_act = mo->process_line( '* CALL FUNCTION' ). "#EC NOTEXT
cl_abap_unit_assert=>assert_equals( cl_abap_unit_assert=>assert_equals(
act = lv_line_act act = lv_line_act
exp = '<span class="comment">* CALL FUNCTION</span>' "#EC NOTEXT exp = '<span class="comment">* CALL FUNCTION</span>' "#EC NOTEXT
msg = 'Failure in method process_line.' ). "#EC NOTEXT msg = 'Failure in method process_line.' ). "#EC NOTEXT
ENDMETHOD. " process_line ENDMETHOD.
ENDCLASS. " ltcl_syntax_highlighter ENDCLASS.

2
src/ui/zcl_abapgit_gui.clas.abap
View File

@ -261,7 +261,7 @@ CLASS ZCL_ABAPGIT_GUI IMPLEMENTATION.
WHEN zif_abapgit_definitions=>gc_event_state-go_back. WHEN zif_abapgit_definitions=>gc_event_state-go_back.
back( ). back( ).
WHEN zif_abapgit_definitions=>gc_event_state-go_back_to_bookmark. WHEN zif_abapgit_definitions=>gc_event_state-go_back_to_bookmark.
back( iv_to_bookmark = abap_true ). back( abap_true ).
WHEN zif_abapgit_definitions=>gc_event_state-no_more_act. WHEN zif_abapgit_definitions=>gc_event_state-no_more_act.
" Do nothing, handling completed " Do nothing, handling completed
WHEN OTHERS. WHEN OTHERS.

4
src/ui/zcl_abapgit_gui_page_boverview.clas.abap
View File

@ -59,7 +59,7 @@ ENDCLASS.
CLASS zcl_abapgit_gui_page_boverview IMPLEMENTATION. CLASS ZCL_ABAPGIT_GUI_PAGE_BOVERVIEW IMPLEMENTATION.
METHOD body. METHOD body.
@ -249,7 +249,7 @@ CLASS zcl_abapgit_gui_page_boverview IMPLEMENTATION.
METHOD refresh. METHOD refresh.
mi_branch_overview = zcl_abapgit_factory=>get_branch_overview( io_repo = mo_repo ). mi_branch_overview = zcl_abapgit_factory=>get_branch_overview( mo_repo ).
mt_commits = mi_branch_overview->get_commits( ). mt_commits = mi_branch_overview->get_commits( ).
IF mv_compress = abap_true. IF mv_compress = abap_true.

2
src/zcl_abapgit_file_status.clas.abap
View File

@ -222,7 +222,7 @@ CLASS ZCL_ABAPGIT_FILE_STATUS IMPLEMENTATION.
ASSERT <ls_remote>-sha1 IS NOT INITIAL. ASSERT <ls_remote>-sha1 IS NOT INITIAL.
CLEAR <ls_remote>-sha1. " Mark as processed CLEAR <ls_remote>-sha1. " Mark as processed
ELSE. " Only L exists ELSE. " Only L exists
<ls_result> = build_new_local( is_local = <ls_local> ). <ls_result> = build_new_local( <ls_local> ).
ENDIF. ENDIF.
ENDLOOP. ENDLOOP.