SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Minor ux improvements (#3253)

Browse Source 
* Resize stage list to full width

* Move patch button to the top menu

* Center stage list, increase line width in repo, stage

* Repo page - Increase line height for path column

* Stage list to full size

Co-authored-by: Lars Hvam <larshp@hotmail.com>
This commit is contained in:
Frederik Hudák 2020-03-21 09:56:53 +01:00 committed by GitHub
parent 7bf443d7a8
commit 63640bb3fc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/ui/zabapgit_css_common.w3mi.data.css
View File

@ -206,6 +206,7 @@ table.repo_tab {
border: 1px solid; border: 1px solid;
border-radius: 3px; border-radius: 3px;
width: 100%; width: 100%;
line-height: 1.5;
} }
.repo_tab th { .repo_tab th {
text-align: left; text-align: left;
@ -238,6 +239,7 @@ table.repo_tab {
} }
.repo_tab td.files { .repo_tab td.files {
padding-left: 0.5em; padding-left: 0.5em;
line-height: 1.5;
} }
.repo_tab td.cmd, .repo_tab th.cmd { .repo_tab td.cmd, .repo_tab th.cmd {
text-align: right; text-align: right;
@ -250,12 +252,15 @@ table.repo_tab {
.repo_tab tr:first-child td { border-top: 0px; } .repo_tab tr:first-child td { border-top: 0px; }
/* STAGE */ /* STAGE */
div.stage-container { width: 900px; }
th.stage-status { width: 30px; }
th.stage-objtype { width: 30px; }
input.stage-filter { width: 18em; } input.stage-filter { width: 18em; }
.stage_tab { .stage_tab {
border: 1px solid; border: 1px solid;
margin-top: 0.2em; margin-top: 0.2em;
line-height: 1.5;
} }
.stage_tab td { .stage_tab td {
border-top: 1px solid; border-top: 1px solid;

20
src/ui/zcl_abapgit_gui_page_stage.clas.abap
View File

@ -113,6 +113,9 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_STAGE IMPLEMENTATION.
IF lines( ms_files-local ) > 0. IF lines( ms_files-local ) > 0.
ro_menu->add( iv_txt = |All diffs| ro_menu->add( iv_txt = |All diffs|
iv_act = |{ zif_abapgit_definitions=>c_action-go_diff }?key={ mo_repo->get_key( ) }| ). iv_act = |{ zif_abapgit_definitions=>c_action-go_diff }?key={ mo_repo->get_key( ) }| ).
ro_menu->add( iv_txt = |Patch|
iv_act = |{ zif_abapgit_definitions=>c_action-go_patch }?key={ mo_repo->get_key( ) }| ).
ENDIF. ENDIF.
ENDMETHOD. ENDMETHOD.
@ -259,9 +262,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_STAGE IMPLEMENTATION.
METHOD render_actions. METHOD render_actions.
DATA: lv_local_count TYPE i, DATA: lv_local_count TYPE i,
lv_add_all_txt TYPE string, lv_add_all_txt TYPE string.
lv_param TYPE string,
ls_file TYPE zif_abapgit_definitions=>ty_file.
CREATE OBJECT ro_html. CREATE OBJECT ro_html.
lv_local_count = count_default_files_to_commit( ). lv_local_count = count_default_files_to_commit( ).
@ -289,16 +290,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_STAGE IMPLEMENTATION.
iv_id = 'commitAllButton' iv_id = 'commitAllButton'
iv_txt = lv_add_all_txt ) ##NO_TEXT. iv_txt = lv_add_all_txt ) ##NO_TEXT.
lv_param = zcl_abapgit_html_action_utils=>file_encode( iv_key = mo_repo->get_key( )
ig_file = ls_file ).
ro_html->add( '</td>' ).
ro_html->add( '<td class="pad-sides">' ).
ro_html->add_a(
iv_txt = |Patch|
iv_act = |{ zif_abapgit_definitions=>c_action-go_patch }?{ lv_param }| ).
ro_html->add( '</td>' ). ro_html->add( '</td>' ).
" Filter bar " Filter bar
@ -411,8 +403,8 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_STAGE IMPLEMENTATION.
LOOP AT ms_files-local ASSIGNING <ls_local>. LOOP AT ms_files-local ASSIGNING <ls_local>.
AT FIRST. AT FIRST.
ro_html->add( '<thead><tr class="local">' ). ro_html->add( '<thead><tr class="local">' ).
ro_html->add( '<th></th>' ). " Diff state ro_html->add( '<th class="stage-status"></th>' ). " Diff state
ro_html->add( '<th>Type</th>' ). ro_html->add( '<th class="stage-objtype">Type</th>' ).
ro_html->add( '<th>Files to add (click to see diff)</th>' ). ro_html->add( '<th>Files to add (click to see diff)</th>' ).
ro_html->add( '<th>Changed by</th>' ). ro_html->add( '<th>Changed by</th>' ).
ro_html->add( '<th>Transport</th>' ). ro_html->add( '<th>Transport</th>' ).