SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-04-30 20:03:20 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

cleanup tadir injections in unit test teardown (#6385)

Browse Source
This commit is contained in:
Lars Hvam 2023-08-25 07:17:56 +02:00 committed by GitHub
parent 55fb0d07a4
commit 65146ff970
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 24 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
package.json
View File

@ -27,12 +27,12 @@
] ]
}, },
"devDependencies": { "devDependencies": {
"@abaplint/cli": "^2.102.10", "@abaplint/cli": "^2.102.28",
"@abaplint/database-sqlite": "^2.7.18", "@abaplint/database-sqlite": "^2.7.74",
"@abaplint/runtime": "^2.7.55", "@abaplint/runtime": "^2.7.80",
"@abaplint/transpiler-cli": "^2.7.55", "@abaplint/transpiler-cli": "^2.7.80",
"abapmerge": "^0.16.0", "abapmerge": "^0.16.0",
"c8": "^8.0.1", "c8": "^8.0.1",
"eslint": "^8.46.0" "eslint": "^8.47.0"
} }
} }

16
src/repo/zcl_abapgit_repo_status.clas.testclasses.abap
View File

@ -644,7 +644,6 @@ CLASS ltcl_status_helper DEFINITION FOR TESTING.
zif_abapgit_tadir. zif_abapgit_tadir.
METHODS: METHODS:
constructor,
add_tadir add_tadir
IMPORTING IMPORTING
iv_obj_type TYPE tadir-object iv_obj_type TYPE tadir-object
@ -695,12 +694,6 @@ ENDCLASS.
CLASS ltcl_status_helper IMPLEMENTATION. CLASS ltcl_status_helper IMPLEMENTATION.
METHOD constructor.
zcl_abapgit_injector=>set_tadir( me ).
ENDMETHOD.
METHOD add_tadir. METHOD add_tadir.
FIELD-SYMBOLS: <ls_tadir> LIKE LINE OF mt_tadir. FIELD-SYMBOLS: <ls_tadir> LIKE LINE OF mt_tadir.
@ -812,6 +805,7 @@ CLASS ltcl_calculate_status DEFINITION FOR TESTING RISK LEVEL HARMLESS
METHODS: METHODS:
setup, setup,
teardown,
complete_local, complete_local,
complete_remote, complete_remote,
complete_state, complete_state,
@ -834,6 +828,14 @@ CLASS ltcl_calculate_status IMPLEMENTATION.
METHOD setup. METHOD setup.
CREATE OBJECT mo_helper. CREATE OBJECT mo_helper.
zcl_abapgit_injector=>set_tadir( mo_helper ).
ENDMETHOD.
METHOD teardown.
DATA li_tadir TYPE REF TO zif_abapgit_tadir.
zcl_abapgit_injector=>set_tadir( li_tadir ).
ENDMETHOD. ENDMETHOD.

18
src/zcl_abapgit_injector.clas.testclasses.abap
View File

@ -1,13 +1,11 @@
CLASS ltcl_abapgit_tadir_mock DEFINITION FOR TESTING. CLASS ltcl_abapgit_tadir_mock DEFINITION FOR TESTING.
PUBLIC SECTION. PUBLIC SECTION.
INTERFACES: zif_abapgit_tadir. INTERFACES zif_abapgit_tadir.
ENDCLASS. ENDCLASS.
CLASS ltcl_no_dependency_injection DEFINITION FOR TESTING CLASS ltcl_no_dependency_injection DEFINITION FOR TESTING RISK LEVEL HARMLESS DURATION SHORT.
RISK LEVEL HARMLESS
DURATION SHORT.
PRIVATE SECTION. PRIVATE SECTION.
METHODS: METHODS:
@ -15,13 +13,12 @@ CLASS ltcl_no_dependency_injection DEFINITION FOR TESTING
ENDCLASS. ENDCLASS.
CLASS ltcl_simple_dependency_inject DEFINITION FOR TESTING CLASS ltcl_simple_dependency_inject DEFINITION FOR TESTING RISK LEVEL HARMLESS DURATION SHORT.
RISK LEVEL HARMLESS
DURATION SHORT.
PRIVATE SECTION. PRIVATE SECTION.
METHODS: METHODS:
setup, setup,
teardown,
simple_injection FOR TESTING RAISING cx_static_check. simple_injection FOR TESTING RAISING cx_static_check.
ENDCLASS. ENDCLASS.
@ -65,7 +62,7 @@ CLASS ltcl_simple_dependency_inject IMPLEMENTATION.
METHOD setup. METHOD setup.
DATA: lo_tadir_mock TYPE REF TO ltcl_abapgit_tadir_mock. DATA lo_tadir_mock TYPE REF TO ltcl_abapgit_tadir_mock.
CREATE OBJECT lo_tadir_mock. CREATE OBJECT lo_tadir_mock.
@ -73,6 +70,11 @@ CLASS ltcl_simple_dependency_inject IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD teardown.
DATA li_tadir TYPE REF TO zif_abapgit_tadir.
zcl_abapgit_injector=>set_tadir( li_tadir ).
ENDMETHOD.
METHOD simple_injection. METHOD simple_injection.
DATA: li_tadir TYPE REF TO zif_abapgit_tadir, DATA: li_tadir TYPE REF TO zif_abapgit_tadir,