SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-04-30 11:46:38 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #737 from christianguenter2/ADT_Jump

Browse Source 
Adt jump
This commit is contained in:
Lars Hvam 2017-04-26 18:17:00 +02:00 committed by GitHub
commit 654c89cd0c
5 changed files with 100 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/zabapgit_object_dcls.prog.abap
View File

@ -52,7 +52,8 @@ CLASS lcl_object_dcls IMPLEMENTATION.
TRY.
jump_adt( ).
jump_adt( i_obj_name = ms_item-obj_name
i_obj_type = ms_item-obj_type ).
CATCH lcx_exception.
lcx_exception=>raise( 'DCLS Jump Error' ).

23
src/zabapgit_objects.prog.abap
View File

@ -557,6 +557,12 @@ CLASS lcl_objects_super DEFINITION ABSTRACT.
is_item TYPE ty_item
iv_language TYPE spras.
CLASS-METHODS:
jump_adt
IMPORTING i_obj_name TYPE ty_item-obj_name
i_obj_type TYPE ty_item-obj_type
RAISING lcx_exception.
CONSTANTS: c_user_unknown TYPE xubname VALUE 'UNKNOWN'.
PROTECTED SECTION.
@ -576,10 +582,6 @@ CLASS lcl_objects_super DEFINITION ABSTRACT.
jump_se11
IMPORTING iv_radio TYPE string
iv_field TYPE string
RAISING lcx_exception,
jump_adt
IMPORTING i_obj_name LIKE ms_item-obj_name OPTIONAL
i_obj_type LIKE ms_item-obj_type OPTIONAL
RAISING lcx_exception.
ENDCLASS. "lcl_objects_super DEFINITION
@ -1629,17 +1631,8 @@ CLASS lcl_objects_super IMPLEMENTATION.
FIELD-SYMBOLS: <uri> TYPE string.
IF i_obj_name IS SUPPLIED.
obj_name = i_obj_name.
ELSE.
obj_name = ms_item-obj_name.
ENDIF.
IF i_obj_type IS SUPPLIED.
obj_type = i_obj_type.
ELSE.
obj_type = ms_item-obj_type.
ENDIF.
obj_name = i_obj_name.
obj_type = i_obj_type.
TRY.
li_object = cl_wb_object=>create_from_transport_key( p_object = obj_type p_obj_name = obj_name ).

24
src/zabapgit_objects_impl.prog.abap
View File

@ -231,13 +231,31 @@ CLASS lcl_objects IMPLEMENTATION.
METHOD jump.
DATA: li_obj TYPE REF TO lif_object.
DATA: li_obj TYPE REF TO lif_object,
adt_jump_enabled TYPE abap_bool.
li_obj = create_object( is_item = is_item
iv_language = gc_english ).
li_obj->jump( ).
adt_jump_enabled = lcl_app=>settings( )->read( )->get_adt_jump_enabled( ).
IF adt_jump_enabled = abap_true.
TRY.
lcl_objects_super=>jump_adt( i_obj_name = is_item-obj_name
i_obj_type = is_item-obj_type ).
CATCH lcx_exception.
li_obj->jump( ).
ENDTRY.
ELSE.
li_obj->jump( ).
ENDIF.
ENDMETHOD. "jump

39
src/zabapgit_page_settings.prog.abap
View File

@ -32,6 +32,8 @@ CLASS lcl_gui_page_settings DEFINITION FINAL INHERITING FROM lcl_gui_page.
RETURNING VALUE(ro_html) TYPE REF TO lcl_html.
METHODS render_max_lines
RETURNING VALUE(ro_html) TYPE REF TO lcl_html.
METHODS render_adt_jump_enabled
RETURNING VALUE(ro_html) TYPE REF TO lcl_html.
METHODS render_commit_msg
RETURNING VALUE(ro_html) TYPE REF TO lcl_html.
METHODS build_settings
@ -68,6 +70,8 @@ CLASS lcl_gui_page_settings IMPLEMENTATION.
ro_html->add( |<hr>| ).
ro_html->add( render_max_lines( ) ).
ro_html->add( |<hr>| ).
ro_html->add( render_adt_jump_enabled( ) ).
ro_html->add( |<hr>| ).
ro_html->add( render_commit_msg( ) ).
ro_html->add( |<hr>| ).
ro_html->add( render_development_internals( ) ).
@ -168,38 +172,33 @@ CLASS lcl_gui_page_settings IMPLEMENTATION.
mo_settings->set_max_lines( 0 ).
ENDIF.
READ TABLE it_post_fields ASSIGNING <ls_post_field> WITH KEY name = 'adt_jump_enabled'.
IF sy-subrc = 0.
mo_settings->set_adt_jump_enanbled( abap_true ).
ELSE.
mo_settings->set_adt_jump_enanbled( abap_false ).
ENDIF.
READ TABLE it_post_fields ASSIGNING <ls_post_field> WITH KEY name = 'comment_length'.
IF sy-subrc = 0.
lv_i_param_value = <ls_post_field>-value.
IF lv_i_param_value < lcl_settings=>c_commitmsg_comment_length_dft.
lv_i_param_value = lcl_settings=>c_commitmsg_comment_length_dft.
ENDIF.
mo_settings->set_commitmsg_comment_length( lv_i_param_value ).
ELSE.
mo_settings->set_commitmsg_comment_length( lcl_settings=>c_commitmsg_comment_length_dft ).
ENDIF.
READ TABLE it_post_fields ASSIGNING <ls_post_field> WITH KEY name = 'body_size'.
IF sy-subrc = 0.
lv_i_param_value = <ls_post_field>-value.
IF lv_i_param_value < lcl_settings=>c_commitmsg_body_size_dft.
lv_i_param_value = lcl_settings=>c_commitmsg_body_size_dft.
ENDIF.
mo_settings->set_commitmsg_body_size( lv_i_param_value ).
ELSE.
mo_settings->set_commitmsg_body_size( lcl_settings=>c_commitmsg_body_size_dft ).
ENDIF.
ENDMETHOD.
@ -290,6 +289,22 @@ CLASS lcl_gui_page_settings IMPLEMENTATION.
ro_html->add( |<br>| ).
ENDMETHOD.
METHOD render_adt_jump_enabled.
DATA lv_checked TYPE string.
IF mo_settings->get_adt_jump_enabled( ) = abap_true.
lv_checked = 'checked'.
ENDIF.
CREATE OBJECT ro_html.
ro_html->add( |<h2>ABAP Development Tools (ADT)</h2>| ).
ro_html->add( `<input type="checkbox" name="adt_jump_enabled" value="X" `
&& lv_checked && ` > Enable jump to ADT first` ).
ro_html->add( |<br>| ).
ro_html->add( |<br>| ).
ENDMETHOD.
METHOD render_commit_msg.
CREATE OBJECT ro_html.

51
src/zabapgit_persistence.prog.abap
View File

@ -113,7 +113,7 @@ CLASS lcl_persistence_repo DEFINITION FINAL.
TYPES: BEGIN OF ty_repo,
key TYPE lcl_persistence_db=>ty_value.
INCLUDE TYPE ty_repo_xml.
INCLUDE TYPE ty_repo_xml.
TYPES: END OF ty_repo.
TYPES: tt_repo TYPE STANDARD TABLE OF ty_repo WITH DEFAULT KEY.
TYPES: tt_repo_keys TYPE STANDARD TABLE OF ty_repo-key WITH DEFAULT KEY.
@ -230,7 +230,7 @@ CLASS lcl_persistence_background DEFINITION FINAL.
TYPES: BEGIN OF ty_background,
key TYPE lcl_persistence_db=>ty_value.
INCLUDE TYPE ty_xml.
INCLUDE TYPE ty_xml.
TYPES: END OF ty_background.
TYPES: tt_background TYPE STANDARD TABLE OF ty_background WITH DEFAULT KEY.
@ -1566,6 +1566,11 @@ CLASS lcl_settings DEFINITION FINAL.
METHODS get_max_lines
RETURNING
VALUE(rv_lines) TYPE i.
METHODS set_adt_jump_enanbled
IMPORTING iv_adt_jump_enabled TYPE abap_bool.
METHODS get_adt_jump_enabled
RETURNING
VALUE(rv_adt_jump_enabled) TYPE abap_bool.
METHODS set_commitmsg_comment_length
IMPORTING iv_length TYPE i.
METHODS get_commitmsg_comment_length
@ -1583,6 +1588,7 @@ CLASS lcl_settings DEFINITION FINAL.
mv_proxy_auth TYPE string,
mv_run_critical_tests TYPE abap_bool,
mv_lines TYPE i,
mv_adt_jump_enabled TYPE abap_bool,
mv_commitmsg_comment_length TYPE i,
mv_commitmsg_body_size TYPE i.
@ -1630,6 +1636,14 @@ CLASS lcl_settings IMPLEMENTATION.
mv_lines = iv_lines.
ENDMETHOD.
METHOD get_adt_jump_enabled.
rv_adt_jump_enabled = mv_adt_jump_enabled.
ENDMETHOD.
METHOD set_adt_jump_enanbled.
mv_adt_jump_enabled = iv_adt_jump_enabled.
ENDMETHOD.
METHOD get_commitmsg_comment_length.
rv_length = mv_commitmsg_comment_length.
ENDMETHOD.
@ -1645,6 +1659,7 @@ CLASS lcl_settings IMPLEMENTATION.
METHOD set_commitmsg_body_size.
mv_commitmsg_body_size = iv_length.
ENDMETHOD.
ENDCLASS.
CLASS lcl_persistence_settings DEFINITION FINAL.
@ -1691,6 +1706,11 @@ CLASS lcl_persistence_settings IMPLEMENTATION.
iv_value = 'MAX_LINES'
iv_data = |{ io_settings->get_max_lines( ) }| ).
lcl_app=>db( )->modify(
iv_type = 'SETTINGS'
iv_value = 'ADT_JUMP'
iv_data = io_settings->get_adt_jump_enabled( ) ).
lcl_app=>db( )->modify(
iv_type = 'SETTINGS'
iv_value = 'COMMENT_LEN'
@ -1705,13 +1725,15 @@ CLASS lcl_persistence_settings IMPLEMENTATION.
METHOD read.
DATA: lv_critical_tests_as_string TYPE string,
lv_critical_tests_as_boolean TYPE abap_bool,
lv_max_lines_as_string TYPE string,
lv_flag TYPE abap_bool,
lv_max_lines_as_integer TYPE i,
lv_s_param_value TYPE string,
lv_i_param_value TYPE i.
DATA: lv_critical_tests_as_string TYPE string,
lv_critical_tests_as_boolean TYPE abap_bool,
lv_max_lines_as_string TYPE string,
lv_flag TYPE abap_bool,
lv_max_lines_as_integer TYPE i,
lv_s_param_value TYPE string,
lv_i_param_value TYPE i,
lv_adt_jump_enabled_as_string TYPE string,
lv_adt_jump_enabled_as_boolean TYPE abap_bool.
CREATE OBJECT ro_settings.
@ -1763,6 +1785,16 @@ CLASS lcl_persistence_settings IMPLEMENTATION.
ro_settings->set_max_lines( 500 ). " default
ENDTRY.
TRY.
lv_adt_jump_enabled_as_string = lcl_app=>db( )->read(
iv_type = 'SETTINGS'
iv_value = 'ADT_JUMP' ).
lv_adt_jump_enabled_as_boolean = lv_adt_jump_enabled_as_string.
ro_settings->set_adt_jump_enanbled( lv_adt_jump_enabled_as_boolean ).
CATCH lcx_not_found.
ro_settings->set_adt_jump_enanbled( abap_false ).
ENDTRY.
TRY.
lv_s_param_value = lcl_app=>db( )->read(
iv_type = 'SETTINGS'
@ -1782,6 +1814,7 @@ CLASS lcl_persistence_settings IMPLEMENTATION.
CATCH lcx_not_found cx_sy_conversion_no_number.
ro_settings->set_commitmsg_body_size( lcl_settings=>c_commitmsg_body_size_dft ). " default
ENDTRY.
ENDMETHOD.
ENDCLASS.