Change icon for user settings (#5282)

* Change icon for user settings

Reduce confusion because of same icon for different settings.

Closes https://github.com/abapGit/abapGit/issues/5088

* Icon

* Update toolbars

Co-authored-by: Lars Hvam <larshp@hotmail.com>
This commit is contained in:
Marc Bernard 2022-01-24 08:21:02 -05:00 committed by GitHub
parent fd167aa13b
commit 656e94c612
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 43 additions and 43 deletions

View File

@ -72,4 +72,5 @@
.icon-times-solid:before { content: "\f12a"; }
.icon-tools-solid:before { content: "\f12b"; }
.icon-truck-solid:before { content: "\f12c"; }
.icon-user-solid:before { content: "\f12d"; }
.icon-user-cog-solid:before { content: "\f12d"; }
.icon-user-solid:before { content: "\f12e"; }

View File

@ -30,28 +30,33 @@ ENDCLASS.
CLASS zcl_abapgit_gui_buttons IMPLEMENTATION.
METHOD new_online.
rv_html_string = `<i class="icon icon-cloud-upload-alt"></i> New Online`.
ENDMETHOD.
METHOD new_offline.
rv_html_string = `<i class="icon icon-plug"></i> New Offline`.
ENDMETHOD.
METHOD advanced.
rv_html_string = `<i class="icon icon-tools-solid"></i>`.
ENDMETHOD.
METHOD help.
rv_html_string = `<i class="icon icon-question-circle-solid"></i>`.
ENDMETHOD.
METHOD new_offline.
rv_html_string = `<i class="icon icon-plug"></i> New Offline`.
ENDMETHOD.
METHOD new_online.
rv_html_string = `<i class="icon icon-cloud-upload-alt"></i> New Online`.
ENDMETHOD.
METHOD repo_list.
rv_html_string = `<i class="icon icon-bars"></i> Repository List`.
ENDMETHOD.
METHOD settings.
rv_html_string = `<i class="icon icon-cog"></i> Settings`.
ENDMETHOD.
ENDCLASS.

View File

@ -432,13 +432,6 @@ CLASS zcl_abapgit_gui_page_repo_view IMPLEMENTATION.
ro_menu->add(
iv_txt = zcl_abapgit_gui_buttons=>repo_list( )
iv_act = zif_abapgit_definitions=>c_action-abapgit_home
)->add(
iv_txt = zcl_abapgit_gui_buttons=>settings( )
iv_act = zif_abapgit_definitions=>c_action-go_settings
)->add(
iv_txt = zcl_abapgit_gui_buttons=>advanced( )
iv_title = 'Utilities'
io_sub = zcl_abapgit_gui_chunk_lib=>advanced_submenu( )
)->add(
iv_txt = zcl_abapgit_gui_buttons=>help( )
iv_title = 'Help'
@ -517,8 +510,9 @@ CLASS zcl_abapgit_gui_page_repo_view IMPLEMENTATION.
iv_act = |{ zif_abapgit_definitions=>c_action-repo_refresh }?key={ mv_key }|
iv_opt = zif_abapgit_html=>c_html_opt-strong ).
ro_toolbar->add( iv_txt = zcl_abapgit_html=>icon( iv_name = 'cog' )
ro_toolbar->add( iv_txt = 'Settings'
iv_act = |{ zif_abapgit_definitions=>c_action-repo_settings }?key={ mv_key }|
iv_opt = zif_abapgit_html=>c_html_opt-strong
iv_title = `Repository Settings` ).
ENDMETHOD.
@ -760,6 +754,31 @@ CLASS zcl_abapgit_gui_page_repo_view IMPLEMENTATION.
ENDMETHOD.
METHOD order_files.
DATA:
lt_sort TYPE abap_sortorder_tab,
ls_sort LIKE LINE OF lt_sort.
IF lines( ct_files ) = 0.
RETURN.
ENDIF.
ls_sort-descending = mv_order_descending.
ls_sort-astext = abap_true.
ls_sort-name = 'PATH'.
INSERT ls_sort INTO TABLE lt_sort.
ls_sort-descending = mv_order_descending.
ls_sort-astext = abap_true.
ls_sort-name = 'FILENAME'.
INSERT ls_sort INTO TABLE lt_sort.
SORT ct_files STABLE BY (lt_sort).
ENDMETHOD.
METHOD render_content.
DATA: lt_repo_items TYPE zif_abapgit_definitions=>ty_repo_item_tt,
@ -1333,29 +1352,4 @@ CLASS zcl_abapgit_gui_page_repo_view IMPLEMENTATION.
INSERT ls_hotkey_action INTO TABLE rt_hotkey_actions.
ENDMETHOD.
METHOD order_files.
DATA:
lt_sort TYPE abap_sortorder_tab,
ls_sort LIKE LINE OF lt_sort.
IF lines( ct_files ) = 0.
RETURN.
ENDIF.
ls_sort-descending = mv_order_descending.
ls_sort-astext = abap_true.
ls_sort-name = 'PATH'.
INSERT ls_sort INTO TABLE lt_sort.
ls_sort-descending = mv_order_descending.
ls_sort-astext = abap_true.
ls_sort-name = 'FILENAME'.
INSERT ls_sort INTO TABLE lt_sort.
SORT ct_files STABLE BY (lt_sort).
ENDMETHOD.
ENDCLASS.