From 681f60a265ee8a26884964f8c4ef18358acbab48 Mon Sep 17 00:00:00 2001
From: Lars Hvam <larshp@hotmail.com>
Date: Thu, 27 Aug 2020 07:38:18 +0200
Subject: [PATCH] background pull: always overwrite all objects (#3802)

* background pull: always overwrite all objects

always choose to overwrite all objects when using the pull in background feature. If the decision is not set the job will fail with a "undecided" error

#3800

* fix page title typo
---
 src/background/zcl_abapgit_background_pull.clas.abap | 9 ++++++++-
 src/ui/zcl_abapgit_gui_page_bkg.clas.abap            | 2 +-
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/src/background/zcl_abapgit_background_pull.clas.abap b/src/background/zcl_abapgit_background_pull.clas.abap
index 5abb1a846..5a7f4880e 100644
--- a/src/background/zcl_abapgit_background_pull.clas.abap
+++ b/src/background/zcl_abapgit_background_pull.clas.abap
@@ -30,8 +30,15 @@ CLASS ZCL_ABAPGIT_BACKGROUND_PULL IMPLEMENTATION.
 
     DATA: ls_checks TYPE zif_abapgit_definitions=>ty_deserialize_checks.
 
+    FIELD-SYMBOLS: <ls_overwrite> LIKE LINE OF ls_checks-overwrite.
+
+
+    ls_checks = io_repo->deserialize_checks( ).
+
+    LOOP AT ls_checks-overwrite ASSIGNING <ls_overwrite>.
+      <ls_overwrite>-decision = zif_abapgit_definitions=>gc_yes.
+    ENDLOOP.
 
-* todo, set defaults in ls_checks
     io_repo->deserialize( is_checks = ls_checks
                           ii_log    = ii_log ).
 
diff --git a/src/ui/zcl_abapgit_gui_page_bkg.clas.abap b/src/ui/zcl_abapgit_gui_page_bkg.clas.abap
index 63ac63471..f8e660612 100644
--- a/src/ui/zcl_abapgit_gui_page_bkg.clas.abap
+++ b/src/ui/zcl_abapgit_gui_page_bkg.clas.abap
@@ -78,7 +78,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_BKG IMPLEMENTATION.
     super->constructor( ).
 
     mv_key = iv_key.
-    ms_control-page_title = 'Backround'.
+    ms_control-page_title = 'Background'.
     ms_control-page_menu  = build_menu( ).
 
   ENDMETHOD.