SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

delete some unused variables (#4411)

Browse Source 
* delete some unused variables

* bdef, remove unused vars

* remove some more
This commit is contained in:
Lars Hvam 2021-01-15 08:31:01 +01:00 committed by GitHub
parent 9ef3f1ee7e
commit 690da4e51f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 157 additions and 169 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/cts/zcl_abapgit_transport.clas.abap
View File

@ -293,7 +293,6 @@ CLASS ZCL_ABAPGIT_TRANSPORT IMPLEMENTATION.
lv_package TYPE devclass, lv_package TYPE devclass,
lo_dot_abapgit TYPE REF TO zcl_abapgit_dot_abapgit, lo_dot_abapgit TYPE REF TO zcl_abapgit_dot_abapgit,
ls_local_settings TYPE zif_abapgit_persistence=>ty_repo-local_settings, ls_local_settings TYPE zif_abapgit_persistence=>ty_repo-local_settings,
lo_repo TYPE REF TO zcl_abapgit_repo_offline,
lt_trkorr TYPE trwbo_request_headers. lt_trkorr TYPE trwbo_request_headers.

1
src/data/zcl_abapgit_data_config.clas.abap
View File

@ -30,7 +30,6 @@ CLASS ZCL_ABAPGIT_DATA_CONFIG IMPLEMENTATION.
METHOD dump. METHOD dump.
DATA lo_ajson TYPE REF TO zcl_abapgit_ajson. DATA lo_ajson TYPE REF TO zcl_abapgit_ajson.
DATA lv_string TYPE string.
DATA lx_ajson TYPE REF TO zcx_abapgit_ajson_error. DATA lx_ajson TYPE REF TO zcx_abapgit_ajson_error.

11
src/objects/core/zcl_abapgit_file_status.clas.abap
View File

@ -65,7 +65,7 @@ ENDCLASS.
CLASS zcl_abapgit_file_status IMPLEMENTATION. CLASS ZCL_ABAPGIT_FILE_STATUS IMPLEMENTATION.
METHOD build_existing. METHOD build_existing.
@ -512,12 +512,9 @@ CLASS zcl_abapgit_file_status IMPLEMENTATION.
METHOD status. METHOD status.
DATA: lv_index LIKE sy-tabix, DATA lt_local TYPE zif_abapgit_definitions=>ty_files_item_tt.
lt_local TYPE zif_abapgit_definitions=>ty_files_item_tt.
FIELD-SYMBOLS: <ls_result> LIKE LINE OF rt_results. lt_local = io_repo->get_files_local( ii_log ).
lt_local = io_repo->get_files_local( ii_log = ii_log ).
IF lines( lt_local ) <= 2. IF lines( lt_local ) <= 2.
" Less equal two means that we have only the .abapgit.xml and the package in " Less equal two means that we have only the .abapgit.xml and the package in
@ -530,7 +527,7 @@ CLASS zcl_abapgit_file_status IMPLEMENTATION.
rt_results = calculate_status( rt_results = calculate_status(
iv_devclass = io_repo->get_package( ) iv_devclass = io_repo->get_package( )
io_dot = io_repo->get_dot_abapgit( ) io_dot = io_repo->get_dot_abapgit( )
it_local = io_repo->get_files_local( ii_log = ii_log ) it_local = io_repo->get_files_local( ii_log )
it_remote = io_repo->get_files_remote( ) it_remote = io_repo->get_files_remote( )
it_cur_state = io_repo->get_local_checksums_per_file( ) ). it_cur_state = io_repo->get_local_checksums_per_file( ) ).

306
src/objects/zcl_abapgit_object_bdef.clas.abap
View File

@ -218,6 +218,158 @@ CLASS ZCL_ABAPGIT_OBJECT_BDEF IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD get_object_data.
DATA:
lr_metadata TYPE REF TO data,
lr_data TYPE REF TO data.
FIELD-SYMBOLS:
<lv_metadata_node> TYPE any,
<ls_metadata> TYPE any,
<lv_source> TYPE any,
<lg_data> TYPE any.
CREATE DATA lr_data TYPE ('CL_BLUE_SOURCE_OBJECT_DATA=>TY_OBJECT_DATA').
ASSIGN lr_data->* TO <lg_data>.
ASSERT sy-subrc = 0.
ASSIGN COMPONENT 'METADATA' OF STRUCTURE <lg_data> TO <lv_metadata_node>.
ASSERT sy-subrc = 0.
CREATE DATA lr_metadata TYPE ('IF_ADT_TOOLS_CORE_SOURCE_TYPES=>TY_ABAP_SOURCE_MAIN_OBJECT').
ASSIGN lr_metadata->* TO <ls_metadata>.
ASSERT sy-subrc = 0.
io_xml->read(
EXPORTING
iv_name = 'BDEF'
CHANGING
cg_data = <ls_metadata> ).
<lv_metadata_node> = <ls_metadata>.
ASSIGN COMPONENT 'CONTENT-SOURCE' OF STRUCTURE <lg_data> TO <lv_source>.
ASSERT sy-subrc = 0.
<lv_source> = mo_files->read_string( 'asbdef' ).
CREATE OBJECT ro_object_data TYPE ('CL_BLUE_SOURCE_OBJECT_DATA').
ro_object_data->set_data( p_data = <lg_data> ).
ENDMETHOD.
METHOD get_transport_req_if_needed.
DATA: li_sap_package TYPE REF TO zif_abapgit_sap_package.
li_sap_package = zcl_abapgit_factory=>get_sap_package( iv_package ).
IF li_sap_package->are_changes_recorded_in_tr_req( ) = abap_true.
rv_transport_request = zcl_abapgit_default_transport=>get_instance( )->get( )-ordernum.
ENDIF.
ENDMETHOD.
METHOD get_wb_object_operator.
DATA:
ls_object_type TYPE wbobjtype,
lx_error TYPE REF TO cx_root.
IF mi_wb_object_operator IS BOUND.
ri_wb_object_operator = mi_wb_object_operator.
ENDIF.
ls_object_type-objtype_tr = 'BDEF'.
ls_object_type-subtype_wb = 'BDO'.
TRY.
CALL METHOD ('CL_WB_OBJECT_OPERATOR')=>('CREATE_INSTANCE')
EXPORTING
object_type = ls_object_type
object_key = mv_behaviour_definition_key
RECEIVING
result = mi_wb_object_operator.
CATCH cx_root INTO lx_error.
zcx_abapgit_exception=>raise(
iv_text = lx_error->get_text( )
ix_previous = lx_error ).
ENDTRY.
ri_wb_object_operator = mi_wb_object_operator.
ENDMETHOD.
METHOD merge_object_data.
DATA:
lo_object_data TYPE REF TO object,
lo_object_data_old TYPE REF TO if_wb_object_data_model,
lr_new TYPE REF TO data,
lr_old TYPE REF TO data,
lo_wb_object_operator TYPE REF TO object.
FIELD-SYMBOLS:
<ls_new> TYPE any,
<ls_old> TYPE any,
<lv_field_old> TYPE any,
<lv_field_new> TYPE any.
CREATE OBJECT lo_object_data TYPE ('CL_BLUE_SOURCE_OBJECT_DATA').
lo_object_data = io_object_data.
CREATE DATA lr_new TYPE ('CL_BLUE_SOURCE_OBJECT_DATA=>TY_OBJECT_DATA').
ASSIGN lr_new->* TO <ls_new>.
ASSERT sy-subrc = 0.
CREATE DATA lr_old TYPE ('CL_BLUE_SOURCE_OBJECT_DATA=>TY_OBJECT_DATA').
ASSIGN lr_old->* TO <ls_old>.
ASSERT sy-subrc = 0.
CALL METHOD lo_object_data->('IF_WB_OBJECT_DATA_MODEL~GET_DATA')
EXPORTING
p_metadata_only = abap_false
p_data_selection = 'AL'
IMPORTING
p_data = <ls_new>.
lo_wb_object_operator = get_wb_object_operator( ).
CALL METHOD lo_wb_object_operator->('IF_WB_OBJECT_OPERATOR~READ')
EXPORTING
data_selection = 'AL' " if_wb_object_data_selection_co=>c_all_data
IMPORTING
eo_object_data = lo_object_data_old.
CALL METHOD lo_object_data_old->('GET_DATA')
EXPORTING
p_metadata_only = abap_false
p_data_selection = 'AL' " if_wb_object_data_selection_co=>c_all_data
IMPORTING
p_data = <ls_old>.
ASSIGN COMPONENT 'METADATA-DESCRIPTION' OF STRUCTURE <ls_old> TO <lv_field_old>.
ASSIGN COMPONENT 'METADATA-DESCRIPTION' OF STRUCTURE <ls_new> TO <lv_field_new>.
<lv_field_old> = <lv_field_new>.
ASSIGN COMPONENT 'CONTENT-SOURCE' OF STRUCTURE <ls_old> TO <lv_field_old>.
ASSIGN COMPONENT 'CONTENT-SOURCE' OF STRUCTURE <ls_new> TO <lv_field_new>.
<lv_field_old> = <lv_field_new>.
CREATE OBJECT ro_object_data_merged TYPE ('CL_BLUE_SOURCE_OBJECT_DATA').
CALL METHOD ro_object_data_merged->('SET_DATA')
EXPORTING
p_data = <ls_old>.
ENDMETHOD.
METHOD zif_abapgit_object~changed_by. METHOD zif_abapgit_object~changed_by.
DATA: DATA:
@ -491,158 +643,4 @@ CLASS ZCL_ABAPGIT_OBJECT_BDEF IMPLEMENTATION.
iv_string = lv_source ). iv_string = lv_source ).
ENDMETHOD. ENDMETHOD.
METHOD get_transport_req_if_needed.
DATA: li_sap_package TYPE REF TO zif_abapgit_sap_package.
li_sap_package = zcl_abapgit_factory=>get_sap_package( iv_package ).
IF li_sap_package->are_changes_recorded_in_tr_req( ) = abap_true.
rv_transport_request = zcl_abapgit_default_transport=>get_instance( )->get( )-ordernum.
ENDIF.
ENDMETHOD.
METHOD get_wb_object_operator.
DATA:
ls_object_type TYPE wbobjtype,
lx_error TYPE REF TO cx_root.
IF mi_wb_object_operator IS BOUND.
ri_wb_object_operator = mi_wb_object_operator.
ENDIF.
ls_object_type-objtype_tr = 'BDEF'.
ls_object_type-subtype_wb = 'BDO'.
TRY.
CALL METHOD ('CL_WB_OBJECT_OPERATOR')=>('CREATE_INSTANCE')
EXPORTING
object_type = ls_object_type
object_key = mv_behaviour_definition_key
RECEIVING
result = mi_wb_object_operator.
CATCH cx_root INTO lx_error.
zcx_abapgit_exception=>raise(
iv_text = lx_error->get_text( )
ix_previous = lx_error ).
ENDTRY.
ri_wb_object_operator = mi_wb_object_operator.
ENDMETHOD.
METHOD get_object_data.
DATA:
lo_object_data TYPE REF TO object,
lr_metadata TYPE REF TO data,
lr_data TYPE REF TO data.
FIELD-SYMBOLS:
<lv_metadata_node> TYPE any,
<ls_metadata> TYPE any,
<lv_source> TYPE any,
<lg_data> TYPE any.
CREATE DATA lr_data TYPE ('CL_BLUE_SOURCE_OBJECT_DATA=>TY_OBJECT_DATA').
ASSIGN lr_data->* TO <lg_data>.
ASSERT sy-subrc = 0.
ASSIGN COMPONENT 'METADATA' OF STRUCTURE <lg_data> TO <lv_metadata_node>.
ASSERT sy-subrc = 0.
CREATE DATA lr_metadata TYPE ('IF_ADT_TOOLS_CORE_SOURCE_TYPES=>TY_ABAP_SOURCE_MAIN_OBJECT').
ASSIGN lr_metadata->* TO <ls_metadata>.
ASSERT sy-subrc = 0.
io_xml->read(
EXPORTING
iv_name = 'BDEF'
CHANGING
cg_data = <ls_metadata> ).
<lv_metadata_node> = <ls_metadata>.
ASSIGN COMPONENT 'CONTENT-SOURCE' OF STRUCTURE <lg_data> TO <lv_source>.
ASSERT sy-subrc = 0.
<lv_source> = mo_files->read_string( 'asbdef' ).
CREATE OBJECT ro_object_data TYPE ('CL_BLUE_SOURCE_OBJECT_DATA').
ro_object_data->set_data( p_data = <lg_data> ).
ENDMETHOD.
METHOD merge_object_data.
DATA:
lo_object_data TYPE REF TO object,
lo_object_data_old TYPE REF TO if_wb_object_data_model,
lr_new TYPE REF TO data,
lr_old TYPE REF TO data,
lo_wb_object_operator TYPE REF TO object,
ls_old TYPE cl_blue_source_object_data=>ty_object_data.
FIELD-SYMBOLS:
<ls_new> TYPE any,
<ls_old> TYPE any,
<lv_field_old> TYPE any,
<lv_field_new> TYPE any.
CREATE OBJECT lo_object_data TYPE ('CL_BLUE_SOURCE_OBJECT_DATA').
lo_object_data = io_object_data.
CREATE DATA lr_new TYPE ('CL_BLUE_SOURCE_OBJECT_DATA=>TY_OBJECT_DATA').
ASSIGN lr_new->* TO <ls_new>.
ASSERT sy-subrc = 0.
CREATE DATA lr_old TYPE ('CL_BLUE_SOURCE_OBJECT_DATA=>TY_OBJECT_DATA').
ASSIGN lr_old->* TO <ls_old>.
ASSERT sy-subrc = 0.
CALL METHOD lo_object_data->('IF_WB_OBJECT_DATA_MODEL~GET_DATA')
EXPORTING
p_metadata_only = abap_false
p_data_selection = 'AL'
IMPORTING
p_data = <ls_new>.
lo_wb_object_operator = get_wb_object_operator( ).
CALL METHOD lo_wb_object_operator->('IF_WB_OBJECT_OPERATOR~READ')
EXPORTING
data_selection = 'AL' " if_wb_object_data_selection_co=>c_all_data
IMPORTING
eo_object_data = lo_object_data_old.
CALL METHOD lo_object_data_old->('GET_DATA')
EXPORTING
p_metadata_only = abap_false
p_data_selection = 'AL' " if_wb_object_data_selection_co=>c_all_data
IMPORTING
p_data = <ls_old>.
ASSIGN COMPONENT 'METADATA-DESCRIPTION' OF STRUCTURE <ls_old> TO <lv_field_old>.
ASSIGN COMPONENT 'METADATA-DESCRIPTION' OF STRUCTURE <ls_new> TO <lv_field_new>.
<lv_field_old> = <lv_field_new>.
ASSIGN COMPONENT 'CONTENT-SOURCE' OF STRUCTURE <ls_old> TO <lv_field_old>.
ASSIGN COMPONENT 'CONTENT-SOURCE' OF STRUCTURE <ls_new> TO <lv_field_new>.
<lv_field_old> = <lv_field_new>.
CREATE OBJECT ro_object_data_merged TYPE ('CL_BLUE_SOURCE_OBJECT_DATA').
CALL METHOD ro_object_data_merged->('SET_DATA')
EXPORTING
p_data = <ls_old>.
ENDMETHOD.
ENDCLASS. ENDCLASS.

3
src/ui/zcl_abapgit_gui_page_stage.clas.abap
View File

@ -264,9 +264,6 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_STAGE IMPLEMENTATION.
METHOD find_transports. METHOD find_transports.
FIELD-SYMBOLS: <ls_local> LIKE LINE OF it_files-local.
FIELD-SYMBOLS: <ls_remote> LIKE LINE OF it_files-remote.
TRY. TRY.
find_transports_local( find_transports_local(

3
src/ui/zcl_abapgit_html_form_utils.clas.testclasses.abap
View File

@ -29,8 +29,7 @@ CLASS ltcl_popups_mock DEFINITION FINAL FOR TESTING
BEGIN OF ms_called, BEGIN OF ms_called,
popup_to_confirm TYPE abap_bool, popup_to_confirm TYPE abap_bool,
END OF ms_called, END OF ms_called,
mv_user_decision TYPE ty_user_decision, mv_user_decision TYPE ty_user_decision.
mv_package TYPE devclass.
ENDCLASS. ENDCLASS.

1
src/utils/zcl_abapgit_convert.clas.testclasses.abap
View File

@ -31,7 +31,6 @@ CLASS ltcl_convert IMPLEMENTATION.
TYPES ty_hex TYPE x LENGTH 2. TYPES ty_hex TYPE x LENGTH 2.
DATA lt_bintab TYPE STANDARD TABLE OF ty_hex WITH DEFAULT KEY. DATA lt_bintab TYPE STANDARD TABLE OF ty_hex WITH DEFAULT KEY.
DATA lv_size TYPE i. DATA lv_size TYPE i.
DATA lv_xstr TYPE xstring.
zcl_abapgit_convert=>xstring_to_bintab( zcl_abapgit_convert=>xstring_to_bintab(
EXPORTING EXPORTING