From 69c6854e8e6d80c825c0cf0a700db09e75a8bb95 Mon Sep 17 00:00:00 2001 From: Christian Guenter Date: Mon, 10 Sep 2018 14:45:30 +0000 Subject: [PATCH] Fix ifinite loop in ZCL_ABAPGIT_BRANCH_OVERVIEW --- src/zcl_abapgit_branch_overview.clas.abap | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/zcl_abapgit_branch_overview.clas.abap b/src/zcl_abapgit_branch_overview.clas.abap index 83f8d8234..40c8f104b 100644 --- a/src/zcl_abapgit_branch_overview.clas.abap +++ b/src/zcl_abapgit_branch_overview.clas.abap @@ -57,10 +57,10 @@ CLASS zcl_abapgit_branch_overview DEFINITION zcx_abapgit_exception . METHODS _sort_commits CHANGING ct_commits TYPE ty_commits. METHODS _get_1st_child_commit - IMPORTING itr_commit_sha1s TYPE tyt_commit_sha1_range - EXPORTING etr_commit_sha1s TYPE tyt_commit_sha1_range - e_1st_commit TYPE zif_abapgit_definitions=>ty_commit - CHANGING ct_commits TYPE ty_commits. + IMPORTING itr_commit_sha1s TYPE tyt_commit_sha1_range + EXPORTING etr_commit_sha1s TYPE tyt_commit_sha1_range + e_1st_commit TYPE zif_abapgit_definitions=>ty_commit + CHANGING ct_commits TYPE ty_commits. ENDCLASS. @@ -434,6 +434,8 @@ CLASS zcl_abapgit_branch_overview IMPLEMENTATION. FIELD-SYMBOLS: LIKE LINE OF itr_commit_sha1s. FIELD-SYMBOLS: TYPE zif_abapgit_definitions=>ty_commit. + CLEAR: e_1st_commit. + * get all reachable next commits ltr_commit_sha1s = itr_commit_sha1s. LOOP AT ct_commits ASSIGNING WHERE parent1 IN ltr_commit_sha1s