Fix ifinite loop in ZCL_ABAPGIT_BRANCH_OVERVIEW

This commit is contained in:
Christian Guenter 2018-09-10 14:45:30 +00:00 committed by Lars Hvam
parent 29ce3e8170
commit 69c6854e8e

View File

@ -57,10 +57,10 @@ CLASS zcl_abapgit_branch_overview DEFINITION
zcx_abapgit_exception .
METHODS _sort_commits CHANGING ct_commits TYPE ty_commits.
METHODS _get_1st_child_commit
IMPORTING itr_commit_sha1s TYPE tyt_commit_sha1_range
EXPORTING etr_commit_sha1s TYPE tyt_commit_sha1_range
e_1st_commit TYPE zif_abapgit_definitions=>ty_commit
CHANGING ct_commits TYPE ty_commits.
IMPORTING itr_commit_sha1s TYPE tyt_commit_sha1_range
EXPORTING etr_commit_sha1s TYPE tyt_commit_sha1_range
e_1st_commit TYPE zif_abapgit_definitions=>ty_commit
CHANGING ct_commits TYPE ty_commits.
ENDCLASS.
@ -434,6 +434,8 @@ CLASS zcl_abapgit_branch_overview IMPLEMENTATION.
FIELD-SYMBOLS: <lsr_commit_sha1> LIKE LINE OF itr_commit_sha1s.
FIELD-SYMBOLS: <ls_child_commit> TYPE zif_abapgit_definitions=>ty_commit.
CLEAR: e_1st_commit.
* get all reachable next commits
ltr_commit_sha1s = itr_commit_sha1s.
LOOP AT ct_commits ASSIGNING <ls_child_commit> WHERE parent1 IN ltr_commit_sha1s