dot abapgit file, move file build (#4226)

move responsibility for building the dotabapgit file to the dotabapgit class instead of the repo

https://github.com/abapGit/abapGit/issues/2127#issuecomment-732262897
This commit is contained in:
Lars Hvam 2020-11-24 07:55:15 +01:00 committed by GitHub
parent d3b68b8a48
commit 6bd3242ecf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 16 deletions

View File

@ -22,6 +22,11 @@ CLASS zcl_abapgit_dot_abapgit DEFINITION
VALUE(rv_xstr) TYPE xstring VALUE(rv_xstr) TYPE xstring
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS to_file
RETURNING
VALUE(rs_file) TYPE zif_abapgit_definitions=>ty_file
RAISING
zcx_abapgit_exception.
METHODS get_data METHODS get_data
RETURNING RETURNING
VALUE(rs_data) TYPE zif_abapgit_dot_abapgit=>ty_dot_abapgit . VALUE(rs_data) TYPE zif_abapgit_dot_abapgit=>ty_dot_abapgit .
@ -286,6 +291,14 @@ CLASS ZCL_ABAPGIT_DOT_ABAPGIT IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD to_file.
rs_file-path = zif_abapgit_definitions=>c_root_dir.
rs_file-filename = zif_abapgit_definitions=>c_dot_abapgit.
rs_file-data = serialize( ).
rs_file-sha1 = zcl_abapgit_hash=>sha1_blob( rs_file-data ).
ENDMETHOD.
METHOD to_xml. METHOD to_xml.
CALL TRANSFORMATION id CALL TRANSFORMATION id

View File

@ -186,11 +186,6 @@ CLASS zcl_abapgit_repo DEFINITION
!is_change_mask TYPE zif_abapgit_persistence=>ty_repo_meta_mask !is_change_mask TYPE zif_abapgit_persistence=>ty_repo_meta_mask
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS build_dotabapgit_file
RETURNING
VALUE(rs_file) TYPE zif_abapgit_definitions=>ty_file
RAISING
zcx_abapgit_exception .
METHODS build_apack_manifest_file METHODS build_apack_manifest_file
RETURNING RETURNING
VALUE(rs_file) TYPE zif_abapgit_definitions=>ty_file VALUE(rs_file) TYPE zif_abapgit_definitions=>ty_file
@ -235,16 +230,6 @@ CLASS ZCL_ABAPGIT_REPO IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD build_dotabapgit_file.
rs_file-path = zif_abapgit_definitions=>c_root_dir.
rs_file-filename = zif_abapgit_definitions=>c_dot_abapgit.
rs_file-data = get_dot_abapgit( )->serialize( ).
rs_file-sha1 = zcl_abapgit_hash=>sha1_blob( rs_file-data ).
ENDMETHOD.
METHOD check_for_restart. METHOD check_for_restart.
CONSTANTS: CONSTANTS:
@ -471,7 +456,7 @@ CLASS ZCL_ABAPGIT_REPO IMPLEMENTATION.
ENDIF. ENDIF.
APPEND INITIAL LINE TO rt_files ASSIGNING <ls_return>. APPEND INITIAL LINE TO rt_files ASSIGNING <ls_return>.
<ls_return>-file = build_dotabapgit_file( ). <ls_return>-file = get_dot_abapgit( )->to_file( ).
ls_apack_file = build_apack_manifest_file( ). ls_apack_file = build_apack_manifest_file( ).
IF ls_apack_file IS NOT INITIAL. IF ls_apack_file IS NOT INITIAL.