From 6dac984acc978f8081aa4b1bf396e568b7a26ea6 Mon Sep 17 00:00:00 2001
From: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Date: Mon, 18 Jan 2021 03:31:12 -0500
Subject: [PATCH] Improve error message for getting request type (#4421)

Co-authored-by: Lars Hvam <larshp@hotmail.com>
---
 src/zcl_abapgit_sap_package.clas.abap | 25 +++++--------------------
 1 file changed, 5 insertions(+), 20 deletions(-)

diff --git a/src/zcl_abapgit_sap_package.clas.abap b/src/zcl_abapgit_sap_package.clas.abap
index 4c47b1b77..f9b6a2b3a 100644
--- a/src/zcl_abapgit_sap_package.clas.abap
+++ b/src/zcl_abapgit_sap_package.clas.abap
@@ -221,10 +221,9 @@ CLASS ZCL_ABAPGIT_SAP_PACKAGE IMPLEMENTATION.
 
 
   METHOD zif_abapgit_sap_package~get_transport_type.
-    DATA: lv_err_prefix TYPE string,
-          lv_pkg_name   TYPE e071-obj_name.
 
-    lv_err_prefix = |TRINT_GET_REQUEST_TYPE(R3TR, DEVC, { mv_package })|.
+    DATA lv_pkg_name TYPE e071-obj_name.
+
     lv_pkg_name = mv_package.
 
     CALL FUNCTION 'TRINT_GET_REQUEST_TYPE'
@@ -239,23 +238,9 @@ CLASS ZCL_ABAPGIT_SAP_PACKAGE IMPLEMENTATION.
         no_request_needed          = 1
         internal_error             = 2
         cts_initialization_failure = 3.
-
-    CASE sy-subrc.
-      WHEN 0.
-        " OK!
-
-      WHEN 1.
-        zcx_abapgit_exception=>raise( |{ lv_err_prefix }: transport is not needed| ).
-
-      WHEN 2.
-        zcx_abapgit_exception=>raise( |{ lv_err_prefix }: internal error| ).
-
-      WHEN 3.
-        zcx_abapgit_exception=>raise( |{ lv_err_prefix }: failed to initialized CTS| ).
-
-      WHEN OTHERS.
-        zcx_abapgit_exception=>raise( |{ lv_err_prefix }: unrecognized return code| ).
-    ENDCASE.
+    IF sy-subrc <> 0.
+      zcx_abapgit_exception=>raise_t100( ).
+    ENDIF.
 
   ENDMETHOD.