diff --git a/src/syntax/zcl_abapgit_syntax_highlighter.clas.testclasses.abap b/src/syntax/zcl_abapgit_syntax_highlighter.clas.testclasses.abap index 1b29d1bfc..11a3b9745 100644 --- a/src/syntax/zcl_abapgit_syntax_highlighter.clas.testclasses.abap +++ b/src/syntax/zcl_abapgit_syntax_highlighter.clas.testclasses.abap @@ -530,7 +530,7 @@ CLASS ltcl_syntax_basic_logic DEFINITION FINAL FOR TESTING RISK LEVEL HARMLESS PRIVATE SECTION. - DATA mo TYPE REF TO zcl_abapgit_syntax_highlighter. + DATA mo_syntax_highlighter TYPE REF TO zcl_abapgit_syntax_highlighter. METHODS: setup, @@ -546,7 +546,7 @@ ENDCLASS. CLASS ltcl_syntax_basic_logic IMPLEMENTATION. METHOD setup. - mo = zcl_abapgit_syntax_highlighter=>create( '*.abap' ). + mo_syntax_highlighter = zcl_abapgit_syntax_highlighter=>create( '*.abap' ). ENDMETHOD. METHOD format_line. @@ -564,7 +564,7 @@ CLASS ltcl_syntax_basic_logic IMPLEMENTATION. ' 'FM_NAME'.' && "#EC NOTEXT ' " Commented'. "#EC NOTEXT - lv_line_act = mo->process_line( lv_line ). + lv_line_act = mo_syntax_highlighter->process_line( lv_line ). cl_abap_unit_assert=>assert_equals( exp = lv_line_exp act = lv_line_act @@ -577,7 +577,7 @@ CLASS ltcl_syntax_basic_logic IMPLEMENTATION. DATA lv_line_act TYPE string. " Call the method and compare results - lv_line_act = mo->apply_style( iv_line = 'CALL FUNCTION' "#EC NOTEXT + lv_line_act = mo_syntax_highlighter->apply_style( iv_line = 'CALL FUNCTION' "#EC NOTEXT iv_class = zcl_abapgit_syntax_abap=>c_css-keyword ). cl_abap_unit_assert=>assert_equals( @@ -592,7 +592,7 @@ CLASS ltcl_syntax_basic_logic IMPLEMENTATION. DATA lv_line_act TYPE string. " Call the method with empty parameter and compare results - lv_line_act = mo->process_line( '' ). + lv_line_act = mo_syntax_highlighter->process_line( '' ). cl_abap_unit_assert=>assert_equals( act = lv_line_act @@ -600,7 +600,7 @@ CLASS ltcl_syntax_basic_logic IMPLEMENTATION. msg = 'Failure in method process_line.' ). "#EC NOTEXT " Call the method with non-empty line and compare results - lv_line_act = mo->process_line( '* CALL FUNCTION' ). "#EC NOTEXT + lv_line_act = mo_syntax_highlighter->process_line( '* CALL FUNCTION' ). "#EC NOTEXT cl_abap_unit_assert=>assert_equals( act = lv_line_act diff --git a/src/ui/db/zcl_abapgit_gui_page_db_edit.clas.abap b/src/ui/db/zcl_abapgit_gui_page_db_edit.clas.abap index af21527c7..b5775fbfa 100644 --- a/src/ui/db/zcl_abapgit_gui_page_db_edit.clas.abap +++ b/src/ui/db/zcl_abapgit_gui_page_db_edit.clas.abap @@ -25,9 +25,9 @@ CLASS zcl_abapgit_gui_page_db_edit DEFINITION PRIVATE SECTION. CONSTANTS: - BEGIN OF gc_action, + BEGIN OF c_action, update TYPE string VALUE 'update', - END OF gc_action . + END OF c_action . DATA ms_key TYPE zif_abapgit_persistence=>ty_content . CLASS-METHODS update @@ -65,10 +65,10 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DB_EDIT IMPLEMENTATION. zcl_abapgit_html_action_utils=>get_field( EXPORTING - name = 'XMLDATA' - it = lt_fields + iv_name = 'XMLDATA' + it_field = lt_fields CHANGING - cv = rs_content-data_str ). + cg_field = rs_content-data_str ). IF rs_content-data_str(1) <> '<' AND rs_content-data_str+1(1) = '<'. " Hmmm ??? rs_content-data_str = rs_content-data_str+1. @@ -113,7 +113,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DB_EDIT IMPLEMENTATION. ro_html->add( '' ). " Form - ro_html->add( |
| ). + ro_html->add( || ). ro_html->add( || ). ro_html->add( || ). ro_html->add( || ). @@ -143,7 +143,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DB_EDIT IMPLEMENTATION. DATA: ls_db TYPE zif_abapgit_persistence=>ty_content. CASE iv_action. - WHEN gc_action-update. + WHEN c_action-update. ls_db = dbcontent_decode( it_postdata ). update( ls_db ). ev_state = zif_abapgit_definitions=>gc_event_state-go_back. diff --git a/src/ui/zcl_abapgit_gui_page_bkg.clas.abap b/src/ui/zcl_abapgit_gui_page_bkg.clas.abap index 7648c1d2b..e55d3c1b2 100644 --- a/src/ui/zcl_abapgit_gui_page_bkg.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_bkg.clas.abap @@ -96,27 +96,27 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_BKG IMPLEMENTATION. zcl_abapgit_html_action_utils=>get_field( EXPORTING - name = 'METHOD' - it = lt_fields + iv_name = 'METHOD' + it_field = lt_fields CHANGING - cv = rs_fields ). + cg_field = rs_fields ). IF rs_fields-method IS INITIAL. RETURN. ENDIF. zcl_abapgit_html_action_utils=>get_field( EXPORTING - name = 'USERNAME' - it = lt_fields + iv_name = 'USERNAME' + it_field = lt_fields CHANGING - cv = rs_fields ). + cg_field = rs_fields ). zcl_abapgit_html_action_utils=>get_field( EXPORTING - name = 'PASSWORD' - it = lt_fields + iv_name = 'PASSWORD' + it_field = lt_fields CHANGING - cv = rs_fields ). + cg_field = rs_fields ). CALL METHOD (rs_fields-method)=>zif_abapgit_background~get_settings @@ -125,10 +125,10 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_BKG IMPLEMENTATION. LOOP AT rs_fields-settings ASSIGNING . zcl_abapgit_html_action_utils=>get_field( EXPORTING - name = -key - it = lt_fields + iv_name = -key + it_field = lt_fields CHANGING - cv = -value ). + cg_field = -value ). ENDLOOP. ASSERT NOT rs_fields IS INITIAL. diff --git a/src/ui/zcl_abapgit_gui_page_commit.clas.abap b/src/ui/zcl_abapgit_gui_page_commit.clas.abap index 0a0cba84a..acce5ad08 100644 --- a/src/ui/zcl_abapgit_gui_page_commit.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_commit.clas.abap @@ -27,7 +27,7 @@ CLASS zcl_abapgit_gui_page_commit DEFINITION IMPORTING !it_postdata TYPE cnht_post_data_tab EXPORTING - !es_fields TYPE any . + !eg_fields TYPE any . METHODS render_content REDEFINITION . @@ -79,7 +79,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_COMMIT IMPLEMENTATION. FIELD-SYMBOLS TYPE string. - CLEAR es_fields. + CLEAR eg_fields. CONCATENATE LINES OF it_postdata INTO lv_string. REPLACE ALL OCCURRENCES OF zif_abapgit_definitions=>gc_crlf IN lv_string WITH lc_replace. @@ -88,42 +88,42 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_COMMIT IMPLEMENTATION. zcl_abapgit_html_action_utils=>get_field( EXPORTING - name = 'COMMITTER_NAME' - it = lt_fields + iv_name = 'COMMITTER_NAME' + it_field = lt_fields CHANGING - cv = es_fields ). + cg_field = eg_fields ). zcl_abapgit_html_action_utils=>get_field( EXPORTING - name = 'COMMITTER_EMAIL' - it = lt_fields + iv_name = 'COMMITTER_EMAIL' + it_field = lt_fields CHANGING - cv = es_fields ). + cg_field = eg_fields ). zcl_abapgit_html_action_utils=>get_field( EXPORTING - name = 'AUTHOR_NAME' - it = lt_fields + iv_name = 'AUTHOR_NAME' + it_field = lt_fields CHANGING - cv = es_fields ). + cg_field = eg_fields ). zcl_abapgit_html_action_utils=>get_field( EXPORTING - name = 'AUTHOR_EMAIL' - it = lt_fields + iv_name = 'AUTHOR_EMAIL' + it_field = lt_fields CHANGING - cv = es_fields ). + cg_field = eg_fields ). zcl_abapgit_html_action_utils=>get_field( EXPORTING - name = 'COMMENT' - it = lt_fields + iv_name = 'COMMENT' + it_field = lt_fields CHANGING - cv = es_fields ). + cg_field = eg_fields ). zcl_abapgit_html_action_utils=>get_field( EXPORTING - name = 'BODY' - it = lt_fields + iv_name = 'BODY' + it_field = lt_fields CHANGING - cv = es_fields ). + cg_field = eg_fields ). - ASSIGN COMPONENT 'BODY' OF STRUCTURE es_fields TO . + ASSIGN COMPONENT 'BODY' OF STRUCTURE eg_fields TO . ASSERT IS ASSIGNED. REPLACE ALL OCCURRENCES OF lc_replace IN WITH zif_abapgit_definitions=>gc_newline. @@ -335,7 +335,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_COMMIT IMPLEMENTATION. parse_commit_request( EXPORTING it_postdata = it_postdata - IMPORTING es_fields = ls_commit ). + IMPORTING eg_fields = ls_commit ). ls_commit-repo_key = mo_repo->get_key( ). diff --git a/src/ui/zcl_abapgit_gui_page_merge_res.clas.abap b/src/ui/zcl_abapgit_gui_page_merge_res.clas.abap index c8b174d6a..043bc95b4 100644 --- a/src/ui/zcl_abapgit_gui_page_merge_res.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_merge_res.clas.abap @@ -117,31 +117,31 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_MERGE_RES IMPLEMENTATION. CONSTANTS: lc_replace TYPE string VALUE '<>'. - DATA: BEGIN OF filedata, + DATA: BEGIN OF ls_filedata, merge_content TYPE string, - END OF filedata. + END OF ls_filedata. DATA: lv_string TYPE string, lt_fields TYPE tihttpnvp, lv_new_file_content TYPE xstring. - FIELD-SYMBOLS: LIKE LINE OF it_postdata, + FIELD-SYMBOLS: LIKE LINE OF it_postdata, TYPE zif_abapgit_definitions=>ty_merge_conflict. - LOOP AT it_postdata ASSIGNING . - lv_string = |{ lv_string }{ }|. + LOOP AT it_postdata ASSIGNING . + lv_string = |{ lv_string }{ }|. ENDLOOP. REPLACE ALL OCCURRENCES OF zif_abapgit_definitions=>gc_crlf IN lv_string WITH lc_replace. REPLACE ALL OCCURRENCES OF zif_abapgit_definitions=>gc_newline IN lv_string WITH lc_replace. lt_fields = zcl_abapgit_html_action_utils=>parse_fields_upper_case_name( lv_string ). - zcl_abapgit_html_action_utils=>get_field( EXPORTING name = 'MERGE_CONTENT' - it = lt_fields - CHANGING cv = filedata ). - filedata-merge_content = cl_http_utility=>unescape_url( escaped = filedata-merge_content ). - REPLACE ALL OCCURRENCES OF lc_replace IN filedata-merge_content WITH zif_abapgit_definitions=>gc_newline. + zcl_abapgit_html_action_utils=>get_field( EXPORTING iv_name = 'MERGE_CONTENT' + it_field = lt_fields + CHANGING cg_field = ls_filedata ). + ls_filedata-merge_content = cl_http_utility=>unescape_url( escaped = ls_filedata-merge_content ). + REPLACE ALL OCCURRENCES OF lc_replace IN ls_filedata-merge_content WITH zif_abapgit_definitions=>gc_newline. - lv_new_file_content = zcl_abapgit_convert=>string_to_xstring_utf8( iv_string = filedata-merge_content ). + lv_new_file_content = zcl_abapgit_convert=>string_to_xstring_utf8( iv_string = ls_filedata-merge_content ). READ TABLE mt_conflicts ASSIGNING INDEX mv_current_conflict_index. -result_sha1 = zcl_abapgit_hash=>sha1( iv_type = zif_abapgit_definitions=>gc_type-blob diff --git a/src/ui/zcl_abapgit_gui_page_tag.clas.abap b/src/ui/zcl_abapgit_gui_page_tag.clas.abap index e5f39ada8..b161f462a 100644 --- a/src/ui/zcl_abapgit_gui_page_tag.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_tag.clas.abap @@ -22,10 +22,10 @@ CLASS zcl_abapgit_gui_page_tag DEFINITION PUBLIC FINAL scripts REDEFINITION. PRIVATE SECTION. - CONSTANTS: BEGIN OF co_tag_type, + CONSTANTS: BEGIN OF c_tag_type, lightweight TYPE string VALUE 'lightweight', annotated TYPE string VALUE 'annotated', - END OF co_tag_type. + END OF c_tag_type. DATA: mo_repo_online TYPE REF TO zcl_abapgit_repo_online, mv_selected_type TYPE string. @@ -51,7 +51,7 @@ CLASS zcl_abapgit_gui_page_tag DEFINITION PUBLIC FINAL parse_tag_request IMPORTING it_postdata TYPE cnht_post_data_tab - EXPORTING es_fields TYPE any, + EXPORTING eg_fields TYPE any, parse_change_tag_type_request IMPORTING it_postdata TYPE cnht_post_data_tab. @@ -60,7 +60,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_GUI_PAGE_TAG IMPLEMENTATION. +CLASS zcl_abapgit_gui_page_tag IMPLEMENTATION. METHOD constructor. @@ -69,7 +69,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_TAG IMPLEMENTATION. mo_repo_online ?= io_repo. ms_control-page_title = 'TAG'. - mv_selected_type = co_tag_type-lightweight. + mv_selected_type = c_tag_type-lightweight. ENDMETHOD. @@ -83,7 +83,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_TAG IMPLEMENTATION. parse_tag_request( EXPORTING it_postdata = it_postdata - IMPORTING es_fields = ls_tag ). + IMPORTING eg_fields = ls_tag ). IF ls_tag-name IS INITIAL. zcx_abapgit_exception=>raise( |Please supply a tag name| ). @@ -93,11 +93,11 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_TAG IMPLEMENTATION. ASSERT ls_tag-name CP 'refs/tags/+*'. CASE mv_selected_type. - WHEN co_tag_type-lightweight. + WHEN c_tag_type-lightweight. ls_tag-type = zif_abapgit_definitions=>c_git_branch_type-lightweight_tag. - WHEN co_tag_type-annotated. + WHEN c_tag_type-annotated. ls_tag-type = zif_abapgit_definitions=>c_git_branch_type-annotated_tag. @@ -128,13 +128,13 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_TAG IMPLEMENTATION. METHOD parse_change_tag_type_request. - FIELD-SYMBOLS: TYPE cnht_post_data_line. + FIELD-SYMBOLS: TYPE cnht_post_data_line. - READ TABLE it_postdata ASSIGNING + READ TABLE it_postdata ASSIGNING INDEX 1. IF sy-subrc = 0. FIND FIRST OCCURRENCE OF REGEX `type=(.*)` - IN + IN SUBMATCHES mv_selected_type. ENDIF. @@ -152,21 +152,33 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_TAG IMPLEMENTATION. FIELD-SYMBOLS TYPE string. - CLEAR es_fields. + CLEAR eg_fields. CONCATENATE LINES OF it_postdata INTO lv_string. REPLACE ALL OCCURRENCES OF zif_abapgit_definitions=>gc_crlf IN lv_string WITH lc_replace. REPLACE ALL OCCURRENCES OF zif_abapgit_definitions=>gc_newline IN lv_string WITH lc_replace. lt_fields = zcl_abapgit_html_action_utils=>parse_fields_upper_case_name( lv_string ). - zcl_abapgit_html_action_utils=>get_field( EXPORTING name = 'SHA1' it = lt_fields CHANGING cv = es_fields ). - zcl_abapgit_html_action_utils=>get_field( EXPORTING name = 'NAME' it = lt_fields CHANGING cv = es_fields ). - zcl_abapgit_html_action_utils=>get_field( EXPORTING name = 'TAGGER_NAME' it = lt_fields CHANGING cv = es_fields ). - zcl_abapgit_html_action_utils=>get_field( EXPORTING name = 'TAGGER_EMAIL' it = lt_fields CHANGING cv = es_fields ). - zcl_abapgit_html_action_utils=>get_field( EXPORTING name = 'MESSAGE' it = lt_fields CHANGING cv = es_fields ). - zcl_abapgit_html_action_utils=>get_field( EXPORTING name = 'BODY' it = lt_fields CHANGING cv = es_fields ). + zcl_abapgit_html_action_utils=>get_field( EXPORTING iv_name = 'SHA1' + it_field = lt_fields + CHANGING cg_field = eg_fields ). + zcl_abapgit_html_action_utils=>get_field( EXPORTING iv_name = 'NAME' + it_field = lt_fields + CHANGING cg_field = eg_fields ). + zcl_abapgit_html_action_utils=>get_field( EXPORTING iv_name = 'TAGGER_NAME' + it_field = lt_fields + CHANGING cg_field = eg_fields ). + zcl_abapgit_html_action_utils=>get_field( EXPORTING iv_name = 'TAGGER_EMAIL' + it_field = lt_fields + CHANGING cg_field = eg_fields ). + zcl_abapgit_html_action_utils=>get_field( EXPORTING iv_name = 'MESSAGE' + it_field = lt_fields + CHANGING cg_field = eg_fields ). + zcl_abapgit_html_action_utils=>get_field( EXPORTING iv_name = 'BODY' + it_field = lt_fields + CHANGING cg_field = eg_fields ). - ASSIGN COMPONENT 'BODY' OF STRUCTURE es_fields TO . + ASSIGN COMPONENT 'BODY' OF STRUCTURE eg_fields TO . ASSERT IS ASSIGNED. REPLACE ALL OCCURRENCES OF lc_replace IN WITH zif_abapgit_definitions=>gc_newline. @@ -197,7 +209,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_TAG IMPLEMENTATION. lv_body_size TYPE i, lt_type TYPE stringtab, lv_selected TYPE string. - FIELD-SYMBOLS: LIKE LINE OF lt_type. + FIELD-SYMBOLS: LIKE LINE OF lt_type. lo_user = zcl_abapgit_persistence_user=>get_instance( ). @@ -225,26 +237,26 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_TAG IMPLEMENTATION. ro_html->add( '' ). - INSERT co_tag_type-lightweight + INSERT c_tag_type-lightweight INTO TABLE lt_type. - INSERT co_tag_type-annotated + INSERT c_tag_type-annotated INTO TABLE lt_type. ro_html->add( '
' ). ro_html->add( 'Tag type