From 6f0dfc5a81acc5196043bf38a024324b81089427 Mon Sep 17 00:00:00 2001 From: Marc Bernard <59966492+mbtools@users.noreply.github.com> Date: Tue, 3 Dec 2024 01:21:05 -0500 Subject: [PATCH] Fix extended check issues - Part 2 (#7087) Co-authored-by: Lars Hvam --- src/objects/zcl_abapgit_object_aifc.clas.abap | 2 +- src/objects/zcl_abapgit_object_auth.clas.abap | 2 +- src/objects/zcl_abapgit_object_cmpt.clas.abap | 1 + src/objects/zcl_abapgit_object_fugr.clas.abap | 3 ++- src/objects/zcl_abapgit_object_iext.clas.abap | 5 +++-- src/objects/zcl_abapgit_object_oa2p.clas.abap | 4 ++-- src/objects/zcl_abapgit_object_otgr.clas.abap | 4 ++-- src/objects/zcl_abapgit_object_pdts.clas.locals_imp.abap | 2 +- src/objects/zcl_abapgit_object_pdxx_super.clas.abap | 2 +- src/objects/zcl_abapgit_object_scp1.clas.abap | 3 ++- src/objects/zcl_abapgit_object_sfpf.clas.abap | 2 +- src/objects/zcl_abapgit_object_ueno.clas.abap | 2 +- src/objects/zcl_abapgit_object_wdca.clas.abap | 2 +- src/objects/zcl_abapgit_object_xinx.clas.abap | 5 ++++- src/objects/zcl_abapgit_objects_program.clas.abap | 4 ++-- src/objects/zcl_abapgit_objects_super.clas.abap | 6 +++--- 16 files changed, 28 insertions(+), 21 deletions(-) diff --git a/src/objects/zcl_abapgit_object_aifc.clas.abap b/src/objects/zcl_abapgit_object_aifc.clas.abap index e54a12d16..55dc58237 100644 --- a/src/objects/zcl_abapgit_object_aifc.clas.abap +++ b/src/objects/zcl_abapgit_object_aifc.clas.abap @@ -383,7 +383,7 @@ CLASS zcl_abapgit_object_aifc IMPLEMENTATION. packages = '' ). CATCH cx_abap_not_a_table INTO lx_abap_not_a_table. zcx_abapgit_exception=>raise_with_text( lx_abap_not_a_table ). - CATCH cx_abap_not_in_package. + CATCH cx_abap_not_in_package ##NO_HANDLER. "that's fine ENDTRY. diff --git a/src/objects/zcl_abapgit_object_auth.clas.abap b/src/objects/zcl_abapgit_object_auth.clas.abap index 4241eec8b..462cd5e2b 100644 --- a/src/objects/zcl_abapgit_object_auth.clas.abap +++ b/src/objects/zcl_abapgit_object_auth.clas.abap @@ -159,7 +159,7 @@ CLASS zcl_abapgit_object_auth IMPLEMENTATION. CALL FUNCTION 'SU20_MAINTAIN_SNGL' EXPORTING id_field = mv_fieldname - id_wbo_mode = abap_false. + id_wbo_mode = abap_false ##EXISTS. rv_exit = abap_true. ENDIF. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_cmpt.clas.abap b/src/objects/zcl_abapgit_object_cmpt.clas.abap index 3d0a0a710..a20b5cc56 100644 --- a/src/objects/zcl_abapgit_object_cmpt.clas.abap +++ b/src/objects/zcl_abapgit_object_cmpt.clas.abap @@ -38,6 +38,7 @@ CLASS zcl_abapgit_object_cmpt IMPLEMENTATION. r_ref_db_access = mo_cmp_db. CATCH cx_root. + zcx_abapgit_exception=>raise( 'CMPT not supported' ). ENDTRY. mv_name = ms_item-obj_name. diff --git a/src/objects/zcl_abapgit_object_fugr.clas.abap b/src/objects/zcl_abapgit_object_fugr.clas.abap index 9dc0c1406..d4661d869 100644 --- a/src/objects/zcl_abapgit_object_fugr.clas.abap +++ b/src/objects/zcl_abapgit_object_fugr.clas.abap @@ -786,7 +786,8 @@ CLASS zcl_abapgit_object_fugr IMPLEMENTATION. CHANGING include = lv_include EXCEPTIONS - OTHERS = 1. + OTHERS = 1 ##FM_SUBRC_OK. + IF lv_function_group(1) = 'X'. " "EXIT"-function-module ls_tadir-object = 'FUGS'. ENDIF. diff --git a/src/objects/zcl_abapgit_object_iext.clas.abap b/src/objects/zcl_abapgit_object_iext.clas.abap index e0f681080..712bbf900 100644 --- a/src/objects/zcl_abapgit_object_iext.clas.abap +++ b/src/objects/zcl_abapgit_object_iext.clas.abap @@ -53,8 +53,9 @@ CLASS zcl_abapgit_object_iext IMPLEMENTATION. pe_attributes = ls_attributes EXCEPTIONS OTHERS = 1. - - rv_user = ls_attributes-plast. + IF sy-subrc = 0. + rv_user = ls_attributes-plast. + ENDIF. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_oa2p.clas.abap b/src/objects/zcl_abapgit_object_oa2p.clas.abap index 3a2d26068..d4cb699d0 100644 --- a/src/objects/zcl_abapgit_object_oa2p.clas.abap +++ b/src/objects/zcl_abapgit_object_oa2p.clas.abap @@ -90,7 +90,7 @@ CLASS zcl_abapgit_object_oa2p IMPLEMENTATION. "authority check AUTHORITY-CHECK OBJECT 'S_OA2C_ADM' - ID 'ACTVT' FIELD lc_actvt. + ID 'ACTVT' FIELD lc_actvt ##AUTH_OBJ_OK. IF sy-subrc <> 0. MESSAGE e463(01) WITH mv_profile INTO zcx_abapgit_exception=>null. zcx_abapgit_exception=>raise_t100( ). @@ -104,7 +104,7 @@ CLASS zcl_abapgit_object_oa2p IMPLEMENTATION. CALL METHOD lo_persist->('IF_WB_OBJECT_PERSIST~DELETE') EXPORTING p_object_key = lv_profile_key. " Object Key - CATCH cx_swb_object_does_not_exist. + CATCH cx_swb_object_does_not_exist ##NO_HANDLER. CATCH cx_swb_exception. zcx_abapgit_exception=>raise( |Error when deleting OAuth2 Profile { lv_profile_key }.| ). ENDTRY. diff --git a/src/objects/zcl_abapgit_object_otgr.clas.abap b/src/objects/zcl_abapgit_object_otgr.clas.abap index 73e22c19a..cd5108d74 100644 --- a/src/objects/zcl_abapgit_object_otgr.clas.abap +++ b/src/objects/zcl_abapgit_object_otgr.clas.abap @@ -137,7 +137,7 @@ CLASS zcl_abapgit_object_otgr IMPLEMENTATION. TRY. CREATE DATA lo_parents TYPE TABLE OF ('CLS_TYGR_PARENT'). ASSIGN lo_parents->* TO . - CATCH cx_sy_create_data_error. + CATCH cx_sy_create_data_error ##NO_HANDLER. ENDTRY. IF IS ASSIGNED. @@ -288,7 +288,7 @@ CLASS zcl_abapgit_object_otgr IMPLEMENTATION. TRY. CREATE DATA lo_parents TYPE TABLE OF ('CLS_TYGR_PARENT'). ASSIGN lo_parents->* TO . - CATCH cx_sy_create_data_error. + CATCH cx_sy_create_data_error ##NO_HANDLER. ENDTRY. TRY. diff --git a/src/objects/zcl_abapgit_object_pdts.clas.locals_imp.abap b/src/objects/zcl_abapgit_object_pdts.clas.locals_imp.abap index e8ccc60e4..d21fb9742 100644 --- a/src/objects/zcl_abapgit_object_pdts.clas.locals_imp.abap +++ b/src/objects/zcl_abapgit_object_pdts.clas.locals_imp.abap @@ -172,7 +172,7 @@ CLASS lcl_task_definition IMPLEMENTATION. IF sy-subrc <> 0. TRY. li_container->element_remove( name = lv_element ). - CATCH cx_swf_cnt_container. + CATCH cx_swf_cnt_container ##NO_HANDLER. "Shouldn't happen, doesn't matter if it does ENDTRY. ENDIF. diff --git a/src/objects/zcl_abapgit_object_pdxx_super.clas.abap b/src/objects/zcl_abapgit_object_pdxx_super.clas.abap index 004a4b501..3b066e968 100644 --- a/src/objects/zcl_abapgit_object_pdxx_super.clas.abap +++ b/src/objects/zcl_abapgit_object_pdxx_super.clas.abap @@ -77,7 +77,7 @@ CLASS zcl_abapgit_object_pdxx_super IMPLEMENTATION. enqueue_failed = 1 object_not_deleted = 2 object_not_found = 3 - OTHERS = 4. "#EC SUBRC_OK + OTHERS = 4 ##FM_SUBRC_OK. check_subrc_for( `RH_HRSOBJECT_DELETE` ). diff --git a/src/objects/zcl_abapgit_object_scp1.clas.abap b/src/objects/zcl_abapgit_object_scp1.clas.abap index 00bfe1355..b31918f1a 100644 --- a/src/objects/zcl_abapgit_object_scp1.clas.abap +++ b/src/objects/zcl_abapgit_object_scp1.clas.abap @@ -486,7 +486,8 @@ CLASS zcl_abapgit_object_scp1 IMPLEMENTATION. TABLES texts = ls_scp1-scprtext EXCEPTIONS - no_text_found = 1. + no_text_found = 1 + OTHERS = 2 ##FM_SUBRC_OK. IF ls_scp1-scprattr-type = 'TMP'. load_hier( CHANGING cs_scp1 = ls_scp1 ). diff --git a/src/objects/zcl_abapgit_object_sfpf.clas.abap b/src/objects/zcl_abapgit_object_sfpf.clas.abap index 29564ada8..908114251 100644 --- a/src/objects/zcl_abapgit_object_sfpf.clas.abap +++ b/src/objects/zcl_abapgit_object_sfpf.clas.abap @@ -134,7 +134,7 @@ CLASS zcl_abapgit_object_sfpf IMPLEMENTATION. TRY. rv_xstr = cl_fp_helper=>convert_form_to_xstring( li_fp_form ). - CATCH cx_fp_api INTO lx_fp_conv_err. + CATCH cx_fp_api INTO lx_fp_conv_err ##NO_HANDLER. " Pass - the exception is handled below! ENDTRY. diff --git a/src/objects/zcl_abapgit_object_ueno.clas.abap b/src/objects/zcl_abapgit_object_ueno.clas.abap index 079ac07ac..d23a46759 100644 --- a/src/objects/zcl_abapgit_object_ueno.clas.abap +++ b/src/objects/zcl_abapgit_object_ueno.clas.abap @@ -569,7 +569,7 @@ CLASS zcl_abapgit_object_ueno IMPLEMENTATION. header = ls_docu-header content = ls_docu-content itf = ls_docu-itf - pstatus = lv_error_status. + pstatus = lv_error_status ##ARG_OK. CHECK lv_error_status = 'S'. "Success diff --git a/src/objects/zcl_abapgit_object_wdca.clas.abap b/src/objects/zcl_abapgit_object_wdca.clas.abap index f5f8a1276..fd041d6fc 100644 --- a/src/objects/zcl_abapgit_object_wdca.clas.abap +++ b/src/objects/zcl_abapgit_object_wdca.clas.abap @@ -303,7 +303,7 @@ CLASS zcl_abapgit_object_wdca IMPLEMENTATION. WHERE config_id = ls_outline-config_id AND config_type = ls_outline-config_type AND config_var = ls_outline-config_var. - CATCH zcx_abapgit_exception. + CATCH zcx_abapgit_exception ##NO_HANDLER. " File not found ENDTRY. diff --git a/src/objects/zcl_abapgit_object_xinx.clas.abap b/src/objects/zcl_abapgit_object_xinx.clas.abap index 305e7cef9..020901d8c 100644 --- a/src/objects/zcl_abapgit_object_xinx.clas.abap +++ b/src/objects/zcl_abapgit_object_xinx.clas.abap @@ -100,7 +100,7 @@ CLASS zcl_abapgit_object_xinx IMPLEMENTATION. suppress_transport = 'X' EXCEPTIONS no_docu_found = 1 - OTHERS = 2. + OTHERS = 2 ##FM_SUBRC_OK. ENDMETHOD. @@ -317,6 +317,9 @@ CLASS zcl_abapgit_object_xinx IMPLEMENTATION. EXCEPTIONS illegal_input = 1 OTHERS = 2. + IF sy-subrc <> 0. + zcx_abapgit_exception=>raise( 'Error reading index' ). + ENDIF. rv_bool = boolc( ls_dd12v IS NOT INITIAL ). diff --git a/src/objects/zcl_abapgit_objects_program.clas.abap b/src/objects/zcl_abapgit_objects_program.clas.abap index fc75e7f71..f4266aae9 100644 --- a/src/objects/zcl_abapgit_objects_program.clas.abap +++ b/src/objects/zcl_abapgit_objects_program.clas.abap @@ -650,7 +650,7 @@ CLASS zcl_abapgit_objects_program IMPLEMENTATION. cancelled = 2 name_not_allowed = 3 permission_error = 4 - OTHERS = 5. + OTHERS = 5 ##FM_SUBRC_OK. CATCH cx_sy_dyn_call_param_not_found. CALL FUNCTION 'RPY_PROGRAM_INSERT' EXPORTING @@ -667,7 +667,7 @@ CLASS zcl_abapgit_objects_program IMPLEMENTATION. cancelled = 2 name_not_allowed = 3 permission_error = 4 - OTHERS = 5. + OTHERS = 5 ##FM_SUBRC_OK. ENDTRY. IF sy-subrc = 3. diff --git a/src/objects/zcl_abapgit_objects_super.clas.abap b/src/objects/zcl_abapgit_objects_super.clas.abap index c6b6d0382..3ad0a10c5 100644 --- a/src/objects/zcl_abapgit_objects_super.clas.abap +++ b/src/objects/zcl_abapgit_objects_super.clas.abap @@ -191,7 +191,7 @@ CLASS zcl_abapgit_objects_super IMPLEMENTATION. object_not_specified = 3 permission_failure = 4 dialog_needed = 5 - OTHERS = 6. + OTHERS = 6 ##FM_SUBRC_OK. CATCH cx_sy_dyn_call_param_not_found. TRY. " try to force deletion for APPENDs @@ -207,7 +207,7 @@ CLASS zcl_abapgit_objects_super IMPLEMENTATION. object_not_specified = 3 permission_failure = 4 dialog_needed = 5 - OTHERS = 6. + OTHERS = 6 ##FM_SUBRC_OK. CATCH cx_sy_dyn_call_param_not_found. " no_ask_delete_append and aie_force_deletion not available in lower releases CALL FUNCTION 'RS_DD_DELETE_OBJ' @@ -221,7 +221,7 @@ CLASS zcl_abapgit_objects_super IMPLEMENTATION. object_not_specified = 3 permission_failure = 4 dialog_needed = 5 - OTHERS = 6. + OTHERS = 6 ##FM_SUBRC_OK. ENDTRY. ENDTRY.