Fix extended check issues - Part 2 (#7087)

Co-authored-by: Lars Hvam <larshp@hotmail.com>

src/objects/zcl_abapgit_object_aifc.clas.abap

@@ -383,7 +383,7 @@ CLASS zcl_abapgit_object_aifc IMPLEMENTATION.
                                                                     packages = '' ).
             CATCH cx_abap_not_a_table INTO lx_abap_not_a_table.
               zcx_abapgit_exception=>raise_with_text( lx_abap_not_a_table ).
-            CATCH cx_abap_not_in_package.
+            CATCH cx_abap_not_in_package ##NO_HANDLER.
               "that's fine
           ENDTRY.
 

src/objects/zcl_abapgit_object_auth.clas.abap

@@ -159,7 +159,7 @@ CLASS zcl_abapgit_object_auth IMPLEMENTATION.
       CALL FUNCTION 'SU20_MAINTAIN_SNGL'
         EXPORTING
           id_field    = mv_fieldname
-          id_wbo_mode = abap_false.
+          id_wbo_mode = abap_false ##EXISTS.
       rv_exit = abap_true.
     ENDIF.
   ENDMETHOD.

src/objects/zcl_abapgit_object_cmpt.clas.abap

@@ -38,6 +38,7 @@ CLASS zcl_abapgit_object_cmpt IMPLEMENTATION.
             r_ref_db_access = mo_cmp_db.
 
       CATCH cx_root.
+        zcx_abapgit_exception=>raise( 'CMPT not supported' ).
     ENDTRY.
 
     mv_name = ms_item-obj_name.

src/objects/zcl_abapgit_object_fugr.clas.abap

@@ -786,7 +786,8 @@ CLASS zcl_abapgit_object_fugr IMPLEMENTATION.
         CHANGING
           include   = lv_include
         EXCEPTIONS
-          OTHERS    = 1.
+          OTHERS    = 1 ##FM_SUBRC_OK.
+
       IF lv_function_group(1) = 'X'.    " "EXIT"-function-module
         ls_tadir-object = 'FUGS'.
       ENDIF.

src/objects/zcl_abapgit_object_iext.clas.abap

@@ -53,8 +53,9 @@ CLASS zcl_abapgit_object_iext IMPLEMENTATION.
         pe_attributes = ls_attributes
       EXCEPTIONS
         OTHERS        = 1.
-
-    rv_user = ls_attributes-plast.
+    IF sy-subrc = 0.
+      rv_user = ls_attributes-plast.
+    ENDIF.
 
   ENDMETHOD.
 

src/objects/zcl_abapgit_object_oa2p.clas.abap

@@ -90,7 +90,7 @@ CLASS zcl_abapgit_object_oa2p IMPLEMENTATION.
 
     "authority check
     AUTHORITY-CHECK OBJECT 'S_OA2C_ADM'
-      ID 'ACTVT'     FIELD lc_actvt.
+      ID 'ACTVT' FIELD lc_actvt ##AUTH_OBJ_OK.
     IF sy-subrc <> 0.
       MESSAGE e463(01) WITH mv_profile INTO zcx_abapgit_exception=>null.
       zcx_abapgit_exception=>raise_t100( ).
@@ -104,7 +104,7 @@ CLASS zcl_abapgit_object_oa2p IMPLEMENTATION.
         CALL METHOD lo_persist->('IF_WB_OBJECT_PERSIST~DELETE')
           EXPORTING
             p_object_key = lv_profile_key.   " Object Key
-      CATCH cx_swb_object_does_not_exist.
+      CATCH cx_swb_object_does_not_exist ##NO_HANDLER.
       CATCH cx_swb_exception.
         zcx_abapgit_exception=>raise( |Error when deleting OAuth2 Profile { lv_profile_key }.| ).
     ENDTRY.

src/objects/zcl_abapgit_object_otgr.clas.abap

@@ -137,7 +137,7 @@ CLASS zcl_abapgit_object_otgr IMPLEMENTATION.
     TRY.
         CREATE DATA lo_parents TYPE TABLE OF ('CLS_TYGR_PARENT').
         ASSIGN lo_parents->* TO <lt_parents>.
-      CATCH cx_sy_create_data_error.
+      CATCH cx_sy_create_data_error ##NO_HANDLER.
     ENDTRY.
 
     IF <lt_parents> IS ASSIGNED.
@@ -288,7 +288,7 @@ CLASS zcl_abapgit_object_otgr IMPLEMENTATION.
     TRY.
         CREATE DATA lo_parents TYPE TABLE OF ('CLS_TYGR_PARENT').
         ASSIGN lo_parents->* TO <lt_parents>.
-      CATCH cx_sy_create_data_error.
+      CATCH cx_sy_create_data_error ##NO_HANDLER.
     ENDTRY.
 
     TRY.

src/objects/zcl_abapgit_object_pdts.clas.locals_imp.abap

@@ -172,7 +172,7 @@ CLASS lcl_task_definition IMPLEMENTATION.
       IF sy-subrc <> 0.
         TRY.
             li_container->element_remove( name = lv_element ).
-          CATCH cx_swf_cnt_container.
+          CATCH cx_swf_cnt_container ##NO_HANDLER.
             "Shouldn't happen, doesn't matter if it does
         ENDTRY.
       ENDIF.

src/objects/zcl_abapgit_object_pdxx_super.clas.abap

@@ -77,7 +77,7 @@ CLASS zcl_abapgit_object_pdxx_super IMPLEMENTATION.
         enqueue_failed      = 1
         object_not_deleted  = 2
         object_not_found    = 3
-        OTHERS              = 4.       "#EC SUBRC_OK
+        OTHERS              = 4 ##FM_SUBRC_OK.
 
     check_subrc_for( `RH_HRSOBJECT_DELETE` ).
 

src/objects/zcl_abapgit_object_scp1.clas.abap

@@ -486,7 +486,8 @@ CLASS zcl_abapgit_object_scp1 IMPLEMENTATION.
       TABLES
         texts         = ls_scp1-scprtext
       EXCEPTIONS
-        no_text_found = 1.
+        no_text_found = 1
+        OTHERS        = 2 ##FM_SUBRC_OK.
 
     IF ls_scp1-scprattr-type = 'TMP'.
       load_hier( CHANGING cs_scp1 = ls_scp1 ).

src/objects/zcl_abapgit_object_sfpf.clas.abap

@@ -134,7 +134,7 @@ CLASS zcl_abapgit_object_sfpf IMPLEMENTATION.
 
     TRY.
         rv_xstr = cl_fp_helper=>convert_form_to_xstring( li_fp_form ).
-      CATCH cx_fp_api INTO lx_fp_conv_err.
+      CATCH cx_fp_api INTO lx_fp_conv_err ##NO_HANDLER.
         " Pass - the exception is handled below!
     ENDTRY.
 

src/objects/zcl_abapgit_object_ueno.clas.abap

@@ -569,7 +569,7 @@ CLASS zcl_abapgit_object_ueno IMPLEMENTATION.
           header  = ls_docu-header
           content = ls_docu-content
           itf     = ls_docu-itf
-          pstatus = lv_error_status.
+          pstatus = lv_error_status ##ARG_OK.
 
       CHECK lv_error_status = 'S'. "Success
 

src/objects/zcl_abapgit_object_wdca.clas.abap

@@ -303,7 +303,7 @@ CLASS zcl_abapgit_object_wdca IMPLEMENTATION.
           WHERE config_id   = ls_outline-config_id
             AND config_type = ls_outline-config_type
             AND config_var  = ls_outline-config_var.
-      CATCH zcx_abapgit_exception.
+      CATCH zcx_abapgit_exception ##NO_HANDLER.
         " File not found
     ENDTRY.
 

src/objects/zcl_abapgit_object_xinx.clas.abap

@@ -100,7 +100,7 @@ CLASS zcl_abapgit_object_xinx IMPLEMENTATION.
         suppress_transport = 'X'
       EXCEPTIONS
         no_docu_found      = 1
-        OTHERS             = 2.
+        OTHERS             = 2 ##FM_SUBRC_OK.
 
   ENDMETHOD.
 
@@ -317,6 +317,9 @@ CLASS zcl_abapgit_object_xinx IMPLEMENTATION.
       EXCEPTIONS
         illegal_input = 1
         OTHERS        = 2.
+    IF sy-subrc <> 0.
+      zcx_abapgit_exception=>raise( 'Error reading index' ).
+    ENDIF.
 
     rv_bool = boolc( ls_dd12v IS NOT INITIAL ).
 

src/objects/zcl_abapgit_objects_program.clas.abap

@@ -650,7 +650,7 @@ CLASS zcl_abapgit_objects_program IMPLEMENTATION.
             cancelled         = 2
             name_not_allowed  = 3
             permission_error  = 4
-            OTHERS            = 5.
+            OTHERS            = 5 ##FM_SUBRC_OK.
       CATCH cx_sy_dyn_call_param_not_found.
         CALL FUNCTION 'RPY_PROGRAM_INSERT'
           EXPORTING
@@ -667,7 +667,7 @@ CLASS zcl_abapgit_objects_program IMPLEMENTATION.
             cancelled         = 2
             name_not_allowed  = 3
             permission_error  = 4
-            OTHERS            = 5.
+            OTHERS            = 5 ##FM_SUBRC_OK.
     ENDTRY.
     IF sy-subrc = 3.
 

src/objects/zcl_abapgit_objects_super.clas.abap

@@ -191,7 +191,7 @@ CLASS zcl_abapgit_objects_super IMPLEMENTATION.
             object_not_specified = 3
             permission_failure   = 4
             dialog_needed        = 5
-            OTHERS               = 6.
+            OTHERS               = 6 ##FM_SUBRC_OK.
       CATCH cx_sy_dyn_call_param_not_found.
         TRY.
             " try to force deletion for APPENDs
@@ -207,7 +207,7 @@ CLASS zcl_abapgit_objects_super IMPLEMENTATION.
                 object_not_specified = 3
                 permission_failure   = 4
                 dialog_needed        = 5
-                OTHERS               = 6.
+                OTHERS               = 6 ##FM_SUBRC_OK.
           CATCH cx_sy_dyn_call_param_not_found.
             " no_ask_delete_append and aie_force_deletion not available in lower releases
             CALL FUNCTION 'RS_DD_DELETE_OBJ'
@@ -221,7 +221,7 @@ CLASS zcl_abapgit_objects_super IMPLEMENTATION.
                 object_not_specified = 3
                 permission_failure   = 4
                 dialog_needed        = 5
-                OTHERS               = 6.
+                OTHERS               = 6 ##FM_SUBRC_OK.
         ENDTRY.
     ENDTRY.