From 6f6338bc67eb9d8c4549cee242918badef9354cd Mon Sep 17 00:00:00 2001 From: Jakub Filak Date: Thu, 9 Aug 2018 11:09:43 +0200 Subject: [PATCH] repo: skip missing packages in new repo validation When we try to add a new online repository and we have a repository whose package does not exist in abapGit we get a short dump caused by assert in the method zif_abapgit_sap_package~read_parent of the class zcl_abapgit_sap_pacakge. This commit makes sure we skip such repositories because we believe it does not make sense to prevent us from cloning in these cases. Thank you Petr Benes ! --- src/zcl_abapgit_repo_srv.clas.abap | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/zcl_abapgit_repo_srv.clas.abap b/src/zcl_abapgit_repo_srv.clas.abap index 4c17d2375..0a7c4eeeb 100644 --- a/src/zcl_abapgit_repo_srv.clas.abap +++ b/src/zcl_abapgit_repo_srv.clas.abap @@ -136,6 +136,10 @@ CLASS ZCL_ABAPGIT_REPO_SRV IMPLEMENTATION. lo_repo = get( ls_repo-key ). lo_package = zcl_abapgit_factory=>get_sap_package( ls_repo-package ). + IF lo_package->exists( ) eq ABAP_FALSE. + " Skip dangling repository + CONTINUE. + ENDIF. CLEAR lt_packages. IF lo_repo->get_local_settings( )-ignore_subpackages = abap_false.