SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-04-30 11:46:38 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Refactor status log (#6225)

Browse Source
This commit is contained in:
Marc Bernard 2023-04-17 14:23:18 +02:00 committed by GitHub
parent 22c84b6ea3
commit 7031195b41
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/repo/zcl_abapgit_file_status.clas.locals_imp.abap
View File

@ -137,9 +137,8 @@ CLASS lcl_status_consistency_checks IMPLEMENTATION.
BINARY SEARCH. " Sorted above
IF sy-subrc <> 0 OR <ls_result>-path <> <ls_result_idx>-path. " All paths are same
mi_log->add( iv_msg = |Files for object { <ls_result>-obj_type } {
<ls_result>-obj_name } are not placed in the same folder|
iv_type = 'W' ).
mi_log->add_warning( |Files for object { <ls_result>-obj_type } { <ls_result>-obj_name }|
&& | are not placed in the same folder| ).
ENDIF.
ENDLOOP.
@ -159,13 +158,11 @@ CLASS lcl_status_consistency_checks IMPLEMENTATION.
LOOP AT lt_res_sort ASSIGNING <ls_result> WHERE obj_type <> 'DEVC' AND packmove = abap_false.
IF <ls_result>-filename IS NOT INITIAL AND <ls_result>-filename = ls_file-filename.
mi_log->add( iv_msg = |Multiple files with same filename, { <ls_result>-filename }|
iv_type = 'W' ).
mi_log->add_warning( |Multiple files with same filename, { <ls_result>-filename }| ).
ENDIF.
IF <ls_result>-filename IS INITIAL.
mi_log->add( iv_msg = |Filename is empty for object { <ls_result>-obj_type } { <ls_result>-obj_name }|
iv_type = 'W' ).
mi_log->add_warning( |Filename is empty for object { <ls_result>-obj_type } { <ls_result>-obj_name }| ).
ENDIF.
MOVE-CORRESPONDING <ls_result> TO ls_file.
@ -207,13 +204,10 @@ CLASS lcl_status_consistency_checks IMPLEMENTATION.
ENDIF.
IF li_namespace->exists( lv_namespace ) = abap_false.
mi_log->add(
iv_msg = |Namespace { lv_namespace } does not exist. Pull it first (or create it in transaction SE03)|
iv_type = 'W' ).
mi_log->add_warning( |Namespace { lv_namespace } does not exist.|
&& | Pull it first (or create it in transaction SE03)| ).
ELSEIF li_namespace->is_editable( lv_namespace ) = abap_false.
mi_log->add(
iv_msg = |Namespace { lv_namespace } is not modifiable. Check it in transaction SE03|
iv_type = 'W' ).
mi_log->add_warning( |Namespace { lv_namespace } is not modifiable. Check it in transaction SE03| ).
ENDIF.
ENDLOOP.
@ -271,9 +265,8 @@ CLASS lcl_status_consistency_checks IMPLEMENTATION.
obj_name = <ls_result>-obj_name
BINARY SEARCH. " Sorted since it_result is sorted
IF sy-subrc <> 0.
mi_log->add(
iv_msg = |Changed package assignment for object { <ls_result>-obj_type } { <ls_result>-obj_name }|
iv_type = 'W' ).
mi_log->add_warning( |Changed package assignment for object|
&& | { <ls_result>-obj_type } { <ls_result>-obj_name }| ).
APPEND INITIAL LINE TO lt_move_idx ASSIGNING <ls_result_move>.
<ls_result_move>-obj_type = <ls_result>-obj_type.
<ls_result_move>-obj_name = <ls_result>-obj_name.
@ -304,8 +297,7 @@ CLASS lcl_status_consistency_checks IMPLEMENTATION.
&& |Check your package and folder logic, and either assign { <ls_result>-obj_name } |
&& |to the package hierarchy of { iv_top } or remove package { <ls_result>-obj_name } |
&& |from the repository.|.
mi_log->add( iv_msg = lv_msg
iv_type = 'W' ).
mi_log->add_warning( lv_msg ).
ENDIF.
ENDLOOP.