SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

CTS API: remove unused iv_resolve_task_to_request (#4633)

Browse Source
This commit is contained in:
Lars Hvam 2021-03-13 13:29:05 +01:00 committed by GitHub
parent 72f34f5bdf
commit 70fdc8771e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 27 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/cts/zcl_abapgit_cts_api.clas.abap
View File

@ -10,11 +10,11 @@ CLASS zcl_abapgit_cts_api DEFINITION
zif_abapgit_cts_api.
PROTECTED SECTION.
PRIVATE SECTION.
"! Returns the transport request / task the object is currently locked in
"! @parameter iv_program_id | Program ID
"! @parameter iv_object_type | Object type
"! @parameter iv_object_name | Object name
"! @parameter iv_resolve_task_to_request | Return the transport request number if the object is locked in a task
"! @parameter rv_transport | Transport request / task
"! @raising zcx_abapgit_exception | Object is not locked in a transport
METHODS get_current_transport_for_obj
@ -22,7 +22,6 @@ CLASS zcl_abapgit_cts_api DEFINITION
!iv_program_id TYPE pgmid DEFAULT 'R3TR'
!iv_object_type TYPE trobjtype
!iv_object_name TYPE sobj_name
!iv_resolve_task_to_request TYPE abap_bool DEFAULT abap_true
RETURNING
VALUE(rv_transport) TYPE trkorr
RAISING
@ -31,7 +30,6 @@ CLASS zcl_abapgit_cts_api DEFINITION
"! @parameter iv_program_id | Program ID
"! @parameter iv_object_type | Object type
"! @parameter iv_object_name | Object name
"! @parameter iv_resolve_task_to_request | Return the transport request number if the object is in a task
"! @parameter rv_transport | Transport request / task
"! @raising zcx_abapgit_exception | Object is not locked in a transport
METHODS get_current_transport_from_db
@ -39,7 +37,6 @@ CLASS zcl_abapgit_cts_api DEFINITION
!iv_program_id TYPE pgmid DEFAULT 'R3TR'
!iv_object_type TYPE trobjtype
!iv_object_name TYPE sobj_name
!iv_resolve_task_to_request TYPE abap_bool DEFAULT abap_true
RETURNING
VALUE(rv_transport) TYPE trkorr
RAISING
@ -83,7 +80,7 @@ ENDCLASS.
CLASS zcl_abapgit_cts_api IMPLEMENTATION.
CLASS ZCL_ABAPGIT_CTS_API IMPLEMENTATION.
METHOD get_current_transport_for_obj.
@ -123,27 +120,19 @@ CLASS zcl_abapgit_cts_api IMPLEMENTATION.
zcx_abapgit_exception=>raise( |Object type { iv_program_id }-{ iv_object_type } not lockable| ).
ENDIF.
IF lv_task IS NOT INITIAL AND lv_task <> lv_transport_request AND iv_resolve_task_to_request = abap_false.
rv_transport = lv_task.
ELSE.
rv_transport = lv_transport_request.
ENDIF.
ENDMETHOD.
METHOD get_current_transport_from_db.
DATA lv_strkorr TYPE e070-strkorr.
" This method is used for objects that are included in transports but not locked
" for example, namespaces (NSPC)
SELECT SINGLE a~trkorr a~strkorr FROM e070 AS a JOIN e071 AS b ON a~trkorr = b~trkorr
INTO (rv_transport, lv_strkorr)
SELECT SINGLE a~trkorr FROM e070 AS a JOIN e071 AS b ON a~trkorr = b~trkorr
INTO rv_transport
WHERE ( a~trstatus = 'D' OR a~trstatus = 'L' )
AND b~pgmid = iv_program_id AND b~object = iv_object_type AND b~obj_name = iv_object_name.
IF sy-subrc = 0 AND iv_resolve_task_to_request = abap_true.
rv_transport = lv_strkorr.
ENDIF.
ENDMETHOD.
@ -234,15 +223,13 @@ CLASS zcl_abapgit_cts_api IMPLEMENTATION.
rv_transport = get_current_transport_for_obj(
iv_object_type = is_item-obj_type
iv_object_name = is_item-obj_name
iv_resolve_task_to_request = iv_resolve_task_to_request ).
iv_object_name = is_item-obj_name ).
ELSEIF is_object_type_transportable( is_item-obj_type ) = abap_true.
rv_transport = get_current_transport_from_db(
iv_object_type = is_item-obj_type
iv_object_name = is_item-obj_name
iv_resolve_task_to_request = iv_resolve_task_to_request ).
iv_object_name = is_item-obj_name ).
ENDIF.

2
src/cts/zif_abapgit_cts_api.intf.abap
View File

@ -4,13 +4,11 @@ INTERFACE zif_abapgit_cts_api
"! Returns the transport request / task the object is currently in
"! @parameter is_item | Object
"! @parameter iv_resolve_task_to_request | Return the transport request number
"! @parameter rv_transport | Transport request / task
"! @raising zcx_abapgit_exception | Object is not in a transport
METHODS get_transport_for_object
IMPORTING
!is_item TYPE zif_abapgit_definitions=>ty_item
!iv_resolve_task_to_request TYPE abap_bool DEFAULT abap_false
RETURNING
VALUE(rv_transport) TYPE trkorr
RAISING

26
src/ui/zcl_abapgit_gui_page_stage.clas.abap
View File

@ -139,7 +139,7 @@ ENDCLASS.
CLASS zcl_abapgit_gui_page_stage IMPLEMENTATION.
CLASS ZCL_ABAPGIT_GUI_PAGE_STAGE IMPLEMENTATION.
METHOD build_menu.
@ -348,9 +348,7 @@ CLASS zcl_abapgit_gui_page_stage IMPLEMENTATION.
CLEAR ls_new.
ls_new-item = <ls_local>-item.
ls_new-transport = li_cts_api->get_transport_for_object(
is_item = <ls_local>-item
iv_resolve_task_to_request = abap_false ).
ls_new-transport = li_cts_api->get_transport_for_object( <ls_local>-item ).
IF ls_new-transport IS NOT INITIAL.
INSERT ls_new INTO TABLE ct_transports.
@ -389,9 +387,7 @@ CLASS zcl_abapgit_gui_page_stage IMPLEMENTATION.
CONTINUE.
ELSE.
ls_new-item = ls_item.
ls_new-transport = li_cts_api->get_transport_for_object(
is_item = ls_item
iv_resolve_task_to_request = abap_false ).
ls_new-transport = li_cts_api->get_transport_for_object( ls_item ).
IF ls_new-transport IS NOT INITIAL.
INSERT ls_new INTO TABLE ct_transports.
@ -425,6 +421,14 @@ CLASS zcl_abapgit_gui_page_stage IMPLEMENTATION.
ENDMETHOD.
METHOD init_files.
ms_files = zcl_abapgit_factory=>get_stage_logic( )->get( mo_repo ).
IF lines( ms_files-local ) = 0 AND lines( ms_files-remote ) = 0.
zcx_abapgit_exception=>raise( 'There are no changes that could be staged' ).
ENDIF.
ENDMETHOD.
METHOD render_actions.
DATA: lv_local_count TYPE i,
@ -905,12 +909,4 @@ CLASS zcl_abapgit_gui_page_stage IMPLEMENTATION.
INSERT ls_hotkey_action INTO TABLE rt_hotkey_actions.
ENDMETHOD.
METHOD init_files.
ms_files = zcl_abapgit_factory=>get_stage_logic( )->get( mo_repo ).
IF lines( ms_files-local ) = 0 AND lines( ms_files-remote ) = 0.
zcx_abapgit_exception=>raise( 'There are no changes that could be staged' ).
ENDIF.
ENDMETHOD.
ENDCLASS.