From 714fe7202dbd225433a42dfe08f66753e6f5005b Mon Sep 17 00:00:00 2001 From: Lars Hvam Date: Fri, 11 Oct 2019 02:50:16 -0700 Subject: [PATCH] whitespace fixes (#2964) * whitespace fixes * fix sql compare operators --- src/git/zcl_abapgit_git_porcelain.clas.abap | 2 +- .../zcl_abapgit_ecatt_script_downl.clas.abap | 5 ++--- src/objects/zcl_abapgit_longtexts.clas.abap | 6 +++--- src/objects/zcl_abapgit_object_clas.clas.abap | 9 +++------ src/objects/zcl_abapgit_object_devc.clas.abap | 6 +++--- src/objects/zcl_abapgit_object_doma.clas.abap | 2 +- src/objects/zcl_abapgit_object_dtel.clas.abap | 2 +- src/objects/zcl_abapgit_object_fugr.clas.abap | 4 ++-- src/objects/zcl_abapgit_object_intf.clas.abap | 2 +- src/objects/zcl_abapgit_object_msag.clas.abap | 10 +++++----- src/objects/zcl_abapgit_object_pers.clas.abap | 2 +- src/objects/zcl_abapgit_object_pinf.clas.abap | 2 +- src/objects/zcl_abapgit_object_prog.clas.abap | 12 ++++++------ src/objects/zcl_abapgit_object_sfsw.clas.abap | 10 +++++----- src/objects/zcl_abapgit_object_sots.clas.abap | 8 ++++---- src/objects/zcl_abapgit_object_sprx.clas.abap | 10 +++++----- src/objects/zcl_abapgit_object_tran.clas.abap | 15 ++++++--------- src/objects/zcl_abapgit_object_udmo.clas.abap | 6 +++--- src/objects/zcl_abapgit_object_ueno.clas.abap | 10 +++++----- src/objects/zcl_abapgit_object_w3super.clas.abap | 12 ++++++------ src/objects/zcl_abapgit_objects_generic.clas.abap | 2 +- src/persist/zcl_abapgit_persistence_db.clas.abap | 2 +- src/ui/zcl_abapgit_gui_chunk_lib.clas.abap | 4 ++-- src/ui/zcl_abapgit_gui_page.clas.abap | 4 ++-- src/ui/zcl_abapgit_gui_page_code_insp.clas.abap | 2 +- src/ui/zcl_abapgit_gui_page_diff.clas.abap | 9 ++++----- src/ui/zcl_abapgit_gui_page_settings.clas.abap | 7 +++---- src/ui/zcl_abapgit_gui_view_repo.clas.abap | 3 +-- src/ui/zcl_abapgit_services_repo.clas.abap | 2 +- .../zcl_abapgit_xml_output.clas.testclasses.abap | 2 +- src/zcl_abapgit_dependencies.clas.abap | 2 +- src/zcl_abapgit_repo.clas.abap | 4 ++-- src/zcl_abapgit_repo_content_list.clas.abap | 2 +- src/zcl_abapgit_repo_online.clas.abap | 4 ++-- src/zcl_abapgit_stage.clas.abap | 3 +-- 35 files changed, 88 insertions(+), 99 deletions(-) diff --git a/src/git/zcl_abapgit_git_porcelain.clas.abap b/src/git/zcl_abapgit_git_porcelain.clas.abap index df193b79a..b43c2df6e 100644 --- a/src/git/zcl_abapgit_git_porcelain.clas.abap +++ b/src/git/zcl_abapgit_git_porcelain.clas.abap @@ -484,7 +484,7 @@ CLASS ZCL_ABAPGIT_GIT_PORCELAIN IMPLEMENTATION. WHEN zcl_abapgit_stage=>c_method-rm. DELETE lt_expanded WHERE name = -file-filename - AND path = -file-path. + AND path = -file-path. ASSERT sy-subrc = 0. CLEAR -sha1. " Mark as deleted diff --git a/src/objects/ecatt/zcl_abapgit_ecatt_script_downl.clas.abap b/src/objects/ecatt/zcl_abapgit_ecatt_script_downl.clas.abap index e45eb834c..4a9879a21 100644 --- a/src/objects/ecatt/zcl_abapgit_ecatt_script_downl.clas.abap +++ b/src/objects/ecatt/zcl_abapgit_ecatt_script_downl.clas.abap @@ -98,7 +98,7 @@ CLASS ZCL_ABAPGIT_ECATT_SCRIPT_DOWNL IMPLEMENTATION. set_deep_stru_to_dom( ecatt_script->params ). set_deep_data_to_dom( ecatt_script->params ). IF wa_parm-xmlref_typ = cl_apl_ecatt_const=>ref_type_c_tcd. - set_control_data_for_tcd( is_param = wa_parm + set_control_data_for_tcd( is_param = wa_parm io_params = ecatt_script->params ). ENDIF. @@ -272,8 +272,7 @@ CLASS ZCL_ABAPGIT_ECATT_SCRIPT_DOWNL IMPLEMENTATION. FIELD-SYMBOLS: TYPE STANDARD TABLE. - IF is_param-xmlref_typ <> cl_apl_ecatt_const=>ref_type_c_tcd - OR io_params IS INITIAL. + IF is_param-xmlref_typ <> cl_apl_ecatt_const=>ref_type_c_tcd OR io_params IS INITIAL. RETURN. ENDIF. diff --git a/src/objects/zcl_abapgit_longtexts.clas.abap b/src/objects/zcl_abapgit_longtexts.clas.abap index 76aa469a3..12d221f95 100644 --- a/src/objects/zcl_abapgit_longtexts.clas.abap +++ b/src/objects/zcl_abapgit_longtexts.clas.abap @@ -54,9 +54,9 @@ CLASS ZCL_ABAPGIT_LONGTEXTS IMPLEMENTATION. FIELD-SYMBOLS: TYPE dokil. SELECT * FROM dokil - INTO TABLE lt_dokil - WHERE id = iv_longtext_id - AND object = iv_longtext_id. + INTO TABLE lt_dokil + WHERE id = iv_longtext_id + AND object = iv_longtext_id. LOOP AT lt_dokil ASSIGNING . diff --git a/src/objects/zcl_abapgit_object_clas.clas.abap b/src/objects/zcl_abapgit_object_clas.clas.abap index 362e85b32..a07ba381f 100644 --- a/src/objects/zcl_abapgit_object_clas.clas.abap +++ b/src/objects/zcl_abapgit_object_clas.clas.abap @@ -246,7 +246,7 @@ CLASS ZCL_ABAPGIT_OBJECT_CLAS IMPLEMENTATION. ig_data = add_tpool( lt_tpool ) ). IF ls_vseoclass-category = seoc_category_exception. - lt_sotr = mi_object_oriented_object_fct->read_sotr( ms_item-obj_name ). + lt_sotr = mi_object_oriented_object_fct->read_sotr( ms_item-obj_name ). IF lines( lt_sotr ) > 0. io_xml->add( iv_name = 'SOTR' ig_data = lt_sotr ). @@ -299,7 +299,7 @@ CLASS ZCL_ABAPGIT_OBJECT_CLAS IMPLEMENTATION. INTO TABLE lt_reposrc FOR ALL ENTRIES IN lt_includes WHERE progname = lt_includes-programm - AND r3state = 'A'. + AND r3state = 'A'. IF sy-subrc <> 0. rv_user = c_user_unknown. ELSE. @@ -367,11 +367,8 @@ CLASS ZCL_ABAPGIT_OBJECT_CLAS IMPLEMENTATION. lv_classpool = cl_oo_classname_service=>get_classpool_name( |{ ms_item-obj_name }| ). - IF is_class_locked( ) = abap_true - OR is_text_locked( lv_classpool ) = abap_true. - + IF is_class_locked( ) = abap_true OR is_text_locked( lv_classpool ) = abap_true. rv_is_locked = abap_true. - ENDIF. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_devc.clas.abap b/src/objects/zcl_abapgit_object_devc.clas.abap index 599a2e8d0..d5f1b3ed5 100644 --- a/src/objects/zcl_abapgit_object_devc.clas.abap +++ b/src/objects/zcl_abapgit_object_devc.clas.abap @@ -72,9 +72,9 @@ CLASS ZCL_ABAPGIT_OBJECT_DEVC IMPLEMENTATION. SELECT SINGLE obj_name FROM tadir INTO lv_object_name - WHERE pgmid = 'R3TR' - AND NOT ( object = 'DEVC' AND obj_name = iv_package_name ) - AND devclass = iv_package_name. + WHERE pgmid = 'R3TR' + AND NOT ( object = 'DEVC' AND obj_name = iv_package_name ) + AND devclass = iv_package_name. rv_is_empty = boolc( sy-subrc <> 0 ). ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_doma.clas.abap b/src/objects/zcl_abapgit_object_doma.clas.abap index 831caa536..647fd95e8 100644 --- a/src/objects/zcl_abapgit_object_doma.clas.abap +++ b/src/objects/zcl_abapgit_object_doma.clas.abap @@ -135,7 +135,7 @@ CLASS ZCL_ABAPGIT_OBJECT_DOMA IMPLEMENTATION. SELECT DISTINCT ddlanguage AS langu INTO TABLE lt_i18n_langs FROM dd01v WHERE domname = lv_name - AND ddlanguage <> mv_language. "#EC CI_SUBRC + AND ddlanguage <> mv_language. "#EC CI_SUBRC LOOP AT lt_i18n_langs ASSIGNING . lv_index = sy-tabix. diff --git a/src/objects/zcl_abapgit_object_dtel.clas.abap b/src/objects/zcl_abapgit_object_dtel.clas.abap index e83c57fbf..e4fda8cd4 100644 --- a/src/objects/zcl_abapgit_object_dtel.clas.abap +++ b/src/objects/zcl_abapgit_object_dtel.clas.abap @@ -105,7 +105,7 @@ CLASS ZCL_ABAPGIT_OBJECT_DTEL IMPLEMENTATION. SELECT DISTINCT ddlanguage AS langu INTO TABLE lt_i18n_langs FROM dd04v WHERE rollname = lv_name - AND ddlanguage <> mv_language. "#EC CI_SUBRC + AND ddlanguage <> mv_language. "#EC CI_SUBRC LOOP AT lt_i18n_langs ASSIGNING . lv_index = sy-tabix. diff --git a/src/objects/zcl_abapgit_object_fugr.clas.abap b/src/objects/zcl_abapgit_object_fugr.clas.abap index 9586e9495..d2b3b874c 100644 --- a/src/objects/zcl_abapgit_object_fugr.clas.abap +++ b/src/objects/zcl_abapgit_object_fugr.clas.abap @@ -806,8 +806,8 @@ CLASS ZCL_ABAPGIT_OBJECT_FUGR IMPLEMENTATION. INTO CORRESPONDING FIELDS OF TABLE lt_tpool_i18n FROM d010tinf WHERE r3state = 'A' - AND prog = iv_prog_name - AND language <> mv_language. + AND prog = iv_prog_name + AND language <> mv_language. SORT lt_tpool_i18n BY language ASCENDING. LOOP AT lt_tpool_i18n ASSIGNING . diff --git a/src/objects/zcl_abapgit_object_intf.clas.abap b/src/objects/zcl_abapgit_object_intf.clas.abap index 2f04fd808..5f301dfcc 100644 --- a/src/objects/zcl_abapgit_object_intf.clas.abap +++ b/src/objects/zcl_abapgit_object_intf.clas.abap @@ -198,7 +198,7 @@ CLASS ZCL_ABAPGIT_OBJECT_INTF IMPLEMENTATION. INTO TABLE lt_reposrc FOR ALL ENTRIES IN lt_includes WHERE progname = lt_includes-programm - AND r3state = 'A'. + AND r3state = 'A'. IF sy-subrc <> 0. rv_user = c_user_unknown. ELSE. diff --git a/src/objects/zcl_abapgit_object_msag.clas.abap b/src/objects/zcl_abapgit_object_msag.clas.abap index ccdf952d8..aa4183a5d 100644 --- a/src/objects/zcl_abapgit_object_msag.clas.abap +++ b/src/objects/zcl_abapgit_object_msag.clas.abap @@ -180,10 +180,10 @@ CLASS ZCL_ABAPGIT_OBJECT_MSAG IMPLEMENTATION. ENDLOOP. SELECT * FROM dokil - INTO TABLE lt_dokil - FOR ALL ENTRIES IN lt_objects - WHERE id = 'NA' - AND object = lt_objects-table_line. + INTO TABLE lt_dokil + FOR ALL ENTRIES IN lt_objects + WHERE id = 'NA' + AND object = lt_objects-table_line. CLEAR ls_dokil-dokstate. MODIFY lt_dokil FROM ls_dokil TRANSPORTING dokstate WHERE dokstate IS NOT INITIAL. @@ -214,7 +214,7 @@ CLASS ZCL_ABAPGIT_OBJECT_MSAG IMPLEMENTATION. SELECT DISTINCT sprsl AS langu INTO TABLE lt_i18n_langs FROM t100t WHERE arbgb = lv_msg_id - AND sprsl <> mv_language. "#EC CI_BYPASS "#EC CI_GENBUFF. + AND sprsl <> mv_language. "#EC CI_BYPASS "#EC CI_GENBUFF SORT lt_i18n_langs ASCENDING. diff --git a/src/objects/zcl_abapgit_object_pers.clas.abap b/src/objects/zcl_abapgit_object_pers.clas.abap index 3c22d88ee..b26098f1d 100644 --- a/src/objects/zcl_abapgit_object_pers.clas.abap +++ b/src/objects/zcl_abapgit_object_pers.clas.abap @@ -91,7 +91,7 @@ CLASS zcl_abapgit_object_pers IMPLEMENTATION. lo_personalization_object->set_reg_data( p_pers_reg = ls_personalization_object-pers_reg - p_pers_reg_text = ls_personalization_object-pers_reg_text ). + p_pers_reg_text = ls_personalization_object-pers_reg_text ). lo_personalization_object->save( EXPORTING diff --git a/src/objects/zcl_abapgit_object_pinf.clas.abap b/src/objects/zcl_abapgit_object_pinf.clas.abap index d5fc4f709..15ac9d854 100644 --- a/src/objects/zcl_abapgit_object_pinf.clas.abap +++ b/src/objects/zcl_abapgit_object_pinf.clas.abap @@ -313,7 +313,7 @@ CLASS ZCL_ABAPGIT_OBJECT_PINF IMPLEMENTATION. DATA: lv_argument TYPE eqegraarg. lv_argument = |PF{ ms_item-obj_name }|. - OVERLAY lv_argument WITH ' *'. + OVERLAY lv_argument WITH ' *'. rv_is_locked = exists_a_lock_entry_for( iv_lock_object = 'EEUDB' iv_argument = lv_argument ). diff --git a/src/objects/zcl_abapgit_object_prog.clas.abap b/src/objects/zcl_abapgit_object_prog.clas.abap index 059d83276..9f8a95278 100644 --- a/src/objects/zcl_abapgit_object_prog.clas.abap +++ b/src/objects/zcl_abapgit_object_prog.clas.abap @@ -80,8 +80,8 @@ CLASS ZCL_ABAPGIT_OBJECT_PROG IMPLEMENTATION. INTO CORRESPONDING FIELDS OF TABLE lt_tpool_i18n FROM d010tinf WHERE r3state = 'A' - AND prog = ms_item-obj_name - AND language <> mv_language. + AND prog = ms_item-obj_name + AND language <> mv_language. SORT lt_tpool_i18n BY language ASCENDING. LOOP AT lt_tpool_i18n ASSIGNING . @@ -216,10 +216,10 @@ CLASS ZCL_ABAPGIT_OBJECT_PROG IMPLEMENTATION. METHOD zif_abapgit_object~is_locked. - IF is_program_locked( ) = abap_true - OR is_any_dynpro_locked( ms_item-obj_name ) = abap_true - OR is_cua_locked( ms_item-obj_name ) = abap_true - OR is_text_locked( ms_item-obj_name ) = abap_true. + IF is_program_locked( ) = abap_true + OR is_any_dynpro_locked( ms_item-obj_name ) = abap_true + OR is_cua_locked( ms_item-obj_name ) = abap_true + OR is_text_locked( ms_item-obj_name ) = abap_true. rv_is_locked = abap_true. diff --git a/src/objects/zcl_abapgit_object_sfsw.clas.abap b/src/objects/zcl_abapgit_object_sfsw.clas.abap index 4ecc797e6..2007bd385 100644 --- a/src/objects/zcl_abapgit_object_sfsw.clas.abap +++ b/src/objects/zcl_abapgit_object_sfsw.clas.abap @@ -47,11 +47,11 @@ CLASS ZCL_ABAPGIT_OBJECT_SFSW IMPLEMENTATION. DO 5 TIMES. SELECT SINGLE jobcount - FROM tbtco - INTO lv_job_count - WHERE jobname = 'SFW_DELETE_SWITCH' - AND status = 'R' - AND sdluname = sy-uname. + FROM tbtco + INTO lv_job_count + WHERE jobname = 'SFW_DELETE_SWITCH' + AND status = 'R' + AND sdluname = sy-uname. IF sy-subrc = 0. WAIT UP TO 1 SECONDS. diff --git a/src/objects/zcl_abapgit_object_sots.clas.abap b/src/objects/zcl_abapgit_object_sots.clas.abap index de5331359..15cf2fd47 100644 --- a/src/objects/zcl_abapgit_object_sots.clas.abap +++ b/src/objects/zcl_abapgit_object_sots.clas.abap @@ -68,10 +68,10 @@ CLASS ZCL_ABAPGIT_OBJECT_SOTS IMPLEMENTATION. PERFORM btfr_create IN PROGRAM saplsotr_db_string - USING iv_object - lv_source_langu - lv_flag_correction_entry - lv_flag_is_string + USING iv_object + lv_source_langu + lv_flag_correction_entry + lv_flag_is_string CHANGING lv_text_tab lt_entries ls_header diff --git a/src/objects/zcl_abapgit_object_sprx.clas.abap b/src/objects/zcl_abapgit_object_sprx.clas.abap index c052f7d73..4d1097948 100644 --- a/src/objects/zcl_abapgit_object_sprx.clas.abap +++ b/src/objects/zcl_abapgit_object_sprx.clas.abap @@ -217,11 +217,11 @@ CLASS ZCL_ABAPGIT_OBJECT_SPRX IMPLEMENTATION. rv_user = c_user_unknown. SELECT SINGLE changed_by - FROM sproxhdr - INTO lv_changed_by - WHERE object = mv_object - AND obj_name = mv_obj_name - AND inactive = abap_false. + FROM sproxhdr + INTO lv_changed_by + WHERE object = mv_object + AND obj_name = mv_obj_name + AND inactive = abap_false. IF sy-subrc = 0 AND lv_changed_by IS NOT INITIAL. rv_user = lv_changed_by. diff --git a/src/objects/zcl_abapgit_object_tran.clas.abap b/src/objects/zcl_abapgit_object_tran.clas.abap index a06da1f79..cc65bec16 100644 --- a/src/objects/zcl_abapgit_object_tran.clas.abap +++ b/src/objects/zcl_abapgit_object_tran.clas.abap @@ -117,16 +117,13 @@ CLASS ZCL_ABAPGIT_OBJECT_TRAN IMPLEMENTATION. zcx_abapgit_exception=>raise( |Error deserializing { ms_item-obj_type } { ms_item-obj_name }| ). ENDIF. - LOOP AT lt_message ASSIGNING - WHERE msgtyp CA 'EAX'. - - MESSAGE ID -msgid - TYPE -msgtyp - NUMBER -msgnr - WITH -msgv1 -msgv2 -msgv3 -msgv4 - INTO sy-msgli. + LOOP AT lt_message ASSIGNING WHERE msgtyp CA 'EAX'. + MESSAGE ID -msgid + TYPE -msgtyp + NUMBER -msgnr + WITH -msgv1 -msgv2 -msgv3 -msgv4 + INTO sy-msgli. zcx_abapgit_exception=>raise_t100( ). - ENDLOOP. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_udmo.clas.abap b/src/objects/zcl_abapgit_object_udmo.clas.abap index 5fac62dc4..e6c710abb 100644 --- a/src/objects/zcl_abapgit_object_udmo.clas.abap +++ b/src/objects/zcl_abapgit_object_udmo.clas.abap @@ -581,9 +581,9 @@ CLASS ZCL_ABAPGIT_OBJECT_UDMO IMPLEMENTATION. METHOD zif_abapgit_object~changed_by. SELECT SINGLE lstuser INTO rv_user - FROM dm40l - WHERE dmoid = me->mv_data_model - AND as4local = me->mv_activation_state. + FROM dm40l + WHERE dmoid = me->mv_data_model + AND as4local = me->mv_activation_state. IF sy-subrc <> 0. rv_user = c_user_unknown. diff --git a/src/objects/zcl_abapgit_object_ueno.clas.abap b/src/objects/zcl_abapgit_object_ueno.clas.abap index f95995a5f..ed673d7e6 100644 --- a/src/objects/zcl_abapgit_object_ueno.clas.abap +++ b/src/objects/zcl_abapgit_object_ueno.clas.abap @@ -142,7 +142,7 @@ CLASS zcl_abapgit_object_ueno IMPLEMENTATION. SELECT * FROM dm02l INTO TABLE lt_dm02l - WHERE entid EQ me->mv_entity_id. + WHERE entid = me->mv_entity_id. LOOP AT lt_dm02l INTO ls_dm02l. @@ -188,7 +188,7 @@ CLASS zcl_abapgit_object_ueno IMPLEMENTATION. SELECT * FROM dm42s INTO TABLE lt_dm42s - WHERE entidto EQ me->mv_entity_id. + WHERE entidto = me->mv_entity_id. LOOP AT lt_dm42s INTO ls_dm42s. @@ -238,7 +238,7 @@ CLASS zcl_abapgit_object_ueno IMPLEMENTATION. SELECT * FROM dm45l INTO TABLE lt_dm45l - WHERE entid EQ me->ms_item-obj_name. + WHERE entid = me->ms_item-obj_name. LOOP AT lt_dm45l INTO ls_dm45l. @@ -480,8 +480,8 @@ CLASS zcl_abapgit_object_ueno IMPLEMENTATION. SELECT SINGLE lstuser INTO rv_user FROM dm02l - WHERE entid EQ me->mv_entity_id - AND as4local EQ c_active_state. + WHERE entid = me->mv_entity_id + AND as4local = c_active_state. IF sy-subrc <> 0. rv_user = c_user_unknown. diff --git a/src/objects/zcl_abapgit_object_w3super.clas.abap b/src/objects/zcl_abapgit_object_w3super.clas.abap index 6d1e99fb6..0151c3291 100644 --- a/src/objects/zcl_abapgit_object_w3super.clas.abap +++ b/src/objects/zcl_abapgit_object_w3super.clas.abap @@ -140,8 +140,8 @@ CLASS ZCL_ABAPGIT_OBJECT_W3SUPER IMPLEMENTATION. SELECT SINGLE chname INTO rv_user FROM wwwdata WHERE relid = ms_key-relid - AND objid = ms_key-objid - AND srtf2 = 0. + AND objid = ms_key-objid + AND srtf2 = 0. IF sy-subrc IS NOT INITIAL OR rv_user IS INITIAL. rv_user = c_user_unknown. @@ -323,8 +323,8 @@ CLASS ZCL_ABAPGIT_OBJECT_W3SUPER IMPLEMENTATION. SELECT SINGLE objid INTO ms_key-objid FROM wwwdata WHERE relid = ms_key-relid - AND objid = ms_key-objid - AND srtf2 = 0. + AND objid = ms_key-objid + AND srtf2 = 0. IF sy-subrc IS NOT INITIAL. RETURN. @@ -431,8 +431,8 @@ CLASS ZCL_ABAPGIT_OBJECT_W3SUPER IMPLEMENTATION. SELECT SINGLE * INTO CORRESPONDING FIELDS OF ms_key FROM wwwdata WHERE relid = ms_key-relid - AND objid = ms_key-objid - AND srtf2 = 0. + AND objid = ms_key-objid + AND srtf2 = 0. IF sy-subrc IS NOT INITIAL. RETURN. diff --git a/src/objects/zcl_abapgit_objects_generic.clas.abap b/src/objects/zcl_abapgit_objects_generic.clas.abap index 7db18a499..ecc408232 100644 --- a/src/objects/zcl_abapgit_objects_generic.clas.abap +++ b/src/objects/zcl_abapgit_objects_generic.clas.abap @@ -205,7 +205,7 @@ CLASS ZCL_ABAPGIT_OBJECTS_GENERIC IMPLEMENTATION. * object methods SELECT * FROM objm INTO TABLE mt_object_method WHERE objectname = is_item-obj_type - AND objecttype = lc_logical_transport_object + AND objecttype = lc_logical_transport_object ORDER BY PRIMARY KEY. ms_item = is_item. diff --git a/src/persist/zcl_abapgit_persistence_db.clas.abap b/src/persist/zcl_abapgit_persistence_db.clas.abap index 8bf9fc023..eb9c15924 100644 --- a/src/persist/zcl_abapgit_persistence_db.clas.abap +++ b/src/persist/zcl_abapgit_persistence_db.clas.abap @@ -226,7 +226,7 @@ CLASS ZCL_ABAPGIT_PERSISTENCE_DB IMPLEMENTATION. UPDATE (c_tabname) SET data_str = lv_data WHERE type = iv_type - AND value = iv_value. + AND value = iv_value. IF sy-subrc <> 0. zcx_abapgit_exception=>raise( 'DB update failed' ). ENDIF. diff --git a/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap b/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap index ae6922ae7..6811efeca 100644 --- a/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap +++ b/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap @@ -147,8 +147,8 @@ CLASS zcl_abapgit_gui_chunk_lib IMPLEMENTATION. FROM t100 INTO rv_text WHERE arbgb = iv_msgid - AND msgnr = iv_msgno - AND sprsl = sy-langu. + AND msgnr = iv_msgno + AND sprsl = sy-langu. ENDMETHOD. diff --git a/src/ui/zcl_abapgit_gui_page.clas.abap b/src/ui/zcl_abapgit_gui_page.clas.abap index 4be798093..d5c2646f6 100644 --- a/src/ui/zcl_abapgit_gui_page.clas.abap +++ b/src/ui/zcl_abapgit_gui_page.clas.abap @@ -446,14 +446,14 @@ CLASS zcl_abapgit_gui_page IMPLEMENTATION. call_browser( iv_getdata ). ev_state = zcl_abapgit_gui=>c_event_state-no_more_act. - WHEN zif_abapgit_definitions=>c_action-goto_source. + WHEN zif_abapgit_definitions=>c_action-goto_source. IF mo_exception_viewer IS BOUND. mo_exception_viewer->goto_source( ). ENDIF. ev_state = zcl_abapgit_gui=>c_event_state-no_more_act. - WHEN zif_abapgit_definitions=>c_action-show_callstack. + WHEN zif_abapgit_definitions=>c_action-show_callstack. IF mo_exception_viewer IS BOUND. mo_exception_viewer->show_callstack( ). diff --git a/src/ui/zcl_abapgit_gui_page_code_insp.clas.abap b/src/ui/zcl_abapgit_gui_page_code_insp.clas.abap index 8d366a02f..18f33aad8 100644 --- a/src/ui/zcl_abapgit_gui_page_code_insp.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_code_insp.clas.abap @@ -177,7 +177,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_CODE_INSP IMPLEMENTATION. METHOD is_stage_allowed. - rv_is_stage_allowed = boolc( NOT ( mo_repo->get_local_settings( )-block_commit = abap_true + rv_is_stage_allowed = boolc( NOT ( mo_repo->get_local_settings( )-block_commit = abap_true AND has_inspection_errors( ) = abap_true ) ). ENDMETHOD. diff --git a/src/ui/zcl_abapgit_gui_page_diff.clas.abap b/src/ui/zcl_abapgit_gui_page_diff.clas.abap index 4715721b0..d95871b3f 100644 --- a/src/ui/zcl_abapgit_gui_page_diff.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_diff.clas.abap @@ -210,8 +210,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DIFF IMPLEMENTATION. lv_patch = lo_git_add_patch->get_patch_binary( ). - IF -lstate = 'D' - AND are_all_lines_patched( lt_diff ) = abap_true. + IF -lstate = 'D' AND are_all_lines_patched( lt_diff ) = abap_true. mo_stage->rm( iv_path = -path @@ -370,7 +369,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DIFF IMPLEMENTATION. WHEN zif_abapgit_definitions=>c_diff-delete. - lv_line = ls_diff_line-old_num. + lv_line = ls_diff_line-old_num. lo_diff->set_patch_old( iv_line_old = lv_line iv_patch_flag = iv_patch_flag ). @@ -447,8 +446,8 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DIFF IMPLEMENTATION. LOOP AT lt_status ASSIGNING WHERE obj_type = is_object-obj_type - AND obj_name = is_object-obj_name - AND match IS INITIAL. + AND obj_name = is_object-obj_name + AND match IS INITIAL. append_diff( it_remote = lt_remote it_local = lt_local is_status = ). diff --git a/src/ui/zcl_abapgit_gui_page_settings.clas.abap b/src/ui/zcl_abapgit_gui_page_settings.clas.abap index b027167be..a780b5392 100644 --- a/src/ui/zcl_abapgit_gui_page_settings.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_settings.clas.abap @@ -329,8 +329,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_SETTINGS IMPLEMENTATION. ENDCASE. ENDLOOP. - DELETE lt_key_bindings WHERE hotkey IS INITIAL - OR action IS INITIAL. + DELETE lt_key_bindings WHERE hotkey IS INITIAL OR action IS INITIAL. mo_settings->set_hotkeys( lt_key_bindings ). @@ -755,8 +754,8 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_SETTINGS IMPLEMENTATION. METHOD validate_settings. - IF ( mo_settings->get_proxy_url( ) IS NOT INITIAL AND mo_settings->get_proxy_port( ) IS INITIAL ) OR - ( mo_settings->get_proxy_url( ) IS INITIAL AND mo_settings->get_proxy_port( ) IS NOT INITIAL ). + IF ( mo_settings->get_proxy_url( ) IS NOT INITIAL AND mo_settings->get_proxy_port( ) IS INITIAL ) OR + ( mo_settings->get_proxy_url( ) IS INITIAL AND mo_settings->get_proxy_port( ) IS NOT INITIAL ). MESSAGE 'If specifying proxy, specify both URL and port' TYPE 'W'. ENDIF. diff --git a/src/ui/zcl_abapgit_gui_view_repo.clas.abap b/src/ui/zcl_abapgit_gui_view_repo.clas.abap index f1cef9875..36983c381 100644 --- a/src/ui/zcl_abapgit_gui_view_repo.clas.abap +++ b/src/ui/zcl_abapgit_gui_view_repo.clas.abap @@ -1004,8 +1004,7 @@ CLASS zcl_abapgit_gui_view_repo IMPLEMENTATION. " so we isolate them and and sort only the code artifacts LOOP AT ct_repo_items ASSIGNING . - IF -obj_type IS INITIAL - AND -is_dir = abap_false. + IF -obj_type IS INITIAL AND -is_dir = abap_false. INSERT INTO TABLE lt_non_code_and_metadata_items. ELSE. INSERT INTO TABLE lt_code_items. diff --git a/src/ui/zcl_abapgit_services_repo.clas.abap b/src/ui/zcl_abapgit_services_repo.clas.abap index ea1087cb1..3fc0e379a 100644 --- a/src/ui/zcl_abapgit_services_repo.clas.abap +++ b/src/ui/zcl_abapgit_services_repo.clas.abap @@ -353,7 +353,7 @@ CLASS ZCL_ABAPGIT_SERVICES_REPO IMPLEMENTATION. lo_repo = zcl_abapgit_repo_srv=>get_instance( )->get( iv_key ). - lv_question = 'This will rebuild and overwrite local repo checksums.'. + lv_question = 'This will rebuild and overwrite local repo checksums.'. IF lo_repo->is_offline( ) = abap_false. lv_question = lv_question diff --git a/src/xml/zcl_abapgit_xml_output.clas.testclasses.abap b/src/xml/zcl_abapgit_xml_output.clas.testclasses.abap index fd6036643..1a52fdeef 100644 --- a/src/xml/zcl_abapgit_xml_output.clas.testclasses.abap +++ b/src/xml/zcl_abapgit_xml_output.clas.testclasses.abap @@ -1,7 +1,7 @@ CLASS ltcl_xml_output DEFINITION DEFERRED. CLASS zcl_abapgit_xml_output DEFINITION LOCAL FRIENDS ltcl_xml_output. -CLASS ltcl_xml_output DEFINITION FOR TESTING DURATION SHORT RISK LEVEL HARMLESS. +CLASS ltcl_xml_output DEFINITION FOR TESTING DURATION SHORT RISK LEVEL HARMLESS. PUBLIC SECTION. METHODS: diff --git a/src/zcl_abapgit_dependencies.clas.abap b/src/zcl_abapgit_dependencies.clas.abap index 3e20022eb..2496d5290 100644 --- a/src/zcl_abapgit_dependencies.clas.abap +++ b/src/zcl_abapgit_dependencies.clas.abap @@ -250,7 +250,7 @@ CLASS ZCL_ABAPGIT_DEPENDENCIES IMPLEMENTATION. LOOP AT lt_dependency ASSIGNING WHERE deptyp = 'DDLS' - AND refname = -obj_name. + AND refname = -obj_name. READ TABLE ct_tadir ASSIGNING WITH KEY pgmid = 'R3TR' diff --git a/src/zcl_abapgit_repo.clas.abap b/src/zcl_abapgit_repo.clas.abap index 2d522eeb0..f85b7a18c 100644 --- a/src/zcl_abapgit_repo.clas.abap +++ b/src/zcl_abapgit_repo.clas.abap @@ -515,8 +515,8 @@ CLASS ZCL_ABAPGIT_REPO IMPLEMENTATION. DELETE lt_local " Remove non-code related files except .abapgit WHERE item IS INITIAL - AND NOT ( file-path = zif_abapgit_definitions=>c_root_dir - AND file-filename = zif_abapgit_definitions=>c_dot_abapgit ). + AND NOT ( file-path = zif_abapgit_definitions=>c_root_dir + AND file-filename = zif_abapgit_definitions=>c_dot_abapgit ). SORT lt_local BY item. LOOP AT lt_local ASSIGNING . diff --git a/src/zcl_abapgit_repo_content_list.clas.abap b/src/zcl_abapgit_repo_content_list.clas.abap index 0284c056d..87698aef3 100644 --- a/src/zcl_abapgit_repo_content_list.clas.abap +++ b/src/zcl_abapgit_repo_content_list.clas.abap @@ -208,7 +208,7 @@ CLASS ZCL_ABAPGIT_REPO_CONTENT_LIST IMPLEMENTATION. METHOD get_log. DATA li_repo_log TYPE REF TO zif_abapgit_log. - DATA lt_repo_msg TYPE zif_abapgit_log=>tty_log_out. + DATA lt_repo_msg TYPE zif_abapgit_log=>tty_log_out. DATA lr_repo_msg TYPE REF TO zif_abapgit_log=>ty_log_out. ri_log = mi_log. diff --git a/src/zcl_abapgit_repo_online.clas.abap b/src/zcl_abapgit_repo_online.clas.abap index ac91542dd..654dd1bfb 100644 --- a/src/zcl_abapgit_repo_online.clas.abap +++ b/src/zcl_abapgit_repo_online.clas.abap @@ -199,8 +199,8 @@ CLASS ZCL_ABAPGIT_REPO_ONLINE IMPLEMENTATION. DELETE lt_local " Remove non-code related files except .abapgit WHERE item IS INITIAL - AND NOT ( file-path = zif_abapgit_definitions=>c_root_dir - AND file-filename = zif_abapgit_definitions=>c_dot_abapgit ). + AND NOT ( file-path = zif_abapgit_definitions=>c_root_dir + AND file-filename = zif_abapgit_definitions=>c_dot_abapgit ). SORT lt_local BY item. lt_remote = get_files_remote( ). diff --git a/src/zcl_abapgit_stage.clas.abap b/src/zcl_abapgit_stage.clas.abap index c1f487bd7..489f9a8b4 100644 --- a/src/zcl_abapgit_stage.clas.abap +++ b/src/zcl_abapgit_stage.clas.abap @@ -166,8 +166,7 @@ CLASS zcl_abapgit_stage IMPLEMENTATION. METHOD reset. - DELETE mt_stage WHERE file-path = iv_path - AND file-filename = iv_filename. + DELETE mt_stage WHERE file-path = iv_path AND file-filename = iv_filename. ASSERT sy-subrc = 0. ENDMETHOD.