whitespace fixes (#2964)

* whitespace fixes

* fix sql compare operators

src/objects/ecatt/zcl_abapgit_ecatt_script_downl.clas.abap

@@ -272,8 +272,7 @@ CLASS ZCL_ABAPGIT_ECATT_SCRIPT_DOWNL IMPLEMENTATION.
 
     FIELD-SYMBOLS: <lt_tab> TYPE STANDARD TABLE.
 
-    IF is_param-xmlref_typ <> cl_apl_ecatt_const=>ref_type_c_tcd
+    IF is_param-xmlref_typ <> cl_apl_ecatt_const=>ref_type_c_tcd OR io_params IS INITIAL.
-      OR  io_params IS INITIAL.
       RETURN.
     ENDIF.
 

src/objects/zcl_abapgit_object_clas.clas.abap

@@ -367,11 +367,8 @@ CLASS ZCL_ABAPGIT_OBJECT_CLAS IMPLEMENTATION.
 
     lv_classpool = cl_oo_classname_service=>get_classpool_name( |{ ms_item-obj_name }| ).
 
-    IF is_class_locked( )             = abap_true
+    IF is_class_locked( ) = abap_true OR is_text_locked( lv_classpool ) = abap_true.
-    OR is_text_locked( lv_classpool ) = abap_true.
-
       rv_is_locked = abap_true.
-
     ENDIF.
 
   ENDMETHOD.

src/objects/zcl_abapgit_object_msag.clas.abap

@@ -214,7 +214,7 @@ CLASS ZCL_ABAPGIT_OBJECT_MSAG IMPLEMENTATION.
     SELECT DISTINCT sprsl AS langu INTO TABLE lt_i18n_langs
       FROM t100t
       WHERE arbgb = lv_msg_id
-      AND   sprsl <> mv_language.       "#EC CI_BYPASS "#EC CI_GENBUFF.
+      AND sprsl <> mv_language.       "#EC CI_BYPASS "#EC CI_GENBUFF
 
     SORT lt_i18n_langs ASCENDING.
 

src/objects/zcl_abapgit_object_tran.clas.abap

@@ -117,16 +117,13 @@ CLASS ZCL_ABAPGIT_OBJECT_TRAN IMPLEMENTATION.
       zcx_abapgit_exception=>raise( |Error deserializing { ms_item-obj_type } { ms_item-obj_name }| ).
     ENDIF.
 
-    LOOP AT lt_message ASSIGNING <ls_message>
+    LOOP AT lt_message ASSIGNING <ls_message> WHERE msgtyp CA 'EAX'.
-                       WHERE msgtyp CA 'EAX'.
-
       MESSAGE ID <ls_message>-msgid
         TYPE <ls_message>-msgtyp
         NUMBER <ls_message>-msgnr
         WITH <ls_message>-msgv1 <ls_message>-msgv2 <ls_message>-msgv3 <ls_message>-msgv4
         INTO sy-msgli.
       zcx_abapgit_exception=>raise_t100( ).
-
     ENDLOOP.
 
   ENDMETHOD.

src/objects/zcl_abapgit_object_ueno.clas.abap

@@ -142,7 +142,7 @@ CLASS zcl_abapgit_object_ueno IMPLEMENTATION.
     SELECT *
       FROM dm02l
       INTO TABLE lt_dm02l
-      WHERE entid    EQ me->mv_entity_id.
+      WHERE entid = me->mv_entity_id.
 
     LOOP AT lt_dm02l INTO ls_dm02l.
 
@@ -188,7 +188,7 @@ CLASS zcl_abapgit_object_ueno IMPLEMENTATION.
     SELECT *
       FROM dm42s
       INTO TABLE lt_dm42s
-      WHERE entidto  EQ me->mv_entity_id.
+      WHERE entidto = me->mv_entity_id.
 
     LOOP AT lt_dm42s INTO ls_dm42s.
 
@@ -238,7 +238,7 @@ CLASS zcl_abapgit_object_ueno IMPLEMENTATION.
     SELECT *
       FROM dm45l
       INTO TABLE lt_dm45l
-      WHERE entid EQ me->ms_item-obj_name.
+      WHERE entid = me->ms_item-obj_name.
 
     LOOP AT lt_dm45l INTO ls_dm45l.
 
@@ -480,8 +480,8 @@ CLASS zcl_abapgit_object_ueno IMPLEMENTATION.
 
     SELECT SINGLE lstuser INTO rv_user
       FROM dm02l
-      WHERE entid    EQ me->mv_entity_id
+      WHERE entid = me->mv_entity_id
-      AND   as4local EQ c_active_state.
+      AND as4local = c_active_state.
 
     IF sy-subrc <> 0.
       rv_user = c_user_unknown.

src/ui/zcl_abapgit_gui_page_diff.clas.abap

@@ -210,8 +210,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DIFF IMPLEMENTATION.
 
       lv_patch = lo_git_add_patch->get_patch_binary( ).
 
-      IF  <ls_diff_file>-lstate = 'D'
+      IF <ls_diff_file>-lstate = 'D' AND are_all_lines_patched( lt_diff ) = abap_true.
-      AND are_all_lines_patched( lt_diff ) = abap_true.
 
         mo_stage->rm(
             iv_path     = <ls_diff_file>-path

src/ui/zcl_abapgit_gui_page_settings.clas.abap

@@ -329,8 +329,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_SETTINGS IMPLEMENTATION.
       ENDCASE.
     ENDLOOP.
 
-    DELETE lt_key_bindings WHERE hotkey IS INITIAL
+    DELETE lt_key_bindings WHERE hotkey IS INITIAL OR action IS INITIAL.
-                           OR    action IS INITIAL.
 
     mo_settings->set_hotkeys( lt_key_bindings ).
 

src/ui/zcl_abapgit_gui_view_repo.clas.abap

@@ -1004,8 +1004,7 @@ CLASS zcl_abapgit_gui_view_repo IMPLEMENTATION.
     " so we isolate them and and sort only the code artifacts
     LOOP AT ct_repo_items ASSIGNING <ls_repo_item>.
 
-      IF  <ls_repo_item>-obj_type IS INITIAL
+      IF <ls_repo_item>-obj_type IS INITIAL AND <ls_repo_item>-is_dir = abap_false.
-      AND <ls_repo_item>-is_dir = abap_false.
         INSERT <ls_repo_item> INTO TABLE lt_non_code_and_metadata_items.
       ELSE.
         INSERT <ls_repo_item> INTO TABLE lt_code_items.

src/zcl_abapgit_stage.clas.abap

@@ -166,8 +166,7 @@ CLASS zcl_abapgit_stage IMPLEMENTATION.
 
 
   METHOD reset.
-    DELETE mt_stage WHERE file-path     = iv_path
+    DELETE mt_stage WHERE file-path = iv_path AND file-filename = iv_filename.
-                    AND   file-filename = iv_filename.
     ASSERT sy-subrc = 0.
   ENDMETHOD.