From 725d92f98ec84134a0695d0ca6e5d9b4c3f97bf5 Mon Sep 17 00:00:00 2001
From: Lars Hvam <larshp@hotmail.com>
Date: Fri, 20 Nov 2020 08:51:01 +0100
Subject: [PATCH] bugfix, PR popup sorting (#4206)

---
 src/ui/zcl_abapgit_gui_page_repo_view.clas.abap | 4 +++-
 src/ui/zcl_abapgit_popups.clas.abap             | 3 +--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/ui/zcl_abapgit_gui_page_repo_view.clas.abap b/src/ui/zcl_abapgit_gui_page_repo_view.clas.abap
index 4e78d36ea..96edd5028 100644
--- a/src/ui/zcl_abapgit_gui_page_repo_view.clas.abap
+++ b/src/ui/zcl_abapgit_gui_page_repo_view.clas.abap
@@ -186,7 +186,7 @@ ENDCLASS.
 
 
 
-CLASS zcl_abapgit_gui_page_repo_view IMPLEMENTATION.
+CLASS ZCL_ABAPGIT_GUI_PAGE_REPO_VIEW IMPLEMENTATION.
 
 
   METHOD apply_order_by.
@@ -1157,6 +1157,8 @@ CLASS zcl_abapgit_gui_page_repo_view IMPLEMENTATION.
         RETURN. " false
       ENDIF.
 
+      SORT lt_pulls BY number DESCENDING.
+
       ls_pull = zcl_abapgit_ui_factory=>get_popups( )->choose_pr_popup( lt_pulls ).
       IF ls_pull IS INITIAL.
         RETURN. " false
diff --git a/src/ui/zcl_abapgit_popups.clas.abap b/src/ui/zcl_abapgit_popups.clas.abap
index e89efaa61..9349fc108 100644
--- a/src/ui/zcl_abapgit_popups.clas.abap
+++ b/src/ui/zcl_abapgit_popups.clas.abap
@@ -89,7 +89,7 @@ ENDCLASS.
 
 
 
-CLASS zcl_abapgit_popups IMPLEMENTATION.
+CLASS ZCL_ABAPGIT_POPUPS IMPLEMENTATION.
 
 
   METHOD add_field.
@@ -633,7 +633,6 @@ CLASS zcl_abapgit_popups IMPLEMENTATION.
       APPEND INITIAL LINE TO lt_selection ASSIGNING <ls_sel>.
       <ls_sel>-varoption = |{ <ls_pull>-number } - { <ls_pull>-title } @{ <ls_pull>-user }|.
     ENDLOOP.
-    SORT lt_selection BY varoption DESCENDING.
 
     CALL FUNCTION 'POPUP_TO_DECIDE_LIST'
       EXPORTING