SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #614 from sbcgua/t556-limit-line-ux

Browse Source 
Improve UX of object limit bottom line, #566
This commit is contained in:
Lars Hvam 2017-02-13 10:06:58 +01:00 committed by GitHub
commit 73491c62fd
1 changed files with 28 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
src/zabapgit_view_repo.prog.abap
View File

@ -12,6 +12,7 @@ CLASS lcl_gui_view_repo_content DEFINITION FINAL.
toggle_hide_files TYPE string VALUE 'toggle_hide_files' ##NO_TEXT, toggle_hide_files TYPE string VALUE 'toggle_hide_files' ##NO_TEXT,
toggle_folders TYPE string VALUE 'toggle_folders' ##NO_TEXT, toggle_folders TYPE string VALUE 'toggle_folders' ##NO_TEXT,
toggle_changes TYPE string VALUE 'toggle_changes' ##NO_TEXT, toggle_changes TYPE string VALUE 'toggle_changes' ##NO_TEXT,
display_more TYPE string VALUE 'display_more' ##NO_TEXT,
END OF c_actions. END OF c_actions.
METHODS constructor METHODS constructor
@ -23,6 +24,8 @@ CLASS lcl_gui_view_repo_content DEFINITION FINAL.
DATA: mo_repo TYPE REF TO lcl_repo, DATA: mo_repo TYPE REF TO lcl_repo,
mv_cur_dir TYPE string, mv_cur_dir TYPE string,
mv_hide_files TYPE abap_bool, mv_hide_files TYPE abap_bool,
mv_max_lines TYPE i,
mv_max_setting TYPE i,
mv_show_folders TYPE abap_bool, mv_show_folders TYPE abap_bool,
mv_changes_only TYPE abap_bool. mv_changes_only TYPE abap_bool.
@ -71,6 +74,8 @@ CLASS lcl_gui_view_repo_content IMPLEMENTATION.
METHOD constructor. METHOD constructor.
DATA lo_settings TYPE REF TO lcl_settings.
super->constructor( ). super->constructor( ).
mo_repo = lcl_app=>repo_srv( )->get( iv_key ). mo_repo = lcl_app=>repo_srv( )->get( iv_key ).
@ -78,6 +83,11 @@ CLASS lcl_gui_view_repo_content IMPLEMENTATION.
mv_hide_files = lcl_app=>user( )->get_hide_files( ). mv_hide_files = lcl_app=>user( )->get_hide_files( ).
mv_changes_only = lcl_app=>user( )->get_changes_only( ). mv_changes_only = lcl_app=>user( )->get_changes_only( ).
" Read global settings to get max # of objects to be listed
lo_settings = lcl_app=>settings( )->read( ).
mv_max_lines = lo_settings->get_max_lines( ).
mv_max_setting = mv_max_lines.
ENDMETHOD. "constructor ENDMETHOD. "constructor
METHOD lif_gui_page~on_event. METHOD lif_gui_page~on_event.
@ -99,6 +109,9 @@ CLASS lcl_gui_view_repo_content IMPLEMENTATION.
WHEN c_actions-toggle_changes. " Toggle changes only view WHEN c_actions-toggle_changes. " Toggle changes only view
mv_changes_only = lcl_app=>user( )->toggle_changes_only( ). mv_changes_only = lcl_app=>user( )->toggle_changes_only( ).
ev_state = gc_event_state-re_render. ev_state = gc_event_state-re_render.
WHEN c_actions-display_more. " Increase MAX lines limit
mv_max_lines = mv_max_lines + mv_max_setting.
ev_state = gc_event_state-re_render.
ENDCASE. ENDCASE.
ENDMETHOD. "lif_gui_page~on_event ENDMETHOD. "lif_gui_page~on_event
@ -111,16 +124,12 @@ CLASS lcl_gui_view_repo_content IMPLEMENTATION.
lv_lstate TYPE char1, lv_lstate TYPE char1,
lv_rstate TYPE char1, lv_rstate TYPE char1,
lv_max TYPE abap_bool, lv_max TYPE abap_bool,
lo_log TYPE REF TO lcl_log, lv_max_str TYPE string,
lo_settings TYPE REF TO lcl_settings, lv_add_str TYPE string,
lv_max_lines TYPE i. lo_log TYPE REF TO lcl_log.
FIELD-SYMBOLS <ls_item> LIKE LINE OF lt_repo_items. FIELD-SYMBOLS <ls_item> LIKE LINE OF lt_repo_items.
" Read global settings to get max # of objects to be listed
lo_settings = lcl_app=>settings( )->read( ).
lv_max_lines = lo_settings->get_max_lines( ).
" Reinit, for the case of type change " Reinit, for the case of type change
mo_repo = lcl_app=>repo_srv( )->get( mo_repo->get_key( ) ). mo_repo = lcl_app=>repo_srv( )->get( mo_repo->get_key( ) ).
@ -165,7 +174,7 @@ CLASS lcl_gui_view_repo_content IMPLEMENTATION.
ro_html->add( render_empty_package( ) ). ro_html->add( render_empty_package( ) ).
ELSE. ELSE.
LOOP AT lt_repo_items ASSIGNING <ls_item>. LOOP AT lt_repo_items ASSIGNING <ls_item>.
IF lv_max_lines > 0 AND sy-tabix > lv_max_lines. IF mv_max_lines > 0 AND sy-tabix > mv_max_lines.
lv_max = abap_true. lv_max = abap_true.
EXIT. " current loop EXIT. " current loop
ENDIF. ENDIF.
@ -176,11 +185,19 @@ CLASS lcl_gui_view_repo_content IMPLEMENTATION.
ro_html->add( '</table>' ). ro_html->add( '</table>' ).
IF lv_max = abap_true. IF lv_max = abap_true.
IF lv_max_lines = 1. ro_html->add( '<div class = "dummydiv">' ).
ro_html->add( |Only 1 object shown in list (Set in Advanced > Settings )| ). IF mv_max_lines = 1.
lv_max_str = '1 object'.
ELSE. ELSE.
ro_html->add( |Only first { lv_max_lines } objects shown in list (Set in Advanced > Settings )| ). lv_max_str = |first { mv_max_lines } objects|.
ENDIF. ENDIF.
lv_add_str = |+{ mv_max_setting }|.
ro_html->add( |Only { lv_max_str } shown in list. Display {
lcl_html=>a( iv_txt = lv_add_str iv_act = c_actions-display_more )
} more. (Set in Advanced > {
lcl_html=>a( iv_txt = 'Settings' iv_act = gc_action-go_settings )
} )| ).
ro_html->add( '</div>' ).
ENDIF. ENDIF.
ro_html->add( '</div>' ). ro_html->add( '</div>' ).