From 744ce9efce47f2264bb0b206b9050d816309778c Mon Sep 17 00:00:00 2001 From: Marc Bernard <59966492+mbtools@users.noreply.github.com> Date: Tue, 15 Dec 2020 02:05:11 -0500 Subject: [PATCH] Align naming of object super classes (#4327) * Align naming of object super classes - SAXX_SUPER for SAMC %26 SAPC - W3XX_SUPER for W3HT %26 W3MI * Delete old classes Co-authored-by: Lars Hvam --- src/objects/zcl_abapgit_object_samc.clas.abap | 20 +++++++---- src/objects/zcl_abapgit_object_sapc.clas.abap | 20 +++++++---- ...> zcl_abapgit_object_saxx_super.clas.abap} | 6 ++-- ...=> zcl_abapgit_object_saxx_super.clas.xml} | 2 +- src/objects/zcl_abapgit_object_w3ht.clas.abap | 7 ++-- src/objects/zcl_abapgit_object_w3mi.clas.abap | 7 ++-- ...> zcl_abapgit_object_w3xx_super.clas.abap} | 34 +++++++++++-------- ...=> zcl_abapgit_object_w3xx_super.clas.xml} | 2 +- 8 files changed, 64 insertions(+), 34 deletions(-) rename src/objects/{zcl_abapgit_objects_saxx_super.clas.abap => zcl_abapgit_object_saxx_super.clas.abap} (98%) rename src/objects/{zcl_abapgit_objects_saxx_super.clas.xml => zcl_abapgit_object_saxx_super.clas.xml} (89%) rename src/objects/{zcl_abapgit_object_w3super.clas.abap => zcl_abapgit_object_w3xx_super.clas.abap} (95%) rename src/objects/{zcl_abapgit_object_w3super.clas.xml => zcl_abapgit_object_w3xx_super.clas.xml} (89%) diff --git a/src/objects/zcl_abapgit_object_samc.clas.abap b/src/objects/zcl_abapgit_object_samc.clas.abap index 5e6cb25e9..1eb462b2b 100644 --- a/src/objects/zcl_abapgit_object_samc.clas.abap +++ b/src/objects/zcl_abapgit_object_samc.clas.abap @@ -1,16 +1,24 @@ -CLASS zcl_abapgit_object_samc DEFINITION PUBLIC INHERITING FROM zcl_abapgit_objects_saxx_super FINAL. +CLASS zcl_abapgit_object_samc DEFINITION + PUBLIC + INHERITING FROM zcl_abapgit_object_saxx_super + FINAL + CREATE PUBLIC . + PUBLIC SECTION. PROTECTED SECTION. - METHODS: - get_persistence_class_name REDEFINITION, - get_data_class_name REDEFINITION, - get_data_structure_name REDEFINITION. + METHODS get_data_class_name + REDEFINITION . + METHODS get_data_structure_name + REDEFINITION . + METHODS get_persistence_class_name + REDEFINITION . + PRIVATE SECTION. ENDCLASS. -CLASS ZCL_ABAPGIT_OBJECT_SAMC IMPLEMENTATION. +CLASS zcl_abapgit_object_samc IMPLEMENTATION. METHOD get_data_class_name. diff --git a/src/objects/zcl_abapgit_object_sapc.clas.abap b/src/objects/zcl_abapgit_object_sapc.clas.abap index f6b94886f..438bd287c 100644 --- a/src/objects/zcl_abapgit_object_sapc.clas.abap +++ b/src/objects/zcl_abapgit_object_sapc.clas.abap @@ -1,16 +1,24 @@ -CLASS zcl_abapgit_object_sapc DEFINITION PUBLIC INHERITING FROM zcl_abapgit_objects_saxx_super FINAL. +CLASS zcl_abapgit_object_sapc DEFINITION + PUBLIC + INHERITING FROM zcl_abapgit_object_saxx_super + FINAL + CREATE PUBLIC . + PUBLIC SECTION. PROTECTED SECTION. - METHODS: - get_persistence_class_name REDEFINITION, - get_data_class_name REDEFINITION, - get_data_structure_name REDEFINITION. + METHODS get_data_class_name + REDEFINITION . + METHODS get_data_structure_name + REDEFINITION . + METHODS get_persistence_class_name + REDEFINITION . + PRIVATE SECTION. ENDCLASS. -CLASS ZCL_ABAPGIT_OBJECT_SAPC IMPLEMENTATION. +CLASS zcl_abapgit_object_sapc IMPLEMENTATION. METHOD get_data_class_name. diff --git a/src/objects/zcl_abapgit_objects_saxx_super.clas.abap b/src/objects/zcl_abapgit_object_saxx_super.clas.abap similarity index 98% rename from src/objects/zcl_abapgit_objects_saxx_super.clas.abap rename to src/objects/zcl_abapgit_object_saxx_super.clas.abap index d2af778ea..16dbd5e2f 100644 --- a/src/objects/zcl_abapgit_objects_saxx_super.clas.abap +++ b/src/objects/zcl_abapgit_object_saxx_super.clas.abap @@ -1,4 +1,4 @@ -CLASS zcl_abapgit_objects_saxx_super DEFINITION +CLASS zcl_abapgit_object_saxx_super DEFINITION PUBLIC INHERITING FROM zcl_abapgit_objects_super ABSTRACT @@ -8,6 +8,7 @@ CLASS zcl_abapgit_objects_saxx_super DEFINITION PUBLIC SECTION. INTERFACES zif_abapgit_object . + PROTECTED SECTION. METHODS get_persistence_class_name @@ -22,6 +23,7 @@ CLASS zcl_abapgit_objects_saxx_super DEFINITION ABSTRACT RETURNING VALUE(rv_data_structure_name) TYPE string . + PRIVATE SECTION. DATA mi_persistence TYPE REF TO if_wb_object_persist . @@ -49,7 +51,7 @@ ENDCLASS. -CLASS zcl_abapgit_objects_saxx_super IMPLEMENTATION. +CLASS zcl_abapgit_object_saxx_super IMPLEMENTATION. METHOD create_channel_objects. diff --git a/src/objects/zcl_abapgit_objects_saxx_super.clas.xml b/src/objects/zcl_abapgit_object_saxx_super.clas.xml similarity index 89% rename from src/objects/zcl_abapgit_objects_saxx_super.clas.xml rename to src/objects/zcl_abapgit_object_saxx_super.clas.xml index 50812dd9d..bafeaf9b1 100644 --- a/src/objects/zcl_abapgit_objects_saxx_super.clas.xml +++ b/src/objects/zcl_abapgit_object_saxx_super.clas.xml @@ -3,7 +3,7 @@ - ZCL_ABAPGIT_OBJECTS_SAXX_SUPER + ZCL_ABAPGIT_OBJECT_SAXX_SUPER E SAXX - ABAP Channels 1 diff --git a/src/objects/zcl_abapgit_object_w3ht.clas.abap b/src/objects/zcl_abapgit_object_w3ht.clas.abap index 08c3a28d1..610709e8f 100644 --- a/src/objects/zcl_abapgit_object_w3ht.clas.abap +++ b/src/objects/zcl_abapgit_object_w3ht.clas.abap @@ -1,11 +1,15 @@ -CLASS zcl_abapgit_object_w3ht DEFINITION PUBLIC INHERITING FROM zcl_abapgit_object_w3super FINAL. +CLASS zcl_abapgit_object_w3ht DEFINITION PUBLIC INHERITING FROM zcl_abapgit_object_w3xx_super FINAL. PROTECTED SECTION. METHODS: change_bdc_jump_data REDEFINITION. + PRIVATE SECTION. ENDCLASS. + + CLASS zcl_abapgit_object_w3ht IMPLEMENTATION. + METHOD change_bdc_jump_data. DATA: ls_bdcdata LIKE LINE OF ct_bdcdata. @@ -20,5 +24,4 @@ CLASS zcl_abapgit_object_w3ht IMPLEMENTATION. APPEND ls_bdcdata TO ct_bdcdata. ENDMETHOD. - ENDCLASS. diff --git a/src/objects/zcl_abapgit_object_w3mi.clas.abap b/src/objects/zcl_abapgit_object_w3mi.clas.abap index b62cbe9a7..6583a4bef 100644 --- a/src/objects/zcl_abapgit_object_w3mi.clas.abap +++ b/src/objects/zcl_abapgit_object_w3mi.clas.abap @@ -1,11 +1,15 @@ -CLASS zcl_abapgit_object_w3mi DEFINITION PUBLIC INHERITING FROM zcl_abapgit_object_w3super FINAL. +CLASS zcl_abapgit_object_w3mi DEFINITION PUBLIC INHERITING FROM zcl_abapgit_object_w3xx_super FINAL. PROTECTED SECTION. METHODS: change_bdc_jump_data REDEFINITION. + PRIVATE SECTION. ENDCLASS. + + CLASS zcl_abapgit_object_w3mi IMPLEMENTATION. + METHOD change_bdc_jump_data. DATA: ls_bdcdata LIKE LINE OF ct_bdcdata. @@ -20,5 +24,4 @@ CLASS zcl_abapgit_object_w3mi IMPLEMENTATION. APPEND ls_bdcdata TO ct_bdcdata. ENDMETHOD. - ENDCLASS. diff --git a/src/objects/zcl_abapgit_object_w3super.clas.abap b/src/objects/zcl_abapgit_object_w3xx_super.clas.abap similarity index 95% rename from src/objects/zcl_abapgit_object_w3super.clas.abap rename to src/objects/zcl_abapgit_object_w3xx_super.clas.abap index d91346035..4b10cf649 100644 --- a/src/objects/zcl_abapgit_object_w3super.clas.abap +++ b/src/objects/zcl_abapgit_object_w3xx_super.clas.abap @@ -1,23 +1,29 @@ -CLASS zcl_abapgit_object_w3super DEFINITION PUBLIC INHERITING FROM zcl_abapgit_objects_super ABSTRACT. +CLASS zcl_abapgit_object_w3xx_super DEFINITION + PUBLIC + INHERITING FROM zcl_abapgit_objects_super + ABSTRACT + CREATE PUBLIC . PUBLIC SECTION. - INTERFACES zif_abapgit_object. - TYPES ty_wwwparams_tt TYPE STANDARD TABLE OF wwwparams WITH DEFAULT KEY. + INTERFACES zif_abapgit_object . - CONSTANTS: BEGIN OF c_param_names, - version TYPE w3_name VALUE 'version', - fileext TYPE w3_name VALUE 'fileextension', - filesize TYPE w3_name VALUE 'filesize', - filename TYPE w3_name VALUE 'filename', - mimetype TYPE w3_name VALUE 'mimetype', - END OF c_param_names. + TYPES: + ty_wwwparams_tt TYPE STANDARD TABLE OF wwwparams WITH DEFAULT KEY . + + CONSTANTS: + BEGIN OF c_param_names, + version TYPE w3_name VALUE 'version', + fileext TYPE w3_name VALUE 'fileextension', + filesize TYPE w3_name VALUE 'filesize', + filename TYPE w3_name VALUE 'filename', + mimetype TYPE w3_name VALUE 'mimetype', + END OF c_param_names . METHODS constructor IMPORTING - is_item TYPE zif_abapgit_definitions=>ty_item - iv_language TYPE spras. - + !is_item TYPE zif_abapgit_definitions=>ty_item + !iv_language TYPE spras . PROTECTED SECTION. TYPES ty_bdcdata TYPE STANDARD TABLE OF bdcdata WITH NON-UNIQUE DEFAULT KEY. @@ -56,7 +62,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_OBJECT_W3SUPER IMPLEMENTATION. +CLASS zcl_abapgit_object_w3xx_super IMPLEMENTATION. METHOD constructor. diff --git a/src/objects/zcl_abapgit_object_w3super.clas.xml b/src/objects/zcl_abapgit_object_w3xx_super.clas.xml similarity index 89% rename from src/objects/zcl_abapgit_object_w3super.clas.xml rename to src/objects/zcl_abapgit_object_w3xx_super.clas.xml index f9098bb60..1da595306 100644 --- a/src/objects/zcl_abapgit_object_w3super.clas.xml +++ b/src/objects/zcl_abapgit_object_w3xx_super.clas.xml @@ -3,7 +3,7 @@ - ZCL_ABAPGIT_OBJECT_W3SUPER + ZCL_ABAPGIT_OBJECT_W3XX_SUPER E W3XX - Web Reporting/Internet Transaction Server 1