Align naming of object super classes (#4327)

* Align naming of object super classes

- SAXX_SUPER for SAMC %26 SAPC
- W3XX_SUPER for W3HT %26 W3MI

* Delete old classes

Co-authored-by: Lars Hvam <larshp@hotmail.com>

src/objects/zcl_abapgit_object_samc.clas.abap

@@ -1,16 +1,24 @@
-CLASS zcl_abapgit_object_samc DEFINITION PUBLIC INHERITING FROM zcl_abapgit_objects_saxx_super FINAL.
+CLASS zcl_abapgit_object_samc DEFINITION
+  PUBLIC
+  INHERITING FROM zcl_abapgit_object_saxx_super
+  FINAL
+  CREATE PUBLIC .
 
+  PUBLIC SECTION.
   PROTECTED SECTION.
-    METHODS:
-      get_persistence_class_name REDEFINITION,
-      get_data_class_name REDEFINITION,
-      get_data_structure_name REDEFINITION.
 
+    METHODS get_data_class_name
+        REDEFINITION .
+    METHODS get_data_structure_name
+        REDEFINITION .
+    METHODS get_persistence_class_name
+        REDEFINITION .
+  PRIVATE SECTION.
 ENDCLASS.
 
 
 
-CLASS ZCL_ABAPGIT_OBJECT_SAMC IMPLEMENTATION.
+CLASS zcl_abapgit_object_samc IMPLEMENTATION.
 
 
   METHOD get_data_class_name.

src/objects/zcl_abapgit_object_sapc.clas.abap

@@ -1,16 +1,24 @@
-CLASS zcl_abapgit_object_sapc DEFINITION PUBLIC INHERITING FROM zcl_abapgit_objects_saxx_super FINAL.
+CLASS zcl_abapgit_object_sapc DEFINITION
+  PUBLIC
+  INHERITING FROM zcl_abapgit_object_saxx_super
+  FINAL
+  CREATE PUBLIC .
 
+  PUBLIC SECTION.
   PROTECTED SECTION.
-    METHODS:
-      get_persistence_class_name REDEFINITION,
-      get_data_class_name REDEFINITION,
-      get_data_structure_name REDEFINITION.
 
+    METHODS get_data_class_name
+        REDEFINITION .
+    METHODS get_data_structure_name
+        REDEFINITION .
+    METHODS get_persistence_class_name
+        REDEFINITION .
+  PRIVATE SECTION.
 ENDCLASS.
 
 
 
-CLASS ZCL_ABAPGIT_OBJECT_SAPC IMPLEMENTATION.
+CLASS zcl_abapgit_object_sapc IMPLEMENTATION.
 
 
   METHOD get_data_class_name.

src/objects/zcl_abapgit_object_saxx_super.clas.abap

@@ -1,4 +1,4 @@
-CLASS zcl_abapgit_objects_saxx_super DEFINITION
+CLASS zcl_abapgit_object_saxx_super DEFINITION
   PUBLIC
   INHERITING FROM zcl_abapgit_objects_super
   ABSTRACT
@@ -8,6 +8,7 @@ CLASS zcl_abapgit_objects_saxx_super DEFINITION
   PUBLIC SECTION.
 
     INTERFACES zif_abapgit_object .
+
   PROTECTED SECTION.
 
     METHODS get_persistence_class_name
@@ -22,6 +23,7 @@ CLASS zcl_abapgit_objects_saxx_super DEFINITION
           ABSTRACT
       RETURNING
         VALUE(rv_data_structure_name) TYPE string .
+
   PRIVATE SECTION.
 
     DATA mi_persistence TYPE REF TO if_wb_object_persist .
@@ -49,7 +51,7 @@ ENDCLASS.
 
 
 
-CLASS zcl_abapgit_objects_saxx_super IMPLEMENTATION.
+CLASS zcl_abapgit_object_saxx_super IMPLEMENTATION.
 
 
   METHOD create_channel_objects.

src/objects/zcl_abapgit_object_saxx_super.clas.xml

@@ -3,7 +3,7 @@
  <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
   <asx:values>
    <VSEOCLASS>
-    <CLSNAME>ZCL_ABAPGIT_OBJECTS_SAXX_SUPER</CLSNAME>
+    <CLSNAME>ZCL_ABAPGIT_OBJECT_SAXX_SUPER</CLSNAME>
     <LANGU>E</LANGU>
     <DESCRIPT>SAXX - ABAP Channels</DESCRIPT>
     <STATE>1</STATE>

src/objects/zcl_abapgit_object_w3ht.clas.abap

@@ -1,11 +1,15 @@
-CLASS zcl_abapgit_object_w3ht DEFINITION PUBLIC INHERITING FROM zcl_abapgit_object_w3super FINAL.
+CLASS zcl_abapgit_object_w3ht DEFINITION PUBLIC INHERITING FROM zcl_abapgit_object_w3xx_super FINAL.
 
   PROTECTED SECTION.
     METHODS: change_bdc_jump_data REDEFINITION.
+  PRIVATE SECTION.
 ENDCLASS.
 
+
+
 CLASS zcl_abapgit_object_w3ht IMPLEMENTATION.
 
+
   METHOD change_bdc_jump_data.
 
     DATA: ls_bdcdata LIKE LINE OF ct_bdcdata.
@@ -20,5 +24,4 @@ CLASS zcl_abapgit_object_w3ht IMPLEMENTATION.
     APPEND ls_bdcdata TO ct_bdcdata.
 
   ENDMETHOD.
-
 ENDCLASS.

src/objects/zcl_abapgit_object_w3mi.clas.abap

@@ -1,11 +1,15 @@
-CLASS zcl_abapgit_object_w3mi DEFINITION PUBLIC INHERITING FROM zcl_abapgit_object_w3super FINAL.
+CLASS zcl_abapgit_object_w3mi DEFINITION PUBLIC INHERITING FROM zcl_abapgit_object_w3xx_super FINAL.
 
   PROTECTED SECTION.
     METHODS: change_bdc_jump_data REDEFINITION.
+  PRIVATE SECTION.
 ENDCLASS.
 
+
+
 CLASS zcl_abapgit_object_w3mi IMPLEMENTATION.
 
+
   METHOD change_bdc_jump_data.
 
     DATA: ls_bdcdata LIKE LINE OF ct_bdcdata.
@@ -20,5 +24,4 @@ CLASS zcl_abapgit_object_w3mi IMPLEMENTATION.
     APPEND ls_bdcdata TO ct_bdcdata.
 
   ENDMETHOD.
-
 ENDCLASS.

src/objects/zcl_abapgit_object_w3xx_super.clas.abap

@@ -1,23 +1,29 @@
-CLASS zcl_abapgit_object_w3super DEFINITION PUBLIC INHERITING FROM zcl_abapgit_objects_super ABSTRACT.
+CLASS zcl_abapgit_object_w3xx_super DEFINITION
+  PUBLIC
+  INHERITING FROM zcl_abapgit_objects_super
+  ABSTRACT
+  CREATE PUBLIC .
 
   PUBLIC SECTION.
-    INTERFACES zif_abapgit_object.
 
-    TYPES ty_wwwparams_tt TYPE STANDARD TABLE OF wwwparams WITH DEFAULT KEY.
+    INTERFACES zif_abapgit_object .
 
-    CONSTANTS: BEGIN OF c_param_names,
+    TYPES:
-                 version  TYPE w3_name VALUE 'version',
+      ty_wwwparams_tt TYPE STANDARD TABLE OF wwwparams WITH DEFAULT KEY .
-                 fileext  TYPE w3_name VALUE 'fileextension',
+
-                 filesize TYPE w3_name VALUE 'filesize',
+    CONSTANTS:
-                 filename TYPE w3_name VALUE 'filename',
+      BEGIN OF c_param_names,
-                 mimetype TYPE w3_name VALUE 'mimetype',
+        version  TYPE w3_name VALUE 'version',
-               END OF c_param_names.
+        fileext  TYPE w3_name VALUE 'fileextension',
+        filesize TYPE w3_name VALUE 'filesize',
+        filename TYPE w3_name VALUE 'filename',
+        mimetype TYPE w3_name VALUE 'mimetype',
+      END OF c_param_names .
 
     METHODS constructor
       IMPORTING
-        is_item     TYPE zif_abapgit_definitions=>ty_item
+        !is_item     TYPE zif_abapgit_definitions=>ty_item
-        iv_language TYPE spras.
+        !iv_language TYPE spras .
-
   PROTECTED SECTION.
     TYPES ty_bdcdata TYPE STANDARD TABLE OF bdcdata
                            WITH NON-UNIQUE DEFAULT KEY.
@@ -56,7 +62,7 @@ ENDCLASS.
 
 
 
-CLASS ZCL_ABAPGIT_OBJECT_W3SUPER IMPLEMENTATION.
+CLASS zcl_abapgit_object_w3xx_super IMPLEMENTATION.
 
 
   METHOD constructor.

src/objects/zcl_abapgit_object_w3xx_super.clas.xml

@@ -3,7 +3,7 @@
  <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
   <asx:values>
    <VSEOCLASS>
-    <CLSNAME>ZCL_ABAPGIT_OBJECT_W3SUPER</CLSNAME>
+    <CLSNAME>ZCL_ABAPGIT_OBJECT_W3XX_SUPER</CLSNAME>
     <LANGU>E</LANGU>
     <DESCRIPT>W3XX - Web Reporting/Internet Transaction Server</DESCRIPT>
     <STATE>1</STATE>