From 7492d1da900f8c91330d83d35a9165edd5484691 Mon Sep 17 00:00:00 2001 From: Marc Bernard <59966492+mbtools@users.noreply.github.com> Date: Thu, 16 Jan 2025 14:59:05 +0100 Subject: [PATCH] Update menu ids --- src/test/zcl_abapgit_gui_page_template.clas.abap | 2 +- src/ui/lib/zcl_abapgit_gui_menus.clas.abap | 2 +- src/ui/pages/codi/zcl_abapgit_gui_page_codi_base.clas.abap | 2 +- src/ui/pages/db/zcl_abapgit_gui_page_db.clas.abap | 4 ++-- src/ui/pages/db/zcl_abapgit_gui_page_db_entry.clas.abap | 2 +- src/ui/pages/zcl_abapgit_gui_page_data.clas.abap | 2 +- src/ui/pages/zcl_abapgit_gui_page_debuginfo.clas.abap | 2 +- src/ui/pages/zcl_abapgit_gui_page_repo_over.clas.abap | 6 ------ src/ui/pages/zcl_abapgit_gui_page_repo_view.clas.abap | 3 --- 9 files changed, 8 insertions(+), 17 deletions(-) diff --git a/src/test/zcl_abapgit_gui_page_template.clas.abap b/src/test/zcl_abapgit_gui_page_template.clas.abap index d6eb04fa8..25f6f0f48 100644 --- a/src/test/zcl_abapgit_gui_page_template.clas.abap +++ b/src/test/zcl_abapgit_gui_page_template.clas.abap @@ -99,7 +99,7 @@ CLASS zcl_abapgit_gui_page_template IMPLEMENTATION. " TODO: top level menu; use unique id - ro_toolbar = zcl_abapgit_html_toolbar=>create( 'toolbar-id' )->add( + ro_toolbar = zcl_abapgit_html_toolbar=>create( 'toolbar-template-id' )->add( iv_txt = 'Refresh' iv_act = c_action-refresh ). diff --git a/src/ui/lib/zcl_abapgit_gui_menus.clas.abap b/src/ui/lib/zcl_abapgit_gui_menus.clas.abap index a17f81147..32967c429 100644 --- a/src/ui/lib/zcl_abapgit_gui_menus.clas.abap +++ b/src/ui/lib/zcl_abapgit_gui_menus.clas.abap @@ -152,7 +152,7 @@ CLASS zcl_abapgit_gui_menus IMPLEMENTATION. METHOD settings. - ro_menu = zcl_abapgit_html_toolbar=>create( 'toolbar-Settings' ). + ro_menu = zcl_abapgit_html_toolbar=>create( 'toolbar-abapgit-settings' ). ro_menu->add( iv_txt = 'Global' diff --git a/src/ui/pages/codi/zcl_abapgit_gui_page_codi_base.clas.abap b/src/ui/pages/codi/zcl_abapgit_gui_page_codi_base.clas.abap index ec1ec5909..e3cc43d01 100644 --- a/src/ui/pages/codi/zcl_abapgit_gui_page_codi_base.clas.abap +++ b/src/ui/pages/codi/zcl_abapgit_gui_page_codi_base.clas.abap @@ -168,7 +168,7 @@ CLASS zcl_abapgit_gui_page_codi_base IMPLEMENTATION. METHOD build_base_menu. - ro_menu = zcl_abapgit_html_toolbar=>create( 'code-inspector' )->add( + ro_menu = zcl_abapgit_html_toolbar=>create( 'toolbar-code-inspector' )->add( iv_txt = 'Re-Run' iv_act = c_actions-rerun ). diff --git a/src/ui/pages/db/zcl_abapgit_gui_page_db.clas.abap b/src/ui/pages/db/zcl_abapgit_gui_page_db.clas.abap index 43e491142..e6e435979 100644 --- a/src/ui/pages/db/zcl_abapgit_gui_page_db.clas.abap +++ b/src/ui/pages/db/zcl_abapgit_gui_page_db.clas.abap @@ -595,7 +595,7 @@ CLASS zcl_abapgit_gui_page_db IMPLEMENTATION. METHOD zif_abapgit_gui_menu_provider~get_menu. - ro_toolbar = zcl_abapgit_html_toolbar=>create( 'database-utility' ). + ro_toolbar = zcl_abapgit_html_toolbar=>create( 'toolbar-database-utility' ). ro_toolbar->add( iv_txt = 'Backup' @@ -648,7 +648,7 @@ CLASS zcl_abapgit_gui_page_db IMPLEMENTATION. rs_render-css_class = 'data'. WHEN 'cmd'. lv_action = zcl_abapgit_html_action_utils=>dbkey_encode( is_row ). - lo_toolbar = zcl_abapgit_html_toolbar=>create( + lo_toolbar = zcl_abapgit_html_toolbar=>create( 'actionbar-database-utility' )->add( iv_txt = 'Display' iv_act = |{ zif_abapgit_definitions=>c_action-db_display }?{ lv_action }| diff --git a/src/ui/pages/db/zcl_abapgit_gui_page_db_entry.clas.abap b/src/ui/pages/db/zcl_abapgit_gui_page_db_entry.clas.abap index 81d9977f1..1e34e75f2 100644 --- a/src/ui/pages/db/zcl_abapgit_gui_page_db_entry.clas.abap +++ b/src/ui/pages/db/zcl_abapgit_gui_page_db_entry.clas.abap @@ -96,7 +96,7 @@ CLASS zcl_abapgit_gui_page_db_entry IMPLEMENTATION. METHOD build_toolbar. - ro_toolbar = zcl_abapgit_html_toolbar=>create( 'database-entry' ). + ro_toolbar = zcl_abapgit_html_toolbar=>create( 'toolbar-database-entry' ). IF mv_edit_mode = abap_true. ro_toolbar->add( diff --git a/src/ui/pages/zcl_abapgit_gui_page_data.clas.abap b/src/ui/pages/zcl_abapgit_gui_page_data.clas.abap index 86cb8a6ea..5ad9314cf 100644 --- a/src/ui/pages/zcl_abapgit_gui_page_data.clas.abap +++ b/src/ui/pages/zcl_abapgit_gui_page_data.clas.abap @@ -382,7 +382,7 @@ CLASS zcl_abapgit_gui_page_data IMPLEMENTATION. METHOD zif_abapgit_gui_menu_provider~get_menu. - ro_toolbar = zcl_abapgit_html_toolbar=>create( 'advanced-data' ). + ro_toolbar = zcl_abapgit_html_toolbar=>create( 'toolbar-advanced-data' ). ro_toolbar->add( iv_txt = 'Add Via Transport' iv_act = c_event-add_via_transport ). diff --git a/src/ui/pages/zcl_abapgit_gui_page_debuginfo.clas.abap b/src/ui/pages/zcl_abapgit_gui_page_debuginfo.clas.abap index 7133636ad..b320ba6a1 100644 --- a/src/ui/pages/zcl_abapgit_gui_page_debuginfo.clas.abap +++ b/src/ui/pages/zcl_abapgit_gui_page_debuginfo.clas.abap @@ -71,7 +71,7 @@ CLASS zcl_abapgit_gui_page_debuginfo IMPLEMENTATION. METHOD build_toolbar. - ro_menu = zcl_abapgit_html_toolbar=>create( 'toolbar-debug' ). + ro_menu = zcl_abapgit_html_toolbar=>create( 'toolbar-debug-info' ). ro_menu->add( iv_txt = 'Save' diff --git a/src/ui/pages/zcl_abapgit_gui_page_repo_over.clas.abap b/src/ui/pages/zcl_abapgit_gui_page_repo_over.clas.abap index 6b79e09d3..efb693d25 100644 --- a/src/ui/pages/zcl_abapgit_gui_page_repo_over.clas.abap +++ b/src/ui/pages/zcl_abapgit_gui_page_repo_over.clas.abap @@ -510,12 +510,6 @@ CLASS zcl_abapgit_gui_page_repo_over IMPLEMENTATION. iv_class = |{ lc_action_class } { lc_offline_class }| iv_li_class = |{ lc_action_class }| ). - lo_toolbar_more_sub->add( - iv_txt = |Change Repository Package| - iv_act = |{ zif_abapgit_definitions=>c_action-repo_change_package }{ lc_dummy_key }| - iv_class = |{ lc_action_class } { lc_online_class }| - iv_li_class = |{ lc_action_class }| ). - lo_toolbar_more_sub->add( iv_txt = 'Danger' iv_typ = zif_abapgit_html=>c_action_type-separator ). diff --git a/src/ui/pages/zcl_abapgit_gui_page_repo_view.clas.abap b/src/ui/pages/zcl_abapgit_gui_page_repo_view.clas.abap index 022374aec..870b03eff 100644 --- a/src/ui/pages/zcl_abapgit_gui_page_repo_view.clas.abap +++ b/src/ui/pages/zcl_abapgit_gui_page_repo_view.clas.abap @@ -303,9 +303,6 @@ CLASS zcl_abapgit_gui_page_repo_view IMPLEMENTATION. iv_act = |{ zif_abapgit_definitions=>c_action-go_stage_transport }?key={ mv_key }| ). ENDIF. - ro_advanced_dropdown->add( iv_txt = 'Change Repository Package' - iv_act = |{ zif_abapgit_definitions=>c_action-repo_change_package }?key={ mv_key }| ). - ro_advanced_dropdown->add( iv_txt = 'Quality Assurance' iv_typ = zif_abapgit_html=>c_action_type-separator ).