Escape display name for javascript repo catalog (#6482)

src/ui/lib/zcl_abapgit_gui_chunk_lib.clas.abap

@@ -1043,7 +1043,8 @@ CLASS zcl_abapgit_gui_chunk_lib IMPLEMENTATION.
     LOOP AT lt_repo_list ASSIGNING <ls_repo>.
       lv_repo_json = |\{ key: "{ <ls_repo>-key
         }", isOffline: "{ <ls_repo>-offline
-        }", displayName: "{ <ls_repo>-local_settings-display_name }"  \}|.
+        }", displayName: "{ escape( val = <ls_repo>-local_settings-display_name
+                                    format = cl_abap_format=>e_html_js ) }"  \}|.
       IF sy-tabix < lv_size.
         lv_repo_json = lv_repo_json && ','.
       ENDIF.

src/ui/lib/zcl_abapgit_gui_chunk_lib.clas.testclasses.abap

@@ -14,7 +14,55 @@ CLASS ltcl_normalize_program_name DEFINITION FINAL FOR TESTING
 
 ENDCLASS.
 
-CLASS zcl_abapgit_gui_chunk_lib DEFINITION LOCAL FRIENDS ltcl_normalize_program_name.
+
+CLASS ltd_repo DEFINITION FINAL FOR TESTING
+  DURATION SHORT
+  RISK LEVEL HARMLESS.
+
+  PUBLIC SECTION.
+    INTERFACES zif_abapgit_repo.
+
+    DATA ms_data TYPE zif_abapgit_persistence=>ty_repo READ-ONLY.
+
+    METHODS set_display_name
+      IMPORTING !iv_display_name TYPE csequence.
+ENDCLASS.
+
+
+CLASS ltd_repo_srv DEFINITION FINAL FOR TESTING
+  DURATION SHORT
+  RISK LEVEL HARMLESS.
+
+  PUBLIC SECTION.
+    INTERFACES zif_abapgit_repo_srv.
+
+    METHODS add_repository
+      IMPORTING !iv_display_name TYPE csequence.
+
+  PRIVATE SECTION.
+    DATA mt_repositories TYPE STANDARD TABLE OF REF TO ltd_repo.
+ENDCLASS.
+
+
+CLASS ltcl_render_repo DEFINITION FINAL FOR TESTING
+  DURATION SHORT
+  RISK LEVEL HARMLESS.
+
+  PRIVATE SECTION.
+    DATA:
+      mo_chunk_lib TYPE REF TO zcl_abapgit_gui_chunk_lib.
+    DATA mo_repo_srv TYPE REF TO ltd_repo_srv.
+
+    METHODS:
+      setup,
+      render_repo_palette_display_nm FOR TESTING RAISING cx_static_check.
+
+ENDCLASS.
+
+CLASS zcl_abapgit_gui_chunk_lib DEFINITION
+  LOCAL FRIENDS ltcl_normalize_program_name
+                ltcl_render_repo.
+
 
 CLASS ltcl_normalize_program_name IMPLEMENTATION.
 
@@ -47,3 +95,185 @@ CLASS ltcl_normalize_program_name IMPLEMENTATION.
   ENDMETHOD.
 
 ENDCLASS.
+
+
+CLASS ltd_repo_srv IMPLEMENTATION.
+
+  METHOD add_repository.
+    DATA lo_new_repo TYPE REF TO ltd_repo.
+
+    CREATE OBJECT lo_new_repo.
+    lo_new_repo->set_display_name( iv_display_name ).
+
+    APPEND lo_new_repo TO mt_repositories.
+  ENDMETHOD.
+
+  METHOD zif_abapgit_repo_srv~list.
+    DATA lo_test_double_repo TYPE REF TO ltd_repo.
+    DATA lo_abapgit_repo TYPE REF TO zif_abapgit_repo.
+
+    LOOP AT mt_repositories INTO lo_test_double_repo.
+      lo_abapgit_repo ?= lo_test_double_repo.
+      APPEND lo_test_double_repo TO rt_list.
+    ENDLOOP.
+  ENDMETHOD.
+
+  METHOD zif_abapgit_repo_srv~delete.
+
+  ENDMETHOD.
+
+  METHOD zif_abapgit_repo_srv~get.
+
+  ENDMETHOD.
+
+  METHOD zif_abapgit_repo_srv~get_label_list.
+
+  ENDMETHOD.
+
+  METHOD zif_abapgit_repo_srv~get_repo_from_package.
+
+  ENDMETHOD.
+
+  METHOD zif_abapgit_repo_srv~get_repo_from_url.
+
+  ENDMETHOD.
+
+  METHOD zif_abapgit_repo_srv~init.
+
+  ENDMETHOD.
+
+  METHOD zif_abapgit_repo_srv~is_repo_installed.
+
+  ENDMETHOD.
+
+  METHOD zif_abapgit_repo_srv~list_favorites.
+
+  ENDMETHOD.
+
+  METHOD zif_abapgit_repo_srv~new_offline.
+
+  ENDMETHOD.
+
+  METHOD zif_abapgit_repo_srv~new_online.
+
+  ENDMETHOD.
+
+  METHOD zif_abapgit_repo_srv~purge.
+
+  ENDMETHOD.
+
+  METHOD zif_abapgit_repo_srv~validate_package.
+
+  ENDMETHOD.
+
+  METHOD zif_abapgit_repo_srv~validate_url.
+
+  ENDMETHOD.
+
+ENDCLASS.
+
+
+CLASS ltd_repo IMPLEMENTATION.
+
+  METHOD set_display_name.
+    ms_data-local_settings-display_name = iv_display_name.
+  ENDMETHOD.
+
+  METHOD zif_abapgit_repo~get_name.
+    rv_name = ms_data-local_settings-display_name.
+  ENDMETHOD.
+
+  METHOD zif_abapgit_repo~checksums.
+
+  ENDMETHOD.
+
+  METHOD zif_abapgit_repo~deserialize.
+
+  ENDMETHOD.
+
+  METHOD zif_abapgit_repo~deserialize_checks.
+
+  ENDMETHOD.
+
+  METHOD zif_abapgit_repo~get_dot_abapgit.
+
+  ENDMETHOD.
+
+  METHOD zif_abapgit_repo~get_files_local.
+
+  ENDMETHOD.
+
+  METHOD zif_abapgit_repo~get_files_remote.
+
+  ENDMETHOD.
+
+  METHOD zif_abapgit_repo~get_key.
+
+  ENDMETHOD.
+
+  METHOD zif_abapgit_repo~get_local_settings.
+
+  ENDMETHOD.
+
+  METHOD zif_abapgit_repo~get_package.
+
+  ENDMETHOD.
+
+  METHOD zif_abapgit_repo~is_offline.
+
+  ENDMETHOD.
+
+  METHOD zif_abapgit_repo~refresh.
+
+  ENDMETHOD.
+
+  METHOD zif_abapgit_repo~set_dot_abapgit.
+
+  ENDMETHOD.
+
+ENDCLASS.
+
+
+CLASS ltcl_render_repo IMPLEMENTATION.
+
+  METHOD setup.
+    CREATE OBJECT mo_repo_srv.
+    zcl_abapgit_repo_srv=>inject_instance( mo_repo_srv ).
+
+    CREATE OBJECT mo_chunk_lib.
+  ENDMETHOD.
+
+
+  METHOD render_repo_palette_display_nm.
+    DATA lx_abapgit TYPE REF TO zcx_abapgit_exception.
+    DATA lo_html TYPE REF TO zif_abapgit_html.
+    DATA lv_html_as_string TYPE string.
+
+    mo_repo_srv->add_repository( |Simple test| ).
+    mo_repo_srv->add_repository( |'Single' quotation marks| ).
+    mo_repo_srv->add_repository( |"Double quotation marks"| ).
+
+    TRY.
+        lo_html = mo_chunk_lib->render_repo_palette( zif_abapgit_definitions=>c_action-go_repo ).
+        lv_html_as_string = lo_html->render( ).
+
+        cl_abap_unit_assert=>assert_char_cp(
+            act = lv_html_as_string
+            exp = |*displayName: "Simple test"*| ).
+
+        cl_abap_unit_assert=>assert_char_cp(
+            act = lv_html_as_string
+            exp = |*displayName: "\\'Single\\' quotation marks"*| ).
+
+        cl_abap_unit_assert=>assert_char_cp(
+            act = lv_html_as_string
+            exp = |*displayName: "\\"Double quotation marks\\""*| ).
+
+      CATCH zcx_abapgit_exception INTO lx_abapgit.
+        cl_abap_unit_assert=>fail(
+            msg    = 'abapGit exception'
+            detail = lx_abapgit->get_text( ) ).
+    ENDTRY.
+  ENDMETHOD.
+
+ENDCLASS.