SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Small refactorings (#3033)

Browse Source 
* remove unusued variables

* surround "recover_version" calls with try-catch
This commit is contained in:
g-back 2019-11-05 08:09:47 +01:00 committed by Lars Hvam
parent a9fee4f863
commit 7c05815437
2 changed files with 33 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/objects/zcl_abapgit_object_iaxu.clas.abap
View File

@ -84,8 +84,7 @@ CLASS zcl_abapgit_object_iaxu IMPLEMENTATION.
METHOD zif_abapgit_object~delete. METHOD zif_abapgit_object~delete.
DATA: lo_xml_api TYPE REF TO cl_w3_api_xml3, DATA: lo_xml_api TYPE REF TO cl_w3_api_xml3,
ls_name TYPE iacikeyt, ls_name TYPE iacikeyt.
lx_root TYPE REF TO zcx_abapgit_exception.
ls_name = ms_item-obj_name. ls_name = ms_item-obj_name.
@ -124,9 +123,7 @@ CLASS zcl_abapgit_object_iaxu IMPLEMENTATION.
METHOD zif_abapgit_object~exists. METHOD zif_abapgit_object~exists.
DATA: ls_name TYPE iacikeyt, DATA: ls_name TYPE iacikeyt.
lv_subrc TYPE sysubrc,
lx_exc TYPE REF TO zcx_abapgit_exception.
ls_name = ms_item-obj_name. ls_name = ms_item-obj_name.

50
src/objects/zcl_abapgit_object_wdyn.clas.abap
View File

@ -69,7 +69,7 @@ ENDCLASS.
CLASS ZCL_ABAPGIT_OBJECT_WDYN IMPLEMENTATION. CLASS zcl_abapgit_object_wdyn IMPLEMENTATION.
METHOD add_fm_exception. METHOD add_fm_exception.
@ -646,12 +646,16 @@ CLASS ZCL_ABAPGIT_OBJECT_WDYN IMPLEMENTATION.
ls_key-component_name = is_controller-definition-component_name. ls_key-component_name = is_controller-definition-component_name.
ls_key-controller_name = is_controller-definition-controller_name. ls_key-controller_name = is_controller-definition-controller_name.
cl_wdy_md_controller=>recover_version( TRY.
EXPORTING cl_wdy_md_controller=>recover_version(
controller_key = ls_key EXPORTING
delta = ls_delta-wdyc controller_key = ls_key
CHANGING delta = ls_delta-wdyc
corrnr = lv_corrnr ). CHANGING
corrnr = lv_corrnr ).
CATCH cx_wdy_md_exception.
zcx_abapgit_exception=>raise( 'error recovering version of controller' ).
ENDTRY.
ENDMETHOD. ENDMETHOD.
@ -669,12 +673,16 @@ CLASS ZCL_ABAPGIT_OBJECT_WDYN IMPLEMENTATION.
ls_key-component_name = is_definition-definition-component_name. ls_key-component_name = is_definition-definition-component_name.
cl_wdy_md_component=>recover_version( TRY.
EXPORTING cl_wdy_md_component=>recover_version(
component_key = ls_key EXPORTING
delta = ls_delta-wdyd component_key = ls_key
CHANGING delta = ls_delta-wdyd
corrnr = lv_corrnr ). CHANGING
corrnr = lv_corrnr ).
CATCH cx_wdy_md_exception.
zcx_abapgit_exception=>raise( 'error recovering version of component' ).
ENDTRY.
ENDMETHOD. ENDMETHOD.
@ -690,12 +698,16 @@ CLASS ZCL_ABAPGIT_OBJECT_WDYN IMPLEMENTATION.
ls_key-component_name = is_view-definition-component_name. ls_key-component_name = is_view-definition-component_name.
ls_key-view_name = is_view-definition-view_name. ls_key-view_name = is_view-definition-view_name.
cl_wdy_md_abstract_view=>recover_version( TRY.
EXPORTING cl_wdy_md_abstract_view=>recover_version(
view_key = ls_key EXPORTING
delta = ls_delta-wdyv view_key = ls_key
CHANGING delta = ls_delta-wdyv
corrnr = lv_corrnr ). CHANGING
corrnr = lv_corrnr ).
CATCH cx_wdy_md_exception.
zcx_abapgit_exception=>raise( 'error recovering version of abstract view' ).
ENDTRY.
ENDMETHOD. ENDMETHOD.