SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-04-30 20:03:20 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

extract calls to SUSR_USER_ADDRESS_READ (#6204)

Browse Source 
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
This commit is contained in:
Lars Hvam 2023-04-12 07:06:39 +02:00 committed by GitHub
parent c2d74685d5
commit 80b3c74ce7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 30 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/ui/lib/zcl_abapgit_gui_chunk_lib.clas.abap
View File

@ -1287,7 +1287,6 @@ CLASS zcl_abapgit_gui_chunk_lib IMPLEMENTATION.
METHOD render_user_name.
DATA:
ls_user_address TYPE addr3_val,
lv_title TYPE string,
lv_jump TYPE string.
@ -1298,17 +1297,7 @@ CLASS zcl_abapgit_gui_chunk_lib IMPLEMENTATION.
ENDIF.
IF iv_username <> zcl_abapgit_objects_super=>c_user_unknown AND iv_suppress_title = abap_false.
CALL FUNCTION 'SUSR_USER_ADDRESS_READ'
EXPORTING
user_name = iv_username
IMPORTING
user_address = ls_user_address
EXCEPTIONS
user_address_not_found = 1
OTHERS = 2.
IF sy-subrc = 0.
lv_title = ls_user_address-name_text.
ENDIF.
lv_title = zcl_abapgit_user_record=>get_title( iv_username ).
ENDIF.
lv_jump = |{ zif_abapgit_definitions=>c_action-jump_user }?user={ iv_username }|.

16
src/ui/pages/zcl_abapgit_gui_page_sett_info.clas.abap
View File

@ -189,9 +189,7 @@ CLASS zcl_abapgit_gui_page_sett_info IMPLEMENTATION.
METHOD format_user.
DATA:
ls_user_address TYPE addr3_val,
lv_title TYPE string.
DATA lv_title TYPE string.
IF iv_username IS INITIAL.
rv_user = 'n/a'.
@ -199,17 +197,7 @@ CLASS zcl_abapgit_gui_page_sett_info IMPLEMENTATION.
ENDIF.
IF iv_username <> zcl_abapgit_objects_super=>c_user_unknown.
CALL FUNCTION 'SUSR_USER_ADDRESS_READ'
EXPORTING
user_name = iv_username
IMPORTING
user_address = ls_user_address
EXCEPTIONS
user_address_not_found = 1
OTHERS = 2.
IF sy-subrc = 0.
lv_title = ls_user_address-name_text.
ENDIF.
lv_title = zcl_abapgit_user_record=>get_title( iv_username ).
ENDIF.
rv_user = iv_username.

31
src/utils/zcl_abapgit_user_record.clas.abap
View File

@ -4,9 +4,6 @@ CLASS zcl_abapgit_user_record DEFINITION
CREATE PRIVATE.
PUBLIC SECTION.
CONSTANTS c_cc_category TYPE string VALUE 'C'.
CLASS-METHODS reset.
CLASS-METHODS get_instance
IMPORTING
@ -22,6 +19,11 @@ CLASS zcl_abapgit_user_record DEFINITION
METHODS get_email
RETURNING
VALUE(rv_email) TYPE zif_abapgit_git_definitions=>ty_git_user-email.
CLASS-METHODS get_title
IMPORTING
iv_username TYPE sy-uname
RETURNING
VALUE(rv_title) TYPE string.
PROTECTED SECTION.
PRIVATE SECTION.
TYPES:
@ -62,6 +64,25 @@ ENDCLASS.
CLASS zcl_abapgit_user_record IMPLEMENTATION.
METHOD get_title.
* the queried username might not exist, so this method is static
DATA ls_user_address TYPE addr3_val.
CALL FUNCTION 'SUSR_USER_ADDRESS_READ'
EXPORTING
user_name = iv_username
IMPORTING
user_address = ls_user_address
EXCEPTIONS
user_address_not_found = 1
OTHERS = 2.
IF sy-subrc = 0.
rv_title = ls_user_address-name_text.
ENDIF.
ENDMETHOD.
METHOD check_user_exists.
DATA lt_return TYPE STANDARD TABLE OF bapiret2 WITH DEFAULT KEY.
@ -156,13 +177,15 @@ CLASS zcl_abapgit_user_record IMPLEMENTATION.
METHOD get_user_dtls_from_other_clnt.
CONSTANTS lc_cc_category TYPE string VALUE 'C'.
DATA lt_dev_clients TYPE ty_dev_clients.
FIELD-SYMBOLS: <lv_dev_client> LIKE LINE OF lt_dev_clients.
" Could not find the user Try other development clients
SELECT mandt FROM t000 INTO TABLE lt_dev_clients
WHERE cccategory = c_cc_category AND mandt <> sy-mandt
WHERE cccategory = lc_cc_category AND mandt <> sy-mandt
ORDER BY PRIMARY KEY.
LOOP AT lt_dev_clients ASSIGNING <lv_dev_client>.