From 8196ae54bb2899f693356fd5984c54c929950e7a Mon Sep 17 00:00:00 2001
From: Marc Bernard <marc@marcbernardtools.com>
Date: Mon, 31 Mar 2025 19:48:57 +0000
Subject: [PATCH] Remove http-agent from factory

Using the http-agent class as singleton has side-effects (http-headers). Creating the instance from the http-agent class works fine.

If you used this factory method somewhere else, replace it with `zcl_abapgit_http_agent=>create( ).`.
---
 .../zcl_abapgit_pr_enumerator.clas.abap           |  2 +-
 src/zcl_abapgit_factory.clas.abap                 | 15 ---------------
 src/zcl_abapgit_injector.clas.abap                |  8 --------
 3 files changed, 1 insertion(+), 24 deletions(-)

diff --git a/src/git_platform/zcl_abapgit_pr_enumerator.clas.abap b/src/git_platform/zcl_abapgit_pr_enumerator.clas.abap
index dadea98c5..201cacb0a 100644
--- a/src/git_platform/zcl_abapgit_pr_enumerator.clas.abap
+++ b/src/git_platform/zcl_abapgit_pr_enumerator.clas.abap
@@ -62,7 +62,7 @@ CLASS zcl_abapgit_pr_enumerator IMPLEMENTATION.
     DATA lv_user TYPE string.
     DATA lv_repo TYPE string.
 
-    li_agent = zcl_abapgit_factory=>get_http_agent( ).
+    li_agent = zcl_abapgit_http_agent=>create( ).
 
     FIND ALL OCCURRENCES OF REGEX 'github\.com\/([^\/]+)\/([^\/]+)'
       IN iv_repo_url
diff --git a/src/zcl_abapgit_factory.clas.abap b/src/zcl_abapgit_factory.clas.abap
index edab35a26..b737a8dd5 100644
--- a/src/zcl_abapgit_factory.clas.abap
+++ b/src/zcl_abapgit_factory.clas.abap
@@ -27,9 +27,6 @@ CLASS zcl_abapgit_factory DEFINITION
     CLASS-METHODS get_longtexts
       RETURNING
         VALUE(ri_longtexts) TYPE REF TO zif_abapgit_longtexts .
-    CLASS-METHODS get_http_agent
-      RETURNING
-        VALUE(ri_http_agent) TYPE REF TO zif_abapgit_http_agent .
     CLASS-METHODS get_lxe_texts
       RETURNING
         VALUE(ri_lxe_texts) TYPE REF TO zif_abapgit_lxe_texts .
@@ -59,7 +56,6 @@ CLASS zcl_abapgit_factory DEFINITION
     CLASS-DATA gi_cts_api TYPE REF TO zif_abapgit_cts_api .
     CLASS-DATA gi_environment TYPE REF TO zif_abapgit_environment .
     CLASS-DATA gi_longtext TYPE REF TO zif_abapgit_longtexts .
-    CLASS-DATA gi_http_agent TYPE REF TO zif_abapgit_http_agent .
     CLASS-DATA gi_lxe_texts TYPE REF TO zif_abapgit_lxe_texts .
     CLASS-DATA gi_sap_namespace TYPE REF TO zif_abapgit_sap_namespace .
     CLASS-DATA gi_sap_report TYPE REF TO zif_abapgit_sap_report.
@@ -111,17 +107,6 @@ CLASS zcl_abapgit_factory IMPLEMENTATION.
   ENDMETHOD.
 
 
-  METHOD get_http_agent.
-
-    IF gi_http_agent IS INITIAL.
-      gi_http_agent = zcl_abapgit_http_agent=>create( ).
-    ENDIF.
-
-    ri_http_agent = gi_http_agent.
-
-  ENDMETHOD.
-
-
   METHOD get_longtexts.
 
     IF gi_longtext IS NOT BOUND.
diff --git a/src/zcl_abapgit_injector.clas.abap b/src/zcl_abapgit_injector.clas.abap
index 2261c7d8c..127b7718b 100644
--- a/src/zcl_abapgit_injector.clas.abap
+++ b/src/zcl_abapgit_injector.clas.abap
@@ -21,9 +21,6 @@ CLASS zcl_abapgit_injector DEFINITION
     CLASS-METHODS set_longtexts
       IMPORTING
         !ii_longtexts TYPE REF TO zif_abapgit_longtexts .
-    CLASS-METHODS set_http_agent
-      IMPORTING
-        !ii_http_agent TYPE REF TO zif_abapgit_http_agent .
     CLASS-METHODS set_lxe_texts
       IMPORTING
         !ii_lxe_texts TYPE REF TO zif_abapgit_lxe_texts .
@@ -68,11 +65,6 @@ CLASS zcl_abapgit_injector IMPLEMENTATION.
   ENDMETHOD.
 
 
-  METHOD set_http_agent.
-    zcl_abapgit_factory=>gi_http_agent = ii_http_agent.
-  ENDMETHOD.
-
-
   METHOD set_longtexts.
     zcl_abapgit_factory=>gi_longtext = ii_longtexts.
   ENDMETHOD.