SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

cleanup and style changes

Browse Source 
pretty printer
remove unused variables
cleanup
This commit is contained in:
larshp 2016-12-29 12:45:16 +00:00
parent b72623e09d
commit 81c2025fac
27 changed files with 504 additions and 534 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/zabapgit_definitions.prog.abap
View File

@ -14,8 +14,11 @@ TYPES: BEGIN OF ty_file_signature,
sha1 TYPE ty_sha1, sha1 TYPE ty_sha1,
END OF ty_file_signature. END OF ty_file_signature.
TYPES: ty_file_signatures_tt TYPE STANDARD TABLE OF ty_file_signature WITH DEFAULT KEY. TYPES: ty_file_signatures_tt TYPE STANDARD TABLE OF
TYPES: ty_file_signatures_ts TYPE SORTED TABLE OF ty_file_signature WITH UNIQUE KEY path filename. ty_file_signature WITH DEFAULT KEY.
TYPES: ty_file_signatures_ts TYPE SORTED TABLE OF
ty_file_signature WITH UNIQUE KEY path filename.
TYPES: BEGIN OF ty_file. TYPES: BEGIN OF ty_file.
INCLUDE TYPE ty_file_signature. INCLUDE TYPE ty_file_signature.
@ -24,7 +27,6 @@ TYPES: data TYPE xstring,
TYPES: ty_files_tt TYPE STANDARD TABLE OF ty_file WITH DEFAULT KEY. TYPES: ty_files_tt TYPE STANDARD TABLE OF ty_file WITH DEFAULT KEY.
TYPES: ty_string_tt TYPE STANDARD TABLE OF string WITH DEFAULT KEY. TYPES: ty_string_tt TYPE STANDARD TABLE OF string WITH DEFAULT KEY.
TYPES: tt_w3urls TYPE STANDARD TABLE OF w3url WITH DEFAULT KEY.
TYPES: BEGIN OF ty_comment, TYPES: BEGIN OF ty_comment,
username TYPE string, username TYPE string,

6
src/zabapgit_file_status.prog.abap
View File

@ -193,7 +193,8 @@ CLASS lcl_file_status IMPLEMENTATION.
" Match against current state " Match against current state
READ TABLE it_state INTO ls_file_sig READ TABLE it_state INTO ls_file_sig
WITH KEY path = is_local-file-path filename = is_local-file-filename WITH KEY path = is_local-file-path
filename = is_local-file-filename
BINARY SEARCH. BINARY SEARCH.
IF sy-subrc = 0. IF sy-subrc = 0.
@ -203,7 +204,8 @@ CLASS lcl_file_status IMPLEMENTATION.
IF ls_file_sig-sha1 <> is_remote-sha1. IF ls_file_sig-sha1 <> is_remote-sha1.
rs_result-rstate = gc_state-modified. rs_result-rstate = gc_state-modified.
ENDIF. ENDIF.
rs_result-match = boolc( rs_result-lstate IS INITIAL AND rs_result-rstate IS INITIAL ). rs_result-match = boolc( rs_result-lstate IS INITIAL
AND rs_result-rstate IS INITIAL ).
ELSE. ELSE.
" This is a strange situation. As both local and remote exist " This is a strange situation. As both local and remote exist
" the state should also be present. Maybe this is a first run of the code. " the state should also be present. Maybe this is a first run of the code.

9
src/zabapgit_git.prog.abap
View File

@ -337,7 +337,8 @@ CLASS lcl_git_transport IMPLEMENTATION.
LOOP AT lt_branches FROM 1 ASSIGNING <ls_branch>. LOOP AT lt_branches FROM 1 ASSIGNING <ls_branch>.
IF sy-tabix = 1. IF sy-tabix = 1.
lv_capa = 'side-band-64k no-progress multi_ack agent=' && lcl_http=>get_agent( ) ##NO_TEXT. lv_capa = 'side-band-64k no-progress multi_ack agent='
&& lcl_http=>get_agent( ) ##NO_TEXT.
lv_line = 'want' && ` ` && <ls_branch>-sha1 lv_line = 'want' && ` ` && <ls_branch>-sha1
&& ` ` && lv_capa && gc_newline. "#EC NOTEXT && ` ` && lv_capa && gc_newline. "#EC NOTEXT
ELSE. ELSE.
@ -348,14 +349,16 @@ CLASS lcl_git_transport IMPLEMENTATION.
ENDLOOP. ENDLOOP.
IF iv_deepen = abap_true. IF iv_deepen = abap_true.
lv_buffer = lv_buffer && lcl_git_utils=>pkt_string( 'deepen 1' && gc_newline ). "#EC NOTEXT lv_buffer = lv_buffer && lcl_git_utils=>pkt_string( 'deepen 1'
&& gc_newline ). "#EC NOTEXT
ENDIF. ENDIF.
lv_buffer = lv_buffer lv_buffer = lv_buffer
&& '0000' && '0000'
&& '0009done' && gc_newline. && '0009done' && gc_newline.
lv_xstring = lo_client->send_receive_close( lcl_convert=>string_to_xstring_utf8( lv_buffer ) ). lv_xstring = lo_client->send_receive_close(
lcl_convert=>string_to_xstring_utf8( lv_buffer ) ).
parse( IMPORTING ev_pack = lv_pack parse( IMPORTING ev_pack = lv_pack
CHANGING cv_data = lv_xstring ). CHANGING cv_data = lv_xstring ).

6
src/zabapgit_git_helpers.prog.abap
View File

@ -273,9 +273,9 @@ CLASS lcl_git_branch_list IMPLEMENTATION.
ENDIF. ENDIF.
IF iv_branch_name CP 'refs/pull/*' IF iv_branch_name CP 'refs/pull/*'
OR iv_branch_name CP 'refs/merge-requests/*' OR iv_branch_name CP 'refs/merge-requests/*'
OR iv_branch_name CP 'refs/keep-around/*' OR iv_branch_name CP 'refs/keep-around/*'
OR iv_branch_name CP 'refs/tmp/*'. OR iv_branch_name CP 'refs/tmp/*'.
rv_ignore = abap_true. rv_ignore = abap_true.
ENDIF. ENDIF.

16
src/zabapgit_gui_asset_manager.prog.abap
View File

@ -108,11 +108,7 @@ CLASS lcl_gui_asset_manager IMPLEMENTATION.
TABLES TABLES
binary_tab = lt_w3mime binary_tab = lt_w3mime
EXCEPTIONS EXCEPTIONS
failed = 1. failed = 1 ##FM_SUBRC_OK.
IF sy-subrc IS NOT INITIAL.
RETURN.
ENDIF.
ENDMETHOD. " get_mime_asset. ENDMETHOD. " get_mime_asset.
@ -136,10 +132,6 @@ CLASS lcl_gui_asset_manager IMPLEMENTATION.
ENDMETHOD. " get_images. ENDMETHOD. " get_images.
DEFINE _inline.
APPEND &1 TO lt_data.
END-OF-DEFINITION.
METHOD get_inline_asset. METHOD get_inline_asset.
DATA: lt_data TYPE ty_string_tt, DATA: lt_data TYPE ty_string_tt,
@ -158,11 +150,11 @@ CLASS lcl_gui_asset_manager IMPLEMENTATION.
CALL FUNCTION 'SCMS_STRING_TO_XSTRING' CALL FUNCTION 'SCMS_STRING_TO_XSTRING'
EXPORTING EXPORTING
text = lv_str text = lv_str
IMPORTING IMPORTING
buffer = rv_data buffer = rv_data
EXCEPTIONS EXCEPTIONS
OTHERS = 1. OTHERS = 1.
ASSERT sy-subrc = 0. ASSERT sy-subrc = 0.
ENDMETHOD. " get_inline_asset. ENDMETHOD. " get_inline_asset.

2
src/zabapgit_html.prog.abap
View File

@ -93,7 +93,7 @@ CLASS lcl_html_helper IMPLEMENTATION.
FIND FIRST OCCURRENCE OF '}' IN iv_str MATCH OFFSET lv_close_offs. " Find close } @beginning FIND FIRST OCCURRENCE OF '}' IN iv_str MATCH OFFSET lv_close_offs. " Find close } @beginning
IF ( mv_within_style > 0 OR mv_within_js > 0 ) IF ( mv_within_style > 0 OR mv_within_js > 0 )
AND sy-subrc = 0 AND lv_close_offs = 0 AND mv_indent > 0. AND sy-subrc = 0 AND lv_close_offs = 0 AND mv_indent > 0.
lv_shift_back = 1. lv_shift_back = 1.
ENDIF. ENDIF.

16
src/zabapgit_migrations.prog.abap
View File

@ -46,7 +46,7 @@ CLASS lcl_migrations IMPLEMENTATION.
" Ignore empty repos or repos with file checksums " Ignore empty repos or repos with file checksums
IF lines( <repo>->get_local_checksums( ) ) = 0 IF lines( <repo>->get_local_checksums( ) ) = 0
OR lines( <repo>->get_local_checksums_per_file( ) ) > 0 . OR lines( <repo>->get_local_checksums_per_file( ) ) > 0.
DELETE lt_repos INDEX lv_index. DELETE lt_repos INDEX lv_index.
CONTINUE. CONTINUE.
ENDIF. ENDIF.
@ -61,13 +61,13 @@ CLASS lcl_migrations IMPLEMENTATION.
SHIFT lv_repo_list BY 2 PLACES LEFT. " Remove leading ', ' SHIFT lv_repo_list BY 2 PLACES LEFT. " Remove leading ', '
lv_question = 'abapGit wants to rebuild missing local checksums' lv_question = 'abapGit wants to rebuild missing local checksums'
&& ' (changes from 2016-12-11).' && ' (changes from 2016-12-11).'
&& ' Generally this is safe except if there are both local ' && ' Generally this is safe except if there are both local '
&& ' and remote changes at the same time. If unsure, please' && ' and remote changes at the same time. If unsure, please'
&& ' skip and update repos individually' && ' skip and update repos individually'
&& ' by "Advances/Update local checksums" command.' && ' by "Advances/Update local checksums" command.'
&& | Repos affected: { lv_repo_list }|. && | Repos affected: { lv_repo_list }|.
lv_answer = lcl_popups=>popup_to_confirm( lv_answer = lcl_popups=>popup_to_confirm(
titlebar = 'Warning' titlebar = 'Warning'

17
src/zabapgit_object_clas.prog.abap
View File

@ -1114,11 +1114,7 @@ CLASS lcl_object_clas IMPLEMENTATION.
METHOD deserialize_sotr. METHOD deserialize_sotr.
"OTR stands for Online Text Repository "OTR stands for Online Text Repository
DATA: lt_sotr TYPE ty_sotr_tt, DATA: lt_sotr TYPE ty_sotr_tt,
lt_objects TYPE sotr_objects, lt_objects TYPE sotr_objects.
ls_paket TYPE sotr_pack,
lv_object LIKE LINE OF lt_objects.
FIELD-SYMBOLS: <ls_sotr> LIKE LINE OF lt_sotr.
io_xml->read( EXPORTING iv_name = 'SOTR' io_xml->read( EXPORTING iv_name = 'SOTR'
@ -1155,8 +1151,7 @@ CLASS lcl_object_clas IMPLEMENTATION.
METHOD deserialize_tpool. METHOD deserialize_tpool.
DATA: lv_cp TYPE program, DATA: lv_clsname TYPE seoclsname,
lv_clsname TYPE seoclsname,
lt_tpool_ext TYPE ty_tpool_tt, lt_tpool_ext TYPE ty_tpool_tt,
lt_tpool TYPE textpool_table. lt_tpool TYPE textpool_table.
@ -1279,10 +1274,10 @@ CLASS lcl_object_intf IMPLEMENTATION.
CHANGING cg_data = ls_vseointerf ). CHANGING cg_data = ls_vseointerf ).
mo_object_oriented_object->create( mo_object_oriented_object->create(
EXPORTING EXPORTING
iv_package = iv_package iv_package = iv_package
CHANGING CHANGING
is_properties = ls_vseointerf ). is_properties = ls_vseointerf ).
mo_object_oriented_object->deserialize_source( mo_object_oriented_object->deserialize_source(
is_key = ls_clskey is_key = ls_clskey

8
src/zabapgit_object_shi3.prog.abap
View File

@ -158,6 +158,7 @@ CLASS lcl_object_shi3 IMPLEMENTATION.
lt_texts TYPE TABLE OF hier_texts, lt_texts TYPE TABLE OF hier_texts,
lt_refs TYPE TABLE OF hier_ref. lt_refs TYPE TABLE OF hier_ref.
CALL FUNCTION 'STREE_STRUCTURE_READ' CALL FUNCTION 'STREE_STRUCTURE_READ'
EXPORTING EXPORTING
structure_id = mv_tree_id structure_id = mv_tree_id
@ -167,10 +168,6 @@ CLASS lcl_object_shi3 IMPLEMENTATION.
TABLES TABLES
description = lt_titles. description = lt_titles.
IF sy-subrc <> 0.
lcx_exception=>raise( 'Error from STREE_STRUCTURE_READ, SHI3' ).
ENDIF.
CALL FUNCTION 'STREE_HIERARCHY_READ' CALL FUNCTION 'STREE_HIERARCHY_READ'
EXPORTING EXPORTING
structure_id = mv_tree_id structure_id = mv_tree_id
@ -182,9 +179,6 @@ CLASS lcl_object_shi3 IMPLEMENTATION.
list_of_nodes = lt_nodes list_of_nodes = lt_nodes
list_of_references = lt_refs list_of_references = lt_refs
list_of_texts = lt_texts. list_of_texts = lt_texts.
IF sy-subrc <> 0.
lcx_exception=>raise( 'Error from STREE_HIERARCHY_READ, SHI3' ).
ENDIF.
strip_stamps( CHANGING cs_head = ls_head strip_stamps( CHANGING cs_head = ls_head
ct_nodes = lt_nodes ). ct_nodes = lt_nodes ).

6
src/zabapgit_object_tabl_valid.prog.abap
View File

@ -187,9 +187,6 @@ CLASS lct_table_validation IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD no_fields_no_message. METHOD no_fields_no_message.
DATA:
ls_current_table_field LIKE LINE OF mt_current_table_fields.
create_xmls( ). create_xmls( ).
mv_validation_message = mo_table_validator->validate( mv_validation_message = mo_table_validator->validate(
@ -199,7 +196,6 @@ CLASS lct_table_validation IMPLEMENTATION.
cl_abap_unit_assert=>assert_initial( mv_validation_message ). cl_abap_unit_assert=>assert_initial( mv_validation_message ).
ENDMETHOD. ENDMETHOD.
METHOD create_xmls. METHOD create_xmls.
CREATE OBJECT mo_previous_version_out_xml. CREATE OBJECT mo_previous_version_out_xml.
mo_previous_version_out_xml->add( mo_previous_version_out_xml->add(
@ -220,6 +216,4 @@ CLASS lct_table_validation IMPLEMENTATION.
iv_xml = mo_current_version_out_xml->render( ). iv_xml = mo_current_version_out_xml->render( ).
ENDMETHOD. ENDMETHOD.
ENDCLASS. ENDCLASS.

3
src/zabapgit_object_tran.prog.abap
View File

@ -243,8 +243,7 @@ CLASS lcl_object_tran IMPLEMENTATION.
communication_failure = 2 communication_failure = 2
resource_failure = 3 resource_failure = 3
OTHERS = 4 OTHERS = 4
##fm_subrc_ok ##fm_subrc_ok. "#EC CI_SUBRC
. "#EC CI_SUBRC
ENDMETHOD. "jump ENDMETHOD. "jump

768
src/zabapgit_object_wdyn.prog.abap
View File

File diff suppressed because it is too large Load Diff

9
src/zabapgit_objects.prog.abap
View File

@ -187,7 +187,7 @@ ENDCLASS. "lcl_objects_activation IMPLEMENTATION
*----------------------------------------------------------------------* *----------------------------------------------------------------------*
* *
*----------------------------------------------------------------------* *----------------------------------------------------------------------*
CLASS lcl_objects_files DEFINITION . CLASS lcl_objects_files DEFINITION.
PUBLIC SECTION. PUBLIC SECTION.
METHODS: METHODS:
@ -1705,9 +1705,9 @@ CLASS lcl_objects DEFINITION FINAL.
CLASS-METHODS supported_list CLASS-METHODS supported_list
RETURNING VALUE(rt_types) TYPE ty_types_tt. RETURNING VALUE(rt_types) TYPE ty_types_tt.
CLASS-METHODS is_language_installed * CLASS-METHODS is_language_installed
IMPORTING iv_language TYPE langu * IMPORTING iv_language TYPE langu
RETURNING VALUE(rv_yes) TYPE abap_bool. * RETURNING VALUE(rv_yes) TYPE abap_bool.
PRIVATE SECTION. PRIVATE SECTION.
@ -1747,7 +1747,6 @@ CLASS lcl_objects DEFINITION FINAL.
RAISING lcx_exception. RAISING lcx_exception.
CLASS-METHODS warning_overwrite CLASS-METHODS warning_overwrite
IMPORTING io_repo TYPE REF TO lcl_repo
CHANGING ct_results TYPE ty_results_tt CHANGING ct_results TYPE ty_results_tt
RAISING lcx_exception. RAISING lcx_exception.

31
src/zabapgit_objects_impl.prog.abap
View File

@ -207,17 +207,17 @@ CLASS lcl_objects IMPLEMENTATION.
ENDMETHOD. "supported_list ENDMETHOD. "supported_list
METHOD is_language_installed. * METHOD is_language_installed.
*
IF mv_langs_installed IS INITIAL. * IF mv_langs_installed IS INITIAL.
CALL FUNCTION 'RSAQ_READ_INSTALLED_LANGUAGES' * CALL FUNCTION 'RSAQ_READ_INSTALLED_LANGUAGES'
IMPORTING * IMPORTING
inst_languages = mv_langs_installed. * inst_languages = mv_langs_installed.
ENDIF. * ENDIF.
*
rv_yes = boolc( mv_langs_installed CA iv_language ). * rv_yes = boolc( mv_langs_installed CA iv_language ).
*
ENDMETHOD. "is_language_installed * ENDMETHOD. "is_language_installed
METHOD exists. METHOD exists.
@ -616,8 +616,7 @@ CLASS lcl_objects IMPLEMENTATION.
lt_results = prioritize_deser( lt_results ). lt_results = prioritize_deser( lt_results ).
warning_overwrite( EXPORTING io_repo = io_repo warning_overwrite( CHANGING ct_results = lt_results ).
CHANGING ct_results = lt_results ).
LOOP AT lt_results ASSIGNING <ls_result> WHERE obj_type IS NOT INITIAL LOOP AT lt_results ASSIGNING <ls_result> WHERE obj_type IS NOT INITIAL
AND NOT ( lstate = gc_state-added AND rstate IS INITIAL ). AND NOT ( lstate = gc_state-added AND rstate IS INITIAL ).
@ -656,9 +655,9 @@ CLASS lcl_objects IMPLEMENTATION.
is_metadata = lo_xml->get_metadata( ) ). is_metadata = lo_xml->get_metadata( ) ).
compare_remote_to_local( compare_remote_to_local(
io_object = li_obj io_object = li_obj
it_remote = lt_remote it_remote = lt_remote
is_result = <ls_result> ). is_result = <ls_result> ).
li_obj->mo_files = lo_files. li_obj->mo_files = lo_files.

1
src/zabapgit_page.prog.abap
View File

@ -53,7 +53,6 @@ CLASS lcl_gui_page_super DEFINITION ABSTRACT.
RAISING lcx_exception. RAISING lcx_exception.
METHODS header METHODS header
IMPORTING io_include_style TYPE REF TO lcl_html_helper OPTIONAL
RETURNING VALUE(ro_html) TYPE REF TO lcl_html_helper. RETURNING VALUE(ro_html) TYPE REF TO lcl_html_helper.
METHODS footer METHODS footer

8
src/zabapgit_page_debug.prog.abap
View File

@ -8,11 +8,11 @@ CLASS lcl_gui_page_debuginfo DEFINITION FINAL INHERITING FROM lcl_gui_page_super
PRIVATE SECTION. PRIVATE SECTION.
METHODS scripts METHODS scripts
RETURNING VALUE(ro_html) TYPE REF TO lcl_html_helper. RETURNING VALUE(ro_html) TYPE REF TO lcl_html_helper.
METHODS render_debug_info METHODS render_debug_info
RETURNING VALUE(ro_html) TYPE REF TO lcl_html_helper. RETURNING VALUE(ro_html) TYPE REF TO lcl_html_helper.
METHODS render_supported_object_types METHODS render_supported_object_types
RETURNING VALUE(rv_html) TYPE string. RETURNING VALUE(rv_html) TYPE string.
ENDCLASS. "lcl_gui_page_debuginfo ENDCLASS. "lcl_gui_page_debuginfo
@ -69,7 +69,7 @@ CLASS lcl_gui_page_debuginfo IMPLEMENTATION.
TABLES TABLES
wt_object_text = lt_objects wt_object_text = lt_objects
EXCEPTIONS EXCEPTIONS
OTHERS = 1. OTHERS = 1 ##FM_SUBRC_OK.
LOOP AT lt_objects ASSIGNING <object> WHERE pgmid = 'R3TR'. LOOP AT lt_objects ASSIGNING <object> WHERE pgmid = 'R3TR'.
ls_item-obj_type = <object>-object. ls_item-obj_type = <object>-object.

7
src/zabapgit_page_diff.prog.abap
View File

@ -93,10 +93,9 @@ CLASS lcl_gui_page_diff IMPLEMENTATION.
ELSEIF is_object IS NOT INITIAL. " Diff for whole object ELSEIF is_object IS NOT INITIAL. " Diff for whole object
LOOP AT lt_status ASSIGNING <ls_status> LOOP AT lt_status ASSIGNING <ls_status>
WHERE obj_type = is_object-obj_type WHERE obj_type = is_object-obj_type
AND obj_name = is_object-obj_name AND obj_name = is_object-obj_name
AND match IS INITIAL. AND match IS INITIAL.
append_diff( it_remote = lt_remote append_diff( it_remote = lt_remote
it_local = lt_local it_local = lt_local
is_status = <ls_status> ). is_status = <ls_status> ).

12
src/zabapgit_page_main.prog.abap
View File

@ -137,14 +137,12 @@ CLASS lcl_gui_page_main IMPLEMENTATION.
IF lines( lt_repos ) = 0 AND lx_error IS INITIAL. IF lines( lt_repos ) = 0 AND lx_error IS INITIAL.
ro_html->add( render_explore( ) ). ro_html->add( render_explore( ) ).
ELSEIF mv_show IS INITIAL.
CREATE OBJECT lo_tutorial.
ro_html->add( lo_tutorial->lif_gui_page~render( ) ).
ELSE. ELSE.
IF mv_show IS INITIAL. lo_repo = lcl_app=>repo_srv( )->get( mv_show ).
CREATE OBJECT lo_tutorial. ro_html->add( render_repo( lo_repo ) ).
ro_html->add( lo_tutorial->lif_gui_page~render( ) ).
ELSE.
lo_repo = lcl_app=>repo_srv( )->get( mv_show ).
ro_html->add( render_repo( lo_repo ) ).
ENDIF.
ENDIF. ENDIF.
ro_html->add( footer( ) ). ro_html->add( footer( ) ).

12
src/zabapgit_persistence.prog.abap
View File

@ -1432,14 +1432,12 @@ CLASS lcl_settings DEFINITION FINAL.
METHODS METHODS
get_run_critical_tests get_run_critical_tests
RETURNING VALUE(rv_run) TYPE abap_bool. RETURNING VALUE(rv_run) TYPE abap_bool.
PROTECTED SECTION.
PRIVATE SECTION. PRIVATE SECTION.
DATA mv_proxy_url TYPE string. DATA mv_proxy_url TYPE string.
DATA mv_proxy_port TYPE string. DATA mv_proxy_port TYPE string.
DATA mv_run_critical_tests TYPE abap_bool. DATA mv_run_critical_tests TYPE abap_bool.
ENDCLASS. ENDCLASS.
CLASS lcl_settings IMPLEMENTATION. CLASS lcl_settings IMPLEMENTATION.
@ -1484,10 +1482,6 @@ CLASS lcl_persistence_settings DEFINITION FINAL.
RETURNING RETURNING
VALUE(ro_settings) TYPE REF TO lcl_settings. VALUE(ro_settings) TYPE REF TO lcl_settings.
PROTECTED SECTION.
PRIVATE SECTION.
ENDCLASS. ENDCLASS.
CLASS lcl_persistence_settings IMPLEMENTATION. CLASS lcl_persistence_settings IMPLEMENTATION.
@ -1520,8 +1514,7 @@ CLASS lcl_persistence_settings IMPLEMENTATION.
ro_settings->set_proxy_url( ro_settings->set_proxy_url(
lcl_app=>db( )->read( lcl_app=>db( )->read(
iv_type = 'SETTINGS' iv_type = 'SETTINGS'
iv_value = 'PROXY_URL' iv_value = 'PROXY_URL' ) ).
) ).
CATCH lcx_not_found. CATCH lcx_not_found.
ro_settings->set_proxy_url( '' ). ro_settings->set_proxy_url( '' ).
ENDTRY. ENDTRY.
@ -1529,8 +1522,7 @@ CLASS lcl_persistence_settings IMPLEMENTATION.
ro_settings->set_proxy_port( ro_settings->set_proxy_port(
lcl_app=>db( )->read( lcl_app=>db( )->read(
iv_type = 'SETTINGS' iv_type = 'SETTINGS'
iv_value = 'PROXY_PORT' iv_value = 'PROXY_PORT' ) ).
) ).
CATCH lcx_not_found. CATCH lcx_not_found.
ro_settings->set_proxy_port( '' ). ro_settings->set_proxy_port( '' ).
ENDTRY. ENDTRY.

5
src/zabapgit_repo_impl.prog.abap
View File

@ -549,8 +549,9 @@ CLASS lcl_repo IMPLEMENTATION.
WITH KEY item = ls_item. " type+name+package key WITH KEY item = ls_item. " type+name+package key
" There is something in cache and the object is unchanged " There is something in cache and the object is unchanged
IF sy-subrc = 0 IF sy-subrc = 0
AND abap_false = lcl_objects=>has_changed_since( is_item = ls_item AND abap_false = lcl_objects=>has_changed_since(
iv_timestamp = mv_last_serialization ). is_item = ls_item
iv_timestamp = mv_last_serialization ).
LOOP AT lt_cache ASSIGNING <ls_cache> WHERE item = ls_item. LOOP AT lt_cache ASSIGNING <ls_cache> WHERE item = ls_item.
APPEND <ls_cache> TO rt_files. APPEND <ls_cache> TO rt_files.
ENDLOOP. ENDLOOP.

3
src/zabapgit_sap_package.prog.abap
View File

@ -117,7 +117,8 @@ CLASS lcl_sap_package IMPLEMENTATION.
SORT lt_res_sort BY obj_type ASCENDING obj_name ASCENDING. SORT lt_res_sort BY obj_type ASCENDING obj_name ASCENDING.
LOOP AT it_results ASSIGNING <ls_res1> WHERE NOT obj_type IS INITIAL. LOOP AT it_results ASSIGNING <ls_res1> WHERE NOT obj_type IS INITIAL.
IF NOT ( <ls_res1>-obj_type = ls_item-obj_type AND <ls_res1>-obj_name = ls_item-obj_name ). IF NOT ( <ls_res1>-obj_type = ls_item-obj_type
AND <ls_res1>-obj_name = ls_item-obj_name ).
APPEND INITIAL LINE TO lt_item_idx ASSIGNING <ls_res2>. APPEND INITIAL LINE TO lt_item_idx ASSIGNING <ls_res2>.
<ls_res2>-obj_type = <ls_res1>-obj_type. <ls_res2>-obj_type = <ls_res1>-obj_type.
<ls_res2>-obj_name = <ls_res1>-obj_name. <ls_res2>-obj_name = <ls_res1>-obj_name.

18
src/zabapgit_services_abapgit.prog.abap
View File

@ -5,12 +5,18 @@
CLASS lcl_services_abapgit DEFINITION FINAL. CLASS lcl_services_abapgit DEFINITION FINAL.
PUBLIC SECTION. PUBLIC SECTION.
CONSTANTS c_abapgit_homepage TYPE string VALUE 'http://www.abapgit.org' ##NO_TEXT. CONSTANTS c_abapgit_homepage TYPE string
CONSTANTS c_abapgit_wikipage TYPE string VALUE 'https://github.com/larshp/abapGit/wiki'. VALUE 'http://www.abapgit.org' ##NO_TEXT.
CONSTANTS c_package_abapgit TYPE devclass VALUE '$ABAPGIT'. CONSTANTS c_abapgit_wikipage TYPE string
CONSTANTS c_package_plugins TYPE devclass VALUE '$ABAPGIT_PLUGINS'. VALUE 'https://github.com/larshp/abapGit/wiki'.
CONSTANTS c_abapgit_url TYPE string VALUE 'https://github.com/larshp/abapGit.git'. CONSTANTS c_package_abapgit TYPE devclass
CONSTANTS c_plugins_url TYPE string VALUE 'https://github.com/larshp/abapGit-plugins.git'. VALUE '$ABAPGIT'.
CONSTANTS c_package_plugins TYPE devclass
VALUE '$ABAPGIT_PLUGINS'.
CONSTANTS c_abapgit_url TYPE string
VALUE 'https://github.com/larshp/abapGit.git'.
CONSTANTS c_plugins_url TYPE string
VALUE 'https://github.com/larshp/abapGit-plugins.git'.
CLASS-METHODS open_abapgit_homepage CLASS-METHODS open_abapgit_homepage
RAISING lcx_exception. RAISING lcx_exception.

3
src/zabapgit_services_db.prog.abap
View File

@ -32,8 +32,7 @@ CLASS lcl_services_db IMPLEMENTATION.
text_button_2 = 'Cancel' text_button_2 = 'Cancel'
icon_button_2 = 'ICON_CANCEL' icon_button_2 = 'ICON_CANCEL'
default_button = '2' default_button = '2'
display_cancel_button = abap_false display_cancel_button = abap_false ). "#EC NOTEXT
). "#EC NOTEXT
IF lv_answer = '2'. IF lv_answer = '2'.
RAISE EXCEPTION TYPE lcx_cancel. RAISE EXCEPTION TYPE lcx_cancel.

11
src/zabapgit_services_git.prog.abap
View File

@ -34,9 +34,9 @@ CLASS lcl_services_git DEFINITION FINAL.
RAISING lcx_exception lcx_cancel. RAISING lcx_exception lcx_cancel.
CLASS-METHODS commit CLASS-METHODS commit
IMPORTING io_repo TYPE REF TO lcl_repo_online IMPORTING io_repo TYPE REF TO lcl_repo_online
is_commit TYPE ty_commit_fields is_commit TYPE ty_commit_fields
io_stage TYPE REF TO lcl_stage io_stage TYPE REF TO lcl_stage
RAISING lcx_exception lcx_cancel. RAISING lcx_exception lcx_cancel.
ENDCLASS. " lcl_services_git ENDCLASS. " lcl_services_git
@ -63,8 +63,7 @@ CLASS lcl_services_git IMPLEMENTATION.
text_button_2 = 'Cancel' text_button_2 = 'Cancel'
icon_button_2 = 'ICON_CANCEL' icon_button_2 = 'ICON_CANCEL'
default_button = '2' default_button = '2'
display_cancel_button = abap_false display_cancel_button = abap_false ). "#EC NOTEXT
). "#EC NOTEXT
IF lv_answer = '2'. IF lv_answer = '2'.
RAISE EXCEPTION TYPE lcx_cancel. RAISE EXCEPTION TYPE lcx_cancel.
@ -124,7 +123,7 @@ CLASS lcl_services_git IMPLEMENTATION.
METHOD switch_branch. METHOD switch_branch.
DATA: lo_repo TYPE REF TO lcl_repo_online, DATA: lo_repo TYPE REF TO lcl_repo_online,
ls_branch TYPE lcl_git_branch_list=>ty_git_branch. ls_branch TYPE lcl_git_branch_list=>ty_git_branch.

36
src/zabapgit_services_repo.prog.abap
View File

@ -21,7 +21,7 @@ CLASS lcl_services_repo DEFINITION FINAL.
RAISING lcx_exception lcx_cancel. RAISING lcx_exception lcx_cancel.
CLASS-METHODS new_offline CLASS-METHODS new_offline
RAISING lcx_exception lcx_cancel. RAISING lcx_exception lcx_cancel.
CLASS-METHODS remote_attach CLASS-METHODS remote_attach
IMPORTING iv_key TYPE lcl_persistence_repo=>ty_repo-key IMPORTING iv_key TYPE lcl_persistence_repo=>ty_repo-key
@ -53,7 +53,7 @@ CLASS lcl_services_repo IMPLEMENTATION.
METHOD clone. METHOD clone.
DATA: lo_repo TYPE REF TO lcl_repo_online, DATA: lo_repo TYPE REF TO lcl_repo_online,
ls_popup TYPE lcl_popups=>ty_popup. ls_popup TYPE lcl_popups=>ty_popup.
@ -105,8 +105,7 @@ CLASS lcl_services_repo IMPLEMENTATION.
text_button_2 = 'Cancel' text_button_2 = 'Cancel'
icon_button_2 = 'ICON_CANCEL' icon_button_2 = 'ICON_CANCEL'
default_button = '2' default_button = '2'
display_cancel_button = abap_false display_cancel_button = abap_false ). "#EC NOTEXT
). "#EC NOTEXT
IF lv_answer = '2'. IF lv_answer = '2'.
RAISE EXCEPTION TYPE lcx_cancel. RAISE EXCEPTION TYPE lcx_cancel.
@ -149,8 +148,7 @@ CLASS lcl_services_repo IMPLEMENTATION.
text_button_2 = 'Cancel' text_button_2 = 'Cancel'
icon_button_2 = 'ICON_CANCEL' icon_button_2 = 'ICON_CANCEL'
default_button = '2' default_button = '2'
display_cancel_button = abap_false display_cancel_button = abap_false ). "#EC NOTEXT
). "#EC NOTEXT
IF lv_answer = '2'. IF lv_answer = '2'.
RAISE EXCEPTION TYPE lcx_cancel. RAISE EXCEPTION TYPE lcx_cancel.
@ -199,8 +197,7 @@ CLASS lcl_services_repo IMPLEMENTATION.
text_button_2 = 'Cancel' text_button_2 = 'Cancel'
icon_button_2 = 'ICON_CANCEL' icon_button_2 = 'ICON_CANCEL'
default_button = '2' default_button = '2'
display_cancel_button = abap_false display_cancel_button = abap_false ). "#EC NOTEXT
). "#EC NOTEXT
IF lv_answer = '2'. IF lv_answer = '2'.
RAISE EXCEPTION TYPE lcx_cancel. RAISE EXCEPTION TYPE lcx_cancel.
@ -215,8 +212,8 @@ CLASS lcl_services_repo IMPLEMENTATION.
METHOD remote_attach. METHOD remote_attach.
DATA: ls_popup TYPE lcl_popups=>ty_popup, DATA: ls_popup TYPE lcl_popups=>ty_popup,
lo_repo TYPE REF TO lcl_repo_online. lo_repo TYPE REF TO lcl_repo_online.
ls_popup = lcl_popups=>repo_popup( ls_popup = lcl_popups=>repo_popup(
iv_title = 'Attach repo to remote ...' iv_title = 'Attach repo to remote ...'
@ -239,8 +236,8 @@ CLASS lcl_services_repo IMPLEMENTATION.
METHOD remote_change. METHOD remote_change.
DATA: ls_popup TYPE lcl_popups=>ty_popup, DATA: ls_popup TYPE lcl_popups=>ty_popup,
lo_repo TYPE REF TO lcl_repo_online. lo_repo TYPE REF TO lcl_repo_online.
lo_repo ?= lcl_app=>repo_srv( )->get( iv_key ). lo_repo ?= lcl_app=>repo_srv( )->get( iv_key ).
@ -267,7 +264,8 @@ CLASS lcl_services_repo IMPLEMENTATION.
lv_question TYPE string, lv_question TYPE string,
lo_repo TYPE REF TO lcl_repo. lo_repo TYPE REF TO lcl_repo.
lo_repo ?= lcl_app=>repo_srv( )->get( iv_key ).
lo_repo = lcl_app=>repo_srv( )->get( iv_key ).
lv_question = 'This will rebuild and overwrite local repo checksums.'. lv_question = 'This will rebuild and overwrite local repo checksums.'.
@ -288,7 +286,7 @@ CLASS lcl_services_repo IMPLEMENTATION.
text_button_2 = 'Cancel' text_button_2 = 'Cancel'
icon_button_2 = 'ICON_CANCEL' icon_button_2 = 'ICON_CANCEL'
default_button = '2' default_button = '2'
display_cancel_button = abap_false ). "#EC NOTEXT display_cancel_button = abap_false ). "#EC NOTEXT
IF lv_answer = '2'. IF lv_answer = '2'.
RAISE EXCEPTION TYPE lcx_cancel. RAISE EXCEPTION TYPE lcx_cancel.
@ -308,11 +306,11 @@ CLASS lcl_services_repo IMPLEMENTATION.
CALL FUNCTION 'RS_TOOL_ACCESS' CALL FUNCTION 'RS_TOOL_ACCESS'
EXPORTING EXPORTING
OPERATION = 'SHOW' operation = 'SHOW'
IN_NEW_WINDOW = 'X' in_new_window = 'X'
OBJECT_NAME = iv_package object_name = iv_package
OBJECT_TYPE = 'DEVC' object_type = 'DEVC'
WITH_OBJECTLIST = 'X'. with_objectlist = 'X'.
ENDMETHOD. " open_se80. ENDMETHOD. " open_se80.

8
src/zabapgit_syntax_highlighter.prog.abap
View File

@ -197,8 +197,7 @@ CLASS lcl_syntax_highlighter IMPLEMENTATION.
FIELD-SYMBOLS: FIELD-SYMBOLS:
<regex> LIKE LINE OF mt_rules, <regex> LIKE LINE OF mt_rules,
<result> TYPE match_result, <result> TYPE match_result.
<match> TYPE ty_match.
CLEAR et_matches. CLEAR et_matches.
@ -651,8 +650,7 @@ CLASS ltcl_syntax_cases DEFINITION FINAL
METHODS: METHODS:
do_test IMPORTING iv_line TYPE string do_test IMPORTING iv_line TYPE string
iv_filename TYPE string iv_filename TYPE string,
RETURNING VALUE(ro_instance) TYPE REF TO lcl_syntax_highlighter,
test_abap_01 FOR TESTING, test_abap_01 FOR TESTING,
test_abap_02 FOR TESTING, test_abap_02 FOR TESTING,
test_abap_03 FOR TESTING, test_abap_03 FOR TESTING,
@ -702,7 +700,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION.
lo TYPE REF TO lcl_syntax_highlighter. lo TYPE REF TO lcl_syntax_highlighter.
lo = lcl_syntax_highlighter=>create( iv_filename ). lo = lcl_syntax_highlighter=>create( iv_filename ).
lo->parse_line( EXPORTING iv_line = iv_line lo->parse_line( EXPORTING iv_line = iv_line
IMPORTING et_matches = lt_matches_act ). IMPORTING et_matches = lt_matches_act ).

9
src/zabapgit_unit_test.prog.abap
View File

@ -1839,7 +1839,6 @@ CLASS ltcl_file_status IMPLEMENTATION.
DATA: lt_local TYPE ty_files_item_tt, DATA: lt_local TYPE ty_files_item_tt,
lt_remote TYPE ty_files_tt, lt_remote TYPE ty_files_tt,
lt_state TYPE ty_file_signatures_tt, lt_state TYPE ty_file_signatures_tt,
lt_tadir TYPE ty_tadir_tt,
lt_results TYPE ty_results_tt, lt_results TYPE ty_results_tt,
lt_results_exp TYPE ty_results_tt. lt_results_exp TYPE ty_results_tt.
@ -2185,21 +2184,21 @@ CLASS ltcl_persistence_settings IMPLEMENTATION.
lcl_app=>db( )->delete( lcl_app=>db( )->delete(
iv_type = 'SETTINGS' iv_type = 'SETTINGS'
iv_value = 'PROXY_URL' ). iv_value = 'PROXY_URL' ).
CATCH cx_static_check. CATCH cx_static_check ##NO_HANDLER.
"If entry didn't exist, that's okay "If entry didn't exist, that's okay
ENDTRY. ENDTRY.
TRY. TRY.
lcl_app=>db( )->delete( lcl_app=>db( )->delete(
iv_type = 'SETTINGS' iv_type = 'SETTINGS'
iv_value = 'PROXY_PORT' ). iv_value = 'PROXY_PORT' ).
CATCH cx_static_check. CATCH cx_static_check ##NO_HANDLER.
"If entry didn't exist, that's okay "If entry didn't exist, that's okay
ENDTRY. ENDTRY.
TRY. TRY.
lcl_app=>db( )->delete( lcl_app=>db( )->delete(
iv_type = 'SETTINGS' iv_type = 'SETTINGS'
iv_value = 'CRIT_TESTS' ). iv_value = 'CRIT_TESTS' ).
CATCH cx_static_check. CATCH cx_static_check ##NO_HANDLER.
"If entry didn't exist, that's okay "If entry didn't exist, that's okay
ENDTRY. ENDTRY.
@ -2337,7 +2336,7 @@ CLASS ltd_fake_object_files IMPLEMENTATION.
ENDCLASS. ENDCLASS.
CLASS ltc_oo_test DEFINITION FOR TESTING RISK LEVEL HARMLESS DURATION SHORT . CLASS ltc_oo_test DEFINITION FOR TESTING RISK LEVEL HARMLESS DURATION SHORT.
PROTECTED SECTION. PROTECTED SECTION.
DATA: DATA:
mo_spy_oo_object TYPE REF TO ltd_spy_oo_object, mo_spy_oo_object TYPE REF TO ltd_spy_oo_object,