From 824195f63a073e2248903174c3e822631aaaaa43 Mon Sep 17 00:00:00 2001 From: larshp Date: Fri, 9 Jun 2017 07:41:05 +0000 Subject: [PATCH] rename classes #733 --- src/zabapgit_2fa.prog.abap | 58 +++++++++-------- src/zabapgit_app.prog.abap | 6 +- src/zabapgit_background.prog.abap | 16 ++--- src/zabapgit_gui_router.prog.abap | 10 +-- src/zabapgit_html_action_utils.prog.abap | 2 +- src/zabapgit_html_chunks.prog.abap | 2 +- src/zabapgit_http.prog.abap | 8 +-- src/zabapgit_migrations.prog.abap | 2 +- src/zabapgit_object_acid.prog.abap | 2 +- src/zabapgit_object_auth.prog.abap | 2 +- src/zabapgit_object_clas.prog.abap | 49 ++++++++------- src/zabapgit_object_dcls.prog.abap | 2 +- src/zabapgit_object_ddls.prog.abap | 2 +- src/zabapgit_object_doct.prog.abap | 2 +- src/zabapgit_object_docv.prog.abap | 2 +- src/zabapgit_object_doma.prog.abap | 2 +- src/zabapgit_object_dtel.prog.abap | 2 +- src/zabapgit_object_enho.prog.abap | 14 ++--- src/zabapgit_object_enhs.prog.abap | 2 +- src/zabapgit_object_enqu.prog.abap | 2 +- src/zabapgit_object_ensc.prog.abap | 2 +- src/zabapgit_object_form.prog.abap | 2 +- src/zabapgit_object_fugr.prog.abap | 2 +- src/zabapgit_object_iarp.prog.abap | 2 +- src/zabapgit_object_iasp.prog.abap | 2 +- src/zabapgit_object_iatu.prog.abap | 2 +- src/zabapgit_object_intf.prog.abap | 35 ++++++----- src/zabapgit_object_msag.prog.abap | 2 +- src/zabapgit_object_nrob.prog.abap | 2 +- src/zabapgit_object_oo_factory.prog.abap | 10 +-- src/zabapgit_object_oo_functions.prog.abap | 69 +++++++++++---------- src/zabapgit_object_para.prog.abap | 2 +- src/zabapgit_object_pinf.prog.abap | 2 +- src/zabapgit_object_prog.prog.abap | 2 +- src/zabapgit_object_samc.prog.abap | 4 +- src/zabapgit_object_sapc.prog.abap | 4 +- src/zabapgit_object_sfbf.prog.abap | 2 +- src/zabapgit_object_sfbs.prog.abap | 2 +- src/zabapgit_object_sfpf.prog.abap | 2 +- src/zabapgit_object_sfpi.prog.abap | 2 +- src/zabapgit_object_sfsw.prog.abap | 2 +- src/zabapgit_object_shi3.prog.abap | 2 +- src/zabapgit_object_shlp.prog.abap | 2 +- src/zabapgit_object_sicf.prog.abap | 2 +- src/zabapgit_object_smim.prog.abap | 2 +- src/zabapgit_object_splo.prog.abap | 2 +- src/zabapgit_object_ssfo.prog.abap | 2 +- src/zabapgit_object_ssst.prog.abap | 2 +- src/zabapgit_object_styl.prog.abap | 2 +- src/zabapgit_object_susc.prog.abap | 2 +- src/zabapgit_object_suso.prog.abap | 2 +- src/zabapgit_object_tabl.prog.abap | 6 +- src/zabapgit_object_tabl_valid.prog.abap | 20 +++--- src/zabapgit_object_tobj.prog.abap | 2 +- src/zabapgit_object_tran.prog.abap | 2 +- src/zabapgit_object_ttyp.prog.abap | 2 +- src/zabapgit_object_type.prog.abap | 4 +- src/zabapgit_object_vcls.prog.abap | 2 +- src/zabapgit_object_view.prog.abap | 2 +- src/zabapgit_object_w3xx.prog.abap | 2 +- src/zabapgit_object_wapa.prog.abap | 2 +- src/zabapgit_object_wdya.prog.abap | 2 +- src/zabapgit_object_wdyn.prog.abap | 2 +- src/zabapgit_object_webi.prog.abap | 2 +- src/zabapgit_object_xslt.prog.abap | 2 +- src/zabapgit_objects.prog.abap | 18 +++--- src/zabapgit_objects_impl.prog.abap | 2 +- src/zabapgit_page_background.prog.abap | 26 ++++---- src/zabapgit_page_branch_overview.prog.abap | 4 +- src/zabapgit_page_db.prog.abap | 6 +- src/zabapgit_page_main.prog.abap | 4 +- src/zabapgit_page_repo_settings.prog.abap | 6 +- src/zabapgit_page_settings.prog.abap | 4 +- src/zabapgit_persistence.prog.abap | 14 ++--- src/zabapgit_persistence_old.prog.abap | 6 +- src/zabapgit_repo_browser_util.prog.abap | 4 +- src/zabapgit_services_background.prog.abap | 10 +-- src/zabapgit_services_repo.prog.abap | 10 +-- src/zabapgit_transport.prog.abap | 4 +- src/zabapgit_unit_test.prog.abap | 2 +- src/zabapgit_unit_test_clas_intf.prog.abap | 41 ++++++------ src/zabapgit_view_repo.prog.abap | 20 +++--- 82 files changed, 299 insertions(+), 295 deletions(-) diff --git a/src/zabapgit_2fa.prog.abap b/src/zabapgit_2fa.prog.abap index 7506e1635..58b7bcf2a 100644 --- a/src/zabapgit_2fa.prog.abap +++ b/src/zabapgit_2fa.prog.abap @@ -50,13 +50,13 @@ CLASS lcx_2fa_auth_failed IMPLEMENTATION. ENDMETHOD. ENDCLASS. -CLASS lcx_2fa_token_gen_failed DEFINITION INHERITING FROM lcx_2fa_error FINAL. +CLASS lcx_2fa_gen_failed DEFINITION INHERITING FROM lcx_2fa_error FINAL. PROTECTED SECTION. METHODS: get_default_text REDEFINITION. ENDCLASS. -CLASS lcx_2fa_token_gen_failed IMPLEMENTATION. +CLASS lcx_2fa_gen_failed IMPLEMENTATION. METHOD get_default_text. rv_text = 'Two factor access token generation failed.' ##NO_TEXT. ENDMETHOD. @@ -74,25 +74,25 @@ CLASS lcx_2fa_unsupported IMPLEMENTATION. ENDMETHOD. ENDCLASS. -CLASS lcx_2fa_token_del_failed DEFINITION INHERITING FROM lcx_2fa_error FINAL. +CLASS lcx_2fa_del_failed DEFINITION INHERITING FROM lcx_2fa_error FINAL. PROTECTED SECTION. METHODS: get_default_text REDEFINITION. ENDCLASS. -CLASS lcx_2fa_token_del_failed IMPLEMENTATION. +CLASS lcx_2fa_del_failed IMPLEMENTATION. METHOD get_default_text. rv_text = 'Deleting previous access tokens failed.' ##NO_TEXT. ENDMETHOD. ENDCLASS. -CLASS lcx_2fa_communication_error DEFINITION INHERITING FROM lcx_2fa_error FINAL. +CLASS lcx_2fa_comm_error DEFINITION INHERITING FROM lcx_2fa_error FINAL. PROTECTED SECTION. METHODS: get_default_text REDEFINITION. ENDCLASS. -CLASS lcx_2fa_communication_error IMPLEMENTATION. +CLASS lcx_2fa_comm_error IMPLEMENTATION. METHOD get_default_text. rv_text = 'Communication error.' ##NO_TEXT. ENDMETHOD. @@ -143,8 +143,8 @@ INTERFACE lif_2fa_authenticator. iv_2fa_token TYPE string RETURNING VALUE(rv_access_token) TYPE string RAISING lcx_2fa_auth_failed - lcx_2fa_token_gen_failed - lcx_2fa_communication_error, + lcx_2fa_gen_failed + lcx_2fa_comm_error, "! Check if this authenticator instance supports the give repository url "! @parameter iv_url | Repository url "! @parameter rv_supported | Is supported @@ -166,7 +166,7 @@ INTERFACE lif_2fa_authenticator. iv_username TYPE string iv_password TYPE string RETURNING VALUE(rv_required) TYPE abap_bool - RAISING lcx_2fa_communication_error, + RAISING lcx_2fa_comm_error, "! Delete all previously created access tokens for abapGit "! @parameter iv_url | Repository url "! @parameter iv_username | Username @@ -178,8 +178,8 @@ INTERFACE lif_2fa_authenticator. iv_username TYPE string iv_password TYPE string iv_2fa_token TYPE string - RAISING lcx_2fa_token_del_failed - lcx_2fa_communication_error + RAISING lcx_2fa_del_failed + lcx_2fa_comm_error lcx_2fa_auth_failed, "! Begin an authenticator session that uses internal caching for authorizations "! @raising lcx_2fa_illegal_state | Session already started @@ -190,7 +190,7 @@ INTERFACE lif_2fa_authenticator. ENDINTERFACE. "! Default LIF_2FA-AUTHENTICATOR implememtation -CLASS lcl_2fa_authenticator_base DEFINITION +CLASS lcl_2fa_auth_base DEFINITION ABSTRACT CREATE PUBLIC. @@ -216,7 +216,7 @@ CLASS lcl_2fa_authenticator_base DEFINITION "!

"! sy-msg... must be set right before calling! "!

- raise_comm_error_from_sy RAISING lcx_2fa_communication_error. + raise_comm_error_from_sy RAISING lcx_2fa_comm_error. METHODS: "! @parameter rv_running | Internal session is currently active is_session_running RETURNING VALUE(rv_running) TYPE abap_bool. @@ -226,7 +226,7 @@ CLASS lcl_2fa_authenticator_base DEFINITION mv_session_running TYPE abap_bool. ENDCLASS. -CLASS lcl_2fa_authenticator_base IMPLEMENTATION. +CLASS lcl_2fa_auth_base IMPLEMENTATION. METHOD constructor. CREATE OBJECT mo_url_regex EXPORTING @@ -251,7 +251,7 @@ CLASS lcl_2fa_authenticator_base IMPLEMENTATION. ENDMETHOD. METHOD delete_access_tokens. - RAISE EXCEPTION TYPE lcx_2fa_token_del_failed. " Needs to be overwritten in subclasses + RAISE EXCEPTION TYPE lcx_2fa_del_failed. " Needs to be overwritten in subclasses ENDMETHOD. METHOD raise_comm_error_from_sy. @@ -260,7 +260,7 @@ CLASS lcl_2fa_authenticator_base IMPLEMENTATION. MESSAGE ID sy-msgid TYPE sy-msgty NUMBER sy-msgno WITH sy-msgv1 sy-msgv2 sy-msgv3 sy-msgv4 INTO lv_error_msg. - RAISE EXCEPTION TYPE lcx_2fa_communication_error + RAISE EXCEPTION TYPE lcx_2fa_comm_error EXPORTING iv_error_text = |Communication error: { lv_error_msg }| ##NO_TEXT. ENDMETHOD. @@ -286,10 +286,8 @@ CLASS lcl_2fa_authenticator_base IMPLEMENTATION. ENDMETHOD. ENDCLASS. -CLASS lcl_2fa_github_authenticator DEFINITION - INHERITING FROM lcl_2fa_authenticator_base - FINAL - CREATE PUBLIC. +CLASS lcl_2fa_github_auth DEFINITION INHERITING FROM lcl_2fa_auth_base + FINAL CREATE PUBLIC. PUBLIC SECTION. METHODS: @@ -320,12 +318,12 @@ CLASS lcl_2fa_github_authenticator DEFINITION iv_2fa_token TYPE string RETURNING VALUE(ri_client) TYPE REF TO if_http_client RAISING lcx_2fa_auth_failed - lcx_2fa_communication_error. + lcx_2fa_comm_error. DATA: mi_authenticated_session TYPE REF TO if_http_client. ENDCLASS. -CLASS lcl_2fa_github_authenticator IMPLEMENTATION. +CLASS lcl_2fa_github_auth IMPLEMENTATION. METHOD constructor. super->constructor( '^https?://(www\.)?github.com.*$' ). ENDMETHOD. @@ -360,14 +358,14 @@ CLASS lcl_2fa_github_authenticator IMPLEMENTATION. code = lv_http_code reason = lv_http_code_description ). IF lv_http_code <> 201. - RAISE EXCEPTION TYPE lcx_2fa_token_gen_failed + RAISE EXCEPTION TYPE lcx_2fa_gen_failed EXPORTING iv_error_text = |Token generation failed: { lv_http_code } { lv_http_code_description }|. ENDIF. rv_access_token = get_token_from_response( li_http_client->response ). IF rv_access_token IS INITIAL. - RAISE EXCEPTION TYPE lcx_2fa_token_gen_failed + RAISE EXCEPTION TYPE lcx_2fa_gen_failed EXPORTING iv_error_text = 'Token generation failed: parser error' ##NO_TEXT. ENDIF. @@ -525,7 +523,7 @@ CLASS lcl_2fa_github_authenticator IMPLEMENTATION. code = lv_http_code reason = lv_http_code_description ). IF lv_http_code <> 200. - RAISE EXCEPTION TYPE lcx_2fa_token_del_failed + RAISE EXCEPTION TYPE lcx_2fa_del_failed EXPORTING iv_error_text = |Could not fetch current 2FA authorizations: | && |{ lv_http_code } { lv_http_code_description }|. @@ -550,7 +548,7 @@ CLASS lcl_2fa_github_authenticator IMPLEMENTATION. code = lv_http_code reason = lv_http_code_description ). IF lv_http_code <> 204. - RAISE EXCEPTION TYPE lcx_2fa_token_del_failed + RAISE EXCEPTION TYPE lcx_2fa_del_failed EXPORTING iv_error_text = |Could not delete token '{ }': | && |{ lv_http_code } { lv_http_code_description }|. @@ -630,7 +628,7 @@ CLASS lcl_2fa_github_authenticator IMPLEMENTATION. ENDCLASS. "! Static registry class to find LIF_2FA_AUTHENTICATOR instances -CLASS lcl_2fa_authenticator_registry DEFINITION +CLASS lcl_2fa_auth_registry DEFINITION FINAL CREATE PRIVATE. @@ -675,9 +673,9 @@ CLASS lcl_2fa_authenticator_registry DEFINITION RAISING lcx_exception. ENDCLASS. -CLASS lcl_2fa_authenticator_registry IMPLEMENTATION. +CLASS lcl_2fa_auth_registry IMPLEMENTATION. METHOD class_constructor. - DEFINE register. + DEFINE _register. CREATE OBJECT li_authenticator TYPE &1. INSERT li_authenticator INTO TABLE gt_registered_authenticators. END-OF-DEFINITION. @@ -687,7 +685,7 @@ CLASS lcl_2fa_authenticator_registry IMPLEMENTATION. " If there are new authenticators these need to be added here manually. " I do not think there is an equivalent to SEO_INTERFACE_IMPLEM_GET_ALL for local classes " without invoking the compiler directly. - register: lcl_2fa_github_authenticator. + _register: lcl_2fa_github_auth. ENDMETHOD. METHOD get_authenticator_for_url. diff --git a/src/zabapgit_app.prog.abap b/src/zabapgit_app.prog.abap index f6ea82515..da8b71e6c 100644 --- a/src/zabapgit_app.prog.abap +++ b/src/zabapgit_app.prog.abap @@ -6,7 +6,7 @@ CLASS lcl_gui DEFINITION DEFERRED. CLASS lcl_persistence_user DEFINITION DEFERRED. CLASS lcl_repo_srv DEFINITION DEFERRED. CLASS lcl_persistence_db DEFINITION DEFERRED. -CLASS lcl_persistence_settings DEFINITION DEFERRED. +CLASS lcl_persist_settings DEFINITION DEFERRED. *----------------------------------------------------------------------* * CLASS lcl_app DEFINITION @@ -33,13 +33,13 @@ CLASS lcl_app DEFINITION FINAL. RETURNING VALUE(ro_db) TYPE REF TO lcl_persistence_db. CLASS-METHODS settings - RETURNING VALUE(ro_settings) TYPE REF TO lcl_persistence_settings. + RETURNING VALUE(ro_settings) TYPE REF TO lcl_persist_settings. PRIVATE SECTION. CLASS-DATA: go_gui TYPE REF TO lcl_gui, go_current_user TYPE REF TO lcl_persistence_user, go_db TYPE REF TO lcl_persistence_db, go_repo_srv TYPE REF TO lcl_repo_srv, - go_settings TYPE REF TO lcl_persistence_settings. + go_settings TYPE REF TO lcl_persist_settings. ENDCLASS. "lcl_app diff --git a/src/zabapgit_background.prog.abap b/src/zabapgit_background.prog.abap index 284a2b6b6..252883901 100644 --- a/src/zabapgit_background.prog.abap +++ b/src/zabapgit_background.prog.abap @@ -16,11 +16,11 @@ CLASS lcl_background DEFINITION FINAL. RETURNING VALUE(rv_comment) TYPE string, push IMPORTING io_repo TYPE REF TO lcl_repo_online - is_settings TYPE lcl_persistence_background=>ty_background + is_settings TYPE lcl_persist_background=>ty_background RAISING lcx_exception, push_fixed IMPORTING io_repo TYPE REF TO lcl_repo_online - is_settings TYPE lcl_persistence_background=>ty_background + is_settings TYPE lcl_persist_background=>ty_background RAISING lcx_exception, push_auto IMPORTING io_repo TYPE REF TO lcl_repo_online @@ -38,10 +38,10 @@ CLASS lcl_background IMPLEMENTATION. ENDIF. CASE is_settings-amethod. - WHEN lcl_persistence_background=>c_amethod-fixed. + WHEN lcl_persist_background=>c_amethod-fixed. push_fixed( io_repo = io_repo is_settings = is_settings ). - WHEN lcl_persistence_background=>c_amethod-auto. + WHEN lcl_persist_background=>c_amethod-auto. push_auto( io_repo ). WHEN OTHERS. lcx_exception=>raise( 'unknown push method' ). @@ -171,9 +171,9 @@ CLASS lcl_background IMPLEMENTATION. CONSTANTS: c_enq_type TYPE c LENGTH 12 VALUE 'BACKGROUND'. - DATA: lo_per TYPE REF TO lcl_persistence_background, + DATA: lo_per TYPE REF TO lcl_persist_background, lo_repo TYPE REF TO lcl_repo_online, - lt_list TYPE lcl_persistence_background=>tt_background, + lt_list TYPE lcl_persist_background=>tt_background, lv_repo_name TYPE string. FIELD-SYMBOLS: LIKE LINE OF lt_list. @@ -209,9 +209,9 @@ CLASS lcl_background IMPLEMENTATION. iv_password = -password ). CASE -method. - WHEN lcl_persistence_background=>c_method-pull. + WHEN lcl_persist_background=>c_method-pull. lo_repo->deserialize( ). - WHEN lcl_persistence_background=>c_method-push. + WHEN lcl_persist_background=>c_method-push. push( io_repo = lo_repo is_settings = ). WHEN OTHERS. diff --git a/src/zabapgit_gui_router.prog.abap b/src/zabapgit_gui_router.prog.abap index 4a1a71e4c..8903c595f 100644 --- a/src/zabapgit_gui_router.prog.abap +++ b/src/zabapgit_gui_router.prog.abap @@ -77,11 +77,13 @@ CLASS lcl_gui_router IMPLEMENTATION. WHEN lif_defs=>gc_action-go_main " Go Main page OR lif_defs=>gc_action-go_explore " Go Explore page OR lif_defs=>gc_action-go_db " Go DB util page - OR lif_defs=>gc_action-go_background_run " Go background run page OR lif_defs=>gc_action-go_debuginfo " Go debug info page OR lif_defs=>gc_action-go_settings. " Go settings page ei_page = get_page_by_name( iv_action ). ev_state = lif_defs=>gc_event_state-new_page. + WHEN lif_defs=>gc_action-go_background_run. " Go background run page + CREATE OBJECT ei_page TYPE lcl_gui_page_bkg_run. + ev_state = lif_defs=>gc_event_state-new_page. WHEN lif_defs=>gc_action-go_background. " Go Background page ei_page = get_page_background( lv_key ). ev_state = lif_defs=>gc_event_state-new_page. @@ -175,7 +177,7 @@ CLASS lcl_gui_router IMPLEMENTATION. lcl_services_repo=>transport_to_branch( iv_repository_key = lv_key ). ev_state = lif_defs=>gc_event_state-re_render. WHEN lif_defs=>gc_action-repo_settings. - CREATE OBJECT ei_page TYPE lcl_gui_page_repo_settings + CREATE OBJECT ei_page TYPE lcl_gui_page_repo_sett EXPORTING io_repo = lcl_app=>repo_srv( )->get( lv_key ). ev_state = lif_defs=>gc_event_state-new_page. @@ -273,7 +275,7 @@ CLASS lcl_gui_router IMPLEMENTATION. METHOD get_page_branch_overview. DATA: lo_repo TYPE REF TO lcl_repo_online, - lo_page TYPE REF TO lcl_gui_page_branch_overview, + lo_page TYPE REF TO lcl_gui_page_boverview, lv_key TYPE lcl_persistence_repo=>ty_repo-key. @@ -346,7 +348,7 @@ CLASS lcl_gui_router IMPLEMENTATION. METHOD get_page_background. - CREATE OBJECT ri_page TYPE lcl_gui_page_background + CREATE OBJECT ri_page TYPE lcl_gui_page_bkg EXPORTING iv_key = iv_key. diff --git a/src/zabapgit_html_action_utils.prog.abap b/src/zabapgit_html_action_utils.prog.abap index b7bbe26e2..905fb4b15 100644 --- a/src/zabapgit_html_action_utils.prog.abap +++ b/src/zabapgit_html_action_utils.prog.abap @@ -80,7 +80,7 @@ CLASS lcl_html_action_utils DEFINITION FINAL. CLASS-METHODS decode_bg_update IMPORTING iv_getdata TYPE clike - RETURNING VALUE(rs_fields) TYPE lcl_persistence_background=>ty_background. + RETURNING VALUE(rs_fields) TYPE lcl_persist_background=>ty_background. CLASS-METHODS stage_decode IMPORTING iv_getdata TYPE clike diff --git a/src/zabapgit_html_chunks.prog.abap b/src/zabapgit_html_chunks.prog.abap index 188bf75e2..bae2b2983 100644 --- a/src/zabapgit_html_chunks.prog.abap +++ b/src/zabapgit_html_chunks.prog.abap @@ -50,7 +50,7 @@ CLASS lcl_gui_chunk_lib IMPLEMENTATION. METHOD render_repo_top. DATA: lo_repo_online TYPE REF TO lcl_repo_online, - lo_pback TYPE REF TO lcl_persistence_background, + lo_pback TYPE REF TO lcl_persist_background, lv_hint TYPE string, lv_icon TYPE string. diff --git a/src/zabapgit_http.prog.abap b/src/zabapgit_http.prog.abap index 554c61023..c75f907b2 100644 --- a/src/zabapgit_http.prog.abap +++ b/src/zabapgit_http.prog.abap @@ -2,7 +2,7 @@ *& Include ZABAPGIT_HTTP *&---------------------------------------------------------------------* -CLASS lcl_proxy_authentication DEFINITION FINAL. +CLASS lcl_proxy_auth DEFINITION FINAL. PUBLIC SECTION. CLASS-METHODS: @@ -18,7 +18,7 @@ CLASS lcl_proxy_authentication DEFINITION FINAL. ENDCLASS. -CLASS lcl_proxy_authentication IMPLEMENTATION. +CLASS lcl_proxy_auth IMPLEMENTATION. METHOD run. @@ -450,7 +450,7 @@ CLASS lcl_http IMPLEMENTATION. ENDIF. IF lo_settings->get_proxy_authentication( ) = abap_true. - lcl_proxy_authentication=>run( li_client ). + lcl_proxy_auth=>run( li_client ). ENDIF. CREATE OBJECT ro_client @@ -565,7 +565,7 @@ CLASS lcl_http IMPLEMENTATION. ENDIF. " Offer two factor authentication if it is available and required - lcl_2fa_authenticator_registry=>use_2fa_if_required( + lcl_2fa_auth_registry=>use_2fa_if_required( EXPORTING iv_url = iv_url CHANGING diff --git a/src/zabapgit_migrations.prog.abap b/src/zabapgit_migrations.prog.abap index 4a104cd34..fe556d302 100644 --- a/src/zabapgit_migrations.prog.abap +++ b/src/zabapgit_migrations.prog.abap @@ -21,7 +21,7 @@ CLASS lcl_migrations IMPLEMENTATION. METHOD run. " Migrate STDTEXT to TABLE - lcl_persistence_migrate=>run( ). + lcl_persist_migrate=>run( ). " Rebuild local file checksums rebuild_local_checksums_161112( ). diff --git a/src/zabapgit_object_acid.prog.abap b/src/zabapgit_object_acid.prog.abap index a63bd5a94..2e339f2b8 100644 --- a/src/zabapgit_object_acid.prog.abap +++ b/src/zabapgit_object_acid.prog.abap @@ -150,7 +150,7 @@ CLASS lcl_object_acid IMPLEMENTATION. ENDMETHOD. "lif_object~jump METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_acid IMPLEMENTATION diff --git a/src/zabapgit_object_auth.prog.abap b/src/zabapgit_object_auth.prog.abap index 34f3be155..fde332ce9 100644 --- a/src/zabapgit_object_auth.prog.abap +++ b/src/zabapgit_object_auth.prog.abap @@ -127,7 +127,7 @@ CLASS lcl_object_auth IMPLEMENTATION. ENDMETHOD. "lif_object~jump METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_auth IMPLEMENTATION diff --git a/src/zabapgit_object_clas.prog.abap b/src/zabapgit_object_clas.prog.abap index 225d96144..0f58fa619 100644 --- a/src/zabapgit_object_clas.prog.abap +++ b/src/zabapgit_object_clas.prog.abap @@ -26,7 +26,7 @@ CLASS lcl_object_clas DEFINITION INHERITING FROM lcl_objects_program. METHODS deserialize_docu IMPORTING io_xml TYPE REF TO lcl_xml_input RAISING lcx_exception. - DATA mo_object_oriented_object_fct TYPE REF TO lif_object_oriented_object_fnc. + DATA mo_object_oriented_object_fct TYPE REF TO lif_oo_object_fnc. PRIVATE SECTION. DATA mv_skip_testclass TYPE abap_bool. @@ -389,36 +389,36 @@ CLASS lcl_object_clas IMPLEMENTATION. ENDMETHOD. "deserialize METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. METHOD constructor. super->constructor( is_item = is_item iv_language = iv_language ). - mo_object_oriented_object_fct = lcl_object_oriented_factory=>make( iv_object_type = ms_item-obj_type ). + mo_object_oriented_object_fct = lcl_oo_factory=>make( iv_object_type = ms_item-obj_type ). ENDMETHOD. ENDCLASS. "lcl_object_CLAS IMPLEMENTATION +CLASS lcl_oo_class DEFINITION INHERITING FROM lcl_oo_base. -CLASS lcl_object_oriented_class DEFINITION - INHERITING FROM lcl_object_oriented_base. PUBLIC SECTION. METHODS: - lif_object_oriented_object_fnc~create REDEFINITION, - lif_object_oriented_object_fnc~generate_locals REDEFINITION, - lif_object_oriented_object_fnc~insert_text_pool REDEFINITION, - lif_object_oriented_object_fnc~create_sotr REDEFINITION, - lif_object_oriented_object_fnc~get_includes REDEFINITION, - lif_object_oriented_object_fnc~get_class_properties REDEFINITION, - lif_object_oriented_object_fnc~read_text_pool REDEFINITION, - lif_object_oriented_object_fnc~read_sotr REDEFINITION, - lif_object_oriented_object_fnc~delete REDEFINITION. + lif_oo_object_fnc~create REDEFINITION, + lif_oo_object_fnc~generate_locals REDEFINITION, + lif_oo_object_fnc~insert_text_pool REDEFINITION, + lif_oo_object_fnc~create_sotr REDEFINITION, + lif_oo_object_fnc~get_includes REDEFINITION, + lif_oo_object_fnc~get_class_properties REDEFINITION, + lif_oo_object_fnc~read_text_pool REDEFINITION, + lif_oo_object_fnc~read_sotr REDEFINITION, + lif_oo_object_fnc~delete REDEFINITION. ENDCLASS. -CLASS lcl_object_oriented_class IMPLEMENTATION. - METHOD lif_object_oriented_object_fnc~create. + +CLASS lcl_oo_class IMPLEMENTATION. + METHOD lif_oo_object_fnc~create. CALL FUNCTION 'SEO_CLASS_CREATE_COMPLETE' EXPORTING devclass = iv_package @@ -437,7 +437,8 @@ CLASS lcl_object_oriented_class IMPLEMENTATION. lcx_exception=>raise( 'error from SEO_CLASS_CREATE_COMPLETE' ). ENDIF. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~generate_locals. + + METHOD lif_oo_object_fnc~generate_locals. CALL FUNCTION 'SEO_CLASS_GENERATE_LOCALS' EXPORTING clskey = is_key @@ -456,7 +457,7 @@ CLASS lcl_object_oriented_class IMPLEMENTATION. lcx_exception=>raise( 'error from generate_locals' ). ENDIF. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~insert_text_pool. + METHOD lif_oo_object_fnc~insert_text_pool. DATA: lv_cp TYPE program. lv_cp = cl_oo_classname_service=>get_classpool_name( iv_class_name ). @@ -473,7 +474,7 @@ CLASS lcl_object_oriented_class IMPLEMENTATION. iv_name = lv_cp ). ENDMETHOD. - METHOD lif_object_oriented_object_fnc~create_sotr. + METHOD lif_oo_object_fnc~create_sotr. DATA: lt_sotr TYPE lif_defs=>ty_sotr_tt, lt_objects TYPE sotr_objects, ls_paket TYPE sotr_pack, @@ -533,7 +534,7 @@ CLASS lcl_object_oriented_class IMPLEMENTATION. ENDLOOP. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~get_includes. + METHOD lif_oo_object_fnc~get_includes. * note: includes returned might not exist * method cl_oo_classname_service=>GET_ALL_CLASS_INCLUDES does not exist in 702 @@ -566,7 +567,7 @@ CLASS lcl_object_oriented_class IMPLEMENTATION. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~get_class_properties. + METHOD lif_oo_object_fnc~get_class_properties. CALL FUNCTION 'SEO_CLIF_GET' EXPORTING cifkey = is_class_key @@ -585,7 +586,7 @@ CLASS lcl_object_oriented_class IMPLEMENTATION. ENDIF. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~read_text_pool. + METHOD lif_oo_object_fnc~read_text_pool. DATA: lv_cp TYPE program. @@ -593,7 +594,7 @@ CLASS lcl_object_oriented_class IMPLEMENTATION. READ TEXTPOOL lv_cp INTO rt_text_pool LANGUAGE iv_language. "#EC CI_READ_REP ENDMETHOD. - METHOD lif_object_oriented_object_fnc~read_sotr. + METHOD lif_oo_object_fnc~read_sotr. DATA: lv_concept TYPE sotr_head-concept, lt_seocompodf TYPE STANDARD TABLE OF seocompodf WITH DEFAULT KEY, ls_header TYPE sotr_head, @@ -652,7 +653,7 @@ CLASS lcl_object_oriented_class IMPLEMENTATION. ENDLOOP. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~delete. + METHOD lif_oo_object_fnc~delete. CALL FUNCTION 'SEO_CLASS_DELETE_COMPLETE' EXPORTING clskey = is_deletion_key diff --git a/src/zabapgit_object_dcls.prog.abap b/src/zabapgit_object_dcls.prog.abap index 1f2789c76..9fda374ee 100644 --- a/src/zabapgit_object_dcls.prog.abap +++ b/src/zabapgit_object_dcls.prog.abap @@ -183,7 +183,7 @@ CLASS lcl_object_dcls IMPLEMENTATION. ENDMETHOD. METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. diff --git a/src/zabapgit_object_ddls.prog.abap b/src/zabapgit_object_ddls.prog.abap index c5a665605..fcf760998 100644 --- a/src/zabapgit_object_ddls.prog.abap +++ b/src/zabapgit_object_ddls.prog.abap @@ -207,7 +207,7 @@ CLASS lcl_object_ddls IMPLEMENTATION. ENDMETHOD. "deserialize METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. "lif_object~compare_to_remote_version METHOD open_adt_stob. diff --git a/src/zabapgit_object_doct.prog.abap b/src/zabapgit_object_doct.prog.abap index 250730cd6..6700ab155 100644 --- a/src/zabapgit_object_doct.prog.abap +++ b/src/zabapgit_object_doct.prog.abap @@ -152,7 +152,7 @@ CLASS lcl_object_doct IMPLEMENTATION. ENDMETHOD. "serialize METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_msag IMPLEMENTATION diff --git a/src/zabapgit_object_docv.prog.abap b/src/zabapgit_object_docv.prog.abap index ef3374284..da0aaaeea 100644 --- a/src/zabapgit_object_docv.prog.abap +++ b/src/zabapgit_object_docv.prog.abap @@ -156,7 +156,7 @@ CLASS lcl_object_docv IMPLEMENTATION. ENDMETHOD. "serialize METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_msag IMPLEMENTATION diff --git a/src/zabapgit_object_doma.prog.abap b/src/zabapgit_object_doma.prog.abap index 5fe7f932c..f3384b9ba 100644 --- a/src/zabapgit_object_doma.prog.abap +++ b/src/zabapgit_object_doma.prog.abap @@ -360,7 +360,7 @@ CLASS lcl_object_doma IMPLEMENTATION. ENDMETHOD. "deserialize_texts METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_doma IMPLEMENTATION diff --git a/src/zabapgit_object_dtel.prog.abap b/src/zabapgit_object_dtel.prog.abap index 9a56112b4..ab9e75ce8 100644 --- a/src/zabapgit_object_dtel.prog.abap +++ b/src/zabapgit_object_dtel.prog.abap @@ -328,7 +328,7 @@ CLASS lcl_object_dtel IMPLEMENTATION. ENDMETHOD. METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_dtel IMPLEMENTATION diff --git a/src/zabapgit_object_enho.prog.abap b/src/zabapgit_object_enho.prog.abap index f89b040b7..30debffb4 100644 --- a/src/zabapgit_object_enho.prog.abap +++ b/src/zabapgit_object_enho.prog.abap @@ -23,7 +23,7 @@ ENDINTERFACE. "lif_object_enho *----------------------------------------------------------------------* * *----------------------------------------------------------------------* -CLASS lcl_object_enho_wdyconf DEFINITION. +CLASS lcl_object_enho_wdyc DEFINITION. PUBLIC SECTION. METHODS: constructor @@ -43,7 +43,7 @@ ENDCLASS. "lcl_object_enho_wdyconf DEFINITION *----------------------------------------------------------------------* * *----------------------------------------------------------------------* -CLASS lcl_object_enho_wdyconf IMPLEMENTATION. +CLASS lcl_object_enho_wdyc IMPLEMENTATION. METHOD constructor. ms_item = is_item. @@ -633,7 +633,7 @@ ENDCLASS. "lcl_object_enho_hook IMPLEMENTATION *----------------------------------------------------------------------* * *----------------------------------------------------------------------* -CLASS lcl_object_enho_interface DEFINITION. +CLASS lcl_object_enho_intf DEFINITION. PUBLIC SECTION. METHODS: @@ -654,7 +654,7 @@ ENDCLASS. "lcl_object_enho_interface DEFINITION *----------------------------------------------------------------------* * *----------------------------------------------------------------------* -CLASS lcl_object_enho_interface IMPLEMENTATION. +CLASS lcl_object_enho_intf IMPLEMENTATION. METHOD constructor. ms_item = is_item. @@ -979,12 +979,12 @@ CLASS lcl_object_enho IMPLEMENTATION. is_item = ms_item io_files = mo_files. WHEN cl_enh_tool_intf=>tooltype. - CREATE OBJECT ri_enho TYPE lcl_object_enho_interface + CREATE OBJECT ri_enho TYPE lcl_object_enho_intf EXPORTING is_item = ms_item io_files = mo_files. WHEN cl_wdr_cfg_enhancement=>tooltype. - CREATE OBJECT ri_enho TYPE lcl_object_enho_wdyconf + CREATE OBJECT ri_enho TYPE lcl_object_enho_wdyc EXPORTING is_item = ms_item io_files = mo_files. @@ -1051,7 +1051,7 @@ CLASS lcl_object_enho IMPLEMENTATION. ENDMETHOD. "jump METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. "lif_object~compare_to_remote_version ENDCLASS. "lcl_object_enho IMPLEMENTATION diff --git a/src/zabapgit_object_enhs.prog.abap b/src/zabapgit_object_enhs.prog.abap index 623d4dbbd..c15baca28 100644 --- a/src/zabapgit_object_enhs.prog.abap +++ b/src/zabapgit_object_enhs.prog.abap @@ -212,7 +212,7 @@ CLASS lcl_object_enhs IMPLEMENTATION. ENDMETHOD. "jump METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_enhs diff --git a/src/zabapgit_object_enqu.prog.abap b/src/zabapgit_object_enqu.prog.abap index 0daf862d9..e3425e9d8 100644 --- a/src/zabapgit_object_enqu.prog.abap +++ b/src/zabapgit_object_enqu.prog.abap @@ -184,7 +184,7 @@ CLASS lcl_object_enqu IMPLEMENTATION. ENDMETHOD. "deserialize METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_enqu IMPLEMENTATION diff --git a/src/zabapgit_object_ensc.prog.abap b/src/zabapgit_object_ensc.prog.abap index c7bdc0a8b..5b5ba51c5 100644 --- a/src/zabapgit_object_ensc.prog.abap +++ b/src/zabapgit_object_ensc.prog.abap @@ -191,7 +191,7 @@ CLASS lcl_object_ensc IMPLEMENTATION. ENDMETHOD. "jump METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_ensc diff --git a/src/zabapgit_object_form.prog.abap b/src/zabapgit_object_form.prog.abap index 248ff1f81..63b5a6c32 100644 --- a/src/zabapgit_object_form.prog.abap +++ b/src/zabapgit_object_form.prog.abap @@ -260,7 +260,7 @@ CLASS lcl_object_form IMPLEMENTATION. ENDMETHOD. METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. METHOD _build_extra_from_header. diff --git a/src/zabapgit_object_fugr.prog.abap b/src/zabapgit_object_fugr.prog.abap index 96d898321..85396b89a 100644 --- a/src/zabapgit_object_fugr.prog.abap +++ b/src/zabapgit_object_fugr.prog.abap @@ -769,7 +769,7 @@ CLASS lcl_object_fugr IMPLEMENTATION. ENDMETHOD. "jump METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_fugr IMPLEMENTATION diff --git a/src/zabapgit_object_iarp.prog.abap b/src/zabapgit_object_iarp.prog.abap index ecf2118d5..ff3cd15b0 100644 --- a/src/zabapgit_object_iarp.prog.abap +++ b/src/zabapgit_object_iarp.prog.abap @@ -189,7 +189,7 @@ CLASS lcl_object_iarp IMPLEMENTATION. ENDMETHOD. "lif_object~jump METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_iarp IMPLEMENTATION diff --git a/src/zabapgit_object_iasp.prog.abap b/src/zabapgit_object_iasp.prog.abap index ae8338707..74c24d2a1 100644 --- a/src/zabapgit_object_iasp.prog.abap +++ b/src/zabapgit_object_iasp.prog.abap @@ -189,7 +189,7 @@ CLASS lcl_object_iasp IMPLEMENTATION. ENDMETHOD. "lif_object~jump METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_iasp IMPLEMENTATION diff --git a/src/zabapgit_object_iatu.prog.abap b/src/zabapgit_object_iatu.prog.abap index 57321b2cb..e589eaff8 100644 --- a/src/zabapgit_object_iatu.prog.abap +++ b/src/zabapgit_object_iatu.prog.abap @@ -206,7 +206,7 @@ CLASS lcl_object_iatu IMPLEMENTATION. ENDMETHOD. "lif_object~jump METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_iatu IMPLEMENTATION diff --git a/src/zabapgit_object_intf.prog.abap b/src/zabapgit_object_intf.prog.abap index 7ec595a45..2cfd0ec6f 100644 --- a/src/zabapgit_object_intf.prog.abap +++ b/src/zabapgit_object_intf.prog.abap @@ -26,7 +26,7 @@ CLASS lcl_object_intf DEFINITION FINAL INHERITING FROM lcl_objects_program. RAISING lcx_exception. PRIVATE SECTION. - DATA mo_object_oriented_object_fct TYPE REF TO lif_object_oriented_object_fnc. + DATA mo_object_oriented_object_fct TYPE REF TO lif_oo_object_fnc. METHODS serialize_xml IMPORTING io_xml TYPE REF TO lcl_xml_output @@ -40,23 +40,25 @@ CLASS lcl_object_intf IMPLEMENTATION. super->constructor( is_item = is_item iv_language = iv_language ). - mo_object_oriented_object_fct = lcl_object_oriented_factory=>make( iv_object_type = ms_item-obj_type ). + mo_object_oriented_object_fct = lcl_oo_factory=>make( iv_object_type = ms_item-obj_type ). ENDMETHOD. + METHOD lif_object~deserialize. deserialize_abap( io_xml = io_xml iv_package = iv_package ). deserialize_docu( io_xml ). ENDMETHOD. + METHOD deserialize_abap. DATA: ls_vseointerf TYPE vseointerf, lt_source TYPE seop_source_string, lt_descriptions TYPE lif_defs=>ty_seocompotx_tt, ls_clskey TYPE seoclskey. + + ls_clskey-clsname = ms_item-obj_name. - lt_source = mo_files->read_abap( ). - io_xml->read( EXPORTING iv_name = 'VSEOINTERF' CHANGING cg_data = ls_vseointerf ). @@ -212,7 +214,7 @@ CLASS lcl_object_intf IMPLEMENTATION. ENDMETHOD. METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. METHOD lif_object~delete. @@ -259,18 +261,18 @@ CLASS lcl_object_intf IMPLEMENTATION. ENDCLASS. -CLASS lcl_object_oriented_interface DEFINITION - INHERITING FROM lcl_object_oriented_base. +CLASS lcl_oo_interface DEFINITION + INHERITING FROM lcl_oo_base. PUBLIC SECTION. METHODS: - lif_object_oriented_object_fnc~create REDEFINITION, - lif_object_oriented_object_fnc~get_includes REDEFINITION, - lif_object_oriented_object_fnc~get_interface_properties REDEFINITION, - lif_object_oriented_object_fnc~delete REDEFINITION. + lif_oo_object_fnc~create REDEFINITION, + lif_oo_object_fnc~get_includes REDEFINITION, + lif_oo_object_fnc~get_interface_properties REDEFINITION, + lif_oo_object_fnc~delete REDEFINITION. ENDCLASS. -CLASS lcl_object_oriented_interface IMPLEMENTATION. - METHOD lif_object_oriented_object_fnc~create. +CLASS lcl_oo_interface IMPLEMENTATION. + METHOD lif_oo_object_fnc~create. CALL FUNCTION 'SEO_INTERFACE_CREATE_COMPLETE' EXPORTING devclass = iv_package @@ -289,13 +291,14 @@ CLASS lcl_object_oriented_interface IMPLEMENTATION. lcx_exception=>raise( 'Error from SEO_INTERFACE_CREATE_COMPLETE' ). ENDIF. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~get_includes. + + METHOD lif_oo_object_fnc~get_includes. DATA lv_interface_name TYPE seoclsname. lv_interface_name = iv_object_name. APPEND cl_oo_classname_service=>get_interfacepool_name( lv_interface_name ) TO rt_includes. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~get_interface_properties. + METHOD lif_oo_object_fnc~get_interface_properties. CALL FUNCTION 'SEO_CLIF_GET' EXPORTING cifkey = is_interface_key @@ -314,7 +317,7 @@ CLASS lcl_object_oriented_interface IMPLEMENTATION. ENDIF. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~delete. + METHOD lif_oo_object_fnc~delete. CALL FUNCTION 'SEO_INTERFACE_DELETE_COMPLETE' EXPORTING intkey = is_deletion_key diff --git a/src/zabapgit_object_msag.prog.abap b/src/zabapgit_object_msag.prog.abap index af778b680..e14a7f751 100644 --- a/src/zabapgit_object_msag.prog.abap +++ b/src/zabapgit_object_msag.prog.abap @@ -299,7 +299,7 @@ CLASS lcl_object_msag IMPLEMENTATION. ENDMETHOD. METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_msag IMPLEMENTATION diff --git a/src/zabapgit_object_nrob.prog.abap b/src/zabapgit_object_nrob.prog.abap index 489db90f5..1e4fa6e63 100644 --- a/src/zabapgit_object_nrob.prog.abap +++ b/src/zabapgit_object_nrob.prog.abap @@ -255,7 +255,7 @@ CLASS lcl_object_nrob IMPLEMENTATION. ENDMETHOD. "jump METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_nrob IMPLEMENTATION diff --git a/src/zabapgit_object_oo_factory.prog.abap b/src/zabapgit_object_oo_factory.prog.abap index 06c7f5444..b825492ea 100644 --- a/src/zabapgit_object_oo_factory.prog.abap +++ b/src/zabapgit_object_oo_factory.prog.abap @@ -1,16 +1,16 @@ *&---------------------------------------------------------------------* *& Include zabapgit_object_oo_factory *&---------------------------------------------------------------------* -CLASS lcl_object_oriented_factory IMPLEMENTATION. +CLASS lcl_oo_factory IMPLEMENTATION. METHOD make. IF go_object_oriented_object IS BOUND. ro_object_oriented_object = go_object_oriented_object. RETURN. ENDIF. IF iv_object_type = 'CLAS'. - CREATE OBJECT ro_object_oriented_object TYPE lcl_object_oriented_class. + CREATE OBJECT ro_object_oriented_object TYPE lcl_oo_class. ELSEIF iv_object_type = 'INTF'. - CREATE OBJECT ro_object_oriented_object TYPE lcl_object_oriented_interface. + CREATE OBJECT ro_object_oriented_object TYPE lcl_oo_interface. ENDIF. ENDMETHOD. ENDCLASS. @@ -20,11 +20,11 @@ CLASS ltcl_oo_factory_injector DEFINITION FOR TESTING. CLASS-METHODS: inject IMPORTING - io_object_oriented_object TYPE REF TO lif_object_oriented_object_fnc. + io_object_oriented_object TYPE REF TO lif_oo_object_fnc. ENDCLASS. CLASS ltcl_oo_factory_injector IMPLEMENTATION. METHOD inject. - lcl_object_oriented_factory=>go_object_oriented_object = io_object_oriented_object. + lcl_oo_factory=>go_object_oriented_object = io_object_oriented_object. ENDMETHOD. ENDCLASS. diff --git a/src/zabapgit_object_oo_functions.prog.abap b/src/zabapgit_object_oo_functions.prog.abap index 08157f5b8..fe6c1da0b 100644 --- a/src/zabapgit_object_oo_functions.prog.abap +++ b/src/zabapgit_object_oo_functions.prog.abap @@ -1,6 +1,6 @@ "This interface contains SAP object oriented functions that can't be put under test "(i.e. creating a Class in the system) -INTERFACE lif_object_oriented_object_fnc. +INTERFACE lif_oo_object_fnc. TYPES: BEGIN OF ty_includes, programm TYPE programm, END OF ty_includes, @@ -128,7 +128,7 @@ INTERFACE lif_object_oriented_object_fnc. lcx_exception. ENDINTERFACE. -CLASS lcl_oo_object_serializer DEFINITION. +CLASS lcl_oo_serializer DEFINITION. PUBLIC SECTION. METHODS: @@ -187,7 +187,7 @@ CLASS lcl_oo_object_serializer DEFINITION. CHANGING ct_source TYPE lif_defs=>ty_string_tt. ENDCLASS. -CLASS lcl_oo_object_serializer IMPLEMENTATION. +CLASS lcl_oo_serializer IMPLEMENTATION. METHOD serialize_abap_clif_source. TRY. rt_source = serialize_abap_new( is_class_key ). @@ -195,6 +195,7 @@ CLASS lcl_oo_object_serializer IMPLEMENTATION. rt_source = serialize_abap_old( is_class_key ). ENDTRY. ENDMETHOD. + METHOD serialize_abap_old. * for old ABAP AS versions DATA: lo_source TYPE REF TO cl_oo_source. @@ -383,11 +384,13 @@ CLASS lcl_oo_object_serializer IMPLEMENTATION. ENDCLASS. -CLASS lcl_object_oriented_base DEFINITION ABSTRACT. +CLASS lcl_oo_base DEFINITION ABSTRACT. PUBLIC SECTION. - INTERFACES: lif_object_oriented_object_fnc. + INTERFACES: lif_oo_object_fnc. + PRIVATE SECTION. DATA mv_skip_test_classes TYPE abap_bool. + METHODS deserialize_abap_source_old IMPORTING is_clskey TYPE seoclskey it_source TYPE lif_defs=>ty_string_tt @@ -400,13 +403,13 @@ CLASS lcl_object_oriented_base DEFINITION ABSTRACT. cx_sy_dyn_call_error. ENDCLASS. -CLASS lcl_object_oriented_base IMPLEMENTATION. +CLASS lcl_oo_base IMPLEMENTATION. - METHOD lif_object_oriented_object_fnc~create. + METHOD lif_oo_object_fnc~create. ASSERT 0 = 1. "Subclass responsibility ENDMETHOD. - METHOD lif_object_oriented_object_fnc~deserialize_source. + METHOD lif_oo_object_fnc~deserialize_source. TRY. deserialize_abap_source_new( is_clskey = is_key @@ -418,7 +421,7 @@ CLASS lcl_object_oriented_base IMPLEMENTATION. ENDTRY. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~generate_locals. + METHOD lif_oo_object_fnc~generate_locals. ASSERT 0 = 1. "Subclass responsibility ENDMETHOD. @@ -479,24 +482,25 @@ CLASS lcl_object_oriented_base IMPLEMENTATION. CALL METHOD lo_source->('IF_OO_CLIF_SOURCE~UNLOCK'). ENDMETHOD. - METHOD lif_object_oriented_object_fnc~add_to_activation_list. + + METHOD lif_oo_object_fnc~add_to_activation_list. lcl_objects_activation=>add_item( is_item ). ENDMETHOD. - METHOD lif_object_oriented_object_fnc~update_descriptions. + METHOD lif_oo_object_fnc~update_descriptions. DELETE FROM seocompotx WHERE clsname = is_key-clsname. "#EC CI_SUBRC INSERT seocompotx FROM TABLE it_descriptions. "#EC CI_SUBRC ENDMETHOD. - METHOD lif_object_oriented_object_fnc~insert_text_pool. + METHOD lif_oo_object_fnc~insert_text_pool. ASSERT 0 = 1. "Subclass responsibility ENDMETHOD. - METHOD lif_object_oriented_object_fnc~create_sotr. + METHOD lif_oo_object_fnc~create_sotr. ASSERT 0 = 1. "Subclass responsibility ENDMETHOD. - METHOD lif_object_oriented_object_fnc~create_documentation. + METHOD lif_oo_object_fnc~create_documentation. CALL FUNCTION 'DOCU_UPD' EXPORTING id = 'CL' @@ -512,11 +516,11 @@ CLASS lcl_object_oriented_base IMPLEMENTATION. ENDIF. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~get_includes. + METHOD lif_oo_object_fnc~get_includes. ASSERT 0 = 1. "Subclass responsibility ENDMETHOD. - METHOD lif_object_oriented_object_fnc~exists. + METHOD lif_oo_object_fnc~exists. CALL FUNCTION 'SEO_CLASS_EXISTENCE_CHECK' EXPORTING clskey = iv_object_name @@ -530,8 +534,8 @@ CLASS lcl_object_oriented_base IMPLEMENTATION. rv_exists = boolc( sy-subrc <> 2 ). ENDMETHOD. - METHOD lif_object_oriented_object_fnc~serialize_abap. - DATA lo_oo_serializer TYPE REF TO lcl_oo_object_serializer. + METHOD lif_oo_object_fnc~serialize_abap. + DATA lo_oo_serializer TYPE REF TO lcl_oo_serializer. CREATE OBJECT lo_oo_serializer. CASE iv_type. WHEN seop_ext_class_locals_def. @@ -548,31 +552,30 @@ CLASS lcl_object_oriented_base IMPLEMENTATION. ENDCASE. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~get_skip_test_classes. + METHOD lif_oo_object_fnc~get_skip_test_classes. rv_skip = mv_skip_test_classes. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~get_class_properties. + METHOD lif_oo_object_fnc~get_class_properties. ASSERT 0 = 1. "Subclass responsibility ENDMETHOD. - METHOD lif_object_oriented_object_fnc~get_interface_properties. + METHOD lif_oo_object_fnc~get_interface_properties. ASSERT 0 = 1. "Subclass responsibility ENDMETHOD. - METHOD lif_object_oriented_object_fnc~read_text_pool. + METHOD lif_oo_object_fnc~read_text_pool. ASSERT 0 = 1. "Subclass responsibility ENDMETHOD. - METHOD lif_object_oriented_object_fnc~read_sotr. + METHOD lif_oo_object_fnc~read_sotr. ASSERT 0 = 1. "Subclass responsibility ENDMETHOD. - METHOD lif_object_oriented_object_fnc~read_documentation. - DATA: - lv_state TYPE dokstate, - lv_object TYPE dokhl-object, - lt_lines TYPE tlinetab. + METHOD lif_oo_object_fnc~read_documentation. + DATA: lv_state TYPE dokstate, + lv_object TYPE dokhl-object, + lt_lines TYPE tlinetab. lv_object = iv_class_name. @@ -598,13 +601,13 @@ CLASS lcl_object_oriented_base IMPLEMENTATION. ENDIF. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~read_descriptions. + METHOD lif_oo_object_fnc~read_descriptions. SELECT * FROM seocompotx INTO TABLE rt_descriptions WHERE clsname = iv_obejct_name. "#EC CI_SUBRC DELETE rt_descriptions WHERE descript IS INITIAL. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~delete. + METHOD lif_oo_object_fnc~delete. ASSERT 0 = 1. "Subclass responsibility ENDMETHOD. @@ -613,7 +616,7 @@ ENDCLASS. "Backdoor injection for test purposes CLASS ltcl_oo_factory_injector DEFINITION DEFERRED. -CLASS lcl_object_oriented_factory DEFINITION +CLASS lcl_oo_factory DEFINITION FRIENDS ltcl_oo_factory_injector. PUBLIC SECTION. @@ -622,10 +625,10 @@ CLASS lcl_object_oriented_factory DEFINITION IMPORTING iv_object_type TYPE tadir-object RETURNING - VALUE(ro_object_oriented_object) TYPE REF TO lif_object_oriented_object_fnc. + VALUE(ro_object_oriented_object) TYPE REF TO lif_oo_object_fnc. PRIVATE SECTION. CLASS-DATA: - go_object_oriented_object TYPE REF TO lif_object_oriented_object_fnc. + go_object_oriented_object TYPE REF TO lif_oo_object_fnc. ENDCLASS. "lcl_object_oriented_factory implementation is in include ZABAPGIT_OBJECT_OO_FACTORY. "Reason: In this way, clas and intf specific OO functions implementations can be done diff --git a/src/zabapgit_object_para.prog.abap b/src/zabapgit_object_para.prog.abap index c3ad3e5b8..be4d3613b 100644 --- a/src/zabapgit_object_para.prog.abap +++ b/src/zabapgit_object_para.prog.abap @@ -145,7 +145,7 @@ CLASS lcl_object_para IMPLEMENTATION. ENDMETHOD. "jump METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_para IMPLEMENTATION diff --git a/src/zabapgit_object_pinf.prog.abap b/src/zabapgit_object_pinf.prog.abap index 887be21e3..810d7696e 100644 --- a/src/zabapgit_object_pinf.prog.abap +++ b/src/zabapgit_object_pinf.prog.abap @@ -356,7 +356,7 @@ CLASS lcl_object_pinf IMPLEMENTATION. ENDMETHOD. "jump METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_PINF IMPLEMENTATION diff --git a/src/zabapgit_object_prog.prog.abap b/src/zabapgit_object_prog.prog.abap index c76690046..76867444d 100644 --- a/src/zabapgit_object_prog.prog.abap +++ b/src/zabapgit_object_prog.prog.abap @@ -158,7 +158,7 @@ CLASS lcl_object_prog IMPLEMENTATION. ENDMETHOD. "lif_serialize~deserialize METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. "lif_object~compare_to_remote_version METHOD serialize_texts. diff --git a/src/zabapgit_object_samc.prog.abap b/src/zabapgit_object_samc.prog.abap index 9e21027c3..166d48a1c 100644 --- a/src/zabapgit_object_samc.prog.abap +++ b/src/zabapgit_object_samc.prog.abap @@ -256,9 +256,7 @@ CLASS lcl_object_samc IMPLEMENTATION. ENDMETHOD. "jump METHOD lif_object~compare_to_remote_version. - - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. - + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. METHOD get_data_object. diff --git a/src/zabapgit_object_sapc.prog.abap b/src/zabapgit_object_sapc.prog.abap index fce33c9ef..f05010fa7 100644 --- a/src/zabapgit_object_sapc.prog.abap +++ b/src/zabapgit_object_sapc.prog.abap @@ -256,9 +256,7 @@ CLASS lcl_object_sapc IMPLEMENTATION. ENDMETHOD. "jump METHOD lif_object~compare_to_remote_version. - - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. - + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. METHOD get_data_object. diff --git a/src/zabapgit_object_sfbf.prog.abap b/src/zabapgit_object_sfbf.prog.abap index 83a73b3ad..c9b1147d4 100644 --- a/src/zabapgit_object_sfbf.prog.abap +++ b/src/zabapgit_object_sfbf.prog.abap @@ -249,7 +249,7 @@ CLASS lcl_object_sfbf IMPLEMENTATION. ENDMETHOD. "jump METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_SFBF IMPLEMENTATION diff --git a/src/zabapgit_object_sfbs.prog.abap b/src/zabapgit_object_sfbs.prog.abap index bef654d9c..10d8a8737 100644 --- a/src/zabapgit_object_sfbs.prog.abap +++ b/src/zabapgit_object_sfbs.prog.abap @@ -223,7 +223,7 @@ CLASS lcl_object_sfbs IMPLEMENTATION. ENDMETHOD. "jump METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_SFBS IMPLEMENTATION diff --git a/src/zabapgit_object_sfpf.prog.abap b/src/zabapgit_object_sfpf.prog.abap index 1210ece1d..b8da5dc5b 100644 --- a/src/zabapgit_object_sfpf.prog.abap +++ b/src/zabapgit_object_sfpf.prog.abap @@ -216,7 +216,7 @@ CLASS lcl_object_sfpf IMPLEMENTATION. ENDMETHOD. "deserialize METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_doma IMPLEMENTATION diff --git a/src/zabapgit_object_sfpi.prog.abap b/src/zabapgit_object_sfpi.prog.abap index 1e9a75873..9ba05f810 100644 --- a/src/zabapgit_object_sfpi.prog.abap +++ b/src/zabapgit_object_sfpi.prog.abap @@ -162,7 +162,7 @@ CLASS lcl_object_sfpi IMPLEMENTATION. ENDMETHOD. "deserialize METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_doma IMPLEMENTATION diff --git a/src/zabapgit_object_sfsw.prog.abap b/src/zabapgit_object_sfsw.prog.abap index 0892f359c..b6ca85aef 100644 --- a/src/zabapgit_object_sfsw.prog.abap +++ b/src/zabapgit_object_sfsw.prog.abap @@ -215,7 +215,7 @@ CLASS lcl_object_sfsw IMPLEMENTATION. ENDMETHOD. "jump METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_sfsw IMPLEMENTATION diff --git a/src/zabapgit_object_shi3.prog.abap b/src/zabapgit_object_shi3.prog.abap index 35fb97238..8e9ffbdec 100644 --- a/src/zabapgit_object_shi3.prog.abap +++ b/src/zabapgit_object_shi3.prog.abap @@ -336,7 +336,7 @@ CLASS lcl_object_shi3 IMPLEMENTATION. ENDMETHOD. "deserialize METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_shi3 IMPLEMENTATION diff --git a/src/zabapgit_object_shlp.prog.abap b/src/zabapgit_object_shlp.prog.abap index 604d6f897..307980a74 100644 --- a/src/zabapgit_object_shlp.prog.abap +++ b/src/zabapgit_object_shlp.prog.abap @@ -205,7 +205,7 @@ CLASS lcl_object_shlp IMPLEMENTATION. ENDMETHOD. "deserialize METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_shlp IMPLEMENTATION diff --git a/src/zabapgit_object_sicf.prog.abap b/src/zabapgit_object_sicf.prog.abap index 7eb829388..8fa11f59f 100644 --- a/src/zabapgit_object_sicf.prog.abap +++ b/src/zabapgit_object_sicf.prog.abap @@ -423,7 +423,7 @@ CLASS lcl_object_sicf IMPLEMENTATION. ENDMETHOD. "jump METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_sicf IMPLEMENTATION diff --git a/src/zabapgit_object_smim.prog.abap b/src/zabapgit_object_smim.prog.abap index 92074dcca..4f13dda9e 100644 --- a/src/zabapgit_object_smim.prog.abap +++ b/src/zabapgit_object_smim.prog.abap @@ -332,7 +332,7 @@ CLASS lcl_object_smim IMPLEMENTATION. ENDMETHOD. "jump METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_smim IMPLEMENTATION diff --git a/src/zabapgit_object_splo.prog.abap b/src/zabapgit_object_splo.prog.abap index a50b721b5..af0407f6c 100644 --- a/src/zabapgit_object_splo.prog.abap +++ b/src/zabapgit_object_splo.prog.abap @@ -120,7 +120,7 @@ CLASS lcl_object_splo IMPLEMENTATION. ENDMETHOD. "lif_object~jump METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_splo IMPLEMENTATION diff --git a/src/zabapgit_object_ssfo.prog.abap b/src/zabapgit_object_ssfo.prog.abap index 671881b61..dfdd4aa39 100644 --- a/src/zabapgit_object_ssfo.prog.abap +++ b/src/zabapgit_object_ssfo.prog.abap @@ -240,7 +240,7 @@ CLASS lcl_object_ssfo IMPLEMENTATION. ENDMETHOD. "deserialize METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_ssfo IMPLEMENTATION diff --git a/src/zabapgit_object_ssst.prog.abap b/src/zabapgit_object_ssst.prog.abap index def3c24af..70bb33c9e 100644 --- a/src/zabapgit_object_ssst.prog.abap +++ b/src/zabapgit_object_ssst.prog.abap @@ -204,7 +204,7 @@ CLASS lcl_object_ssst IMPLEMENTATION. ENDMETHOD. "jump METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_ssst IMPLEMENTATION diff --git a/src/zabapgit_object_styl.prog.abap b/src/zabapgit_object_styl.prog.abap index dfc70e266..3e6537cb8 100644 --- a/src/zabapgit_object_styl.prog.abap +++ b/src/zabapgit_object_styl.prog.abap @@ -157,7 +157,7 @@ CLASS lcl_object_styl IMPLEMENTATION. ENDMETHOD. "serialize METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_styl IMPLEMENTATION diff --git a/src/zabapgit_object_susc.prog.abap b/src/zabapgit_object_susc.prog.abap index 3c6b3d706..e29eed257 100644 --- a/src/zabapgit_object_susc.prog.abap +++ b/src/zabapgit_object_susc.prog.abap @@ -122,7 +122,7 @@ CLASS lcl_object_susc IMPLEMENTATION. ENDMETHOD. "jump METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_susc IMPLEMENTATION diff --git a/src/zabapgit_object_suso.prog.abap b/src/zabapgit_object_suso.prog.abap index c17f5251d..eeaa5d49f 100644 --- a/src/zabapgit_object_suso.prog.abap +++ b/src/zabapgit_object_suso.prog.abap @@ -172,7 +172,7 @@ CLASS lcl_object_suso IMPLEMENTATION. ENDMETHOD. "jump METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_suso IMPLEMENTATION diff --git a/src/zabapgit_object_tabl.prog.abap b/src/zabapgit_object_tabl.prog.abap index 5fc1ca688..d1cff6ed3 100644 --- a/src/zabapgit_object_tabl.prog.abap +++ b/src/zabapgit_object_tabl.prog.abap @@ -426,7 +426,7 @@ CLASS lcl_object_tabl IMPLEMENTATION. ENDMETHOD. "deserialize METHOD lif_object~compare_to_remote_version. - DATA: lo_table_validation TYPE REF TO lcl_object_tabl_validation, + DATA: lo_table_validation TYPE REF TO lcl_object_tabl_valid, lo_local_version_output TYPE REF TO lcl_xml_output, lo_local_version_input TYPE REF TO lcl_xml_input, lv_validation_text TYPE string. @@ -445,11 +445,11 @@ CLASS lcl_object_tabl IMPLEMENTATION. io_local_version = lo_local_version_input ). IF lv_validation_text IS NOT INITIAL. lv_validation_text = |Database Table { ms_item-obj_name }: { lv_validation_text }|. - CREATE OBJECT ro_comparison_result TYPE lcl_tabl_validation_dialog + CREATE OBJECT ro_comparison_result TYPE lcl_tabl_valid_dialog EXPORTING iv_message = lv_validation_text. ELSE. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDIF. ENDMETHOD. diff --git a/src/zabapgit_object_tabl_valid.prog.abap b/src/zabapgit_object_tabl_valid.prog.abap index 6c33de4a5..19d7887f3 100644 --- a/src/zabapgit_object_tabl_valid.prog.abap +++ b/src/zabapgit_object_tabl_valid.prog.abap @@ -2,7 +2,7 @@ *& Include zabapgit_object_tabl_valid *&---------------------------------------------------------------------* -CLASS lcl_object_tabl_validation DEFINITION FINAL. +CLASS lcl_object_tabl_valid DEFINITION FINAL. PUBLIC SECTION. METHODS validate IMPORTING @@ -14,20 +14,20 @@ CLASS lcl_object_tabl_validation DEFINITION FINAL. lcx_exception. ENDCLASS. -CLASS lcl_tabl_validation_dialog DEFINITION FINAL. +CLASS lcl_tabl_valid_dialog DEFINITION FINAL. PUBLIC SECTION. METHODS: constructor IMPORTING iv_message TYPE string. - INTERFACES: lif_object_comparison_result. + INTERFACES: lif_comparison_result. + PRIVATE SECTION. DATA mv_message TYPE string. DATA mv_halt TYPE string. - ENDCLASS. -CLASS lcl_object_tabl_validation IMPLEMENTATION. +CLASS lcl_object_tabl_valid IMPLEMENTATION. METHOD validate. DATA: lt_previous_table_fields TYPE TABLE OF dd03p, @@ -60,15 +60,16 @@ CLASS lcl_object_tabl_validation IMPLEMENTATION. ENDCLASS. -CLASS lcl_tabl_validation_dialog IMPLEMENTATION. +CLASS lcl_tabl_valid_dialog IMPLEMENTATION. METHOD constructor. mv_message = iv_message. ENDMETHOD. - METHOD lif_object_comparison_result~is_result_complete_halt. + + METHOD lif_comparison_result~is_result_complete_halt. rv_response = mv_halt. ENDMETHOD. - METHOD lif_object_comparison_result~show_confirmation_dialog. + METHOD lif_comparison_result~show_confirmation_dialog. DATA lv_answer TYPE string. TRY. lv_answer = lcl_popups=>popup_to_confirm( @@ -102,7 +103,8 @@ CLASS lct_table_validation DEFINITION FOR TESTING RISK LEVEL HARMLESS DURATION S create_xmls RAISING lcx_exception. - DATA: mo_table_validator TYPE REF TO lcl_object_tabl_validation, + + DATA: mo_table_validator TYPE REF TO lcl_object_tabl_valid, mo_previous_version_out_xml TYPE REF TO lcl_xml_output, mo_previous_version_input_xml TYPE REF TO lcl_xml_input, mo_current_version_out_xml TYPE REF TO lcl_xml_output, diff --git a/src/zabapgit_object_tobj.prog.abap b/src/zabapgit_object_tobj.prog.abap index 63e83801b..3e1f83f49 100644 --- a/src/zabapgit_object_tobj.prog.abap +++ b/src/zabapgit_object_tobj.prog.abap @@ -195,7 +195,7 @@ CLASS lcl_object_tobj IMPLEMENTATION. ENDMETHOD. "jump METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_tobj IMPLEMENTATION diff --git a/src/zabapgit_object_tran.prog.abap b/src/zabapgit_object_tran.prog.abap index bde7cd698..6e742dd2d 100644 --- a/src/zabapgit_object_tran.prog.abap +++ b/src/zabapgit_object_tran.prog.abap @@ -430,7 +430,7 @@ CLASS lcl_object_tran IMPLEMENTATION. ENDMETHOD. "serialize METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. METHOD serialize_texts. diff --git a/src/zabapgit_object_ttyp.prog.abap b/src/zabapgit_object_ttyp.prog.abap index a621527ca..659af989c 100644 --- a/src/zabapgit_object_ttyp.prog.abap +++ b/src/zabapgit_object_ttyp.prog.abap @@ -184,7 +184,7 @@ CLASS lcl_object_ttyp IMPLEMENTATION. ENDMETHOD. "deserialize METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_ttyp IMPLEMENTATION diff --git a/src/zabapgit_object_type.prog.abap b/src/zabapgit_object_type.prog.abap index 1908b94e0..562b057d7 100644 --- a/src/zabapgit_object_type.prog.abap +++ b/src/zabapgit_object_type.prog.abap @@ -199,14 +199,12 @@ CLASS lcl_object_type IMPLEMENTATION. ENDMETHOD. "delete METHOD lif_object~jump. - jump_se11( iv_radio = 'RSRD1-TYMA' iv_field = 'RSRD1-TYMA_VAL' ). - ENDMETHOD. "jump METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_type IMPLEMENTATION diff --git a/src/zabapgit_object_vcls.prog.abap b/src/zabapgit_object_vcls.prog.abap index 4b4952620..b6afa441b 100644 --- a/src/zabapgit_object_vcls.prog.abap +++ b/src/zabapgit_object_vcls.prog.abap @@ -196,7 +196,7 @@ CLASS lcl_object_vcls IMPLEMENTATION. ENDMETHOD. "jump METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_vcls IMPLEMENTATION diff --git a/src/zabapgit_object_view.prog.abap b/src/zabapgit_object_view.prog.abap index 36a4fd7ed..c540e7e2f 100644 --- a/src/zabapgit_object_view.prog.abap +++ b/src/zabapgit_object_view.prog.abap @@ -261,7 +261,7 @@ CLASS lcl_object_view IMPLEMENTATION. ENDMETHOD. "deserialize METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. "lif_object~compare_to_remote_version ENDCLASS. "lcl_object_view IMPLEMENTATION diff --git a/src/zabapgit_object_w3xx.prog.abap b/src/zabapgit_object_w3xx.prog.abap index bd54a7193..f5a76ef68 100644 --- a/src/zabapgit_object_w3xx.prog.abap +++ b/src/zabapgit_object_w3xx.prog.abap @@ -434,7 +434,7 @@ CLASS lcl_object_w3super IMPLEMENTATION. ENDMETHOD. " find_param. METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_W3SUPER IMPLEMENTATION diff --git a/src/zabapgit_object_wapa.prog.abap b/src/zabapgit_object_wapa.prog.abap index 83d21d0e5..303ff239d 100644 --- a/src/zabapgit_object_wapa.prog.abap +++ b/src/zabapgit_object_wapa.prog.abap @@ -422,7 +422,7 @@ CLASS lcl_object_wapa IMPLEMENTATION. ENDMETHOD. METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_tran IMPLEMENTATION diff --git a/src/zabapgit_object_wdya.prog.abap b/src/zabapgit_object_wdya.prog.abap index 33dec6469..867396b44 100644 --- a/src/zabapgit_object_wdya.prog.abap +++ b/src/zabapgit_object_wdya.prog.abap @@ -236,7 +236,7 @@ CLASS lcl_object_wdya IMPLEMENTATION. ENDMETHOD. "jump METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_wdya IMPLEMENTATION diff --git a/src/zabapgit_object_wdyn.prog.abap b/src/zabapgit_object_wdyn.prog.abap index 363aed4b0..ad1cfcf86 100644 --- a/src/zabapgit_object_wdyn.prog.abap +++ b/src/zabapgit_object_wdyn.prog.abap @@ -809,7 +809,7 @@ CLASS lcl_object_wdyn IMPLEMENTATION. ENDMETHOD. "jump METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. "lif_object~compare_to_remote_version ENDCLASS. "lcl_object_wdyn IMPLEMENTATION diff --git a/src/zabapgit_object_webi.prog.abap b/src/zabapgit_object_webi.prog.abap index d2c5a9110..65189e3c9 100644 --- a/src/zabapgit_object_webi.prog.abap +++ b/src/zabapgit_object_webi.prog.abap @@ -444,7 +444,7 @@ CLASS lcl_object_webi IMPLEMENTATION. ENDMETHOD. "lif_object~get_metadata METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_webi IMPLEMENTATION diff --git a/src/zabapgit_object_xslt.prog.abap b/src/zabapgit_object_xslt.prog.abap index 5037bb3d7..21cddb4f2 100644 --- a/src/zabapgit_object_xslt.prog.abap +++ b/src/zabapgit_object_xslt.prog.abap @@ -199,7 +199,7 @@ CLASS lcl_object_xslt IMPLEMENTATION. ENDMETHOD. "lif_object~get_metadata METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_object_xslt IMPLEMENTATION diff --git a/src/zabapgit_objects.prog.abap b/src/zabapgit_objects.prog.abap index 3df50888b..da243eb83 100644 --- a/src/zabapgit_objects.prog.abap +++ b/src/zabapgit_objects.prog.abap @@ -234,26 +234,26 @@ CLASS lcl_objects_files DEFINITION. ENDCLASS. "lcl_objects_files DEFINITION -INTERFACE lif_object_comparison_result. +INTERFACE lif_comparison_result. METHODS: show_confirmation_dialog, is_result_complete_halt RETURNING VALUE(rv_response) TYPE abap_bool. - ENDINTERFACE. "Null Object Pattern -CLASS lcl_null_comparison_result DEFINITION FINAL. +CLASS lcl_comparison_null DEFINITION FINAL. PUBLIC SECTION. - INTERFACES lif_object_comparison_result. + INTERFACES lif_comparison_result. ENDCLASS. -CLASS lcl_null_comparison_result IMPLEMENTATION. - METHOD lif_object_comparison_result~is_result_complete_halt. +CLASS lcl_comparison_null IMPLEMENTATION. + + METHOD lif_comparison_result~is_result_complete_halt. rv_response = abap_false. ENDMETHOD. - METHOD lif_object_comparison_result~show_confirmation_dialog. + METHOD lif_comparison_result~show_confirmation_dialog. RETURN. ENDMETHOD. @@ -293,7 +293,7 @@ INTERFACE lif_object. METHODS: compare_to_remote_version IMPORTING io_remote_version_xml TYPE REF TO lcl_xml_input - RETURNING VALUE(ro_comparison_result) TYPE REF TO lif_object_comparison_result + RETURNING VALUE(ro_comparison_result) TYPE REF TO lif_comparison_result RAISING lcx_exception. DATA: mo_files TYPE REF TO lcl_objects_files. @@ -785,7 +785,7 @@ CLASS lcl_objects_bridge IMPLEMENTATION. ENDMETHOD. "class_constructor METHOD lif_object~compare_to_remote_version. - CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. ENDMETHOD. ENDCLASS. "lcl_objects_bridge IMPLEMENTATION diff --git a/src/zabapgit_objects_impl.prog.abap b/src/zabapgit_objects_impl.prog.abap index cd3e342f1..2fba5ea1e 100644 --- a/src/zabapgit_objects_impl.prog.abap +++ b/src/zabapgit_objects_impl.prog.abap @@ -702,7 +702,7 @@ CLASS lcl_objects IMPLEMENTATION. DATA: ls_remote_file TYPE lif_defs=>ty_file, lo_remote_version TYPE REF TO lcl_xml_input, - lo_comparison_result TYPE REF TO lif_object_comparison_result. + lo_comparison_result TYPE REF TO lif_comparison_result. IF is_result-filename CS '.XML'. diff --git a/src/zabapgit_page_background.prog.abap b/src/zabapgit_page_background.prog.abap index e1d392b0c..de86b3422 100644 --- a/src/zabapgit_page_background.prog.abap +++ b/src/zabapgit_page_background.prog.abap @@ -2,7 +2,7 @@ *& Include ZABAPGIT_PAGE_BACKGROUND *&---------------------------------------------------------------------* -CLASS lcl_gui_page_background_run DEFINITION FINAL +CLASS lcl_gui_page_bkg_run DEFINITION FINAL INHERITING FROM lcl_gui_page. PUBLIC SECTION. @@ -19,7 +19,7 @@ CLASS lcl_gui_page_background_run DEFINITION FINAL ENDCLASS. -CLASS lcl_gui_page_background_run IMPLEMENTATION. +CLASS lcl_gui_page_bkg_run IMPLEMENTATION. METHOD constructor. super->constructor( ). @@ -72,16 +72,16 @@ CLASS lcl_gui_page_background_run IMPLEMENTATION. ENDCLASS. -CLASS lcl_gui_page_background DEFINITION FINAL +CLASS lcl_gui_page_bkg DEFINITION FINAL INHERITING FROM lcl_gui_page. PUBLIC SECTION. METHODS: - constructor IMPORTING iv_key TYPE lcl_persistence_repo=>ty_repo-key, + constructor IMPORTING iv_key TYPE lcl_persistence_repo=>ty_repo-key, lif_gui_page~on_event REDEFINITION. PROTECTED SECTION. - METHODS render_content REDEFINITION. + METHODS render_content REDEFINITION. PRIVATE SECTION. DATA: @@ -96,7 +96,7 @@ CLASS lcl_gui_page_background DEFINITION FINAL ENDCLASS. -CLASS lcl_gui_page_background IMPLEMENTATION. +CLASS lcl_gui_page_bkg IMPLEMENTATION. METHOD constructor. @@ -116,13 +116,13 @@ CLASS lcl_gui_page_background IMPLEMENTATION. METHOD lif_gui_page~on_event. - DATA ls_bg_task TYPE lcl_persistence_background=>ty_background. + DATA ls_bg_task TYPE lcl_persist_background=>ty_background. CASE iv_action. WHEN lif_defs=>gc_action-bg_update. ls_bg_task = lcl_html_action_utils=>decode_bg_update( iv_getdata ). ls_bg_task-key = mv_key. - lcl_services_background=>update_task( ls_bg_task ). + lcl_services_bkg=>update_task( ls_bg_task ). ev_state = lif_defs=>gc_event_state-re_render. ENDCASE. @@ -131,8 +131,8 @@ CLASS lcl_gui_page_background IMPLEMENTATION. METHOD render_data. DATA: lo_repo TYPE REF TO lcl_repo_online, - lo_per TYPE REF TO lcl_persistence_background, - lt_per TYPE lcl_persistence_background=>tt_background, + lo_per TYPE REF TO lcl_persist_background, + lt_per TYPE lcl_persist_background=>tt_background, ls_per LIKE LINE OF lt_per, lv_nothing TYPE string, lv_push TYPE string, @@ -163,16 +163,16 @@ CLASS lcl_gui_page_background IMPLEMENTATION. ENDIF. CASE ls_per-method. - WHEN lcl_persistence_background=>c_method-push. + WHEN lcl_persist_background=>c_method-push. lv_push = ' checked' ##NO_TEXT. - WHEN lcl_persistence_background=>c_method-pull. + WHEN lcl_persist_background=>c_method-pull. lv_pull = ' checked' ##NO_TEXT. WHEN OTHERS. lv_nothing = ' checked' ##NO_TEXT. ENDCASE. CASE ls_per-amethod. - WHEN lcl_persistence_background=>c_amethod-auto. + WHEN lcl_persist_background=>c_amethod-auto. lv_aauto = ' checked' ##NO_TEXT. WHEN OTHERS. lv_afixed = ' checked' ##NO_TEXT. diff --git a/src/zabapgit_page_branch_overview.prog.abap b/src/zabapgit_page_branch_overview.prog.abap index da2a2d0c9..6850e845f 100644 --- a/src/zabapgit_page_branch_overview.prog.abap +++ b/src/zabapgit_page_branch_overview.prog.abap @@ -302,7 +302,7 @@ ENDCLASS. *********************** -CLASS lcl_gui_page_branch_overview DEFINITION FINAL INHERITING FROM lcl_gui_page. +CLASS lcl_gui_page_boverview DEFINITION FINAL INHERITING FROM lcl_gui_page. PUBLIC SECTION. METHODS: @@ -358,7 +358,7 @@ CLASS lcl_gui_page_branch_overview DEFINITION FINAL INHERITING FROM lcl_gui_page ENDCLASS. "lcl_gui_page_explore DEFINITION -CLASS lcl_gui_page_branch_overview IMPLEMENTATION. +CLASS lcl_gui_page_boverview IMPLEMENTATION. METHOD constructor. super->constructor( ). diff --git a/src/zabapgit_page_db.prog.abap b/src/zabapgit_page_db.prog.abap index f9721172d..ef8183605 100644 --- a/src/zabapgit_page_db.prog.abap +++ b/src/zabapgit_page_db.prog.abap @@ -2,7 +2,7 @@ *& Include ZABAPGIT_PAGE_DB *&---------------------------------------------------------------------* -CLASS lcl_gui_page_db_display DEFINITION FINAL INHERITING FROM lcl_gui_page. +CLASS lcl_gui_page_db_dis DEFINITION FINAL INHERITING FROM lcl_gui_page. PUBLIC SECTION. METHODS: constructor @@ -20,7 +20,7 @@ CLASS lcl_gui_page_db_display DEFINITION FINAL INHERITING FROM lcl_gui_page. ENDCLASS. -CLASS lcl_gui_page_db_display IMPLEMENTATION. +CLASS lcl_gui_page_db_dis IMPLEMENTATION. METHOD constructor. super->constructor( ). @@ -131,7 +131,7 @@ CLASS lcl_gui_page_db_edit IMPLEMENTATION. " Banners & Toolbar ro_html->add( '
' ). - ro_html->add( lcl_gui_page_db_display=>render_record_banner( ms_key ) ). + ro_html->add( lcl_gui_page_db_dis=>render_record_banner( ms_key ) ). ro_html->add( '' ). ro_html->add( lo_toolbar->render( iv_right = abap_true ) ). ro_html->add( '
' ). diff --git a/src/zabapgit_page_main.prog.abap b/src/zabapgit_page_main.prog.abap index c527ef5da..6aa393b40 100644 --- a/src/zabapgit_page_main.prog.abap +++ b/src/zabapgit_page_main.prog.abap @@ -20,7 +20,7 @@ CLASS lcl_gui_page_main DEFINITION FINAL INHERITING FROM lcl_gui_page. END OF c_actions. DATA: mv_show TYPE lcl_persistence_db=>ty_value, - mo_repo_content TYPE REF TO lcl_gui_view_repo_content. + mo_repo_content TYPE REF TO lcl_gui_view_repo. METHODS: test_changed_by @@ -206,7 +206,7 @@ CLASS lcl_gui_page_main IMPLEMENTATION. METHOD render_toc. - DATA: lo_pback TYPE REF TO lcl_persistence_background, + DATA: lo_pback TYPE REF TO lcl_persist_background, lv_current TYPE abap_bool, lv_key TYPE lcl_persistence_repo=>ty_repo-key, lv_icon TYPE string, diff --git a/src/zabapgit_page_repo_settings.prog.abap b/src/zabapgit_page_repo_settings.prog.abap index 2d1604cba..0b135fb55 100644 --- a/src/zabapgit_page_repo_settings.prog.abap +++ b/src/zabapgit_page_repo_settings.prog.abap @@ -2,7 +2,7 @@ *& Include ZABAPGIT_PAGE_REPO_SETTINGS *&---------------------------------------------------------------------* -CLASS lcl_gui_page_repo_settings DEFINITION FINAL INHERITING FROM lcl_gui_page. +CLASS lcl_gui_page_repo_sett DEFINITION FINAL INHERITING FROM lcl_gui_page. PUBLIC SECTION. METHODS: constructor @@ -25,9 +25,9 @@ CLASS lcl_gui_page_repo_settings DEFINITION FINAL INHERITING FROM lcl_gui_page. RETURNING VALUE(rt_post_fields) TYPE tihttpnvp. -ENDCLASS. "lcl_gui_page_debuginfo +ENDCLASS. -CLASS lcl_gui_page_repo_settings IMPLEMENTATION. +CLASS lcl_gui_page_repo_sett IMPLEMENTATION. METHOD constructor. super->constructor( ). diff --git a/src/zabapgit_page_settings.prog.abap b/src/zabapgit_page_settings.prog.abap index 02cfed03e..687ba4b68 100644 --- a/src/zabapgit_page_settings.prog.abap +++ b/src/zabapgit_page_settings.prog.abap @@ -226,7 +226,7 @@ CLASS lcl_gui_page_settings IMPLEMENTATION. METHOD persist_settings. - DATA lo_settings_persistence TYPE REF TO lcl_persistence_settings. + DATA lo_settings_persistence TYPE REF TO lcl_persist_settings. lo_settings_persistence = lcl_app=>settings( ). lo_settings_persistence->modify( mo_settings ). @@ -254,7 +254,7 @@ CLASS lcl_gui_page_settings IMPLEMENTATION. METHOD read_settings. - DATA lo_settings_persistence TYPE REF TO lcl_persistence_settings. + DATA lo_settings_persistence TYPE REF TO lcl_persist_settings. lo_settings_persistence = lcl_app=>settings( ). mo_settings = lo_settings_persistence->read( ). diff --git a/src/zabapgit_persistence.prog.abap b/src/zabapgit_persistence.prog.abap index 57f6cb7f9..dfe670c3b 100644 --- a/src/zabapgit_persistence.prog.abap +++ b/src/zabapgit_persistence.prog.abap @@ -2,7 +2,7 @@ *& Include ZABAPGIT_PERSISTENCE *&---------------------------------------------------------------------* -CLASS lcl_persistence_migrate DEFINITION FINAL. +CLASS lcl_persist_migrate DEFINITION FINAL. PUBLIC SECTION. CLASS-METHODS: run RAISING lcx_exception. @@ -204,7 +204,7 @@ CLASS lcl_persistence_repo DEFINITION FINAL. ENDCLASS. -CLASS lcl_persistence_background DEFINITION FINAL. +CLASS lcl_persist_background DEFINITION FINAL. PUBLIC SECTION. @@ -270,7 +270,7 @@ CLASS lcl_persistence_background DEFINITION FINAL. ENDCLASS. "lcl_persistence_background DEFINITION -CLASS lcl_persistence_background IMPLEMENTATION. +CLASS lcl_persist_background IMPLEMENTATION. METHOD constructor. mo_db = lcl_app=>db( ). @@ -1010,7 +1010,7 @@ CLASS lcl_persistence_repo IMPLEMENTATION. METHOD delete. - DATA: lo_background TYPE REF TO lcl_persistence_background. + DATA: lo_background TYPE REF TO lcl_persist_background. CREATE OBJECT lo_background. lo_background->delete( iv_key ). @@ -1271,7 +1271,7 @@ CLASS lcl_persistence_repo IMPLEMENTATION. ENDCLASS. -CLASS lcl_persistence_migrate IMPLEMENTATION. +CLASS lcl_persist_migrate IMPLEMENTATION. METHOD run. @@ -1662,7 +1662,7 @@ CLASS lcl_settings IMPLEMENTATION. ENDCLASS. -CLASS lcl_persistence_settings DEFINITION FINAL. +CLASS lcl_persist_settings DEFINITION FINAL. PUBLIC SECTION. METHODS modify @@ -1676,7 +1676,7 @@ CLASS lcl_persistence_settings DEFINITION FINAL. ENDCLASS. -CLASS lcl_persistence_settings IMPLEMENTATION. +CLASS lcl_persist_settings IMPLEMENTATION. * todo, refactor this to use XML and only 1 row in the database? METHOD modify. diff --git a/src/zabapgit_persistence_old.prog.abap b/src/zabapgit_persistence_old.prog.abap index 6123998b6..60255aa33 100644 --- a/src/zabapgit_persistence_old.prog.abap +++ b/src/zabapgit_persistence_old.prog.abap @@ -2,14 +2,14 @@ *& Include ZABAPGIT_PERSISTENCE_OLD *&---------------------------------------------------------------------* -CLASS lcl_persistence_migrate DEFINITION DEFERRED. +CLASS lcl_persist_migrate DEFINITION DEFERRED. *----------------------------------------------------------------------* * CLASS lcl_persistence DEFINITION *----------------------------------------------------------------------* * *----------------------------------------------------------------------* -CLASS lcl_persistence DEFINITION FINAL FRIENDS lcl_persistence_migrate. +CLASS lcl_persistence DEFINITION FINAL FRIENDS lcl_persist_migrate. * this class is obsolete, use LCL_PERSISTENCE_REPO instead @@ -370,7 +370,7 @@ ENDCLASS. "lcl_persistence IMPLEMENTATION *----------------------------------------------------------------------* * *----------------------------------------------------------------------* -CLASS lcl_user DEFINITION FINAL FRIENDS lcl_persistence_migrate. +CLASS lcl_user DEFINITION FINAL FRIENDS lcl_persist_migrate. * this class is obsolete, use LCL_PERSISTENCE_USER instead diff --git a/src/zabapgit_repo_browser_util.prog.abap b/src/zabapgit_repo_browser_util.prog.abap index ecbda6fc5..50e69eeea 100644 --- a/src/zabapgit_repo_browser_util.prog.abap +++ b/src/zabapgit_repo_browser_util.prog.abap @@ -2,7 +2,7 @@ *& Include ZABAPGIT_REPO_BROWSER_UTIL *&---------------------------------------------------------------------* -CLASS lcl_repo_content_browser DEFINITION FINAL. +CLASS lcl_repo_content_list DEFINITION FINAL. PUBLIC SECTION. @@ -73,7 +73,7 @@ DEFINE _reduce_state. ENDIF. END-OF-DEFINITION. -CLASS lcl_repo_content_browser IMPLEMENTATION. +CLASS lcl_repo_content_list IMPLEMENTATION. METHOD constructor. mo_repo = io_repo. diff --git a/src/zabapgit_services_background.prog.abap b/src/zabapgit_services_background.prog.abap index 4e372ddc2..40a38dc2e 100644 --- a/src/zabapgit_services_background.prog.abap +++ b/src/zabapgit_services_background.prog.abap @@ -2,25 +2,25 @@ *& Include ZABAPGIT_SERVICES_BACKGROUND *&---------------------------------------------------------------------* -CLASS lcl_services_background DEFINITION FINAL. +CLASS lcl_services_bkg DEFINITION FINAL. PUBLIC SECTION. CLASS-METHODS update_task - IMPORTING is_bg_task TYPE lcl_persistence_background=>ty_background + IMPORTING is_bg_task TYPE lcl_persist_background=>ty_background RAISING lcx_exception. ENDCLASS. "lcl_services_background -CLASS lcl_services_background IMPLEMENTATION. +CLASS lcl_services_bkg IMPLEMENTATION. METHOD update_task. - DATA lo_persistence TYPE REF TO lcl_persistence_background. + DATA lo_persistence TYPE REF TO lcl_persist_background. CREATE OBJECT lo_persistence. - IF is_bg_task-method = lcl_persistence_background=>c_method-nothing. + IF is_bg_task-method = lcl_persist_background=>c_method-nothing. lo_persistence->delete( is_bg_task-key ). ELSE. lo_persistence->modify( is_bg_task ). diff --git a/src/zabapgit_services_repo.prog.abap b/src/zabapgit_services_repo.prog.abap index f34e24db2..4f5b1234e 100644 --- a/src/zabapgit_services_repo.prog.abap +++ b/src/zabapgit_services_repo.prog.abap @@ -311,20 +311,19 @@ CLASS lcl_services_repo IMPLEMENTATION. CALL FUNCTION 'RS_TOOL_ACCESS' EXPORTING operation = 'SHOW' - in_new_window = 'X' + in_new_window = abap_true object_name = iv_package object_type = 'DEVC' - with_objectlist = 'X'. + with_objectlist = abap_true. ENDMETHOD. " open_se80. - METHOD transport_to_branch. DATA: lo_repository TYPE REF TO lcl_repo_online, - lo_transport_to_branch TYPE REF TO lcl_transport_to_branch, + lo_transport_to_branch TYPE REF TO lcl_transport_2_branch, lt_transport_headers TYPE trwbo_request_headers, - lt_transport_objects TYPE scts_tadir, + lt_transport_objects TYPE scts_tadir, ls_transport_to_branch TYPE lif_defs=>ty_transport_to_branch. lo_repository ?= lcl_app=>repo_srv( )->get( iv_repository_key ). @@ -334,6 +333,7 @@ CLASS lcl_services_repo IMPLEMENTATION. IF lt_transport_objects IS INITIAL. lcx_exception=>raise( 'Canceled or List of objects is empty ' ). ENDIF. + ls_transport_to_branch = lcl_popups=>popup_to_create_transp_branch( lt_transport_headers ). diff --git a/src/zabapgit_transport.prog.abap b/src/zabapgit_transport.prog.abap index 58624f287..b2e9badd2 100644 --- a/src/zabapgit_transport.prog.abap +++ b/src/zabapgit_transport.prog.abap @@ -251,7 +251,7 @@ CLASS lcl_transport_objects IMPLEMENTATION. ENDCLASS. -CLASS lcl_transport_to_branch DEFINITION. +CLASS lcl_transport_2_branch DEFINITION. PUBLIC SECTION. METHODS: create @@ -282,7 +282,7 @@ CLASS lcl_transport_to_branch DEFINITION. lcx_exception. ENDCLASS. -CLASS lcl_transport_to_branch IMPLEMENTATION. +CLASS lcl_transport_2_branch IMPLEMENTATION. METHOD create. DATA: diff --git a/src/zabapgit_unit_test.prog.abap b/src/zabapgit_unit_test.prog.abap index 2c23487c0..9ef13f80e 100644 --- a/src/zabapgit_unit_test.prog.abap +++ b/src/zabapgit_unit_test.prog.abap @@ -2159,7 +2159,7 @@ CLASS ltcl_persistence_settings DEFINITION FINAL FOR TESTING read_run_critical_tests FOR TESTING RAISING cx_static_check, read_not_found_critical_tests FOR TESTING RAISING cx_static_check. DATA: - mo_persistence_settings TYPE REF TO lcl_persistence_settings, + mo_persistence_settings TYPE REF TO lcl_persist_settings, mo_settings TYPE REF TO lcl_settings. ENDCLASS. diff --git a/src/zabapgit_unit_test_clas_intf.prog.abap b/src/zabapgit_unit_test_clas_intf.prog.abap index 8ae3779e1..de0f19545 100644 --- a/src/zabapgit_unit_test_clas_intf.prog.abap +++ b/src/zabapgit_unit_test_clas_intf.prog.abap @@ -1,7 +1,7 @@ CLASS ltd_spy_oo_object DEFINITION FOR TESTING. PUBLIC SECTION. - INTERFACES: lif_object_oriented_object_fnc. + INTERFACES: lif_oo_object_fnc. DATA: mv_package TYPE devclass, mv_overwrite TYPE seox_boolean, @@ -37,7 +37,7 @@ CLASS ltd_spy_oo_object DEFINITION FOR TESTING. ENDCLASS. CLASS ltd_spy_oo_object IMPLEMENTATION. - METHOD lif_object_oriented_object_fnc~create. + METHOD lif_oo_object_fnc~create. DATA lv_properties_structure_name TYPE string. lv_properties_structure_name = cl_abap_typedescr=>describe_by_data( is_properties )->absolute_name. IF lv_properties_structure_name = cl_abap_typedescr=>describe_by_data( ms_interface_properties )->absolute_name. @@ -48,7 +48,8 @@ CLASS ltd_spy_oo_object IMPLEMENTATION. mv_package = iv_package. mv_overwrite = iv_overwrite. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~generate_locals. + + METHOD lif_oo_object_fnc~generate_locals. ms_locals_key = is_key. mt_local_definitions = it_local_definitions. mt_local_implementations = it_local_implementations. @@ -57,21 +58,21 @@ CLASS ltd_spy_oo_object IMPLEMENTATION. mv_force = iv_force. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~deserialize_source. + METHOD lif_oo_object_fnc~deserialize_source. ms_deserialize_key = is_key. mt_source = it_source. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~add_to_activation_list. + METHOD lif_oo_object_fnc~add_to_activation_list. ms_item_to_activate = is_item. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~update_descriptions. + METHOD lif_oo_object_fnc~update_descriptions. ms_description_key = is_key. mt_descriptions = it_descriptions. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~insert_text_pool. + METHOD lif_oo_object_fnc~insert_text_pool. mv_text_pool_inserted = abap_true. mv_text_pool_class_name = iv_class_name. mt_text_pool = it_text_pool. @@ -80,28 +81,28 @@ CLASS ltd_spy_oo_object IMPLEMENTATION. exp = sy-langu ). ENDMETHOD. - METHOD lif_object_oriented_object_fnc~create_sotr. + METHOD lif_oo_object_fnc~create_sotr. mt_sotr = it_sotr. mt_sotr_package = iv_package. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~create_documentation. + METHOD lif_oo_object_fnc~create_documentation. mv_docu_object_name = iv_object_name. mv_docu_language = iv_language. mt_docu_lines = it_lines. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~get_includes. + METHOD lif_oo_object_fnc~get_includes. APPEND 'dummy' TO rt_includes. mv_get_includes_called = abap_true. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~exists. + METHOD lif_oo_object_fnc~exists. mv_exists_called = abap_true. rv_exists = mv_exists. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~serialize_abap. + METHOD lif_oo_object_fnc~serialize_abap. ms_serialize_key = is_class_key. CASE iv_type. WHEN seop_ext_class_locals_def. @@ -117,35 +118,35 @@ CLASS ltd_spy_oo_object IMPLEMENTATION. ENDCASE. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~get_class_properties. + METHOD lif_oo_object_fnc~get_class_properties. rs_class_properties = ms_class_properties. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~get_interface_properties. + METHOD lif_oo_object_fnc~get_interface_properties. rs_interface_properties = ms_interface_properties. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~read_text_pool. + METHOD lif_oo_object_fnc~read_text_pool. rt_text_pool = mt_text_pool. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~read_sotr. + METHOD lif_oo_object_fnc~read_sotr. rt_sotr = mt_sotr. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~read_documentation. + METHOD lif_oo_object_fnc~read_documentation. rt_lines = mt_docu_lines. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~read_descriptions. + METHOD lif_oo_object_fnc~read_descriptions. rt_descriptions = mt_descriptions. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~get_skip_test_classes. + METHOD lif_oo_object_fnc~get_skip_test_classes. rv_skip = mv_skip_test_classes. ENDMETHOD. - METHOD lif_object_oriented_object_fnc~delete. + METHOD lif_oo_object_fnc~delete. ms_delete_key = is_deletion_key. ENDMETHOD. diff --git a/src/zabapgit_view_repo.prog.abap b/src/zabapgit_view_repo.prog.abap index 700a58823..8c88e7394 100644 --- a/src/zabapgit_view_repo.prog.abap +++ b/src/zabapgit_view_repo.prog.abap @@ -2,7 +2,7 @@ *& Include ZABAPGIT_VIEW_REPO *&---------------------------------------------------------------------* -CLASS lcl_gui_view_repo_content DEFINITION FINAL. +CLASS lcl_gui_view_repo DEFINITION FINAL. PUBLIC SECTION. INTERFACES lif_gui_page. ALIASES render FOR lif_gui_page~render. @@ -44,20 +44,20 @@ CLASS lcl_gui_view_repo_content DEFINITION FINAL. RETURNING VALUE(ro_toolbar) TYPE REF TO lcl_html_toolbar RAISING lcx_exception, render_item - IMPORTING is_item TYPE lcl_repo_content_browser=>ty_repo_item + IMPORTING is_item TYPE lcl_repo_content_list=>ty_repo_item RETURNING VALUE(ro_html) TYPE REF TO lcl_html RAISING lcx_exception, render_item_files - IMPORTING is_item TYPE lcl_repo_content_browser=>ty_repo_item + IMPORTING is_item TYPE lcl_repo_content_list=>ty_repo_item RETURNING VALUE(ro_html) TYPE REF TO lcl_html, render_item_command - IMPORTING is_item TYPE lcl_repo_content_browser=>ty_repo_item + IMPORTING is_item TYPE lcl_repo_content_list=>ty_repo_item RETURNING VALUE(ro_html) TYPE REF TO lcl_html, get_item_class - IMPORTING is_item TYPE lcl_repo_content_browser=>ty_repo_item + IMPORTING is_item TYPE lcl_repo_content_list=>ty_repo_item RETURNING VALUE(rv_html) TYPE string, get_item_icon - IMPORTING is_item TYPE lcl_repo_content_browser=>ty_repo_item + IMPORTING is_item TYPE lcl_repo_content_list=>ty_repo_item RETURNING VALUE(rv_html) TYPE string, render_empty_package RETURNING VALUE(rv_html) TYPE string, @@ -67,7 +67,7 @@ CLASS lcl_gui_view_repo_content DEFINITION FINAL. METHODS: build_obj_jump_link - IMPORTING is_item TYPE lcl_repo_content_browser=>ty_repo_item + IMPORTING is_item TYPE lcl_repo_content_list=>ty_repo_item RETURNING VALUE(rv_html) TYPE string, build_dir_jump_link IMPORTING iv_path TYPE string @@ -75,7 +75,7 @@ CLASS lcl_gui_view_repo_content DEFINITION FINAL. ENDCLASS. "lcl_gui_view_repo_content -CLASS lcl_gui_view_repo_content IMPLEMENTATION. +CLASS lcl_gui_view_repo IMPLEMENTATION. METHOD constructor. @@ -123,8 +123,8 @@ CLASS lcl_gui_view_repo_content IMPLEMENTATION. METHOD lif_gui_page~render. - DATA: lt_repo_items TYPE lcl_repo_content_browser=>tt_repo_items, - lo_browser TYPE REF TO lcl_repo_content_browser, + DATA: lt_repo_items TYPE lcl_repo_content_list=>tt_repo_items, + lo_browser TYPE REF TO lcl_repo_content_list, lx_error TYPE REF TO lcx_exception, lv_lstate TYPE char1, lv_rstate TYPE char1,