SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 04:08:27 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #689 from larshp/cleanup2

Browse Source 
delete more unused variables
This commit is contained in:
Lars Hvam 2017-03-24 07:21:39 +01:00 committed by GitHub
commit 828414d67e
15 changed files with 13 additions and 109 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/zabapgit_2fa.prog.abap
View File

@ -309,8 +309,6 @@ CLASS lcl_2fa_github_authenticator DEFINITION
set_new_token_request IMPORTING ii_request TYPE REF TO if_http_request,
get_token_from_response IMPORTING ii_response TYPE REF TO if_http_response
RETURNING VALUE(rv_token) TYPE string,
parse_repo_from_url IMPORTING iv_url TYPE string
RETURNING VALUE(rv_repo_name) TYPE string,
set_list_token_request IMPORTING ii_request TYPE REF TO if_http_request,
get_tobedel_tokens_from_resp IMPORTING ii_response TYPE REF TO if_http_response
RETURNING VALUE(rt_ids) TYPE stringtab,
@ -445,25 +443,6 @@ CLASS lcl_2fa_github_authenticator IMPLEMENTATION.
ENDWHILE.
ENDMETHOD.
METHOD parse_repo_from_url.
* method not used?
ASSERT 0 = 1.
* CONSTANTS: lc_search_regex TYPE string VALUE 'https?:\/\/(www\.)?github.com\/(.*)$'.
* DATA: lo_regex TYPE REF TO cl_abap_regex,
* lo_matcher TYPE REF TO cl_abap_matcher.
*
* CREATE OBJECT lo_regex
* EXPORTING
* pattern = lc_search_regex.
*
* lo_matcher = lo_regex->create_matcher( text = iv_url ).
* IF lo_matcher->match( ) = abap_true.
* rv_repo_name = lo_matcher->get_submatch( 1 ).
* ELSE.
* rv_repo_name = '???' ##NO_TEXT.
* ENDIF.
ENDMETHOD.
METHOD get_service_id_from_url.
rv_id = 'github'.
ENDMETHOD.
@ -689,7 +668,6 @@ CLASS lcl_2fa_authenticator_registry DEFINITION
"! All authenticators managed by the registry
gt_registered_authenticators TYPE HASHED TABLE OF REF TO lif_2fa_authenticator
WITH UNIQUE KEY table_line READ-ONLY.
PROTECTED SECTION.
PRIVATE SECTION.
CLASS-METHODS:
popup_token

2
src/zabapgit_folder_logic.prog.abap
View File

@ -274,7 +274,7 @@ CLASS ltcl_folder_logic IMPLEMENTATION.
iv_package = '$FOOBAR'
iv_path = '/src/' ).
cl_abap_unit_assert=>fail( 'Error expected' ).
CATCH lcx_exception.
CATCH lcx_exception ##NO_HANDLER.
ENDTRY.
ENDMETHOD.

6
src/zabapgit_html.prog.abap
View File

@ -38,7 +38,6 @@ CLASS lcl_html DEFINITION FINAL.
IMPORTING
iv_name TYPE string
iv_hint TYPE string OPTIONAL
iv_alt TYPE string OPTIONAL
iv_class TYPE string OPTIONAL.
CLASS-METHODS a
@ -56,7 +55,6 @@ CLASS lcl_html DEFINITION FINAL.
IMPORTING
iv_name TYPE string
iv_hint TYPE string OPTIONAL
iv_alt TYPE string OPTIONAL
iv_class TYPE string OPTIONAL
RETURNING VALUE(rv_str) TYPE string.
@ -108,8 +106,7 @@ CLASS lcl_html IMPLEMENTATION.
DATA: lv_type TYPE c,
lo_html TYPE REF TO lcl_html.
FIELD-SYMBOLS: <tab> TYPE string_table,
<str> LIKE LINE OF <tab>.
FIELD-SYMBOLS: <tab> TYPE string_table.
DESCRIBE FIELD iv_chunk TYPE lv_type. " Describe is faster than RTTI classes
@ -339,7 +336,6 @@ CLASS lcl_html IMPLEMENTATION.
add( icon( iv_name = iv_name
iv_class = iv_class
iv_alt = iv_alt
iv_hint = iv_hint ) ).
ENDMETHOD. "add_icon

4
src/zabapgit_object_fugr.prog.abap
View File

@ -395,8 +395,7 @@ CLASS lcl_object_fugr IMPLEMENTATION.
METHOD serialize_xml.
DATA: lt_functab TYPE ty_rs38l_incl_tt,
lt_includes TYPE rso_t_objnm,
DATA: lt_includes TYPE rso_t_objnm,
lv_areat TYPE tlibt-areat.
@ -405,7 +404,6 @@ CLASS lcl_object_fugr IMPLEMENTATION.
WHERE spras = mv_language
AND area = ms_item-obj_name. "#EC CI_GENBUFF "#EC CI_SUBRC
lt_functab = functions( ).
lt_includes = includes( ).
io_xml->add( iv_name = 'AREAT'

1
src/zabapgit_object_oo_functions.prog.abap
View File

@ -135,7 +135,6 @@ CLASS lcl_oo_object_serializer DEFINITION.
serialize_abap_clif_source
IMPORTING
is_class_key TYPE seoclskey
iv_type TYPE seop_include_ext_app OPTIONAL
RETURNING
VALUE(rt_source) TYPE ty_string_tt
RAISING

2
src/zabapgit_object_view.prog.abap
View File

@ -86,7 +86,7 @@ CLASS lcl_object_view IMPLEMENTATION.
IF lv_ddl_view = abap_true.
rv_bool = abap_false.
ENDIF.
CATCH cx_root.
CATCH cx_root ##NO_HANDLER.
ENDTRY.
ENDIF.

2
src/zabapgit_page_commit.prog.abap
View File

@ -157,7 +157,6 @@ CLASS lcl_gui_page_commit IMPLEMENTATION.
DATA: lo_user TYPE REF TO lcl_persistence_user,
lv_user TYPE string,
lv_key TYPE lcl_persistence_db=>ty_value,
lv_email TYPE string.
* see https://git-scm.com/book/ch5-2.html
@ -165,7 +164,6 @@ CLASS lcl_gui_page_commit IMPLEMENTATION.
* body should wrap at 72 characters
lo_user = lcl_app=>user( ).
lv_key = mo_repo->get_key( ).
lv_user = lo_user->get_repo_git_user_name( mo_repo->get_url( ) ).
IF lv_user IS INITIAL.

10
src/zabapgit_page_main.prog.abap
View File

@ -145,12 +145,10 @@ CLASS lcl_gui_page_main IMPLEMENTATION.
METHOD retrieve_active_repo.
DATA: lt_repos TYPE lcl_repo_srv=>ty_repo_tt,
lo_repo LIKE LINE OF lt_repos,
lv_show_old LIKE mv_show.
DATA: lv_show_old LIKE mv_show.
TRY.
lt_repos = lcl_app=>repo_srv( )->list( ).
lcl_app=>repo_srv( )->list( ).
CATCH lcx_exception.
RETURN.
ENDTRY.
@ -160,7 +158,7 @@ CLASS lcl_gui_page_main IMPLEMENTATION.
IF mv_show IS NOT INITIAL.
TRY. " verify the key exists
lo_repo = lcl_app=>repo_srv( )->get( mv_show ).
lcl_app=>repo_srv( )->get( mv_show ).
CATCH lcx_exception.
CLEAR mv_show.
lcl_app=>user( )->set_repo_show( mv_show ).
@ -274,7 +272,7 @@ CLASS lcl_gui_page_main IMPLEMENTATION.
ro_html->add( '<table class="w100"><tr>' ).
ro_html->add( |<td class="pad-sides">{
lcl_html=>icon( iv_name = 'star/blue' iv_alt = 'Favs' iv_hint = 'Favorites' )
lcl_html=>icon( iv_name = 'star/blue' iv_hint = 'Favorites' )
}</td>| ).
ro_html->add( '<td class="pad-sides w100 favorites">' ). " Maximize width

8
src/zabapgit_popups.prog.abap
View File

@ -71,7 +71,6 @@ CLASS lcl_popups DEFINITION FINAL.
RAISING lcx_exception,
popup_to_create_transp_branch
IMPORTING it_transport_headers TYPE trwbo_request_headers
it_transport_objects TYPE scts_tadir
RETURNING VALUE(rs_transport_branch) TYPE ty_transport_to_branch
RAISING lcx_exception
lcx_cancel,
@ -592,9 +591,6 @@ CLASS lcl_popups IMPLEMENTATION.
METHOD popup_to_create_transp_branch.
DATA: lv_returncode TYPE c,
lt_fields TYPE TABLE OF sval,
lv_icon_ok TYPE icon-name,
lv_button_transport TYPE svalbutton-buttontext,
lv_icon_transport TYPE icon-name,
lv_transports_as_text TYPE string,
ls_transport_header LIKE LINE OF it_transport_headers.
@ -609,10 +605,6 @@ CLASS lcl_popups IMPLEMENTATION.
_add_dialog_fld 'TEXTL' 'LINE' 'Branch name' lv_transports_as_text ''.
_add_dialog_fld 'ABAPTXT255' 'LINE' 'Commit text' lv_transports_as_text ''.
lv_icon_ok = icon_okay.
lv_button_transport = 'Transport(s)->Branch' ##NO_TEXT.
lv_icon_transport = icon_import_all_requests.
CALL FUNCTION 'POPUP_GET_VALUES'
EXPORTING
* no_value_check = SPACE " Deactivates data type check

3
src/zabapgit_requirements.prog.abap
View File

@ -40,7 +40,6 @@ CLASS lcl_requirement_helper DEFINITION FINAL.
get_requirement_met_status IMPORTING it_requirements TYPE lcl_dot_abapgit=>ty_requirement_tt
RETURNING value(rt_status) TYPE ty_requirement_status_tt
RAISING lcx_exception.
PROTECTED SECTION.
PRIVATE SECTION.
CLASS-METHODS:
show_requirement_popup IMPORTING it_requirements TYPE ty_requirement_status_tt
@ -122,7 +121,7 @@ CLASS lcl_requirement_helper IMPLEMENTATION.
ENDMETHOD. "get_requirement_met_status
METHOD version_greater_or_equal.
DATA: lv_number TYPE numc4.
DATA: lv_number TYPE numc4 ##NEEDED.
TRY.
MOVE EXACT: is_status-installed_release TO lv_number,

3
src/zabapgit_services_repo.prog.abap
View File

@ -335,8 +335,7 @@ CLASS lcl_services_repo IMPLEMENTATION.
lcx_exception=>raise( 'Canceled or List of objects is empty ' ).
ENDIF.
ls_transport_to_branch = lcl_popups=>popup_to_create_transp_branch(
it_transport_headers = lt_transport_headers
it_transport_objects = lt_transport_objects ).
lt_transport_headers ).
CREATE OBJECT lo_transport_to_branch.
lo_transport_to_branch->create(

4
src/zabapgit_syntax_highlighter.prog.abap
View File

@ -577,7 +577,6 @@ CLASS lcl_syntax_xml IMPLEMENTATION.
DATA:
lv_index TYPE sy-tabix,
lv_line_len TYPE i,
lv_prev_token TYPE c,
lv_state TYPE c VALUE 'O'. " O - for open tag; C - for closed tag;
@ -585,9 +584,8 @@ CLASS lcl_syntax_xml IMPLEMENTATION.
<prev> TYPE ty_match,
<match> TYPE ty_match.
SORT ct_matches BY offset.
lv_line_len = strlen( iv_line ).
SORT ct_matches BY offset.
LOOP AT ct_matches ASSIGNING <match>.
lv_index = sy-tabix.

5
src/zabapgit_tadir.prog.abap
View File

@ -126,8 +126,7 @@ CLASS lcl_tadir IMPLEMENTATION.
METHOD build.
DATA: lv_index TYPE i,
lt_tadir TYPE ty_tadir_tt,
DATA: lt_tadir TYPE ty_tadir_tt,
lt_tdevc TYPE STANDARD TABLE OF tdevc,
lv_path TYPE string.
@ -154,8 +153,6 @@ CLASS lcl_tadir IMPLEMENTATION.
ENDIF.
LOOP AT rt_tadir ASSIGNING <ls_tadir>.
lv_index = sy-tabix.
<ls_tadir>-path = lv_path.
CASE <ls_tadir>-object.

4
src/zabapgit_util.prog.abap
View File

@ -371,12 +371,10 @@ CLASS lcl_path IMPLEMENTATION.
METHOD split_file_location.
DATA: lv_cnt TYPE i,
lv_off TYPE i,
lv_len TYPE i.
FIND FIRST OCCURRENCE OF REGEX '^/(.*/)?' IN iv_fullpath
MATCH COUNT lv_cnt
MATCH OFFSET lv_off
MATCH LENGTH lv_len.
IF lv_cnt > 0.
@ -513,7 +511,7 @@ CLASS lcl_url IMPLEMENTATION.
METHOD path_name.
DATA: lv_host TYPE string.
DATA: lv_host TYPE string ##NEEDED.
FIND REGEX '(.*://[^/]*)(.*)' IN iv_repo
SUBMATCHES lv_host rv_path_name.

46
src/zabapgit_zip.prog.abap
View File

@ -55,10 +55,6 @@ CLASS lcl_zip DEFINITION FINAL.
RETURNING VALUE(rv_xstr) TYPE xstring
RAISING lcx_exception.
CLASS-METHODS get_message
RETURNING VALUE(rv_message) TYPE string
RAISING lcx_exception.
ENDCLASS. "lcl_zip DEFINITION
*----------------------------------------------------------------------*
@ -68,46 +64,6 @@ ENDCLASS. "lcl_zip DEFINITION
*----------------------------------------------------------------------*
CLASS lcl_zip IMPLEMENTATION.
METHOD get_message.
* method not in use?
ASSERT 0 = 1.
* DATA: lv_returncode TYPE c,
* lt_fields TYPE TABLE OF sval.
*
* FIELD-SYMBOLS: <ls_field> LIKE LINE OF lt_fields.
*
*
* APPEND INITIAL LINE TO lt_fields ASSIGNING <ls_field>.
* <ls_field>-tabname = 'ABAPTXT255'.
* <ls_field>-fieldname = 'LINE'.
* <ls_field>-fieldtext = 'Commit message'. "#EC NOTEXT
* <ls_field>-field_obl = abap_true.
*
* CALL FUNCTION 'POPUP_GET_VALUES'
* EXPORTING
* no_value_check = abap_true
* popup_title = 'Enter commit message' "#EC NOTEXT
* IMPORTING
* returncode = lv_returncode
* TABLES
* fields = lt_fields
* EXCEPTIONS
* error_in_fields = 1
* OTHERS = 2.
* IF sy-subrc <> 0.
* lcx_exception=>raise( 'Error from POPUP_GET_VALUES' ).
* ENDIF.
* IF lv_returncode = 'A'.
* lcx_exception=>raise( 'cancelled' ).
* ENDIF.
*
* READ TABLE lt_fields INDEX 1 ASSIGNING <ls_field>.
* ASSERT sy-subrc = 0.
* rv_message = <ls_field>-value.
ENDMETHOD. "get_message
METHOD file_download.
DATA: lt_rawdata TYPE solix_tab,
@ -400,8 +356,6 @@ CLASS lcl_zip IMPLEMENTATION.
DATA: lo_log TYPE REF TO lcl_log,
lt_zip TYPE ty_files_item_tt.
FIELD-SYMBOLS: <ls_zip> LIKE LINE OF lt_zip.
CREATE OBJECT lo_log.