From 86657cc6917786f356a6113f36665419d75159d7 Mon Sep 17 00:00:00 2001 From: Lars Hvam Date: Mon, 31 Aug 2020 09:37:36 +0200 Subject: [PATCH] HTML refactoring (#3813) * HTML refactoring * removes the ADD_ICON alias #3460 * remove IS_EMPTY alias * more * refactoring --- src/ui/core/zcl_abapgit_html.clas.abap | 88 ++++--- src/ui/zcl_abapgit_gui_chunk_lib.clas.abap | 10 +- .../zcl_abapgit_gui_page_code_insp.clas.abap | 2 +- .../zcl_abapgit_gui_page_codi_base.clas.abap | 2 +- src/ui/zcl_abapgit_gui_page_diff.clas.abap | 50 ++-- src/ui/zcl_abapgit_gui_page_patch.clas.abap | 233 ++++++++---------- src/ui/zcl_abapgit_gui_page_stage.clas.abap | 8 +- src/ui/zcl_abapgit_gui_page_syntax.clas.abap | 2 +- .../zcl_abapgit_gui_page_tutorial.clas.abap | 2 +- .../zcl_abapgit_gui_page_view_repo.clas.abap | 2 +- src/ui/zcl_abapgit_gui_repo_over.clas.abap | 8 +- 11 files changed, 191 insertions(+), 216 deletions(-) diff --git a/src/ui/core/zcl_abapgit_html.clas.abap b/src/ui/core/zcl_abapgit_html.clas.abap index 2809aa8e8..8d92d5130 100644 --- a/src/ui/core/zcl_abapgit_html.clas.abap +++ b/src/ui/core/zcl_abapgit_html.clas.abap @@ -10,12 +10,8 @@ CLASS zcl_abapgit_html DEFINITION FOR zif_abapgit_html~add . ALIASES add_checkbox FOR zif_abapgit_html~add_checkbox . - ALIASES add_icon - FOR zif_abapgit_html~add_icon . ALIASES icon FOR zif_abapgit_html~icon . - ALIASES is_empty - FOR zif_abapgit_html~is_empty . CONSTANTS c_indent_size TYPE i VALUE 2 ##NO_TEXT. @@ -121,43 +117,6 @@ CLASS ZCL_ABAPGIT_HTML IMPLEMENTATION. ENDMETHOD. - METHOD icon. - - DATA: lv_hint TYPE string, - lv_name TYPE string, - lv_color TYPE string, - lv_class TYPE string, - lv_large_icon TYPE string, - lv_xpixel TYPE i, - lv_onclick TYPE string. - - SPLIT iv_name AT '/' INTO lv_name lv_color. - - IF iv_hint IS NOT INITIAL. - lv_hint = | title="{ iv_hint }"|. - ENDIF. - IF iv_onclick IS NOT INITIAL. - lv_onclick = | onclick="{ iv_onclick }"|. - ENDIF. - IF iv_class IS NOT INITIAL. - lv_class = | { iv_class }|. - ENDIF. - IF lv_color IS NOT INITIAL. - lv_color = | { lv_color }|. - ENDIF. - - lv_xpixel = cl_gui_cfw=>compute_pixel_from_metric( x_or_y = 'X' - in = 1 ). - IF lv_xpixel >= 2. - lv_large_icon = ' large'. - ENDIF. - - rv_str = ||. - - ENDMETHOD. - - METHOD indent_line. DATA: ls_study TYPE ty_study_result, @@ -208,11 +167,6 @@ CLASS ZCL_ABAPGIT_HTML IMPLEMENTATION. ENDMETHOD. - METHOD is_empty. - rv_yes = boolc( lines( mt_buffer ) = 0 ). - ENDMETHOD. - - METHOD study_line. DATA: lv_line TYPE string, @@ -365,6 +319,48 @@ CLASS ZCL_ABAPGIT_HTML IMPLEMENTATION. ENDMETHOD. + METHOD zif_abapgit_html~icon. + + DATA: lv_hint TYPE string, + lv_name TYPE string, + lv_color TYPE string, + lv_class TYPE string, + lv_large_icon TYPE string, + lv_xpixel TYPE i, + lv_onclick TYPE string. + + SPLIT iv_name AT '/' INTO lv_name lv_color. + + IF iv_hint IS NOT INITIAL. + lv_hint = | title="{ iv_hint }"|. + ENDIF. + IF iv_onclick IS NOT INITIAL. + lv_onclick = | onclick="{ iv_onclick }"|. + ENDIF. + IF iv_class IS NOT INITIAL. + lv_class = | { iv_class }|. + ENDIF. + IF lv_color IS NOT INITIAL. + lv_color = | { lv_color }|. + ENDIF. + + lv_xpixel = cl_gui_cfw=>compute_pixel_from_metric( x_or_y = 'X' + in = 1 ). + IF lv_xpixel >= 2. + lv_large_icon = ' large'. + ENDIF. + + rv_str = ||. + + ENDMETHOD. + + + METHOD zif_abapgit_html~is_empty. + rv_yes = boolc( lines( mt_buffer ) = 0 ). + ENDMETHOD. + + METHOD zif_abapgit_html~render. DATA: ls_context TYPE ty_indent_context, diff --git a/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap b/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap index f5f45a83c..6c1b1b84f 100644 --- a/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap +++ b/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap @@ -83,7 +83,7 @@ CLASS zcl_abapgit_gui_chunk_lib DEFINITION IMPORTING !iv_text TYPE string RETURNING - VALUE(ro_html) TYPE REF TO zcl_abapgit_html . + VALUE(ri_html) TYPE REF TO zif_abapgit_html . CLASS-METHODS render_infopanel IMPORTING !iv_div_id TYPE string @@ -813,10 +813,10 @@ CLASS ZCL_ABAPGIT_GUI_CHUNK_LIB IMPLEMENTATION. METHOD render_warning_banner. - CREATE OBJECT ro_html. - ro_html->add( '
' ). - ro_html->add( |{ zcl_abapgit_html=>icon( 'exclamation-triangle/yellow' ) }| && | { iv_text }| ). - ro_html->add( '
' ). + CREATE OBJECT ri_html TYPE zcl_abapgit_html. + ri_html->add( '
' ). + ri_html->add( |{ ri_html->icon( 'exclamation-triangle/yellow' ) }| && | { iv_text }| ). + ri_html->add( '
' ). ENDMETHOD. ENDCLASS. diff --git a/src/ui/zcl_abapgit_gui_page_code_insp.clas.abap b/src/ui/zcl_abapgit_gui_page_code_insp.clas.abap index a03c91844..c864c5ec1 100644 --- a/src/ui/zcl_abapgit_gui_page_code_insp.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_code_insp.clas.abap @@ -190,7 +190,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_CODE_INSP IMPLEMENTATION. IF lines( mt_result ) = 0. ri_html->add( '
' ). - ri_html->add( zcl_abapgit_html=>icon( 'check' ) ). + ri_html->add( ri_html->icon( 'check' ) ). ri_html->add( 'No code inspector findings' ). ri_html->add( '
' ). ELSE. diff --git a/src/ui/zcl_abapgit_gui_page_codi_base.clas.abap b/src/ui/zcl_abapgit_gui_page_codi_base.clas.abap index 33efe71c0..46adbf9b0 100644 --- a/src/ui/zcl_abapgit_gui_page_codi_base.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_codi_base.clas.abap @@ -185,7 +185,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_CODI_BASE IMPLEMENTATION. IF lines( it_result ) > lc_limit. ii_html->add( '
' ). - ii_html->add( zcl_abapgit_html=>icon( 'exclamation-triangle' ) ). + ii_html->add( ii_html->icon( 'exclamation-triangle' ) ). ii_html->add( |Only first { lc_limit } findings shown in list!| ). ii_html->add( '
' ). ENDIF. diff --git a/src/ui/zcl_abapgit_gui_page_diff.clas.abap b/src/ui/zcl_abapgit_gui_page_diff.clas.abap index a09688ded..7251294dc 100644 --- a/src/ui/zcl_abapgit_gui_page_diff.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_diff.clas.abap @@ -81,7 +81,7 @@ CLASS zcl_abapgit_gui_page_diff DEFINITION !is_diff TYPE ty_file_diff . METHODS render_beacon_begin_of_row IMPORTING - !io_html TYPE REF TO zcl_abapgit_html + !ii_html TYPE REF TO zif_abapgit_html !is_diff TYPE ty_file_diff . METHODS render_diff_head_after_state IMPORTING @@ -92,7 +92,7 @@ CLASS zcl_abapgit_gui_page_diff DEFINITION VALUE(rv_insert_nav) TYPE abap_bool . METHODS render_line_split_row IMPORTING - !io_html TYPE REF TO zcl_abapgit_html + !ii_html TYPE REF TO zif_abapgit_html !iv_filename TYPE string !is_diff_line TYPE zif_abapgit_definitions=>ty_diff !iv_index TYPE sy-tabix @@ -115,7 +115,7 @@ CLASS zcl_abapgit_gui_page_diff DEFINITION END OF c_actions . DATA mt_delayed_lines TYPE zif_abapgit_definitions=>ty_diffs_tt . DATA mv_repo_key TYPE zif_abapgit_persistence=>ty_repo-key . - DATA mv_seed TYPE string . " Unique page id to bind JS sessionStorage + DATA mv_seed TYPE string . " Unique page id to bind JS sessionStorage METHODS render_diff IMPORTING @@ -141,7 +141,7 @@ CLASS zcl_abapgit_gui_page_diff DEFINITION !is_diff_line TYPE zif_abapgit_definitions=>ty_diff !is_diff TYPE ty_file_diff RETURNING - VALUE(ro_html) TYPE REF TO zcl_abapgit_html . + VALUE(ri_html) TYPE REF TO zif_abapgit_html . METHODS render_line_split IMPORTING !is_diff_line TYPE zif_abapgit_definitions=>ty_diff @@ -149,7 +149,7 @@ CLASS zcl_abapgit_gui_page_diff DEFINITION !iv_fstate TYPE char1 !iv_index TYPE sy-tabix RETURNING - VALUE(ro_html) TYPE REF TO zcl_abapgit_html + VALUE(ri_html) TYPE REF TO zif_abapgit_html RAISING zcx_abapgit_exception . METHODS render_line_unified @@ -562,7 +562,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DIFF IMPLEMENTATION. DATA: lv_beacon TYPE string, lt_beacons TYPE zif_abapgit_definitions=>ty_string_tt. - CREATE OBJECT ro_html. + CREATE OBJECT ri_html TYPE zcl_abapgit_html. IF is_diff_line-beacon > 0. lt_beacons = is_diff-o_diff->get_beacons( ). @@ -571,30 +571,30 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DIFF IMPLEMENTATION. lv_beacon = '---'. ENDIF. - ro_html->add( '' ). - ro_html->add( '' ). + ri_html->add( '' ). + ri_html->add( '' ). render_beacon_begin_of_row( - io_html = ro_html - is_diff = is_diff ). + ii_html = ri_html + is_diff = is_diff ). IF mv_unified = abap_true. - ro_html->add( '' ). - ro_html->add( '' ). - ro_html->add( |@@ { is_diff_line-new_num } @@ { lv_beacon }| ). + ri_html->add( '' ). + ri_html->add( '' ). + ri_html->add( |@@ { is_diff_line-new_num } @@ { lv_beacon }| ). ELSE. - ro_html->add( |@@ { is_diff_line-new_num } @@ { lv_beacon }| ). + ri_html->add( |@@ { is_diff_line-new_num } @@ { lv_beacon }| ). ENDIF. - ro_html->add( '' ). - ro_html->add( '' ). + ri_html->add( '' ). + ri_html->add( '' ). ENDMETHOD. METHOD render_beacon_begin_of_row. - io_html->add( '' ). + ii_html->add( '' ). ENDMETHOD. @@ -796,7 +796,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DIFF IMPLEMENTATION. lv_mark TYPE string, lv_bg TYPE string. - CREATE OBJECT ro_html. + CREATE OBJECT ri_html TYPE zcl_abapgit_html. " New line lv_mark = ` `. @@ -830,10 +830,10 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DIFF IMPLEMENTATION. && |{ is_diff_line-old }|. " render line, inverse sides if remote is newer - ro_html->add( '' ). "#EC NOTEXT + ri_html->add( '' ). "#EC NOTEXT render_line_split_row( - io_html = ro_html + ii_html = ri_html iv_filename = iv_filename is_diff_line = is_diff_line iv_index = iv_index @@ -841,7 +841,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DIFF IMPLEMENTATION. iv_old = lv_old iv_new = lv_new ). - ro_html->add( '' ). "#EC NOTEXT + ri_html->add( '' ). "#EC NOTEXT ENDMETHOD. @@ -849,11 +849,11 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DIFF IMPLEMENTATION. METHOD render_line_split_row. IF iv_fstate = c_fstate-remote. " Remote file leading changes - io_html->add( iv_old ). " local - io_html->add( iv_new ). " remote + ii_html->add( iv_old ). " local + ii_html->add( iv_new ). " remote ELSE. " Local leading changes or both were modified - io_html->add( iv_new ). " local - io_html->add( iv_old ). " remote + ii_html->add( iv_new ). " local + ii_html->add( iv_old ). " remote ENDIF. ENDMETHOD. diff --git a/src/ui/zcl_abapgit_gui_page_patch.clas.abap b/src/ui/zcl_abapgit_gui_page_patch.clas.abap index 0a87bb051..ba0a15eea 100644 --- a/src/ui/zcl_abapgit_gui_page_patch.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_patch.clas.abap @@ -42,8 +42,8 @@ CLASS zcl_abapgit_gui_page_patch DEFINITION PRIVATE SECTION. - TYPES: - ty_patch_action TYPE string . + + TYPES ty_patch_action TYPE string . CONSTANTS: BEGIN OF c_actions, @@ -51,130 +51,109 @@ CLASS zcl_abapgit_gui_page_patch DEFINITION refresh TYPE string VALUE 'patch_refresh', refresh_local TYPE string VALUE 'patch_refresh_local', refresh_local_object TYPE string VALUE 'patch_refresh_local_object', - END OF c_actions, + END OF c_actions . + CONSTANTS: BEGIN OF c_patch_action, add TYPE ty_patch_action VALUE 'add', remove TYPE ty_patch_action VALUE 'remove', END OF c_patch_action . + DATA mo_stage TYPE REF TO zcl_abapgit_stage . + DATA mv_section_count TYPE i . + DATA mv_pushed TYPE abap_bool . + DATA mo_repo_online TYPE REF TO zcl_abapgit_repo_online . - DATA: - mo_stage TYPE REF TO zcl_abapgit_stage, - mv_section_count TYPE i, - mv_pushed TYPE abap_bool, - mo_repo_online TYPE REF TO zcl_abapgit_repo_online. - - METHODS: - render_patch - IMPORTING - io_html TYPE REF TO zcl_abapgit_html - iv_filename TYPE string - is_diff_line TYPE zif_abapgit_definitions=>ty_diff - iv_index TYPE sy-tabix - RAISING - zcx_abapgit_exception, - - render_patch_head - IMPORTING - io_html TYPE REF TO zcl_abapgit_html - is_diff TYPE ty_file_diff, - - start_staging - IMPORTING - it_postdata TYPE cnht_post_data_tab - RAISING - zcx_abapgit_exception, - - apply_patch_from_form_fields - IMPORTING - it_postdata TYPE cnht_post_data_tab - RAISING - zcx_abapgit_exception, - - restore_patch_flags - IMPORTING - it_diff_files_old TYPE tt_file_diff - RAISING - zcx_abapgit_exception, - - add_to_stage - RAISING - zcx_abapgit_exception, - - refresh - IMPORTING - iv_action TYPE clike - RAISING - zcx_abapgit_exception, - - refresh_full - RAISING - zcx_abapgit_exception, - - refresh_local - RAISING - zcx_abapgit_exception, - - refresh_local_object - IMPORTING - iv_action TYPE clike - RAISING - zcx_abapgit_exception, - - apply_patch_all - IMPORTING - iv_patch TYPE string - iv_patch_flag TYPE abap_bool - RAISING - zcx_abapgit_exception, - - are_all_lines_patched - IMPORTING - it_diff TYPE zif_abapgit_definitions=>ty_diffs_tt - RETURNING - VALUE(rv_are_all_lines_patched) TYPE abap_bool, - - apply_patch_for - IMPORTING - iv_filename TYPE string - iv_line_index TYPE string - iv_patch_flag TYPE abap_bool - RAISING - zcx_abapgit_exception, - - get_diff_object - IMPORTING - iv_filename TYPE string - RETURNING - VALUE(ro_diff) TYPE REF TO zcl_abapgit_diff - RAISING - zcx_abapgit_exception, - - get_diff_line - IMPORTING - io_diff TYPE REF TO zcl_abapgit_diff - iv_line_index TYPE string - RETURNING - VALUE(rs_diff) TYPE zif_abapgit_definitions=>ty_diff - RAISING - zcx_abapgit_exception, - - is_every_changed_line_patched - RETURNING - VALUE(rv_everything_patched) TYPE abap_bool. - - CLASS-METHODS: - is_patch_line_possible - IMPORTING - is_diff_line TYPE zif_abapgit_definitions=>ty_diff - RETURNING - VALUE(rv_is_patch_line_possible) TYPE abap_bool. - + METHODS render_patch + IMPORTING + !ii_html TYPE REF TO zif_abapgit_html + !iv_filename TYPE string + !is_diff_line TYPE zif_abapgit_definitions=>ty_diff + !iv_index TYPE sy-tabix + RAISING + zcx_abapgit_exception . + METHODS render_patch_head + IMPORTING + !io_html TYPE REF TO zcl_abapgit_html + !is_diff TYPE ty_file_diff . + METHODS start_staging + IMPORTING + !it_postdata TYPE cnht_post_data_tab + RAISING + zcx_abapgit_exception . + METHODS apply_patch_from_form_fields + IMPORTING + !it_postdata TYPE cnht_post_data_tab + RAISING + zcx_abapgit_exception . + METHODS restore_patch_flags + IMPORTING + !it_diff_files_old TYPE tt_file_diff + RAISING + zcx_abapgit_exception . + METHODS add_to_stage + RAISING + zcx_abapgit_exception . + METHODS refresh + IMPORTING + !iv_action TYPE clike + RAISING + zcx_abapgit_exception . + METHODS refresh_full + RAISING + zcx_abapgit_exception . + METHODS refresh_local + RAISING + zcx_abapgit_exception . + METHODS refresh_local_object + IMPORTING + !iv_action TYPE clike + RAISING + zcx_abapgit_exception . + METHODS apply_patch_all + IMPORTING + !iv_patch TYPE string + !iv_patch_flag TYPE abap_bool + RAISING + zcx_abapgit_exception . + METHODS are_all_lines_patched + IMPORTING + !it_diff TYPE zif_abapgit_definitions=>ty_diffs_tt + RETURNING + VALUE(rv_are_all_lines_patched) TYPE abap_bool . + METHODS apply_patch_for + IMPORTING + !iv_filename TYPE string + !iv_line_index TYPE string + !iv_patch_flag TYPE abap_bool + RAISING + zcx_abapgit_exception . + METHODS get_diff_object + IMPORTING + !iv_filename TYPE string + RETURNING + VALUE(ro_diff) TYPE REF TO zcl_abapgit_diff + RAISING + zcx_abapgit_exception . + METHODS get_diff_line + IMPORTING + !io_diff TYPE REF TO zcl_abapgit_diff + !iv_line_index TYPE string + RETURNING + VALUE(rs_diff) TYPE zif_abapgit_definitions=>ty_diff + RAISING + zcx_abapgit_exception . + METHODS is_every_changed_line_patched + RETURNING + VALUE(rv_everything_patched) TYPE abap_bool . + CLASS-METHODS is_patch_line_possible + IMPORTING + !is_diff_line TYPE zif_abapgit_definitions=>ty_diff + RETURNING + VALUE(rv_is_patch_line_possible) TYPE abap_bool . METHODS render_scripts RETURNING VALUE(ro_html) TYPE REF TO zcl_abapgit_html RAISING - zcx_abapgit_exception. - + zcx_abapgit_exception . ENDCLASS. @@ -579,9 +558,9 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_PATCH IMPLEMENTATION. mv_section_count = mv_section_count + 1. - io_html->add( || ). - io_html->add_checkbox( iv_id = |patch_section_{ get_normalized_fname_with_path( is_diff ) }_{ mv_section_count }| ). - io_html->add( '' ). + ii_html->add( || ). + ii_html->add_checkbox( iv_id = |patch_section_{ get_normalized_fname_with_path( is_diff ) }_{ mv_section_count }| ). + ii_html->add( '' ). ENDMETHOD. @@ -630,13 +609,13 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_PATCH IMPLEMENTATION. METHOD render_line_split_row. - render_patch( io_html = io_html + render_patch( ii_html = ii_html iv_filename = iv_filename is_diff_line = is_diff_line iv_index = iv_index ). super->render_line_split_row( - io_html = io_html + ii_html = ii_html iv_filename = iv_filename is_diff_line = is_diff_line iv_index = iv_index @@ -667,16 +646,16 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_PATCH IMPLEMENTATION. lv_id = |{ iv_filename }_{ mv_section_count }_{ iv_index }|. - io_html->add( || ). - io_html->add_checkbox( + ii_html->add( || ). + ii_html->add_checkbox( iv_id = |patch_line_{ lv_id }| iv_checked = lv_patched ). - io_html->add( || ). + ii_html->add( || ). ELSE. - io_html->add( || ). - io_html->add( || ). + ii_html->add( || ). + ii_html->add( || ). ENDIF. diff --git a/src/ui/zcl_abapgit_gui_page_stage.clas.abap b/src/ui/zcl_abapgit_gui_page_stage.clas.abap index eac0e4048..c24c4cbc7 100644 --- a/src/ui/zcl_abapgit_gui_page_stage.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_stage.clas.abap @@ -43,7 +43,7 @@ CLASS zcl_abapgit_gui_page_stage DEFINITION DATA mo_repo TYPE REF TO zcl_abapgit_repo_online . DATA ms_files TYPE zif_abapgit_definitions=>ty_stage_files . - DATA mv_seed TYPE string . " Unique page id to bind JS sessionStorage + DATA mv_seed TYPE string . " Unique page id to bind JS sessionStorage DATA mv_filter_value TYPE string . METHODS find_changed_by @@ -96,7 +96,7 @@ CLASS zcl_abapgit_gui_page_stage DEFINITION zcx_abapgit_exception . METHODS render_master_language_warning RETURNING - VALUE(ro_html) TYPE REF TO zcl_abapgit_html . + VALUE(ri_html) TYPE REF TO zif_abapgit_html . METHODS count_default_files_to_commit RETURNING VALUE(rv_count) TYPE i . @@ -502,12 +502,12 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_STAGE IMPLEMENTATION. DATA: ls_dot_abapgit TYPE zif_abapgit_dot_abapgit=>ty_dot_abapgit. - CREATE OBJECT ro_html. + CREATE OBJECT ri_html TYPE zcl_abapgit_html. ls_dot_abapgit = mo_repo->get_dot_abapgit( )->get_data( ). IF ls_dot_abapgit-master_language <> sy-langu. - ro_html->add( zcl_abapgit_gui_chunk_lib=>render_warning_banner( + ri_html->add( zcl_abapgit_gui_chunk_lib=>render_warning_banner( |Caution: Master language of the repo is '{ ls_dot_abapgit-master_language }', | && |but you're logged on in '{ sy-langu }'| ) ). ENDIF. diff --git a/src/ui/zcl_abapgit_gui_page_syntax.clas.abap b/src/ui/zcl_abapgit_gui_page_syntax.clas.abap index 633fcd668..b4db00311 100644 --- a/src/ui/zcl_abapgit_gui_page_syntax.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_syntax.clas.abap @@ -69,7 +69,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_SYNTAX IMPLEMENTATION. IF lines( mt_result ) = 0. ri_html->add( '
' ). - ri_html->add( zcl_abapgit_html=>icon( 'check' ) ). + ri_html->add( ri_html->icon( 'check' ) ). ri_html->add( 'No syntax errors' ). ri_html->add( '
' ). ELSE. diff --git a/src/ui/zcl_abapgit_gui_page_tutorial.clas.abap b/src/ui/zcl_abapgit_gui_page_tutorial.clas.abap index b4f16c176..c54990ccb 100644 --- a/src/ui/zcl_abapgit_gui_page_tutorial.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_tutorial.clas.abap @@ -102,7 +102,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_TUTORIAL IMPLEMENTATION. ri_html->add( '

Repository list and favorites

' ). ri_html->add( '