diff --git a/abaplint.json b/abaplint.json index 1b472096e..1c58b8577 100644 --- a/abaplint.json +++ b/abaplint.json @@ -16,22 +16,22 @@ "version": "v702", "errorNamespace": "^(Z|Y|LT?CL_|TY_|LIF_|.*ABAPGIT)", "globalConstants": [ - "icon_led_red", - "icon_led_yellow", - "icon_led_green", - "icon_led_inactive", - "icon_message_information", - "icon_system_help", - "icon_stack", - "icon_abap", - "icon_display_text", - "icon_set_state", - "icon_workflow_fork", - "icon_okay", - "icon_folder", "abap_func_exporting", "abap_func_tables", "cssf_formtype_text", + "icon_abap", + "icon_display_text", + "icon_folder", + "icon_led_green", + "icon_led_inactive", + "icon_led_red", + "icon_led_yellow", + "icon_message_information", + "icon_okay", + "icon_set_state", + "icon_stack", + "icon_system_help", + "icon_workflow_fork", "seoc_category_exception", "seoc_category_webdynpro_class", "seoc_exposure_private", @@ -47,6 +47,10 @@ "seop_ext_class_locals_imp", "seop_ext_class_macros", "seop_ext_class_testclasses", + "seop_incextapp_definition", + "seop_incextapp_implementation", + "seop_incextapp_macros", + "seop_incextapp_testclasses", "sews_c_vif_version", "skwfc_obtype_folder", "skwfc_obtype_loio", @@ -187,6 +191,7 @@ "ignoreGlobalClassDefinition": false, "ignoreGlobalInterface": false, "ignoreKeywords": [], + "ignoreGlobalClassBoundaries": false, "ignoreFunctionModuleName": false }, "line_length": { @@ -260,6 +265,7 @@ "divide": true, "requested": true, "setExtended": true, + "withHeaderLine": true, "occurs": true }, "parser_error": {}, diff --git a/src/objects/zcl_abapgit_object_dsys.clas.abap b/src/objects/zcl_abapgit_object_dsys.clas.abap index d1053915f..129fe0a1d 100644 --- a/src/objects/zcl_abapgit_object_dsys.clas.abap +++ b/src/objects/zcl_abapgit_object_dsys.clas.abap @@ -97,8 +97,6 @@ CLASS ZCL_ABAPGIT_OBJECT_DSYS IMPLEMENTATION. METHOD get_master_lang. - DATA: lv_language TYPE spras. - SELECT SINGLE langu FROM dokil INTO rv_language WHERE id = c_id AND object = mv_doc_object diff --git a/src/ui/core/zcl_abapgit_gui.clas.abap b/src/ui/core/zcl_abapgit_gui.clas.abap index 9c5b4e0e9..33fca6e5a 100644 --- a/src/ui/core/zcl_abapgit_gui.clas.abap +++ b/src/ui/core/zcl_abapgit_gui.clas.abap @@ -405,10 +405,9 @@ CLASS ZCL_ABAPGIT_GUI IMPLEMENTATION. METHOD zif_abapgit_gui_services~cache_asset. - DATA: lv_xstr TYPE xstring, - lt_xdata TYPE lvc_t_mime, - lv_size TYPE i. - DATA lt_html TYPE w3htmltab. + DATA: lt_xdata TYPE lvc_t_mime, + lv_size TYPE i, + lt_html TYPE w3htmltab. ASSERT iv_text IS SUPPLIED OR iv_xdata IS SUPPLIED. diff --git a/src/ui/zcl_abapgit_gui_page_main.clas.abap b/src/ui/zcl_abapgit_gui_page_main.clas.abap index 4b22f22ce..bb98109ac 100644 --- a/src/ui/zcl_abapgit_gui_page_main.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_main.clas.abap @@ -72,11 +72,6 @@ CLASS zcl_abapgit_gui_page_main IMPLEMENTATION. METHOD render_content. - DATA: lt_repos TYPE zif_abapgit_definitions=>ty_repo_ref_tt, - lx_error TYPE REF TO zcx_abapgit_exception, - li_tutorial TYPE REF TO zif_abapgit_gui_renderable, - lo_repo LIKE LINE OF lt_repos. - CREATE OBJECT ri_html TYPE zcl_abapgit_html. gui_services( )->get_hotkeys_ctl( )->register_hotkeys( me ). @@ -93,9 +88,7 @@ CLASS zcl_abapgit_gui_page_main IMPLEMENTATION. METHOD zif_abapgit_gui_event_handler~on_event. - DATA: lv_key TYPE zif_abapgit_persistence=>ty_value, - li_repo_overview TYPE REF TO zif_abapgit_gui_renderable, - li_main_page TYPE REF TO zcl_abapgit_gui_page_main. + DATA: lv_key TYPE zif_abapgit_persistence=>ty_value. CASE iv_action. WHEN c_actions-abapgit_home. diff --git a/src/ui/zcl_abapgit_gui_page_view_repo.clas.abap b/src/ui/zcl_abapgit_gui_page_view_repo.clas.abap index 592a90031..64d13b215 100644 --- a/src/ui/zcl_abapgit_gui_page_view_repo.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_view_repo.clas.abap @@ -386,9 +386,6 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_VIEW_REPO IMPLEMENTATION. METHOD build_main_menu. - DATA: lo_advsub TYPE REF TO zcl_abapgit_html_toolbar, - lo_helpsub TYPE REF TO zcl_abapgit_html_toolbar. - CREATE OBJECT ro_menu EXPORTING iv_id = 'toolbar-main'. ro_menu->add( diff --git a/src/ui/zcl_abapgit_hotkeys.clas.abap b/src/ui/zcl_abapgit_hotkeys.clas.abap index 98bceaf1e..e5182bfde 100644 --- a/src/ui/zcl_abapgit_hotkeys.clas.abap +++ b/src/ui/zcl_abapgit_hotkeys.clas.abap @@ -253,9 +253,8 @@ CLASS ZCL_ABAPGIT_HOTKEYS IMPLEMENTATION. METHOD render_scripts. DATA lv_json TYPE string. - DATA lt_hotkeys TYPE zif_abapgit_gui_hotkeys=>tty_hotkey_with_descr. - FIELD-SYMBOLS: LIKE LINE OF lt_hotkeys. + FIELD-SYMBOLS: LIKE LINE OF it_hotkeys. lv_json = `{`. diff --git a/src/ui/zcl_abapgit_popups.clas.abap b/src/ui/zcl_abapgit_popups.clas.abap index 5e73e1cea..125f1217b 100644 --- a/src/ui/zcl_abapgit_popups.clas.abap +++ b/src/ui/zcl_abapgit_popups.clas.abap @@ -919,7 +919,6 @@ CLASS zcl_abapgit_popups IMPLEMENTATION. DATA: lv_pfstatus TYPE sypfkey, lo_events TYPE REF TO cl_salv_events_table, - lo_functions TYPE REF TO cl_salv_functions_list, lo_columns TYPE REF TO cl_salv_columns_table, lt_columns TYPE salv_t_column_ref, ls_column TYPE salv_s_column_ref, diff --git a/src/ui/zcl_abapgit_services_abapgit.clas.abap b/src/ui/zcl_abapgit_services_abapgit.clas.abap index 2fc92fab3..a178cd65c 100644 --- a/src/ui/zcl_abapgit_services_abapgit.clas.abap +++ b/src/ui/zcl_abapgit_services_abapgit.clas.abap @@ -11,8 +11,7 @@ CLASS zcl_abapgit_services_abapgit DEFINITION c_dotabap_homepage TYPE string VALUE 'https://dotabap.org' ##NO_TEXT, c_abapgit_package TYPE devclass VALUE '$ABAPGIT' ##NO_TEXT, c_abapgit_url TYPE string VALUE 'https://github.com/larshp/abapGit.git' ##NO_TEXT, - c_abapgit_class TYPE tcode VALUE `ZCL_ABAPGIT_REPO` ##NO_TEXT, - c_abapgit_tcode TYPE tcode VALUE `ZABAPGIT` ##NO_TEXT. + c_abapgit_class TYPE tcode VALUE `ZCL_ABAPGIT_REPO` ##NO_TEXT. CLASS-METHODS open_abapgit_homepage RAISING diff --git a/src/zcl_abapgit_transport.clas.abap b/src/zcl_abapgit_transport.clas.abap index cd149a6f8..200d5177c 100644 --- a/src/zcl_abapgit_transport.clas.abap +++ b/src/zcl_abapgit_transport.clas.abap @@ -286,8 +286,7 @@ CLASS ZCL_ABAPGIT_TRANSPORT IMPLEMENTATION. DATA: lt_objects TYPE scts_tadir, lt_objects_all LIKE lt_objects, - lt_e071 TYPE tr_objects, - ls_e071 LIKE LINE OF lt_e071, + ls_e071 LIKE LINE OF rt_objects, lo_repo TYPE REF TO zcl_abapgit_repo, lv_package TYPE zif_abapgit_persistence=>ty_repo-package, lt_packages TYPE zif_abapgit_sap_package=>ty_devclass_tt.