SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-02 13:03:01 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

WDYN: Improve error messages (#4310)

Browse Source 
Pass exception text to UI/log

Co-authored-by: Lars Hvam <larshp@hotmail.com>
This commit is contained in:
Marc Bernard 2020-12-11 01:54:19 -05:00 committed by GitHub
parent 46e2dd827b
commit 869c0bccb5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 20 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
src/objects/zcl_abapgit_object_wdyn.clas.abap
View File

@ -78,7 +78,7 @@ ENDCLASS.
CLASS ZCL_ABAPGIT_OBJECT_WDYN IMPLEMENTATION. CLASS zcl_abapgit_object_wdyn IMPLEMENTATION.
METHOD add_fm_exception. METHOD add_fm_exception.
@ -155,6 +155,7 @@ CLASS ZCL_ABAPGIT_OBJECT_WDYN IMPLEMENTATION.
METHOD delta_controller. METHOD delta_controller.
DATA: li_controller TYPE REF TO if_wdy_md_controller, DATA: li_controller TYPE REF TO if_wdy_md_controller,
lx_error TYPE REF TO cx_wdy_md_exception,
lv_found TYPE abap_bool, lv_found TYPE abap_bool,
ls_key TYPE wdy_md_controller_key, ls_key TYPE wdy_md_controller_key,
ls_obj_new TYPE svrs2_versionable_object, ls_obj_new TYPE svrs2_versionable_object,
@ -182,8 +183,8 @@ CLASS ZCL_ABAPGIT_OBJECT_WDYN IMPLEMENTATION.
controller_type = is_controller-definition-controller_type ). controller_type = is_controller-definition-controller_type ).
li_controller->save_to_database( ). li_controller->save_to_database( ).
li_controller->unlock( ). li_controller->unlock( ).
CATCH cx_wdy_md_exception. CATCH cx_wdy_md_exception INTO lx_error.
zcx_abapgit_exception=>raise( 'error creating dummy controller' ). zcx_abapgit_exception=>raise( |Error creating dummy controller: { lx_error->get_text( ) }| ).
ENDTRY. ENDTRY.
ENDIF. ENDIF.
@ -255,6 +256,7 @@ CLASS ZCL_ABAPGIT_OBJECT_WDYN IMPLEMENTATION.
lv_found TYPE abap_bool, lv_found TYPE abap_bool,
ls_obj_new TYPE svrs2_versionable_object, ls_obj_new TYPE svrs2_versionable_object,
li_component TYPE REF TO if_wdy_md_component, li_component TYPE REF TO if_wdy_md_component,
lx_error TYPE REF TO cx_wdy_md_exception,
ls_obj_old TYPE svrs2_versionable_object. ls_obj_old TYPE svrs2_versionable_object.
@ -272,8 +274,8 @@ CLASS ZCL_ABAPGIT_OBJECT_WDYN IMPLEMENTATION.
devclass = iv_package ). devclass = iv_package ).
li_component->save_to_database( ). li_component->save_to_database( ).
li_component->unlock( ). li_component->unlock( ).
CATCH cx_wdy_md_exception. CATCH cx_wdy_md_exception INTO lx_error.
zcx_abapgit_exception=>raise( 'error creating dummy component' ). zcx_abapgit_exception=>raise( |Error creating dummy component: { lx_error->get_text( ) }| ).
ENDTRY. ENDTRY.
ENDIF. ENDIF.
@ -312,6 +314,7 @@ CLASS ZCL_ABAPGIT_OBJECT_WDYN IMPLEMENTATION.
ls_obj_new TYPE svrs2_versionable_object, ls_obj_new TYPE svrs2_versionable_object,
ls_obj_old TYPE svrs2_versionable_object, ls_obj_old TYPE svrs2_versionable_object,
lv_found TYPE abap_bool, lv_found TYPE abap_bool,
lx_error TYPE REF TO cx_wdy_md_exception,
li_view TYPE REF TO if_wdy_md_abstract_view. li_view TYPE REF TO if_wdy_md_abstract_view.
FIELD-SYMBOLS: <ls_def> LIKE LINE OF ls_obj_old-wdyv-defin. FIELD-SYMBOLS: <ls_def> LIKE LINE OF ls_obj_old-wdyv-defin.
@ -331,8 +334,8 @@ CLASS ZCL_ABAPGIT_OBJECT_WDYN IMPLEMENTATION.
type = is_view-definition-type ). type = is_view-definition-type ).
li_view->save_to_database( ). li_view->save_to_database( ).
li_view->unlock( ). li_view->unlock( ).
CATCH cx_wdy_md_exception. CATCH cx_wdy_md_exception INTO lx_error.
zcx_abapgit_exception=>raise( 'error creating dummy view' ). zcx_abapgit_exception=>raise( |Error creating dummy view: { lx_error->get_text( ) }| ).
ENDTRY. ENDTRY.
ENDIF. ENDIF.
@ -686,6 +689,7 @@ CLASS ZCL_ABAPGIT_OBJECT_WDYN IMPLEMENTATION.
DATA: ls_key TYPE wdy_controller_key, DATA: ls_key TYPE wdy_controller_key,
lv_corrnr TYPE trkorr, lv_corrnr TYPE trkorr,
lx_error TYPE REF TO cx_wdy_md_exception,
ls_delta TYPE svrs2_xversionable_object. ls_delta TYPE svrs2_xversionable_object.
@ -700,8 +704,8 @@ CLASS ZCL_ABAPGIT_OBJECT_WDYN IMPLEMENTATION.
delta = ls_delta-wdyc delta = ls_delta-wdyc
CHANGING CHANGING
corrnr = lv_corrnr ). corrnr = lv_corrnr ).
CATCH cx_wdy_md_exception. CATCH cx_wdy_md_exception INTO lx_error.
zcx_abapgit_exception=>raise( 'error recovering version of controller' ). zcx_abapgit_exception=>raise( |Error recovering version of controller: { lx_error->get_text( ) }| ).
ENDTRY. ENDTRY.
ENDMETHOD. ENDMETHOD.
@ -711,6 +715,7 @@ CLASS ZCL_ABAPGIT_OBJECT_WDYN IMPLEMENTATION.
DATA: ls_key TYPE wdy_md_component_key, DATA: ls_key TYPE wdy_md_component_key,
lv_corrnr TYPE trkorr, lv_corrnr TYPE trkorr,
lx_error TYPE REF TO cx_wdy_md_exception,
ls_delta TYPE svrs2_xversionable_object. ls_delta TYPE svrs2_xversionable_object.
@ -727,8 +732,8 @@ CLASS ZCL_ABAPGIT_OBJECT_WDYN IMPLEMENTATION.
delta = ls_delta-wdyd delta = ls_delta-wdyd
CHANGING CHANGING
corrnr = lv_corrnr ). corrnr = lv_corrnr ).
CATCH cx_wdy_md_exception. CATCH cx_wdy_md_exception INTO lx_error.
zcx_abapgit_exception=>raise( 'error recovering version of component' ). zcx_abapgit_exception=>raise( |Error recovering version of component: { lx_error->get_text( ) }| ).
ENDTRY. ENDTRY.
ENDMETHOD. ENDMETHOD.
@ -738,6 +743,7 @@ CLASS ZCL_ABAPGIT_OBJECT_WDYN IMPLEMENTATION.
DATA: ls_key TYPE wdy_md_view_key, DATA: ls_key TYPE wdy_md_view_key,
lv_corrnr TYPE trkorr, lv_corrnr TYPE trkorr,
lx_error TYPE REF TO cx_wdy_md_exception,
ls_delta TYPE svrs2_xversionable_object. ls_delta TYPE svrs2_xversionable_object.
@ -752,8 +758,8 @@ CLASS ZCL_ABAPGIT_OBJECT_WDYN IMPLEMENTATION.
delta = ls_delta-wdyv delta = ls_delta-wdyv
CHANGING CHANGING
corrnr = lv_corrnr ). corrnr = lv_corrnr ).
CATCH cx_wdy_md_exception. CATCH cx_wdy_md_exception INTO lx_error.
zcx_abapgit_exception=>raise( 'error recovering version of abstract view' ). zcx_abapgit_exception=>raise( |Error recovering version of abstract view: { lx_error->get_text( ) }| ).
ENDTRY. ENDTRY.
ENDMETHOD. ENDMETHOD.
@ -838,8 +844,7 @@ CLASS ZCL_ABAPGIT_OBJECT_WDYN IMPLEMENTATION.
SELECT SINGLE component_name FROM wdy_component SELECT SINGLE component_name FROM wdy_component
INTO lv_component_name INTO lv_component_name
WHERE component_name = ms_item-obj_name WHERE component_name = ms_item-obj_name. "#EC CI_GENBUFF
AND version = 'A'. "#EC CI_GENBUFF
rv_bool = boolc( sy-subrc = 0 ). rv_bool = boolc( sy-subrc = 0 ).
ENDMETHOD. ENDMETHOD.