Disable sorting for action column (#4087)

* Disable sorting for action column

* abaplint

* Revert renamed methods
This commit is contained in:
Frederik Hudák 2020-10-28 12:23:00 +01:00 committed by GitHub
parent 6b336c58f0
commit 888bbcb27e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 40 additions and 20 deletions

View File

@ -584,11 +584,16 @@ CLASS zcl_abapgit_gui_chunk_lib IMPLEMENTATION.
iv_act = |{ zif_abapgit_definitions=>c_action-direction }?direction=DESCENDING|
iv_title = <ls_col>-title ).
ENDIF.
ELSE.
ELSEIF <ls_col>-allow_order_by = abap_true.
lv_tmp = lv_tmp && ri_html->a(
iv_txt = lv_disp_name
iv_act = |{ zif_abapgit_definitions=>c_action-change_order_by }?orderBy={ <ls_col>-tech_name }|
iv_title = <ls_col>-title ).
ELSE.
lv_tmp = lv_tmp && ri_html->a(
iv_txt = lv_disp_name
iv_act = ``
iv_title = <ls_col>-title ).
ENDIF.
ENDIF.
IF <ls_col>-tech_name = iv_order_by

View File

@ -104,7 +104,8 @@ CLASS zcl_abapgit_gui_page_repo_over DEFINITION
iv_display_name TYPE string OPTIONAL
iv_css_class TYPE string OPTIONAL
iv_add_tz TYPE abap_bool OPTIONAL
iv_title TYPE string OPTIONAL.
iv_title TYPE string OPTIONAL
iv_allow_order_by TYPE any OPTIONAL.
METHODS render_scripts
RETURNING
@ -442,64 +443,76 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_REPO_OVER IMPLEMENTATION.
_add_column(
iv_tech_name = 'FAVORITE'
iv_css_class = 'wmin' ).
iv_css_class = 'wmin'
iv_allow_order_by = abap_false ).
_add_column(
iv_tech_name = 'TYPE'
iv_css_class = 'wmin' ).
iv_css_class = 'wmin'
iv_allow_order_by = abap_false ).
_add_column(
iv_tech_name = 'NAME'
iv_display_name = 'Name' ).
iv_display_name = 'Name'
iv_allow_order_by = abap_true ).
_add_column(
iv_tech_name = 'URL'
iv_display_name = 'Url' ).
iv_display_name = 'Url'
iv_allow_order_by = abap_true ).
_add_column(
iv_tech_name = 'PACKAGE'
iv_display_name = 'Package' ).
iv_display_name = 'Package'
iv_allow_order_by = abap_true ).
_add_column(
iv_tech_name = 'BRANCH'
iv_display_name = 'Branch' ).
iv_display_name = 'Branch'
iv_allow_order_by = abap_true ).
_add_column(
iv_tech_name = 'DESERIALIZED_BY'
iv_display_name = 'Deserialized by'
iv_css_class = 'ro-detail' ).
iv_css_class = 'ro-detail'
iv_allow_order_by = abap_true ).
_add_column(
iv_tech_name = 'DESERIALIZED_AT'
iv_display_name = 'Deserialized at'
iv_css_class = 'ro-detail'
iv_add_tz = abap_true ).
iv_allow_order_by = abap_true ).
_add_column(
iv_tech_name = 'CREATED_BY'
iv_display_name = 'Created by'
iv_css_class = 'ro-detail' ).
iv_css_class = 'ro-detail'
iv_allow_order_by = abap_true ).
_add_column(
iv_tech_name = 'CREATED_AT'
iv_display_name = 'Created at'
iv_css_class = 'ro-detail'
iv_add_tz = abap_true ).
iv_add_tz = abap_true
iv_allow_order_by = abap_true ).
_add_column(
iv_tech_name = 'KEY'
iv_display_name = 'Key'
iv_css_class = 'ro-detail' ).
iv_css_class = 'ro-detail'
iv_allow_order_by = abap_true ).
_add_column(
iv_tech_name = 'ACTION'
iv_display_name = 'Action'
iv_css_class = 'ro-action' ).
iv_css_class = 'ro-action'
iv_allow_order_by = abap_false ).
_add_column(
iv_tech_name = 'GO'
iv_css_class = 'ro-go' ).
iv_css_class = 'ro-go'
iv_allow_order_by = abap_false ).
ii_html->add( |<thead>| ).
ii_html->add( |<tr>| ).
@ -588,5 +601,6 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_REPO_OVER IMPLEMENTATION.
<ls_col>-title = iv_title.
<ls_col>-css_class = iv_css_class.
<ls_col>-add_tz = iv_add_tz.
<ls_col>-allow_order_by = iv_allow_order_by.
ENDMETHOD.
ENDCLASS.

View File

@ -363,11 +363,12 @@ INTERFACE zif_abapgit_definitions
WITH NON-UNIQUE DEFAULT KEY .
TYPES:
BEGIN OF ty_col_spec,
tech_name TYPE string,
display_name TYPE string,
css_class TYPE string,
add_tz TYPE abap_bool,
title TYPE string,
tech_name TYPE string,
display_name TYPE string,
css_class TYPE string,
add_tz TYPE abap_bool,
title TYPE string,
allow_order_by TYPE abap_bool,
END OF ty_col_spec,
ty_col_spec_tt TYPE STANDARD TABLE OF ty_col_spec
WITH NON-UNIQUE KEY tech_name.