From 89dfeb69f8a0bdab2ca92fea16c6f76786a7887e Mon Sep 17 00:00:00 2001 From: mariusraht2 <45243391+mariusraht2@users.noreply.github.com> Date: Sun, 17 Nov 2019 10:31:27 +0100 Subject: [PATCH] Issue 3060: Check repo URLs before creating a new online repo (#3063) * Create pull.yml * Update zcl_abapgit_git_transport.clas.abap * Update zcl_abapgit_git_transport.clas.abap * Update pull.yml * Delete pull.yml * Check repo URLs before creating a new online repo Fixes #3060 * Check repo URLs before creating a new online repo Use method zcl_abapgit_url%3D>name and replace the assert with an exception --- src/utils/zcl_abapgit_url.clas.abap | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/utils/zcl_abapgit_url.clas.abap b/src/utils/zcl_abapgit_url.clas.abap index d03765d2f..801d9f4b5 100644 --- a/src/utils/zcl_abapgit_url.clas.abap +++ b/src/utils/zcl_abapgit_url.clas.abap @@ -47,7 +47,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_URL IMPLEMENTATION. +CLASS zcl_abapgit_url IMPLEMENTATION. METHOD host. @@ -68,10 +68,11 @@ CLASS ZCL_ABAPGIT_URL IMPLEMENTATION. IF rv_name IS INITIAL. FIND REGEX '([\w-]+)/$' IN lv_path SUBMATCHES rv_name. + IF sy-subrc <> 0. + zcx_abapgit_exception=>raise( 'Malformed URL' ). + ENDIF. ENDIF. - ASSERT NOT rv_name IS INITIAL. - ENDMETHOD. @@ -98,7 +99,7 @@ CLASS ZCL_ABAPGIT_URL IMPLEMENTATION. METHOD validate. - regex( iv_url ). + name( iv_url ). ENDMETHOD. ENDCLASS.