SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Naming conventions fixes, #2053 (#2058)

Browse Source 
* fix more naming conventions

* more naming conventions fixes
This commit is contained in:
Lars Hvam 2018-11-07 12:05:27 +01:00 committed by GitHub
parent 788a7fedb9
commit 89e5010fd0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
13 changed files with 261 additions and 254 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/objects/zcl_abapgit_object_dcls.clas.abap
View File

@ -8,7 +8,7 @@ ENDCLASS.
CLASS zcl_abapgit_object_dcls IMPLEMENTATION.
CLASS ZCL_ABAPGIT_OBJECT_DCLS IMPLEMENTATION.
METHOD zif_abapgit_object~changed_by.
@ -128,12 +128,25 @@ CLASS zcl_abapgit_object_dcls IMPLEMENTATION.
ENDMETHOD.
METHOD zif_abapgit_object~is_active.
rv_active = is_active( ).
ENDMETHOD.
METHOD zif_abapgit_object~is_locked.
rv_is_locked = exists_a_lock_entry_for( iv_lock_object = 'E_ACMDCLSRC'
iv_argument = |{ ms_item-obj_name }| ).
ENDMETHOD.
METHOD zif_abapgit_object~jump.
TRY.
jump_adt( i_obj_name = ms_item-obj_name
i_obj_type = ms_item-obj_type ).
jump_adt( iv_obj_name = ms_item-obj_name
iv_obj_type = ms_item-obj_type ).
CATCH zcx_abapgit_exception.
zcx_abapgit_exception=>raise( 'DCLS Jump Error' ).
@ -202,16 +215,4 @@ CLASS zcl_abapgit_object_dcls IMPLEMENTATION.
ENDTRY.
ENDMETHOD.
METHOD zif_abapgit_object~is_locked.
rv_is_locked = exists_a_lock_entry_for( iv_lock_object = 'E_ACMDCLSRC'
iv_argument = |{ ms_item-obj_name }| ).
ENDMETHOD.
METHOD zif_abapgit_object~is_active.
rv_active = is_active( ).
ENDMETHOD.
ENDCLASS.

31
src/objects/zcl_abapgit_object_ddls.clas.abap
View File

@ -13,7 +13,7 @@ ENDCLASS.
CLASS zcl_abapgit_object_ddls IMPLEMENTATION.
CLASS ZCL_ABAPGIT_OBJECT_DDLS IMPLEMENTATION.
METHOD open_adt_stob.
@ -62,8 +62,8 @@ CLASS zcl_abapgit_object_ddls IMPLEMENTATION.
IF sy-subrc = 0.
ASSIGN COMPONENT 'DDLNAME' OF STRUCTURE <lg_entity_view> TO <lg_ddlname>.
jump_adt( i_obj_name = <lg_ddlname>
i_obj_type = 'DDLS' ).
jump_adt( iv_obj_name = <lg_ddlname>
iv_obj_type = 'DDLS' ).
ENDIF.
@ -233,6 +233,19 @@ CLASS zcl_abapgit_object_ddls IMPLEMENTATION.
ENDMETHOD.
METHOD zif_abapgit_object~is_active.
rv_active = is_active( ).
ENDMETHOD.
METHOD zif_abapgit_object~is_locked.
rv_is_locked = exists_a_lock_entry_for( iv_lock_object = 'ESDICT'
iv_argument = |{ ms_item-obj_type }{ ms_item-obj_name }| ).
ENDMETHOD.
METHOD zif_abapgit_object~jump.
DATA: lv_typename TYPE typename.
@ -312,16 +325,4 @@ CLASS zcl_abapgit_object_ddls IMPLEMENTATION.
ig_data = <lg_data> ).
ENDMETHOD.
METHOD zif_abapgit_object~is_locked.
rv_is_locked = exists_a_lock_entry_for( iv_lock_object = 'ESDICT'
iv_argument = |{ ms_item-obj_type }{ ms_item-obj_name }| ).
ENDMETHOD.
METHOD zif_abapgit_object~is_active.
rv_active = is_active( ).
ENDMETHOD.
ENDCLASS.

16
src/objects/zcl_abapgit_object_ddlx.clas.abap
View File

@ -28,7 +28,7 @@ ENDCLASS.
CLASS zcl_abapgit_object_ddlx IMPLEMENTATION.
CLASS ZCL_ABAPGIT_OBJECT_DDLX IMPLEMENTATION.
METHOD clear_field.
@ -209,6 +209,11 @@ CLASS zcl_abapgit_object_ddlx IMPLEMENTATION.
ENDMETHOD.
METHOD zif_abapgit_object~is_active.
rv_active = is_active( ).
ENDMETHOD.
METHOD zif_abapgit_object~is_locked.
rv_is_locked = exists_a_lock_entry_for( iv_lock_object = 'ESDICT'
@ -220,8 +225,8 @@ CLASS zcl_abapgit_object_ddlx IMPLEMENTATION.
METHOD zif_abapgit_object~jump.
TRY.
jump_adt( i_obj_name = ms_item-obj_name
i_obj_type = ms_item-obj_type ).
jump_adt( iv_obj_name = ms_item-obj_name
iv_obj_type = ms_item-obj_type ).
CATCH zcx_abapgit_exception.
zcx_abapgit_exception=>raise( 'DDLX Jump Error' ).
@ -282,9 +287,4 @@ CLASS zcl_abapgit_object_ddlx IMPLEMENTATION.
ENDTRY.
ENDMETHOD.
METHOD zif_abapgit_object~is_active.
rv_active = is_active( ).
ENDMETHOD.
ENDCLASS.

16
src/objects/zcl_abapgit_object_msag.clas.abap
View File

@ -35,7 +35,7 @@ CLASS zcl_abapgit_object_msag DEFINITION PUBLIC INHERITING FROM zcl_abapgit_obje
delete_msgid IMPORTING iv_message_id TYPE arbgb,
free_access_permission
IMPORTING
i_message_id TYPE arbgb,
iv_message_id TYPE arbgb,
delete_documentation
IMPORTING
iv_message_id TYPE arbgb.
@ -44,7 +44,7 @@ ENDCLASS.
CLASS zcl_abapgit_object_msag IMPLEMENTATION.
CLASS ZCL_ABAPGIT_OBJECT_MSAG IMPLEMENTATION.
METHOD delete_documentation.
@ -149,7 +149,7 @@ CLASS zcl_abapgit_object_msag IMPLEMENTATION.
CALL FUNCTION 'RS_ACCESS_PERMISSION'
EXPORTING
mode = 'FREE'
object = i_message_id
object = iv_message_id
object_class = 'T100'.
ENDMETHOD.
@ -421,6 +421,11 @@ CLASS zcl_abapgit_object_msag IMPLEMENTATION.
ENDMETHOD.
METHOD zif_abapgit_object~is_active.
rv_active = is_active( ).
ENDMETHOD.
METHOD zif_abapgit_object~is_locked.
DATA: lv_argument TYPE seqg3-garg.
@ -483,9 +488,4 @@ CLASS zcl_abapgit_object_msag IMPLEMENTATION.
serialize_texts( io_xml ).
ENDMETHOD.
METHOD zif_abapgit_object~is_active.
rv_active = is_active( ).
ENDMETHOD.
ENDCLASS.

14
src/objects/zcl_abapgit_object_samc.clas.abap
View File

@ -8,24 +8,28 @@ CLASS zcl_abapgit_object_samc DEFINITION PUBLIC INHERITING FROM zcl_abapgit_obje
ENDCLASS.
CLASS zcl_abapgit_object_samc IMPLEMENTATION.
CLASS ZCL_ABAPGIT_OBJECT_SAMC IMPLEMENTATION.
METHOD get_data_class_name.
r_data_class_name = 'CL_AMC_APPLICATION_OBJ_DATA'.
rv_data_class_name = 'CL_AMC_APPLICATION_OBJ_DATA'.
ENDMETHOD.
METHOD get_data_structure_name.
r_data_structure_name = 'AMC_APPLICATION_COMPLETE'.
rv_data_structure_name = 'AMC_APPLICATION_COMPLETE'.
ENDMETHOD.
METHOD get_persistence_class_name.
r_persistence_class_name = 'CL_AMC_APPLICATION_OBJ_PERS'.
rv_persistence_class_name = 'CL_AMC_APPLICATION_OBJ_PERS'.
ENDMETHOD.
ENDCLASS.

14
src/objects/zcl_abapgit_object_sapc.clas.abap
View File

@ -8,24 +8,28 @@ CLASS zcl_abapgit_object_sapc DEFINITION PUBLIC INHERITING FROM zcl_abapgit_obje
ENDCLASS.
CLASS zcl_abapgit_object_sapc IMPLEMENTATION.
CLASS ZCL_ABAPGIT_OBJECT_SAPC IMPLEMENTATION.
METHOD get_data_class_name.
r_data_class_name = 'CL_APC_APPLICATION_OBJ_DATA'.
rv_data_class_name = 'CL_APC_APPLICATION_OBJ_DATA'.
ENDMETHOD.
METHOD get_data_structure_name.
r_data_structure_name = 'APC_APPLICATION_COMPLETE'.
rv_data_structure_name = 'APC_APPLICATION_COMPLETE'.
ENDMETHOD.
METHOD get_persistence_class_name.
r_persistence_class_name = 'CL_APC_APPLICATION_OBJ_PERS'.
rv_persistence_class_name = 'CL_APC_APPLICATION_OBJ_PERS'.
ENDMETHOD.
ENDCLASS.

124
src/objects/zcl_abapgit_object_scp1.clas.abap
View File

@ -37,14 +37,14 @@ CLASS zcl_abapgit_object_scp1 DEFINITION
CHANGING
!cs_scp1 TYPE ty_scp1 .
METHODS call_delete_fms
IMPORTING i_profile_id TYPE scpr_id
IMPORTING iv_profile_id TYPE scpr_id
RAISING zcx_abapgit_exception.
PRIVATE SECTION.
ENDCLASS.
CLASS zcl_abapgit_object_scp1 IMPLEMENTATION.
CLASS ZCL_ABAPGIT_OBJECT_SCP1 IMPLEMENTATION.
METHOD adjust_inbound.
@ -79,6 +79,62 @@ CLASS zcl_abapgit_object_scp1 IMPLEMENTATION.
ENDMETHOD.
METHOD call_delete_fms.
CONSTANTS version_new TYPE c VALUE 'N' ##NO_TEXT. "Include SCPRINTCONST version_new
CONSTANTS operation_delete TYPE c VALUE 'D' ##NO_TEXT.
DATA profile_type TYPE scprattr-type.
DATA fatherprofiles TYPE standard table of scproprof WITH DEFAULT KEY.
DATA fatherprofile TYPE scproprof.
CALL FUNCTION 'SCPR_DB_ATTR_GET_DETAIL'
EXPORTING
profid = iv_profile_id
version = version_new
IMPORTING
proftype = profile_type
EXCEPTIONS
OTHERS = 0.
CALL FUNCTION 'SCPR_PRSET_DB_USED_IN'
EXPORTING
profid = iv_profile_id
version = version_new
TABLES
profiles = fatherprofiles.
fatherprofile-id = iv_profile_id.
APPEND fatherprofile TO fatherprofiles.
CALL FUNCTION 'SCPR_CT_TRANSPORT_ENTRIES'
TABLES
profids = fatherprofiles
EXCEPTIONS
error_in_transport_layer = 1
user_abort = 2.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |error while deleting SCP1 - TRANSPORT, { sy-subrc }| ).
ENDIF.
CALL FUNCTION 'SCPR_PRSET_DB_DELETE_ALL'
EXPORTING
profid = iv_profile_id
proftype = profile_type
TABLES
fatherprofs = fatherprofiles
EXCEPTIONS
user_abort = 1.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |error while deleting SCP1 - DB_DELETE, { sy-subrc }| ).
ENDIF.
CALL FUNCTION 'SCPR_MEM_SCPR_ACTIONS_ADD'
EXPORTING
bcset_id = iv_profile_id
operation = operation_delete.
ENDMETHOD.
METHOD dequeue.
DATA: lv_id TYPE scpr_id.
@ -223,60 +279,6 @@ CLASS zcl_abapgit_object_scp1 IMPLEMENTATION.
ENDMETHOD.
METHOD call_delete_fms.
CONSTANTS version_new TYPE c VALUE 'N' ##NO_TEXT. "Include SCPRINTCONST version_new
CONSTANTS operation_delete TYPE c VALUE 'D' ##NO_TEXT.
DATA profile_type TYPE scprattr-type.
DATA fatherprofiles TYPE standard table of scproprof WITH DEFAULT KEY.
DATA fatherprofile TYPE scproprof.
CALL FUNCTION 'SCPR_DB_ATTR_GET_DETAIL'
EXPORTING
profid = i_profile_id
version = version_new
IMPORTING
proftype = profile_type
EXCEPTIONS
OTHERS = 0.
CALL FUNCTION 'SCPR_PRSET_DB_USED_IN'
EXPORTING
profid = i_profile_id
version = version_new
TABLES
profiles = fatherprofiles.
fatherprofile-id = i_profile_id.
APPEND fatherprofile TO fatherprofiles.
CALL FUNCTION 'SCPR_CT_TRANSPORT_ENTRIES'
TABLES
profids = fatherprofiles
EXCEPTIONS
error_in_transport_layer = 1
user_abort = 2.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |error while deleting SCP1 - TRANSPORT, { sy-subrc }| ).
ENDIF.
CALL FUNCTION 'SCPR_PRSET_DB_DELETE_ALL'
EXPORTING
profid = i_profile_id
proftype = profile_type
TABLES
fatherprofs = fatherprofiles
EXCEPTIONS
user_abort = 1.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |error while deleting SCP1 - DB_DELETE, { sy-subrc }| ).
ENDIF.
CALL FUNCTION 'SCPR_MEM_SCPR_ACTIONS_ADD'
EXPORTING
bcset_id = i_profile_id
operation = operation_delete.
ENDMETHOD.
METHOD zif_abapgit_object~deserialize.
@ -335,6 +337,11 @@ CLASS zcl_abapgit_object_scp1 IMPLEMENTATION.
ENDMETHOD.
METHOD zif_abapgit_object~is_active.
rv_active = is_active( ).
ENDMETHOD.
METHOD zif_abapgit_object~is_locked.
rv_is_locked = abap_false.
@ -395,9 +402,4 @@ CLASS zcl_abapgit_object_scp1 IMPLEMENTATION.
ig_data = ls_scp1 ).
ENDMETHOD.
METHOD zif_abapgit_object~is_active.
rv_active = is_active( ).
ENDMETHOD.
ENDCLASS.

70
src/objects/zcl_abapgit_object_ssfo.clas.abap
View File

@ -11,45 +11,45 @@ CLASS zcl_abapgit_object_ssfo DEFINITION PUBLIC INHERITING FROM zcl_abapgit_obje
CONSTANTS: attrib_abapgit_leadig_spaces TYPE string VALUE 'abapgit-leadig-spaces' ##NO_TEXT.
METHODS fix_ids IMPORTING ii_xml_doc TYPE REF TO if_ixml_document.
METHODS set_attribute_leading_spaces IMPORTING i_name TYPE string
i_node TYPE REF TO if_ixml_node
CHANGING c_within_code_section TYPE abap_bool.
METHODS handle_attrib_leading_spaces IMPORTING i_name TYPE string
i_node TYPE REF TO if_ixml_node
CHANGING c_within_code_section TYPE abap_bool.
METHODS set_attribute_leading_spaces IMPORTING iv_name TYPE string
ii_node TYPE REF TO if_ixml_node
CHANGING cv_within_code_section TYPE abap_bool.
METHODS handle_attrib_leading_spaces IMPORTING iv_name TYPE string
ii_node TYPE REF TO if_ixml_node
CHANGING cv_within_code_section TYPE abap_bool.
METHODS get_range_node_codes RETURNING VALUE(e_range_node_codes) TYPE ty_string_range.
METHODS code_item_section_handling IMPORTING i_name TYPE string
i_node TYPE REF TO if_ixml_node
EXPORTING e_code_item_element TYPE REF TO if_ixml_element
CHANGING c_within_code_section TYPE abap_bool
METHODS code_item_section_handling IMPORTING iv_name TYPE string
ii_node TYPE REF TO if_ixml_node
EXPORTING ei_code_item_element TYPE REF TO if_ixml_element
CHANGING cv_within_code_section TYPE abap_bool
RAISING zcx_abapgit_exception.
ENDCLASS.
CLASS zcl_abapgit_object_ssfo IMPLEMENTATION.
CLASS ZCL_ABAPGIT_OBJECT_SSFO IMPLEMENTATION.
METHOD code_item_section_handling.
CONSTANTS: node_item TYPE string VALUE 'item' ##NO_TEXT.
CONSTANTS: node_text TYPE string VALUE '#text' ##NO_TEXT.
IF i_name IN get_range_node_codes( ).
c_within_code_section = abap_true.
IF iv_name IN get_range_node_codes( ).
cv_within_code_section = abap_true.
ENDIF.
IF c_within_code_section = abap_true.
IF i_name = node_item.
IF cv_within_code_section = abap_true.
IF iv_name = node_item.
TRY.
e_code_item_element ?= i_node.
ei_code_item_element ?= ii_node.
RETURN.
CATCH cx_sy_move_cast_error ##no_handler.
ENDTRY.
ELSEIF i_name NOT IN get_range_node_codes( ) AND
i_name <> node_text.
c_within_code_section = abap_false.
ELSEIF iv_name NOT IN get_range_node_codes( ) AND
iv_name <> node_text.
cv_within_code_section = abap_false.
ENDIF.
ENDIF.
@ -160,10 +160,10 @@ CLASS zcl_abapgit_object_ssfo IMPLEMENTATION.
DATA coding_line TYPE string.
TRY.
code_item_section_handling( EXPORTING i_name = i_name
i_node = i_node
IMPORTING e_code_item_element = element
CHANGING c_within_code_section = c_within_code_section ).
code_item_section_handling( EXPORTING iv_name = iv_name
ii_node = ii_node
IMPORTING ei_code_item_element = element
CHANGING cv_within_code_section = cv_within_code_section ).
leading_spaces = element->get_attribute_ns( name = zcl_abapgit_object_ssfo=>attrib_abapgit_leadig_spaces ).
@ -183,17 +183,17 @@ CLASS zcl_abapgit_object_ssfo IMPLEMENTATION.
DATA: offset TYPE i.
TRY.
code_item_section_handling( EXPORTING i_name = i_name
i_node = i_node
IMPORTING e_code_item_element = element
CHANGING c_within_code_section = c_within_code_section ).
code_item_section_handling( EXPORTING iv_name = iv_name
ii_node = ii_node
IMPORTING ei_code_item_element = element
CHANGING cv_within_code_section = cv_within_code_section ).
code_line = i_node->get_value( ).
code_line = ii_node->get_value( ).
"find 1st non space char
FIND FIRST OCCURRENCE OF REGEX '\S' IN code_line MATCH OFFSET offset.
IF sy-subrc = 0 AND offset > 0.
TRY.
element ?= i_node.
element ?= ii_node.
element->set_attribute( name = zcl_abapgit_object_ssfo=>attrib_abapgit_leadig_spaces
value = |{ offset }| ).
@ -275,9 +275,9 @@ CLASS zcl_abapgit_object_ssfo IMPLEMENTATION.
ENDCASE.
handle_attrib_leading_spaces( EXPORTING i_name = lv_name
i_node = li_node
CHANGING c_within_code_section = within_code_section ).
handle_attrib_leading_spaces( EXPORTING iv_name = lv_name
ii_node = li_node
CHANGING cv_within_code_section = within_code_section ).
li_node = li_iterator->get_next( ).
ENDWHILE.
@ -459,9 +459,9 @@ CLASS zcl_abapgit_object_ssfo IMPLEMENTATION.
OR lv_name = 'LASTUSER'.
li_node->set_value( 'DUMMY' ).
ENDIF.
set_attribute_leading_spaces( EXPORTING i_name = lv_name
i_node = li_node
CHANGING c_within_code_section = within_code_section ).
set_attribute_leading_spaces( EXPORTING iv_name = lv_name
ii_node = li_node
CHANGING cv_within_code_section = within_code_section ).
li_node = li_iterator->get_next( ).
ENDWHILE.

63
src/objects/zcl_abapgit_objects_saxx_super.clas.abap
View File

@ -9,47 +9,42 @@ CLASS zcl_abapgit_objects_saxx_super DEFINITION
INTERFACES zif_abapgit_object .
PROTECTED SECTION.
METHODS:
get_persistence_class_name ABSTRACT
RETURNING
VALUE(r_persistence_class_name) TYPE seoclsname,
get_data_class_name ABSTRACT
METHODS get_persistence_class_name
ABSTRACT
RETURNING
VALUE(r_data_class_name) TYPE seoclsname,
get_data_structure_name ABSTRACT
VALUE(rv_persistence_class_name) TYPE seoclsname .
METHODS get_data_class_name
ABSTRACT
RETURNING
VALUE(r_data_structure_name) TYPE string.
VALUE(rv_data_class_name) TYPE seoclsname .
METHODS get_data_structure_name
ABSTRACT
RETURNING
VALUE(rv_data_structure_name) TYPE string .
PRIVATE SECTION.
DATA: mo_persistence TYPE REF TO if_wb_object_persist,
mo_appl_obj_data TYPE REF TO if_wb_object_data_model,
mv_data_structure_name TYPE string,
mv_appl_obj_cls_name TYPE seoclsname,
mv_persistence_cls_name TYPE seoclsname.
METHODS:
create_channel_objects
DATA mo_persistence TYPE REF TO if_wb_object_persist .
DATA mo_appl_obj_data TYPE REF TO if_wb_object_data_model .
DATA mv_data_structure_name TYPE string .
DATA mv_appl_obj_cls_name TYPE seoclsname .
DATA mv_persistence_cls_name TYPE seoclsname .
METHODS create_channel_objects
RAISING
zcx_abapgit_exception,
get_data
zcx_abapgit_exception .
METHODS get_data
EXPORTING
p_data TYPE any
!eg_data TYPE any
RAISING
zcx_abapgit_exception,
lock
zcx_abapgit_exception .
METHODS lock
RAISING
zcx_abapgit_exception,
unlock
zcx_abapgit_exception .
METHODS unlock
RAISING
zcx_abapgit_exception,
get_names.
zcx_abapgit_exception .
METHODS get_names .
ENDCLASS.
@ -97,7 +92,7 @@ CLASS ZCL_ABAPGIT_OBJECTS_SAXX_SUPER IMPLEMENTATION.
mo_appl_obj_data->get_data(
IMPORTING
p_data = p_data ).
p_data = eg_data ).
ENDMETHOD.
@ -184,7 +179,7 @@ CLASS ZCL_ABAPGIT_OBJECTS_SAXX_SUPER IMPLEMENTATION.
get_data(
IMPORTING
p_data = <lg_data> ).
eg_data = <lg_data> ).
ASSIGN COMPONENT 'HEADER' OF STRUCTURE <lg_data> TO <lg_header>.
ASSERT sy-subrc = 0.
@ -364,7 +359,7 @@ CLASS ZCL_ABAPGIT_OBJECTS_SAXX_SUPER IMPLEMENTATION.
get_data(
IMPORTING
p_data = <lg_data> ).
eg_data = <lg_data> ).
ASSIGN COMPONENT 'HEADER' OF STRUCTURE <lg_data> TO <lg_header>.
ASSERT sy-subrc = 0.

48
src/objects/zcl_abapgit_objects_super.clas.abap
View File

@ -10,11 +10,11 @@ CLASS zcl_abapgit_objects_super DEFINITION PUBLIC ABSTRACT.
CLASS-METHODS:
jump_adt
IMPORTING i_obj_name TYPE zif_abapgit_definitions=>ty_item-obj_name
i_obj_type TYPE zif_abapgit_definitions=>ty_item-obj_type
i_sub_obj_name TYPE zif_abapgit_definitions=>ty_item-obj_name OPTIONAL
i_sub_obj_type TYPE zif_abapgit_definitions=>ty_item-obj_type OPTIONAL
i_line_number TYPE i OPTIONAL
IMPORTING iv_obj_name TYPE zif_abapgit_definitions=>ty_item-obj_name
iv_obj_type TYPE zif_abapgit_definitions=>ty_item-obj_type
iv_sub_obj_name TYPE zif_abapgit_definitions=>ty_item-obj_name OPTIONAL
iv_sub_obj_type TYPE zif_abapgit_definitions=>ty_item-obj_type OPTIONAL
iv_line_number TYPE i OPTIONAL
RAISING zcx_abapgit_exception.
CONSTANTS: c_user_unknown TYPE xubname VALUE 'UNKNOWN'.
@ -77,13 +77,13 @@ CLASS zcl_abapgit_objects_super DEFINITION PUBLIC ABSTRACT.
CLASS-METHODS:
get_adt_objects_and_names
IMPORTING
i_obj_name TYPE zif_abapgit_definitions=>ty_item-obj_name
i_obj_type TYPE zif_abapgit_definitions=>ty_item-obj_type
iv_obj_name TYPE zif_abapgit_definitions=>ty_item-obj_name
iv_obj_type TYPE zif_abapgit_definitions=>ty_item-obj_type
EXPORTING
eo_adt_uri_mapper TYPE REF TO object
eo_adt_objectref TYPE REF TO object
e_program TYPE progname
e_include TYPE progname
ev_program TYPE progname
ev_include TYPE progname
RAISING
zcx_abapgit_exception.
@ -91,7 +91,7 @@ ENDCLASS.
CLASS zcl_abapgit_objects_super IMPLEMENTATION.
CLASS ZCL_ABAPGIT_OBJECTS_SUPER IMPLEMENTATION.
METHOD check_timestamp.
@ -204,8 +204,8 @@ CLASS zcl_abapgit_objects_super IMPLEMENTATION.
DATA lo_adt TYPE REF TO object.
FIELD-SYMBOLS <lv_uri> TYPE string.
lv_obj_name = i_obj_name.
lv_obj_type = i_obj_type.
lv_obj_name = iv_obj_name.
lv_obj_type = iv_obj_type.
TRY.
cl_wb_object=>create_from_transport_key(
@ -246,8 +246,8 @@ CLASS zcl_abapgit_objects_super IMPLEMENTATION.
EXPORTING
uri = <lv_uri>
IMPORTING
program = e_program
include = e_include.
program = ev_program
include = ev_include.
CATCH cx_root.
zcx_abapgit_exception=>raise( 'ADT Jump Error' ).
@ -357,29 +357,29 @@ CLASS zcl_abapgit_objects_super IMPLEMENTATION.
get_adt_objects_and_names(
EXPORTING
i_obj_name = i_obj_name
i_obj_type = i_obj_type
iv_obj_name = iv_obj_name
iv_obj_type = iv_obj_type
IMPORTING
eo_adt_uri_mapper = lo_adt_uri_mapper
eo_adt_objectref = lo_adt_objref
e_program = lv_program
e_include = lv_include ).
ev_program = lv_program
ev_include = lv_include ).
TRY.
IF i_sub_obj_name IS NOT INITIAL.
IF iv_sub_obj_name IS NOT INITIAL.
IF ( lv_program <> i_obj_name AND lv_include IS INITIAL ) OR
( lv_program = lv_include AND i_sub_obj_name IS NOT INITIAL ).
lv_include = i_sub_obj_name.
IF ( lv_program <> iv_obj_name AND lv_include IS INITIAL ) OR
( lv_program = lv_include AND iv_sub_obj_name IS NOT INITIAL ).
lv_include = iv_sub_obj_name.
ENDIF.
CALL METHOD lo_adt_uri_mapper->('IF_ADT_URI_MAPPER~MAP_INCLUDE_TO_OBJREF')
EXPORTING
program = lv_program
include = lv_include
line = i_line_number
line = iv_line_number
line_offset = 0
end_line = i_line_number
end_line = iv_line_number
end_offset = 1
RECEIVING
result = lo_adt_sub_objref.

18
src/ui/zcl_abapgit_gui_page_codi_base.clas.abap
View File

@ -16,7 +16,7 @@ CLASS zcl_abapgit_gui_page_codi_base DEFINITION PUBLIC ABSTRACT INHERITING FROM
IMPORTING
is_item TYPE zif_abapgit_definitions=>ty_item
is_sub_item TYPE zif_abapgit_definitions=>ty_item
i_line_number TYPE i
iv_line_number TYPE i
RAISING
zcx_abapgit_exception.
PRIVATE SECTION.
@ -48,12 +48,12 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_CODI_BASE IMPLEMENTATION.
objname = is_item-obj_name
sobjtype = is_sub_item-obj_type
sobjname = is_sub_item-obj_name
line = i_line_number
line = iv_line_number
ASSIGNING <ls_result>.
ELSE.
READ TABLE mt_result WITH KEY objtype = is_item-obj_type
objname = is_item-obj_name
line = i_line_number
line = iv_line_number
ASSIGNING <ls_result>.
ENDIF.
ASSERT <ls_result> IS ASSIGNED.
@ -79,11 +79,11 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_CODI_BASE IMPLEMENTATION.
lv_line_number = <ls_result>-line.
zcl_abapgit_objects_super=>jump_adt( i_obj_name = ls_item-obj_name
i_obj_type = ls_item-obj_type
i_sub_obj_name = ls_sub_item-obj_name
i_sub_obj_type = ls_sub_item-obj_type
i_line_number = lv_line_number ).
zcl_abapgit_objects_super=>jump_adt( iv_obj_name = ls_item-obj_name
iv_obj_type = ls_item-obj_type
iv_sub_obj_name = ls_sub_item-obj_name
iv_sub_obj_type = ls_sub_item-obj_type
iv_line_number = lv_line_number ).
RETURN.
ENDIF.
@ -180,7 +180,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_CODI_BASE IMPLEMENTATION.
jump( is_item = ls_item
is_sub_item = ls_sub_item
i_line_number = lv_line_number ).
iv_line_number = lv_line_number ).
ev_state = zif_abapgit_definitions=>c_event_state-no_more_act.

38
src/ui/zcl_abapgit_gui_view_repo.clas.abap
View File

@ -80,12 +80,12 @@ CLASS zcl_abapgit_gui_view_repo DEFINITION
RETURNING VALUE(rv_html) TYPE string,
build_inactive_object_code
IMPORTING is_item TYPE zif_abapgit_definitions=>ty_repo_item
RETURNING value(r_inactive_html_code) TYPE string.
RETURNING VALUE(rv_inactive_html_code) TYPE string.
ENDCLASS.
CLASS zcl_abapgit_gui_view_repo IMPLEMENTATION.
CLASS ZCL_ABAPGIT_GUI_VIEW_REPO IMPLEMENTATION.
METHOD build_dir_jump_link.
@ -273,6 +273,18 @@ CLASS zcl_abapgit_gui_view_repo IMPLEMENTATION.
ENDMETHOD.
METHOD build_inactive_object_code.
IF is_item-inactive = abap_true.
rv_inactive_html_code = zcl_abapgit_html=>icon(
iv_name = 'zap/orange'
iv_hint = 'Object or object part is inactive'
iv_class = 'inactive' ).
ENDIF.
ENDMETHOD.
METHOD build_obj_jump_link.
DATA: lv_encode TYPE string.
@ -429,17 +441,6 @@ CLASS zcl_abapgit_gui_view_repo IMPLEMENTATION.
ENDMETHOD.
METHOD build_inactive_object_code.
IF is_item-inactive = abap_true.
r_inactive_html_code = zcl_abapgit_html=>icon(
iv_name = 'zap/orange'
iv_hint = 'Object or object part is inactive'
iv_class = 'inactive' ).
ENDIF.
ENDMETHOD.
METHOD render_item_command.
@ -528,6 +529,11 @@ CLASS zcl_abapgit_gui_view_repo IMPLEMENTATION.
ENDMETHOD.
METHOD zif_abapgit_gui_page_hotkey~get_hotkey_actions.
ENDMETHOD.
METHOD zif_abapgit_gui_page~on_event.
DATA: lv_path TYPE string.
@ -648,10 +654,4 @@ CLASS zcl_abapgit_gui_view_repo IMPLEMENTATION.
ENDTRY.
ENDMETHOD.
METHOD zif_abapgit_gui_page_hotkey~get_hotkey_actions.
ENDMETHOD.
ENDCLASS.

6
src/zcl_abapgit_objects.clas.abap
View File

@ -749,9 +749,9 @@ CLASS ZCL_ABAPGIT_OBJECTS IMPLEMENTATION.
IF lv_adt_jump_enabled = abap_true.
TRY.
zcl_abapgit_objects_super=>jump_adt(
i_obj_name = is_item-obj_name
i_obj_type = is_item-obj_type
i_line_number = iv_line_number ).
iv_obj_name = is_item-obj_name
iv_obj_type = is_item-obj_type
iv_line_number = iv_line_number ).
CATCH zcx_abapgit_exception.
li_obj->jump( ).
ENDTRY.