From 8b506aa0771267498f83d55a649a79430a3c049e Mon Sep 17 00:00:00 2001 From: Lars Hvam Date: Mon, 4 Jan 2021 10:41:20 +0100 Subject: [PATCH] omit some default parameter names (#4370) * apack, omit parameter names * mass and objects * omit * omit --- src/apack/zcl_abapgit_apack_helper.clas.abap | 2 +- src/apack/zcl_abapgit_apack_reader.clas.abap | 4 ++-- .../zcl_abapgit_apack_reader.clas.testclasses.abap | 2 +- .../zcl_abapgit_transport_mass.clas.locals_imp.abap | 4 ++-- ...l_abapgit_transport_objects.clas.testclasses.abap | 12 +++++------- src/objects/zcl_abapgit_object_tabl.clas.abap | 8 ++++---- src/repo/zcl_abapgit_repo_content_list.clas.abap | 6 +++--- src/ui/zcl_abapgit_gui_page_addofflin.clas.abap | 5 ++--- 8 files changed, 20 insertions(+), 23 deletions(-) diff --git a/src/apack/zcl_abapgit_apack_helper.clas.abap b/src/apack/zcl_abapgit_apack_helper.clas.abap index ca7e18579..cd38a427b 100644 --- a/src/apack/zcl_abapgit_apack_helper.clas.abap +++ b/src/apack/zcl_abapgit_apack_helper.clas.abap @@ -171,7 +171,7 @@ CLASS ZCL_ABAPGIT_APACK_HELPER IMPLEMENTATION. ENDIF. lo_apack_reader = zcl_abapgit_apack_reader=>create_instance( ls_manifest_implementation-devclass ). - lo_apack_reader->copy_manifest_descriptor( io_manifest_provider = lo_manifest_provider ). + lo_apack_reader->copy_manifest_descriptor( lo_manifest_provider ). ls_descriptor = lo_apack_reader->get_manifest_descriptor( ). IF ls_descriptor IS NOT INITIAL. diff --git a/src/apack/zcl_abapgit_apack_reader.clas.abap b/src/apack/zcl_abapgit_apack_reader.clas.abap index ad49810c6..71bb13c71 100644 --- a/src/apack/zcl_abapgit_apack_reader.clas.abap +++ b/src/apack/zcl_abapgit_apack_reader.clas.abap @@ -70,7 +70,7 @@ ENDCLASS. -CLASS zcl_abapgit_apack_reader IMPLEMENTATION. +CLASS ZCL_ABAPGIT_APACK_READER IMPLEMENTATION. METHOD constructor. @@ -194,7 +194,7 @@ CLASS zcl_abapgit_apack_reader IMPLEMENTATION. CLEAR: rs_manifest_descriptor. ENDTRY. IF lo_manifest_provider IS BOUND. - copy_manifest_descriptor( io_manifest_provider = lo_manifest_provider ). + copy_manifest_descriptor( lo_manifest_provider ). ENDIF. ENDIF. diff --git a/src/apack/zcl_abapgit_apack_reader.clas.testclasses.abap b/src/apack/zcl_abapgit_apack_reader.clas.testclasses.abap index 952ce98e0..08de55b00 100644 --- a/src/apack/zcl_abapgit_apack_reader.clas.testclasses.abap +++ b/src/apack/zcl_abapgit_apack_reader.clas.testclasses.abap @@ -12,7 +12,7 @@ ENDCLASS. CLASS ltcl_apack_manifest_reader IMPLEMENTATION. METHOD manifest_descriptor. - verify_own_descriptor( is_manifest_descriptor = mo_manifest_reader->get_manifest_descriptor( ) ). + verify_own_descriptor( mo_manifest_reader->get_manifest_descriptor( ) ). ENDMETHOD. METHOD setup. diff --git a/src/cts/zcl_abapgit_transport_mass.clas.locals_imp.abap b/src/cts/zcl_abapgit_transport_mass.clas.locals_imp.abap index 196c62e40..da52b5043 100644 --- a/src/cts/zcl_abapgit_transport_mass.clas.locals_imp.abap +++ b/src/cts/zcl_abapgit_transport_mass.clas.locals_imp.abap @@ -145,7 +145,7 @@ CLASS lcl_transport_zipper IMPLEMENTATION. CONCATENATE sy-datlo sy-timlo INTO mv_timestamp SEPARATED BY '_'. - mv_full_folder = get_full_folder( iv_folder = iv_folder ). + mv_full_folder = get_full_folder( iv_folder ). cl_gui_frontend_services=>get_file_separator( CHANGING @@ -206,7 +206,7 @@ CLASS lcl_transport_zipper IMPLEMENTATION. mv_timestamp INTO rv_full_folder SEPARATED BY lv_sep. - IF does_folder_exist( iv_folder = rv_full_folder ) = abap_false. + IF does_folder_exist( rv_full_folder ) = abap_false. cl_gui_frontend_services=>directory_create( EXPORTING diff --git a/src/cts/zcl_abapgit_transport_objects.clas.testclasses.abap b/src/cts/zcl_abapgit_transport_objects.clas.testclasses.abap index ccbee1e1b..1a78235c5 100644 --- a/src/cts/zcl_abapgit_transport_objects.clas.testclasses.abap +++ b/src/cts/zcl_abapgit_transport_objects.clas.testclasses.abap @@ -184,7 +184,7 @@ CLASS ltcl_transport_objects IMPLEMENTATION. iv_filename = 'CL_FOO.abap' iv_path = '/path' iv_data = 'data' ). - then_it_should_raise_exception( iv_with_text = 'Object CL_FOO not found in the local repository files' ). + then_it_should_raise_exception( 'Object CL_FOO not found in the local repository files' ). ENDMETHOD. METHOD cant_be_added_with_del_flag. @@ -198,8 +198,7 @@ CLASS ltcl_transport_objects IMPLEMENTATION. iv_obj_type = 'CLAS' iv_lstate = zif_abapgit_definitions=>c_state-added ). - then_it_should_raise_exception( - iv_with_text = 'Object CL_FOO should be added/modified, but has deletion flag in transport' ). + then_it_should_raise_exception( 'Object CL_FOO should be added/modified, but has deletion flag in transport' ). ENDMETHOD. METHOD cant_be_modified_with_del_flag. @@ -213,9 +212,9 @@ CLASS ltcl_transport_objects IMPLEMENTATION. iv_obj_type = 'CLAS' iv_lstate = zif_abapgit_definitions=>c_state-modified ). - then_it_should_raise_exception( - iv_with_text = 'Object CL_FOO should be added/modified, but has deletion flag in transport' ). + then_it_should_raise_exception( 'Object CL_FOO should be added/modified, but has deletion flag in transport' ). ENDMETHOD. + METHOD deleted_to_removed_files. given_the_transport_object( iv_obj_name = 'CL_FOO' @@ -361,8 +360,7 @@ CLASS ltcl_transport_objects IMPLEMENTATION. iv_path = '/a_path' iv_lstate = zif_abapgit_definitions=>c_state-deleted ). - then_it_should_raise_exception( - iv_with_text = 'Object CL_FOO should be removed, but has NO deletion flag in transport' ). + then_it_should_raise_exception( 'Object CL_FOO should be removed, but has NO deletion flag in transport' ). ENDMETHOD. METHOD given_the_transport_object. diff --git a/src/objects/zcl_abapgit_object_tabl.clas.abap b/src/objects/zcl_abapgit_object_tabl.clas.abap index 2ab877ba3..9c0baa5c4 100644 --- a/src/objects/zcl_abapgit_object_tabl.clas.abap +++ b/src/objects/zcl_abapgit_object_tabl.clas.abap @@ -108,7 +108,7 @@ ENDCLASS. -CLASS zcl_abapgit_object_tabl IMPLEMENTATION. +CLASS ZCL_ABAPGIT_OBJECT_TABL IMPLEMENTATION. METHOD clear_dd03p_fields. @@ -530,7 +530,7 @@ CLASS zcl_abapgit_object_tabl IMPLEMENTATION. METHOD update_extras. IF is_tabl_extras-tddat IS INITIAL. - delete_extras( iv_tabname = iv_tabname ). + delete_extras( iv_tabname ). ELSE. MODIFY tddat FROM is_tabl_extras-tddat. ENDIF. @@ -635,7 +635,7 @@ CLASS zcl_abapgit_object_tabl IMPLEMENTATION. delete_longtexts( c_longtext_id_tabl ). - delete_extras( iv_tabname = lv_objname ). + delete_extras( lv_objname ). ENDIF. @@ -1001,7 +1001,7 @@ CLASS zcl_abapgit_object_tabl IMPLEMENTATION. serialize_idoc_segment( io_xml ). - ls_extras = read_extras( iv_tabname = lv_name ). + ls_extras = read_extras( lv_name ). io_xml->add( iv_name = c_s_dataname-tabl_extras ig_data = ls_extras ). diff --git a/src/repo/zcl_abapgit_repo_content_list.clas.abap b/src/repo/zcl_abapgit_repo_content_list.clas.abap index 51c3a4a1a..331b16ea5 100644 --- a/src/repo/zcl_abapgit_repo_content_list.clas.abap +++ b/src/repo/zcl_abapgit_repo_content_list.clas.abap @@ -53,7 +53,7 @@ ENDCLASS. -CLASS zcl_abapgit_repo_content_list IMPLEMENTATION. +CLASS ZCL_ABAPGIT_REPO_CONTENT_LIST IMPLEMENTATION. METHOD build_folders. @@ -246,9 +246,9 @@ CLASS zcl_abapgit_repo_content_list IMPLEMENTATION. LOOP AT lt_repo_msg REFERENCE INTO lr_repo_msg WHERE type CA 'EW'. CASE lr_repo_msg->type. WHEN 'E'. - ri_log->add_error( iv_msg = lr_repo_msg->text ). + ri_log->add_error( lr_repo_msg->text ). WHEN 'W'. - ri_log->add_warning( iv_msg = lr_repo_msg->text ). + ri_log->add_warning( lr_repo_msg->text ). WHEN OTHERS. CONTINUE. ENDCASE. diff --git a/src/ui/zcl_abapgit_gui_page_addofflin.clas.abap b/src/ui/zcl_abapgit_gui_page_addofflin.clas.abap index 50ca97a7d..142aa7be3 100644 --- a/src/ui/zcl_abapgit_gui_page_addofflin.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_addofflin.clas.abap @@ -58,7 +58,7 @@ ENDCLASS. -CLASS zcl_abapgit_gui_page_addofflin IMPLEMENTATION. +CLASS ZCL_ABAPGIT_GUI_PAGE_ADDOFFLIN IMPLEMENTATION. METHOD constructor. @@ -139,8 +139,7 @@ CLASS zcl_abapgit_gui_page_addofflin IMPLEMENTATION. IF io_form_data->get( c_id-package ) IS NOT INITIAL. TRY. - zcl_abapgit_repo_srv=>get_instance( )->validate_package( - iv_package = |{ io_form_data->get( c_id-package ) }| ). + zcl_abapgit_repo_srv=>get_instance( )->validate_package( |{ io_form_data->get( c_id-package ) }| ). CATCH zcx_abapgit_exception INTO lx_err. ro_validation_log->set( iv_key = c_id-package