diff --git a/src/ui/lib/zcl_abapgit_html_action_utils.clas.abap b/src/ui/lib/zcl_abapgit_html_action_utils.clas.abap index 5ea070153..6adf7d099 100644 --- a/src/ui/lib/zcl_abapgit_html_action_utils.clas.abap +++ b/src/ui/lib/zcl_abapgit_html_action_utils.clas.abap @@ -16,24 +16,6 @@ CLASS zcl_abapgit_html_action_utils DEFINITION !iv_upper_cased TYPE abap_bool DEFAULT abap_false RETURNING VALUE(rt_fields) TYPE tihttpnvp . - CLASS-METHODS parse_fields_upper_case_name - IMPORTING - !iv_string TYPE clike - RETURNING - VALUE(rt_fields) TYPE tihttpnvp . - CLASS-METHODS translate_postdata - IMPORTING - !it_postdata TYPE zif_abapgit_html_viewer=>ty_post_data - RETURNING - VALUE(rv_string) TYPE string . - - CLASS-METHODS get_field - IMPORTING - !iv_name TYPE string - !it_field TYPE tihttpnvp - !iv_decode TYPE abap_bool DEFAULT abap_false - CHANGING - !cg_field TYPE any . CLASS-METHODS jump_encode IMPORTING !iv_obj_type TYPE tadir-object @@ -46,7 +28,6 @@ CLASS zcl_abapgit_html_action_utils DEFINITION !iv_path TYPE string RETURNING VALUE(rv_string) TYPE string . - CLASS-METHODS file_encode IMPORTING !iv_key TYPE zif_abapgit_persistence=>ty_repo-key @@ -59,18 +40,27 @@ CLASS zcl_abapgit_html_action_utils DEFINITION !ig_object TYPE any RETURNING VALUE(rv_string) TYPE string . - - CLASS-METHODS class_constructor. + CLASS-METHODS class_constructor . CLASS-METHODS dbkey_encode IMPORTING !is_key TYPE zif_abapgit_persistence=>ty_content RETURNING VALUE(rv_string) TYPE string . - PROTECTED SECTION. PRIVATE SECTION. - CLASS-DATA gv_non_breaking_space TYPE string. + CLASS-DATA gv_non_breaking_space TYPE string . + + CLASS-METHODS parse_fields_upper_case_name + IMPORTING + !iv_string TYPE clike + RETURNING + VALUE(rt_fields) TYPE tihttpnvp . + CLASS-METHODS translate_postdata + IMPORTING + !it_postdata TYPE zif_abapgit_html_viewer=>ty_post_data + RETURNING + VALUE(rv_string) TYPE string . CLASS-METHODS field_keys_to_upper CHANGING !ct_fields TYPE tihttpnvp . @@ -89,7 +79,7 @@ ENDCLASS. -CLASS zcl_abapgit_html_action_utils IMPLEMENTATION. +CLASS ZCL_ABAPGIT_HTML_ACTION_UTILS IMPLEMENTATION. METHOD add_field. @@ -181,39 +171,6 @@ CLASS zcl_abapgit_html_action_utils IMPLEMENTATION. ENDMETHOD. - METHOD get_field. - - DATA: lv_value TYPE string. - - FIELD-SYMBOLS: LIKE LINE OF it_field, - TYPE any. - - - READ TABLE it_field ASSIGNING WITH KEY name = iv_name. - IF sy-subrc IS NOT INITIAL. - RETURN. - ENDIF. - - lv_value = -value. - - IF iv_decode = abap_true. - lv_value = cl_http_utility=>unescape_url( escaped = lv_value ). - ENDIF. - - CASE cl_abap_typedescr=>describe_by_data( cg_field )->kind. - WHEN cl_abap_typedescr=>kind_elem. - cg_field = lv_value. - WHEN cl_abap_typedescr=>kind_struct. - ASSIGN COMPONENT iv_name OF STRUCTURE cg_field TO . - ASSERT IS ASSIGNED. - = lv_value. - WHEN OTHERS. - ASSERT 0 = 1. - ENDCASE. - - ENDMETHOD. - - METHOD jump_encode. DATA: lt_fields TYPE tihttpnvp. diff --git a/src/ui/lib/zcl_abapgit_html_action_utils.clas.testclasses.abap b/src/ui/lib/zcl_abapgit_html_action_utils.clas.testclasses.abap index d6a5bc343..f5f2450fa 100644 --- a/src/ui/lib/zcl_abapgit_html_action_utils.clas.testclasses.abap +++ b/src/ui/lib/zcl_abapgit_html_action_utils.clas.testclasses.abap @@ -4,7 +4,6 @@ CLASS ltcl_html_action_utils DEFINITION FOR TESTING RISK LEVEL HARMLESS PUBLIC SECTION. CLASS-METHODS class_constructor. - METHODS get_field FOR TESTING. METHODS parse_fields_simple_case FOR TESTING. METHODS parse_fields_advanced_case FOR TESTING. METHODS parse_fields_unescape FOR TESTING. @@ -66,38 +65,6 @@ CLASS ltcl_html_action_utils IMPLEMENTATION. ENDMETHOD. - METHOD get_field. - - DATA: lt_fields TYPE tihttpnvp, - ls_answer LIKE LINE OF lt_fields, - ls_field LIKE LINE OF lt_fields. - - ls_answer-name = 'NAME'. - ls_answer-value = 'TEST'. - APPEND ls_answer TO lt_fields. - - zcl_abapgit_html_action_utils=>get_field( - EXPORTING - iv_name = 'NAME' - it_field = lt_fields - CHANGING - cg_field = ls_field-value ). - zcl_abapgit_html_action_utils=>get_field( - EXPORTING - iv_name = 'NAME' - it_field = lt_fields - CHANGING - cg_field = ls_field ). - - ls_answer-name = 'TEST'. - ls_answer-value = 'TEST'. - - cl_abap_unit_assert=>assert_equals( - act = ls_field - exp = ls_answer ). " Both field are filled! - - ENDMETHOD. - METHOD parse_fields_simple_case. _given_string_is( `committer_name=Gustav Gans` ).